Re: Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

2015-09-21 Thread Guangya Liu
> On 九月 20, 2015, 6:46 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 486 > > > > > > this method should be called suppress too. > > > > > > to avoid conflict with the suppress marco, can you

Re: Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38514/ --- (Updated 九月 21, 2015, 6:05 a.m.) Review request for mesos and Vinod Kone.

Review Request 38544: Update macro of suppress to SUPPRESS

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38544/ --- Review request for mesos. Repository: mesos Description --- The macro

Re: Review Request 38516: Changed quiesceOffers to SuppressOffers

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38516/ --- (Updated 九月 21, 2015, 6:05 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38519: Change function quiesce() to suppress()

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38519/ --- (Updated 九月 21, 2015, 6:06 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38544: libprocess: Updated macro of suppress to SUPPRESS

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38544/ --- (Updated 九月 21, 2015, 6:22 a.m.) Review request for mesos. Summary (updated)

Re: Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

2015-09-21 Thread Guangya Liu
> On 九月 20, 2015, 6:46 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 486 > > > > > > this method should be called suppress too. > > > > > > to avoid conflict with the suppress marco, can you

Re: Review Request 38519: Change function quiesce() to suppress()

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38519/#review99730 --- Patch looks great! Reviews applied: [38514, 38516, 38544, 38519]

Re: Review Request 38544: libprocess: Updated macro of suppress to SUPPRESS

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38544/ --- (Updated 九月 21, 2015, 7:27 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-21 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review99732 --- include/mesos/master/allocator.hpp (line 80)

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review99733 --- src/tests/hook_tests.cpp (line 659)

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review99734 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-21 Thread Yong Qiao Wang
> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote: > > Can you write a test for this? > > Yong Qiao Wang wrote: > I find the code changes in this patch does not be tested with an > end-to-end case except to check the error log messages of master, so my test > strategy are: > > 1.

Re: Review Request 37993: WIP: Add explanatory comments for Allocator interface

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 21, 2015, 7:25 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: WIP: Add explanatory comments for Allocator interface

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 21, 2015, 6:20 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 21, 2015, 7:28 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review99920 --- Patch looks great! Reviews applied: [38574, 38575] All tests

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38578/#review99864 --- docs/upgrades.md (line 30)

Re: Review Request 38569: Made slave's work_dir a shared mount in LinuxFilesystemIsolator.

2015-09-21 Thread Jie Yu
> On Sept. 21, 2015, 10:35 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 73-74 > > > > > > After then sentense `using the bind backend)` add > > > > `because

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Vinod Kone
> On Sept. 21, 2015, 11:32 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 34 > > > > > > what about slaves and executors? > > Guangya Liu wrote: > Vinod, do we need to mention slaves and executors here as my

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/ --- (Updated Sept. 22, 2015, 1:40 a.m.) Review request for mesos. Bugs:

Re: Review Request 38582: Removed the unneeded container work directory mounts.

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38582/#review99907 --- Bad patch! Reviews applied: [38569] Failed command:

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38578/#review99915 --- Patch looks great! Reviews applied: [38578] All tests passed. -

Re: Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.

2015-09-21 Thread Vinod Kone
> On Sept. 21, 2015, 11:01 p.m., Ben Mahler wrote: > > support/verify_reviews.py, line 141 > > > > > > Maybe this should say bad review instead of bad patch? done. > On Sept. 21, 2015, 11:01 p.m., Ben Mahler

Re: Review Request 38602: Fixed minor typo in Executor API protobuf

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38602/#review99913 --- Ship it! Ship It! - Guangya Liu On 九月 22, 2015, 3:07 a.m.,

Re: Review Request 38570: Change documentation image links to absolute paths.

2015-09-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38570/ --- (Updated Sept. 21, 2015, 4:12 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/ --- (Updated Sept. 21, 2015, 11:22 p.m.) Review request for mesos. Bugs:

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/ --- (Updated Sept. 22, 2015, 12:16 a.m.) Review request for mesos. Bugs:

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Guangya Liu
> On 九月 21, 2015, 11:32 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 34 > > > > > > what about slaves and executors? > > Guangya Liu wrote: > Vinod, do we need to mention slaves and executors here as my

Re: Review Request 37540: Add perf event API

2015-09-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review99882 --- src/linux/perf.cpp (lines 515 - 528)

Re: Review Request 38569: Made slave's work_dir a shared mount in LinuxFilesystemIsolator.

2015-09-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38569/#review99895 --- Ship it! Ship It! - haosdent huang On Sept. 21, 2015, 9:23

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Felix Abecassis
> On Sept. 22, 2015, 12:40 a.m., Connor Doyle wrote: > > Ship It! > > Connor Doyle wrote: > Please re-run the post-reviews so the patch applies cleanly > (`src/slave/http.cpp` was concurrently modified). Done. Please verify. - Felix

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Guangya Liu
> On 九月 21, 2015, 7:57 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, line 659 > > > > > > s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g > > Felix Abecassis wrote: > I will rename it to

Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.

2015-09-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38549/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38551: [1/2]CMake: Add version info for APR we need to build Windows.

2015-09-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38551/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38552: [2/2]CMake: Add Windows-specific build targets for APR.

2015-09-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38552/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38552: [2/2]CMake: Add Windows-specific build targets for APR.

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38552/#review99746 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530,

Review Request 38579: Exposing manifest structure outside RegistryClient

2015-09-21 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 38570: Change documentation image links to absolute paths.

2015-09-21 Thread Joseph Wu
> On Sept. 21, 2015, 4:02 p.m., Adam B wrote: > > Looks good. Do the images still show up when the markdown is rendered on > > the github website? Unfortunately, no. This change will break the links when you look at them on Github. We can make it work both ways if we remove that trailing `/`

Review Request 38582: Removed the unneeded container work directory mounts.

2015-09-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38582/ --- Review request for mesos, Jojy Varghese, Timothy Chen, and Jiang Yan Xu. Bugs:

Re: Review Request 38569: Made slave's work_dir a shared mount in LinuxFilesystemIsolator.

2015-09-21 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38569/#review99869 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 21, 2015, 2:23 p.m.,

Re: Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38568/#review99874 --- Patch looks great! Reviews applied: [38568] All tests passed. -

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Connor Doyle
> On Sept. 22, 2015, 12:40 a.m., Connor Doyle wrote: > > Ship It! Please re-run the post-reviews so the patch applies cleanly (`src/slave/http.cpp` was concurrently modified). - Connor --- This is an automatically generated e-mail. To

Re: Review Request 38570: Change documentation image links to absolute paths.

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38570/#review99893 --- Patch looks great! Reviews applied: [38570] All tests passed. -

Re: Review Request 38574: Fixed race in hook self-message loop and reenabled VerifySlaveLaunchExecutorHook test

2015-09-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38574/ --- (Updated Sept. 21, 2015, 3:38 p.m.) Review request for mesos, Joris Van

Re: Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.

2015-09-21 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37914/#review99856 --- Ship it! support/verify_reviews.py (line 141)

Re: Review Request 38570: Change documentation image links to absolute paths.

2015-09-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38570/#review99857 --- Looks good. Do the images still show up when the markdown is

Re: Review Request 38582: Removed the unneeded container work directory mounts.

2015-09-21 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38582/#review99875 --- Ship it! src/slave/containerizer/isolators/filesystem/linux.cpp

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review99885 --- Ship it! LGTM module some minor language fixes for comments/log.

Re: Review Request 38574: Fixed race in hook self-message loop and reenabled VerifySlaveLaunchExecutorHook test

2015-09-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38574/#review99888 --- Ship it! Ship It! - Kapil Arya On Sept. 21, 2015, 6:38 p.m.,

Re: Review Request 38569: Made slave's work_dir a shared mount in LinuxFilesystemIsolator.

2015-09-21 Thread haosdent huang
> On Sept. 21, 2015, 10:35 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 97-98 > > > > > > So this seems to work but oh my godness the the way `mount` command > >

Re: Review Request 38580: Added docker registry RemotePuller

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review99905 --- Patch looks great! Reviews applied: [38443, 38579, 38580] All

Re: Review Request 38569: Made slave's work_dir a shared mount in LinuxFilesystemIsolator.

2015-09-21 Thread Jiang Yan Xu
> On Sept. 21, 2015, 3:35 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 97-98 > > > > > > So this seems to work but oh my godness the the way `mount` command > >

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review99772 --- Overall, looks good. The main issue is that 'Store' should not have

Review Request 38577: Added synchronous validation for Call in Agent

2015-09-21 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs:

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Guangya Liu
> On 九月 21, 2015, 11:32 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 34 > > > > > > what about slaves and executors? Vinod, do we need to mention slaves and executors here as my change does not impact both

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
> On Sept. 21, 2015, 7:57 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, line 659 > > > > > > s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g > > Felix Abecassis wrote: > I will rename it

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99890 --- Ship it! include/mesos/hook.hpp (lines 25 - 27)

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review99892 --- src/hook/manager.cpp (line 270)

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Guangya Liu
> On 九月 21, 2015, 7:57 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, line 659 > > > > > > s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g > > Felix Abecassis wrote: > I will rename it to

Re: Review Request 38279: Add a new callback enabling custom resource discovery logic

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 22, 2015, 2:14 a.m.) Review request for mesos, Connor Doyle and

Review Request 38573: Added changelog for 0.25.0 release

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38573/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3037

Re: Review Request 38573: Added changelog for 0.25.0 release

2015-09-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38573/#review99849 --- Can you also update docs/upgrades.md with the upgrade order

Re: Review Request 38569: Made slave's work_dir a shared mount in LinuxFilesystemIsolator.

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38569/#review99858 --- Patch looks great! Reviews applied: [38569] All tests passed. -

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99846 --- include/mesos/hook.hpp (line 129)

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review99871 --- include/mesos/hook.hpp (line 66)

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99891 --- Ship it! Ship It! - Guangya Liu On 九月 19, 2015, 12:59 a.m.,

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-21 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review99886 --- LGTM, thanks for working on this Isabel ! Waiting for some

Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/ --- Review request for mesos, Joris Van Remoortere and Kapil Arya. Bugs:

Review Request 38574: Fixed race in hook self-message loop and reenabled VerifySlaveLaunchExecutorHook test

2015-09-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38574/ --- Review request for mesos, Jie Yu and Kapil Arya. Bugs: MESOS-2226

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/ --- (Updated Sept. 21, 2015, 3:40 p.m.) Review request for mesos, Joris Van

Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38578/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3037

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
> On Sept. 21, 2015, 10:08 p.m., Guangya Liu wrote: > > I think that you need make this patch depend on > > https://reviews.apache.org/r/38279/ to make this works. Thank you, I hope it's fixed now. - Felix --- This is an automatically

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99883 --- Ship it! Ship It! - Connor Doyle On Sept. 19, 2015, 12:59 a.m.,

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
> On Sept. 21, 2015, 7:57 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, line 659 > > > > > > s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g I will rename it to

Re: Review Request 38569: Made slave's work_dir a shared mount in LinuxFilesystemIsolator.

2015-09-21 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38569/#review99831 --- src/slave/containerizer/isolators/filesystem/linux.cpp (lines 73 -

Re: Review Request 38573: Added changelog for 0.25.0 release

2015-09-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38573/#review99847 --- Ship it! Ship It! - Vinod Kone On Sept. 21, 2015, 10:27 p.m.,

Re: Review Request 38569: Made slave's work_dir a shared mount in LinuxFilesystemIsolator.

2015-09-21 Thread Jie Yu
> On Sept. 21, 2015, 10:35 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 97-98 > > > > > > So this seems to work but oh my godness the the way `mount` command > >

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
> On Sept. 21, 2015, 11:27 p.m., Connor Doyle wrote: > > include/mesos/hook.hpp, line 129 > > > > > > Missing definite article: "within the slave". I wanted to add it, but the hooks above don't. I know, that's not

Review Request 38580: Added docker registry RemotePuller

2015-09-21 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38578/ --- (Updated 九月 21, 2015, 11:44 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/ --- (Updated Sept. 22, 2015, 12:22 a.m.) Review request for mesos, Benjamin

Re: Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38568/#review99880 --- Ship it! Ship It! - Guangya Liu On 九月 21, 2015, 9:45 p.m.,

Review Request 38584: Added a few filesystem isolation and provisioning metrics.

2015-09-21 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38584/ --- Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen. Bugs:

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99889 --- Ship it! src/master/http.cpp (line 30)

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-21 Thread haosdent huang
> On Sept. 21, 2015, 10:04 p.m., Jie Yu wrote: > > OK, I'll address the comments for you since this is a blocker for the > > release. Thank you very much. - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 22, 2015, 1:26 a.m.) Review request for mesos, Connor Doyle and

Re: Review Request 38517: Make attributes.hpp public

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/ --- (Updated Sept. 22, 2015, 1:26 a.m.) Review request for mesos, Connor Doyle and

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
> On Sept. 22, 2015, 1:33 a.m., Kapil Arya wrote: > > src/tests/hook_tests.cpp, line 695 > > > > > > Is it worth checking that resources indeed contains a "foo" before > > validating the value of "foo"? Not sure

Review Request 38602: Fixed minor typo in Executor API protobuf

2015-09-21 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38602/ --- Review request for mesos, Isabel Jimenez and Vinod Kone. Repository: mesos

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review99912 --- Patch looks great! Reviews applied: [38473] All tests passed. -

Re: Review Request 38519: Change function quiesce() to suppress()

2015-09-21 Thread Guangya Liu
> On 九月 21, 2015, 6:15 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 486 > > > > > > doesn't look you changed this to 'suppress' from 'suppressRes'? > > Vinod Kone wrote: > i'll fix this for you and

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99839 --- OK, I'll address the comments for you since this is a blocker for

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99840 --- commit 57361f10ccf1e026dbb691e67277cb0cb71c8ea6 Author: haosdent

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99841 --- I think that you need make this patch depend on

Re: Review Request 38584: Added a few filesystem isolation and provisioning metrics.

2015-09-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38584/#review99917 --- Ship it! src/slave/containerizer/isolators/filesystem/linux.hpp

Re: Review Request 38579: Exposing manifest structure outside RegistryClient

2015-09-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review99925 --- Ship it! Ship It! - Timothy Chen On Sept. 21, 2015, 11:30 p.m.,

Re: Review Request 37821: Join threads in libprocess when shutting down.

2015-09-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/ --- (Updated Sept. 21, 2015, 3:53 p.m.) Review request for mesos, Benjamin

Re: Review Request 37821: Join threads in libprocess when shutting down.

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review99759 --- Patch looks great! Reviews applied: [37821] All tests passed. -

  1   2   >