Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread Kapil Arya
> On Sept. 22, 2015, 2:58 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73 > > > > > > We should delete the stack only if CLONE_VM was not specified in the > > flags

Re: Review Request 38625: Keep clone syscall consistent.

2015-09-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/ --- (Updated Sept. 22, 2015, 6:37 p.m.) Review request for mesos, Jie Yu, Joris

Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread Jie Yu
> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73 > > > > > > We should delete the stack only if CLONE_VM was not specified in the > > flags

Re: Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.

2015-09-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38542/#review100034 --- Ship it! 3rdparty/libprocess/cmake/ProcessConfigure.cmake (lines

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/ --- (Updated Sept. 22, 2015, 6:52 p.m.) Review request for mesos, Jie Yu, Joris

Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread Jie Yu
> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73 > > > > > > We should delete the stack only if CLONE_VM was not specified in the > > flags

Re: Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

2015-09-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38568/ --- (Updated Sept. 22, 2015, 11:51 a.m.) Review request for mesos, Artem

Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38639/#review100042 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/#review100050 --- Ship it! src/tests/containerizer/ns_tests.cpp (lines 169 - 171)

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread haosdent huang
> On Sept. 22, 2015, 4:51 p.m., Cong Wang wrote: > > Why not introduce a wrapper for clone() to hide the 'stack'? > > haosdent huang wrote: > Sure, let me update again. @wangcong I finish update the patch. Could you help review this again? Thank you very much. - haosdent

Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38639/#review100046 --- Ship it!

Re: Review Request 38569: Made slave's work_dir a shared mount in LinuxFilesystemIsolator.

2015-09-22 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38569/#review99927 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 87)

Review Request 38600: Introduced a typedef to make consistent use of case-insentitive http headers easier.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38600/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Review Request 38597: Added URL within http::Request.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38597/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.

Review Request 38599: Consistent use of case insensitive keys for HTTP headers.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38599/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Review Request 38596: Updated http::URL to be a URI-reference.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38596/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.

Review Request 38598: Updates to reflect addition of URL in http::Request.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38598/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-22 Thread Timothy Chen
> On Sept. 21, 2015, 11:22 p.m., Jie Yu wrote: > > src/Makefile.am, line 491 > > > > > > Similar to master/resgistry.proto, we should put this proto file under > > > >

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-22 Thread Timothy Chen
> On Sept. 21, 2015, 11:22 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioner/docker/paths.hpp, line 40 > > > > > > What's this? No longer needed with the shared provisioner change, thanks! > On Sept. 21,

Re: Review Request 38584: Added a few filesystem isolation and provisioning metrics.

2015-09-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38584/#review99930 --- src/slave/containerizer/isolators/filesystem/linux.hpp (line 138)

Review Request 38609: Refactored http::internal::request to use http::connect.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38609/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99934 --- Ship it! Ship It! - Guangya Liu On 九月 22, 2015, 6:05 a.m.,

Review Request 38606: Added ability to check if the streaming decoder is writing to a body pipe.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38606/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Review Request 38601: Added a TODO to keep Request.keepAlive consistent with the 'Connection' header value.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38601/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Review Request 38604: Re-enabled decoder test for case insensitive headers.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38604/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Review Request 38605: Improved streaming decoder tests by checking the failed state.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38605/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Review Request 38607: Pulled out an encode function for http::Request encoding.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38607/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Review Request 38603: Refactored http::internal::Request to take a Request object.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38603/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Review Request 38608: Introduced an http::Connection for connection re-use and pipelining.

2015-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-22 Thread Timothy Chen
> On Sept. 21, 2015, 11:22 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioner/docker/store.cpp, line 256 > > > > > > According to your current design, Store is supposed to be agnostic to > > which puller

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-22 Thread haosdent huang
> On Sept. 22, 2015, 6:21 a.m., Cong Wang wrote: > > src/slave/containerizer/linux_launcher.cpp, line 182 > > > > > > You forgot to remove this line? > > haosdent huang wrote: > sorry, my fault. Let me create

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-22 Thread haosdent huang
> On Sept. 22, 2015, 6:21 a.m., Cong Wang wrote: > > src/slave/containerizer/linux_launcher.cpp, line 182 > > > > > > You forgot to remove this line? sorry, my fault. - haosdent

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Guangya Liu
> On 九月 21, 2015, 10:08 p.m., Guangya Liu wrote: > > I think that you need make this patch depend on > > https://reviews.apache.org/r/38279/ to make this works. > > Felix Abecassis wrote: > Thank you, I hope it's fixed now. I see that this patch is depending on

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Felix Abecassis
> On Sept. 21, 2015, 10:08 p.m., Guangya Liu wrote: > > I think that you need make this patch depend on > > https://reviews.apache.org/r/38279/ to make this works. > > Felix Abecassis wrote: > Thank you, I hope it's fixed now. > > Guangya Liu wrote: > I see that this patch is

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-22 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99932 --- src/slave/containerizer/linux_launcher.cpp (line 182)

Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas

Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-22 Thread Jie Yu
> On Sept. 21, 2015, 11:22 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioner/docker/store.cpp, line 256 > > > > > > According to your current design, Store is supposed to be agnostic to > > which puller

Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38636/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas

Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas

Re: Review Request 38625: Keep clone syscall consistent.

2015-09-22 Thread haosdent huang
> On Sept. 22, 2015, 4:51 p.m., Cong Wang wrote: > > Why not introduce a wrapper for clone() to hide the 'stack'? Sure, let me update again. - haosdent --- This is an automatically generated e-mail. To reply, visit:

Review Request 38630: Fixed order for header includes

2015-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/ --- Review request for mesos, Isabel Jimenez and Vinod Kone. Repository: mesos

Re: Review Request 38584: Added a few filesystem isolation and provisioning metrics.

2015-09-22 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38584/#review15 --- src/slave/containerizer/isolators/filesystem/linux.hpp (line 141)

Re: Review Request 38625: Keep clone syscall consistent.

2015-09-22 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/#review100012 --- Why not introduce a wrapper for clone() to hide the 'stack'? -

Re: Review Request 38630: Fixed order for header includes

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100013 --- Patch looks great! Reviews applied: [38630] All tests passed. -

Re: Review Request 38632: Fix printing of JSON numbers to be valid JSON for web browsers.

2015-09-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38632/ --- (Updated Sept. 22, 2015, 10:58 a.m.) Review request for mesos, Artem

Re: Review Request 38632: Fix printing of JSON numbers to be valid JSON for web browsers.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38632/#review100032 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 22, 2015,

Re: Review Request 38584: Added a few filesystem isolation and provisioning metrics.

2015-09-22 Thread Jiang Yan Xu
> On Sept. 21, 2015, 9:56 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/filesystem/linux.hpp, line 138 > > > > > > `containers_changing_rootfs`? Keeping `containers_new_rootfs` because I think it should

Re: Review Request 38584: Added a few filesystem isolation and provisioning metrics.

2015-09-22 Thread Jiang Yan Xu
> On Sept. 21, 2015, 11:09 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/backends/bind.cpp, line 194 > > > > > > Why only when errno == EBUSY? Because other errors are not masked by the backend

Re: Review Request 38584: Added a few filesystem isolation and provisioning metrics.

2015-09-22 Thread Jiang Yan Xu
> On Sept. 22, 2015, 9:19 a.m., Jojy Varghese wrote: > > src/slave/containerizer/isolators/filesystem/linux.hpp, line 141 > > > > > > is this proper accordng to style guide (Since this is a public method)? It's

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/#review100031 --- Patch looks great! Reviews applied: [38634, 38635, 38636, 38637]

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-22 Thread Jie Yu
> On Sept. 21, 2015, 11:22 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioner/docker/message.proto, line 21 > > > > > > Remove .docker? > > Timothy Chen wrote: > I added the docker namespace since it's

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/#review100066 --- For the sake of repro'ing, maybe you could add a sleep before

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/#review100110 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

2015-09-22 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/#review100112 --- Can we add tests and user docs describing the issue and new

Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread haosdent huang
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100114 --- src/common/values.cpp (lines 141 - 154)

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100118 --- Patch looks great! Reviews applied: [38137] All tests passed. -

Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread haosdent huang
> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73 > > > > > > We should delete the stack only if CLONE_VM was not specified in the > > flags

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-22 Thread Joris Van Remoortere
> On Sept. 23, 2015, 12:48 a.m., Niklas Nielsen wrote: > > src/slave/containerizer/linux_launcher.cpp, line 197 > > > > > > Wouldn't the idomatic way be to use stout's file abstractions? Which ones are you

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38653/#review100113 --- src/master/http.cpp (line 1775)

Re: Review Request 38650: Enabled '--no-cache' for docker images build on ASF CI

2015-09-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38650/#review100122 --- Ship it! Ship It! - Greg Mann On Sept. 22, 2015, 11:42 p.m.,

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-22 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100120 --- src/linux/systemd.cpp (line 38)

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-22 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100109 --- src/slave/containerizer/linux_launcher.cpp (line 197)

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100091 --- I've got some clean-up suggestions, I think `lhs` and `rhs`

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/ --- (Updated Sept. 23, 2015, 1:25 a.m.) Review request for mesos, Jie Yu, Joris

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/ --- (Updated Sept. 23, 2015, 1:48 a.m.) Review request for mesos, Benjamin

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/ --- (Updated Sept. 23, 2015, 1:48 a.m.) Review request for mesos, Benjamin

Re: Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38636/ --- (Updated Sept. 23, 2015, 1:48 a.m.) Review request for mesos, Benjamin

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- (Updated Sept. 23, 2015, 1:48 a.m.) Review request for mesos, Benjamin

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-22 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100111 --- A few questions below src/slave/containerizer/linux_launcher.cpp

Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38639/ --- (Updated Sept. 23, 2015, 1:26 a.m.) Review request for mesos, Jie Yu and Cong

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100119 --- Ship it! After addressing the outstanding issues. - Joris Van

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38653/#review100123 --- Great job, Joris! - Artem Harutyunyan On Sept. 22, 2015, 4:24

Re: Review Request 38650: Enabled '--no-cache' for docker images build on ASF CI

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38650/#review100124 --- Patch looks great! Reviews applied: [38650] All tests passed. -

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-22 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37967/#review100070 --- High level comment: why not just use pid namespace to kill

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/#review100068 --- Patch looks great! Reviews applied: [38639, 38625] All tests

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 22, 2015, 10:15 p.m.) Review request for mesos, Jie Yu, Jojy

Re: Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38568/#review100065 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 22, 2015,

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 22, 2015, 8:46 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 22, 2015, 9:37 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/#review100072 --- Ship it! Ship It! - Neil Conway On Sept. 22, 2015, 9:37 p.m.,

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Anand Mazumdar
> On Sept. 22, 2015, 9:09 p.m., Neil Conway wrote: > > For the sake of repro'ing, maybe you could add a sleep before waiting on > > the future? Obviously not something we want in the actual patch though. Thanks Neil, that worked. Updated the `Testing Done` section with the details now. Should

Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/ --- Review request for mesos. Bugs: MESOS-3493

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 22, 2015, 8:55 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 38646: Added WIP note for Executor endpoint in changelog

2015-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38646/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 38517: Make attributes.hpp public

2015-09-22 Thread Connor Doyle
> On Sept. 22, 2015, 12:40 a.m., Connor Doyle wrote: > > Ship It! > > Connor Doyle wrote: > Please re-run the post-reviews so the patch applies cleanly > (`src/slave/http.cpp` was concurrently modified). > > Felix Abecassis wrote: > Done. Please verify. Verified (patch applied, make,

Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- Review request for mesos, Isabel Jimenez and Vinod Kone. Repository: mesos

Re: Review Request 38517: Make attributes.hpp public

2015-09-22 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review100069 --- Ship it! Ship It! - Niklas Nielsen On Sept. 21, 2015, 6:26

Review Request 38648: Hack the allocator interface to expose the batch allocation internals.

2015-09-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38648/ --- Review request for mesos. Bugs: MESOS-3493

Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/ --- Review request for mesos, haosdent huang and Jie Yu. Bugs: MESOS-3498

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38653/#review100132 --- Patch looks great! Reviews applied: [38653] All tests passed. -

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/#review100129 --- Bad patch! Reviews applied: [38634, 38635] Failed command:

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-09-22 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/ --- (Updated Sept. 23, 2015, 1:16 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread Cong Wang
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/#review100128 --- Patch looks great! Reviews applied: [38639, 38625] All tests

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38653/#review100125 --- src/master/http.cpp (line 1751)

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100131 --- Hi, @kapil The flaky test you metioned is a known issue.

Re: Review Request 38639: Add os::clone function in stout.

2015-09-22 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38639/#review100139 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp

Review Request 38650: Enabled '--no-cache' for docker images build on ASF CI

2015-09-22 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38650/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-3491

  1   2   >