Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100191 --- Patch looks great! Reviews applied: [38158] All tests passed. -

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-23 Thread Joerg Schad
> On Sept. 22, 2015, 10:37 p.m., Jie Yu wrote: > > src/linux/cgroups.hpp, line 666 > > > > > > Any reason you want to expose these two classes in the header? If no > > one is using them right now, please move them

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review100188 --- Patch looks great! Reviews applied: [37714, 37996, 37997, 37998,

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100185 --- src/common/values.cpp (lines 93 - 94)

Re: Review Request 37996: Added property manager

2015-09-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Sept. 23, 2015, 1:17 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-09-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Sept. 23, 2015, 1:17 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100189 --- src/common/values.cpp (line 253)

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
> On Sept. 23, 2015, 12:58 a.m., Michael Park wrote: > > src/common/values.cpp, line 301 > > > > > > Can we just take a `Value::Ranges` here rather than > > `initializer_list`? > > > > It looks like the

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-23 Thread Joerg Schad
> On Sept. 22, 2015, 10:37 p.m., Jie Yu wrote: > > Tests? Also, link the JIRA ticket in the review board. Updated Review 36620, this was only my internal stash, sorry for adding mesos as Group. - Joerg --- This is an automatically

Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-23 Thread Philip Norman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38056/#review100182 --- Ship it! Ship It! - Philip Norman On Sept. 16, 2015, 3:03

Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-23 Thread haosdent huang
> On Sept. 23, 2015, 10:16 a.m., Philip Norman wrote: > > Ship It! Thank you. :-) - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38056/#review100182

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Michael Park
> On Sept. 23, 2015, 12:58 a.m., Michael Park wrote: > > src/common/values.cpp, line 204 > > > > > > Why not pass by value? > > Joerg Schad wrote: > Not sure why you would want to pass either by value. Result

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 23, 2015, 12:37 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38056/ --- (Updated Sept. 23, 2015, 2:03 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 38574: Fixed race in hook self-message loop and reenabled VerifySlaveLaunchExecutorHook test

2015-09-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38574/#review100196 --- Ship it! Verified with 100 runs. I remember talking about this

Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38056/#review100197 --- Patch looks great! Reviews applied: [38056] All tests passed. -

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Niklas Nielsen
> On Sept. 23, 2015, 1:46 a.m., Timothy Chen wrote: > > src/linux/systemd.cpp, line 54 > > > > > > Just tried to run this in CentOS 7 and I couldn't find /bin/systemd, > > but systemd is running. I see :/ So either

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-23 Thread Timothy Chen
> On Sept. 23, 2015, 7:45 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioner/docker/local_puller.hpp, line 45 > > > > > > Not a strong opinion but if you think this could potentially be "not > >

Re: Review Request 38639: Add os::clone function in stout.

2015-09-23 Thread Cong Wang
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-09-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review100235 --- Can we please add this file to the CMakeLists.txt file in

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100226 --- src/slave/containerizer/provisioner/docker/puller.hpp (line 40)

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/#review100231 --- Can we add this test to the relevant CMakeLists.txt too? - Alex

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38653/ --- (Updated Sept. 23, 2015, 8:55 a.m.) Review request for mesos, Benjamin

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

2015-09-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review100211 --- LGTM , just some comments (see inline) around the `struct Status`

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

2015-09-23 Thread Anand Mazumdar
> On Sept. 23, 2015, 4:58 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/http.cpp, line 77 > > > > > > Why not implement a `stringify(...)` for the newly created enum and > > make the `statuses[]` use it ?

Re: Review Request 37997: Running PathInheritedProperties tests from libprocess Makefile

2015-09-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37997/#review100233 --- Can we add these tests to the CMakeLists.txt file in

Re: Review Request 38602: Fixed minor typo in Executor API protobuf

2015-09-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38602/#review100212 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 3:07 a.m.,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-09-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review100237 --- Can we please add this file to the CMakeLists.txt in

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review100221 --- Ship it! Ship It! - haosdent huang On Sept. 21, 2015, 10:40

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38653/#review100216 --- Patch looks great! Reviews applied: [38653] All tests passed. -

Re: Review Request 38667: Added a test for os::realpath().

2015-09-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/#review100222 --- Ship it! Ship It! - Joseph Wu On Sept. 23, 2015, 12:07 a.m.,

Re: Review Request 37996: Added property manager

2015-09-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review100236 --- Can we please add these tests to the CMakeLists.txt file in

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Joseph Wu
> On Sept. 23, 2015, 10:37 a.m., Alex Clemmer wrote: > > Can we add this test to the relevant CMakeLists.txt too? It will be included :) See the not-discarded review: https://reviews.apache.org/r/38667 - Joseph --- This is an

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100239 --- Ship it! I've submitted this review request with the following

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

2015-09-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review100260 --- 3rdparty/libprocess/include/process/http.hpp (lines 657 - 658)

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
> On Sept. 9, 2015, 3:46 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, lines 250-271 > > > > > > I think we can conflate this two cases, how about this: > > ``` > > if (range->end() + 1 >=

Re: Review Request 38686: Fixed broken build due to attributes header being moved to public include folder in slave.hpp

2015-09-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38686/#review100267 --- Ship it! Ship It! - Vinod Kone On Sept. 23, 2015, 7:15 p.m.,

Re: Review Request 38630: Fixed order for header includes

2015-09-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/ --- (Updated Sept. 23, 2015, 6:13 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38630: Fixed order for header includes

2015-09-23 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100264 --- Bad timing, this breaks the build because of

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
> On Sept. 23, 2015, 6:29 p.m., Ben Mahler wrote: > > Where is the benchmark for this change? :( We benchmarked the code with a proprietary benchmark. I added https://issues.apache.org/jira/browse/MESOS-3502 aiming at adding an open-source benchmark for this. - Joerg

Re: Review Request 38684: Made the mount in the bind mount backend a shared mount.

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38684/ --- (Updated Sept. 23, 2015, 7:09 p.m.) Review request for mesos, Timothy Chen and

Re: Review Request 38654: Added digest verifier for image blobs

2015-09-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38654/ --- (Updated Sept. 23, 2015, 7:41 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38630: Fixed order for header includes

2015-09-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100250 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 4:16 p.m.,

Re: Review Request 38595: Removed implicit logging from Socket::shutdown in favor of returning a Try.

2015-09-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38595/#review100258 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 6:18 a.m.,

Review Request 38685: Temporary fix for the issue when making slave's work_dir a shared mount.

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38685/ --- Review request for mesos, Timothy Chen and Jiang Yan Xu. Repository: mesos

Review Request 38686: Fixed broken build due to attributes header being moved to public include folder in slave.hpp

2015-09-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38686/ --- Review request for mesos, Felix Abecassis and Vinod Kone. Repository: mesos

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100261 --- Where is the benchmark for this change? :( - Ben Mahler On

Re: Review Request 38630: Fixed order for header includes

2015-09-23 Thread Anand Mazumdar
> On Sept. 23, 2015, 7:02 p.m., Felix Abecassis wrote: > > Bad timing, this breaks the build because of > > https://reviews.apache.org/r/38517/ Ahh bummer, `make check` succeeded for me too may be it because it was able to find the header `common/attributes.hpp` in the build folder. Fixing

Re: Review Request 38639: Add os::clone function in stout.

2015-09-23 Thread haosdent huang
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38639: Add os::clone function in stout.

2015-09-23 Thread Jie Yu
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100146 --- To fix the ExampleTests, you may want to force to use

Review Request 38665: Added fs::realpath().

2015-09-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-3499

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/#review100150 --- 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp (line 68)

Review Request 38667: Added a test for os::realpath().

2015-09-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-3499

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-23 Thread Timothy Chen
> On Sept. 10, 2015, 10:04 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioners/docker.cpp, lines 104-107 > > > > > > I guess you are modeling this after the `docker pull` syntax here: > >

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-23 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100165 --- src/slave/containerizer/provisioner/docker/puller.hpp (line 60)

Re: Review Request 38639: Add os::clone function in stout.

2015-09-23 Thread Jie Yu
> On Sept. 23, 2015, 5:43 a.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 138 > > > > > > This whitespace change is not supposed in this patch. I'll commit this one

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/#review100151 --- Bad patch! Reviews applied: [38665] Failed command:

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/ --- (Updated Sept. 22, 2015, 11:38 p.m.) Review request for mesos, Joris Van

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Artem Harutyunyan
> On Sept. 22, 2015, 11:35 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp, line 68 > > > > > > what's the different between this and os::realpath? You're right, there is none. I'll

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100148 --- Ship it! Ship It!

Re: Review Request 38639: Add os::clone function in stout.

2015-09-23 Thread haosdent huang
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Artem Harutyunyan
> On Sept. 22, 2015, 11:35 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp, line 68 > > > > > > what's the different between this and os::realpath? > > Artem Harutyunyan wrote: >

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100155 --- src/linux/systemd.cpp (line 38)

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-09-23 Thread Zhiwei Chen
> On Sept. 18, 2015, 12:59 a.m., Joseph Wu wrote: > > docs/authentication.md, line 14 > > > > > > Are you sure this is correct? The ACL changes shouldn't change > > authentication, only authorization. This is used

Re: Review Request 38667: Added a test for os::realpath().

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/#review100164 --- Patch looks great! Reviews applied: [38667] All tests passed. -

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-23 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review99919 --- Much closer! Haven't looked at the tests yet but will do.

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review100169 --- Patch looks great! Reviews applied: [38416] All tests passed. -

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100168 --- src/linux/systemd.cpp (line 54)

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100171 --- src/linux/systemd.cpp (line 161)

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

2015-09-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37998/ --- (Updated Sept. 23, 2015, 10:56 a.m.) Review request for mesos, Adam B,

Re: Review Request 37996: Added property manager

2015-09-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Sept. 23, 2015, 10:55 a.m.) Review request for mesos, Adam B,

Re: Review Request 37997: Running PathInheritedProperties tests from libprocess Makefile

2015-09-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37997/ --- (Updated Sept. 23, 2015, 10:55 a.m.) Review request for mesos, Adam B,

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

2015-09-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Sept. 23, 2015, 10:57 a.m.) Review request for mesos, Adam B,

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-09-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Sept. 23, 2015, 10:57 a.m.) Review request for mesos, Adam B,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-09-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Sept. 23, 2015, 10:58 a.m.) Review request for mesos, Adam B,

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

2015-09-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/ --- (Updated Sept. 23, 2015, 7:59 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38599: Consistent use of case insensitive keys for HTTP headers.

2015-09-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38599/#review100291 --- Ship it! Thanks for the cleanup! - Vinod Kone On Sept. 22,

Re: Review Request 38601: Added a TODO to keep Request.keepAlive consistent with the 'Connection' header value.

2015-09-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38601/#review100293 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 6:18 a.m.,

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100090 --- src/slave/containerizer/provisioner/docker/local_puller.hpp (line

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-23 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review100296 --- Ship it! src/slave/slave.cpp (line 375)

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100302 --- src/slave/flags.cpp (line 62)

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread Niklas Nielsen
> On Sept. 21, 2015, 4:58 p.m., Guangya Liu wrote: > > include/mesos/hook.hpp, line 66 > > > > > > Do we need to update slave to agent in other comments introduced by > > this patch? All code references are now

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review100240 --- It seems good to qualify how we're different from the google style

Review Request 38684: Made the mount in the bind mount backend a shared mount.

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38684/ --- Review request for mesos, Timothy Chen and Jiang Yan Xu. Repository: mesos

Re: Review Request 38600: Introduced a typedef to make consistent use of case-insentitive http headers easier.

2015-09-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38600/#review100289 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 6:18 a.m.,

Review Request 38693: Added MESOS_SANDBOX environment variable in Mesos containerizer.

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38693/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs:

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100303 --- src/slave/containerizer/linux_launcher.cpp (line 81)

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/ --- (Updated Sept. 23, 2015, 3:24 p.m.) Review request for mesos, Joris Van

Re: Review Request 38598: Updates to reflect addition of URL in http::Request.

2015-09-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38598/#review100288 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 6:18 a.m.,

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38653/#review100287 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 23, 2015,

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100290 --- Just some feedback on doxygen usage; trying to avoid comment bloat

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/#review100294 --- Patch looks great! Reviews applied: [38634, 38635, 38636, 38637]

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/ --- (Updated Sept. 23, 2015, 5:46 p.m.) Review request for mesos, haosdent huang

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100298 --- Ship it! Ship It! - Jie Yu On Sept. 23, 2015, 9:46 p.m., Kapil

Re: Review Request 38693: Added MESOS_SANDBOX environment variable in Mesos containerizer.

2015-09-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38693/#review100301 --- src/slave/containerizer/mesos/containerizer.cpp (line 767)

Re: Review Request 38693: Added MESOS_SANDBOX environment variable in Mesos containerizer.

2015-09-23 Thread Jie Yu
> On Sept. 23, 2015, 10:14 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 767 > > > > > > I think we should consolidate it, but we need to allow it to be passed > > in I think

Re: Review Request 38654: Added digest verifier for image blobs

2015-09-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38654/ --- (Updated Sept. 23, 2015, 10:27 p.m.) Review request for mesos, Gilbert Song

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100306 --- src/slave/containerizer/linux_launcher.cpp (line 133)

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review100308 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 23, 2015,

  1   2   >