Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

2015-09-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/#review100376 --- src/slave/containerizer/linux_launcher.cpp (line 246)

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-24 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated Sept. 24, 2015, 9:45 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-24 Thread Yong Qiao Wang
> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote: > > Can you write a test for this? > > Yong Qiao Wang wrote: > I find the code changes in this patch does not be tested with an > end-to-end case except to check the error log messages of master, so my test > strategy are: > > 1.

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

2015-09-24 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/ --- (Updated Sept. 24, 2015, 12:05 p.m.) Review request for mesos, Joerg Schad,

Re: Review Request 37997: Running PathInheritedProperties tests from libprocess Makefile

2015-09-24 Thread Alexander Rojas
> On Sept. 23, 2015, 7:38 p.m., Alex Clemmer wrote: > > Can we add these tests to the CMakeLists.txt file in > > 3rdparty/libprocess/3rdparty/stout/tests/ as well? As I mentioned it was done in a previous patch. But the stout test with autotool are ran from the libprocess Makefile which

Re: Review Request 37996: Added property manager

2015-09-24 Thread Alexander Rojas
> On Sept. 23, 2015, 7:40 p.m., Alex Clemmer wrote: > > Can we please add these tests to the CMakeLists.txt file in > > 3rdparty/libprocess/3rdparty/stout/tests? It was done already since the first version of this patch. - Alexander

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-09-24 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Sept. 24, 2015, 12:33 p.m.) Review request for mesos, Adam B,

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review100394 --- Patch looks great! Reviews applied: [38051] All tests passed. -

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-24 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated Sept. 24, 2015, 9:39 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-09-24 Thread Alexander Rojas
> On Sept. 23, 2015, 7:39 p.m., Alex Clemmer wrote: > > Can we please add this file to the CMakeLists.txt file in > > 3rdparty/libprocess/src as well? The included file is a header and so far cmake file doesn't seem to care about the include directory (can you correct me if I'm wrong). Still,

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-24 Thread Alexander Rukletsov
> On Sept. 23, 2015, 6:29 p.m., Ben Mahler wrote: > > Where is the benchmark for this change? :( > > Joerg Schad wrote: > We benchmarked the code with a proprietary benchmark. I added > https://issues.apache.org/jira/browse/MESOS-3502 aiming at adding an > open-source benchmark for this.

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100387 --- Patch looks great! Reviews applied: [38137] All tests passed. -

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100375 --- Patch looks great! Reviews applied: [38705] All tests passed. -

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Timothy Chen
> On Sept. 23, 2015, 5:34 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/puller.hpp, line 60 > > > > > > I think timeout should be part of the interface. remote puller > > especially

Re: Review Request 38697: Updated documentation strings for --launcher flag.

2015-09-24 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/ --- (Updated Sept. 24, 2015, 2:44 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 38697: Updated documentation strings for --launcher flag.

2015-09-24 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/ --- (Updated Sept. 24, 2015, 2:44 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Timothy Chen
> On Sept. 23, 2015, 5:34 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/store.cpp, line 257 > > > > > > Dont we have to cleanup the created directory? It's automatically cleaned up in

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 24, 2015, 9:21 a.m.) Review request for mesos, Jie Yu, Jojy

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review100398 --- Patch looks great! Reviews applied: [37714, 37996, 37997, 37998,

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-09-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/ --- (Updated Sept. 24, 2015, 2:37 p.m.) Review request for mesos, Alexander

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

2015-09-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Sept. 24, 2015, 2:43 p.m.) Review request for mesos and Michael Park.

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-09-24 Thread Klaus Ma
> On Sept. 15, 2015, 12:59 p.m., Jan Schlicht wrote: > > Please rebase your patch, latest commits in master lots of JSON related > > stuff. > > Jan Schlicht wrote: > Will review this RR after rebase. The code diff was uploaded after resolving the conflict - Klaus

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-09-24 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review100413 --- 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review100393 --- Looking almost perfect! Really appreciate that you diligently

Re: Review Request 38697: Updated documentation strings for --launcher flag.

2015-09-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100439 --- Ship it! Ship It! - Jie Yu On Sept. 24, 2015, 6:44 a.m., Kapil

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 24, 2015, 8:02 p.m.) Review request for mesos, Jie Yu, Jojy

Re: Review Request 38726: Make common attributes symmetrical to v1 attributes.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38726/ --- (Updated Sept. 24, 2015, 6:30 p.m.) Review request for mesos and Benjamin

Re: Review Request 38727: Make common values symmetrical to v1 values.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38727/#review100457 --- Patch looks great! Reviews applied: [38726, 38727] All tests

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100452 --- Ship it! LGTM! Let's get this committed!

Re: Review Request 38728: Cgroups Test Filters aborts test.

2015-09-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38728/#review100454 --- Ship it! Ship It! - Ben Mahler On Sept. 24, 2015, 7:35 p.m.,

Review Request 38725: Fixed a typo for Agent help string for --launcher.

2015-09-24 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38725/ --- Review request for mesos, Jie Yu and Niklas Nielsen. Repository: mesos

Review Request 38726: Make common attributes symmetrical to v1 attributes.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38726/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 38727: Make common values symmetrical to v1 values.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38727/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-3510

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100451 --- Ship it! Ship It! - Jojy Varghese On Sept. 24, 2015, 9:21

Review Request 38730: Do not retry close on EINTR.

2015-09-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38730/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3512

Review Request 38729: Do not retry close on EINTR.

2015-09-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38729/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3512

Review Request 38731: Make common resources symmetrical to v1 resources.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38731/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-3510

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100449 --- Ship it! Thanks for being patient. Please commit this!

Re: Review Request 38726: Make common attributes symmetrical to v1 attributes.

2015-09-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38726/#review100480 --- Ship it! Ship It! - Ben Mahler On Sept. 24, 2015, 6:30 p.m.,

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

2015-09-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/ --- (Updated Sept. 24, 2015, 9:29 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38729: Do not retry close on EINTR.

2015-09-24 Thread Ben Mahler
> On Sept. 24, 2015, 8:55 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 133 > > > > > > Should we wrap it with #ifdef linux? Sadly, it is more involved than just an ifdef :( For example, on

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 24, 2015, 11:24 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/#review100499 --- Ship it! Ship It! - Vinod Kone On Sept. 24, 2015, 11:24 p.m.,

Re: Review Request 38729: Do not retry close on EINTR.

2015-09-24 Thread Jie Yu
> On Sept. 24, 2015, 8:55 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 133 > > > > > > Should we wrap it with #ifdef linux? > > Ben Mahler wrote: > Sadly, it is more involved than just

Re: Review Request 38729: Do not retry close on EINTR.

2015-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38729/#review100472 --- Ship it! Ship It! - Vinod Kone On Sept. 24, 2015, 7:41 p.m.,

Re: Review Request 38730: Do not retry close on EINTR.

2015-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38730/#review100473 --- Ship it! Ship It! - Vinod Kone On Sept. 24, 2015, 7:41 p.m.,

Re: Review Request 38731: Make common resources symmetrical to v1 resources.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38731/#review100474 --- Patch looks great! Reviews applied: [38726, 38727, 38731] All

Review Request 38738: Make common public header type_utils symmetrical to v1 mesos.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38738/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-3510

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Timothy Chen
> On Sept. 24, 2015, 9 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioner/docker/local_puller.hpp, line 40 > > > > > > s/docker_discovery_local_dir/docker_local_archives_dir/ > > > > I

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 24, 2015, 11:09 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38729: Do not retry close on EINTR.

2015-09-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38729/#review100463 --- 3rdparty/libprocess/src/subprocess.cpp (line 133)

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Jiang Yan Xu
> On Sept. 23, 2015, 12:50 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioner/docker/puller.hpp, line 60 > > > > > > If we use LinkedHashMap we don't need to create another struct right? > > Timothy

Review Request 38734: Cleaned up function signatures to use Option.

2015-09-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38734/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 38646: Added WIP note for Executor endpoint in changelog

2015-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38646/#review100493 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 9:18 p.m.,

Review Request 38733: Make common type_utils symmetrical to v1 mesos.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38733/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-3510

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-24 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review100494 --- src/docker/docker.cpp (line 422)

Re: Review Request 38726: Make common attributes symmetrical to v1 attributes.

2015-09-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38726/#review100498 --- Ship it! Ship It! - Benjamin Hindman On Sept. 24, 2015, 6:30

Re: Review Request 38731: Make common resources symmetrical to v1 resources.

2015-09-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38731/#review100496 --- Ship it! Ship It! - Benjamin Hindman On Sept. 24, 2015, 8:20

Re: Review Request 38733: Make common type_utils symmetrical to v1 mesos.

2015-09-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38733/#review100495 --- Ship it! But let's keep the 'checkpoint' stuff in type_utils.cpp

Re: Review Request 38727: Make common values symmetrical to v1 values.

2015-09-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38727/#review100497 --- Ship it! Ship It! - Benjamin Hindman On Sept. 24, 2015, 6:53

Review Request 38743: files: fix potential fd leaks under error conditions.

2015-09-24 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38743/ --- Review request for mesos. Repository: mesos Description --- files: fix

Re: Review Request 38730: Do not retry close on EINTR.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38730/#review100462 --- Patch looks great! Reviews applied: [38729, 38730] All tests

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

2015-09-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/ --- (Updated Sept. 24, 2015, 9:29 p.m.) Review request for mesos. Changes

Re: Review Request 38137: Added Docker provisioner, store and local puller

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100492 --- Patch looks great! Reviews applied: [38137] All tests passed. -

Re: Review Request 38646: Added WIP note for Executor endpoint in changelog

2015-09-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38646/ --- (Updated Sept. 25, 2015, 12:09 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review100507 --- Patch looks great! Reviews applied: [38468] All tests passed. -

Re: Review Request 38738: Make common public header type_utils symmetrical to v1 mesos.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38738/ --- (Updated Sept. 25, 2015, 12:45 a.m.) Review request for mesos, Benjamin

Re: Review Request 38743: files: fix potential fd leaks under error conditions.

2015-09-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38743/#review100511 --- Ship it! Can't wait to have a ref-counted abstraction to avoid

Review Request 38747: Adding digest utilities

2015-09-24 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- Review request for mesos, Gilbert Song and Timothy Chen. Repository: mesos

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 24, 2015, 11:48 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38734: Cleaned up function signatures to use Option.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38734/#review100501 --- Patch looks great! Reviews applied: [38734] All tests passed. -

Re: Review Request 38733: Make common type_utils symmetrical to v1 mesos.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38733/ --- (Updated Sept. 25, 2015, 12:06 a.m.) Review request for mesos and Benjamin

Re: Review Request 38731: Make common resources symmetrical to v1 resources.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38731/ --- (Updated Sept. 25, 2015, 12:07 a.m.) Review request for mesos and Benjamin

Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

2015-09-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone. Bugs:

Re: Review Request 38607: Pulled out an encode function for http::Request encoding.

2015-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38607/#review100500 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 6:18 a.m.,

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/ --- (Updated Sept. 25, 2015, 1:12 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38738: Make common public header type_utils symmetrical to v1 mesos.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38738/#review100518 --- Bad patch! Reviews applied: [38726] Failed command:

Re: Review Request 38749: Added `image_providers` flags to configuration.md.

2015-09-24 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38749/#review100527 --- Ship it! Ship It! - Niklas Nielsen On Sept. 24, 2015, 9:57

Re: Review Request 38747: Adding digest utilities

2015-09-24 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 5:43 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review100526 --- Patch looks great! Reviews applied: [38746] All tests passed. -

Re: Review Request 38749: Added `image_providers` flags to configuration.md.

2015-09-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38749/#review100528 --- Ship it! Ship It! - Michael Park On Sept. 25, 2015, 4:57 a.m.,

Review Request 38750: Updated changelog for 0.25.0

2015-09-24 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38750/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 38747: Adding digest utilities

2015-09-24 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 5:46 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 37996: Added property manager

2015-09-24 Thread Alex Clemmer
> On Sept. 23, 2015, 5:40 p.m., Alex Clemmer wrote: > > Can we please add these tests to the CMakeLists.txt file in > > 3rdparty/libprocess/3rdparty/stout/tests? > > Alexander Rojas wrote: > It was done already since the first version of this patch. Ah. I'm so sorry. I just kind of troll

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-09-24 Thread Alex Clemmer
> On Sept. 23, 2015, 5:39 p.m., Alex Clemmer wrote: > > Can we please add this file to the CMakeLists.txt file in > > 3rdparty/libprocess/src as well? > > Alexander Rojas wrote: > The included file is a header and so far cmake file doesn't seem to care > about the include directory (can

Review Request 38728: Cgroups Test Filters aborts test.

2015-09-24 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38728/ --- Review request for mesos, Ben Mahler and Ian Downes. Bugs: MESOS-3513

Re: Review Request 38738: Make common public header type_utils symmetrical to v1 mesos.

2015-09-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38738/#review100504 --- Ship it! Let's actually keep the comment (but change the wording

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100505 --- Mostly just python style and commenting. My python is a bit rusty

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review100520 --- Patch looks great! Reviews applied: [38338] All tests passed. -

Review Request 38749: Added `image_providers` flags to configuration.md.

2015-09-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38749/ --- Review request for mesos and Niklas Nielsen. Repository: mesos Description

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review100509 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-24 Thread haosdent huang
> On Sept. 24, 2015, 11:28 p.m., Vaibhav Khanduja wrote: > > src/docker/docker.cpp, line 422 > > > > > > volumn - "volume" fixed. - haosdent --- This is

Re: Review Request 38654: Added digest verifier for image blobs

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38654/#review100517 --- Patch looks great! Reviews applied: [38443, 38579, 38580, 38654]

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-09-24 Thread Klaus Ma
> On Sept. 24, 2015, 3:52 p.m., Jan Schlicht wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 609 > > > > > > s/protobuf(const T& message)/protobuf(const google::protobuf::Message& > >

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/#review100477 --- src/tests/executor_http_api_tests.cpp (line 95)

Re: Review Request 38731: Make common resources symmetrical to v1 resources.

2015-09-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38731/#review100485 --- Ship it! Ship It! - Ben Mahler On Sept. 24, 2015, 8:20 p.m.,

Re: Review Request 38654: Added digest verifier for image blobs

2015-09-24 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38654/ --- (Updated Sept. 25, 2015, 12:38 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 38646: Added WIP note for Executor endpoint in changelog

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38646/#review100515 --- Patch looks great! Reviews applied: [38646] All tests passed. -

Re: Review Request 38747: Adding digest utilities

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100530 --- Bad patch! Reviews applied: [38443, 38579, 38580, 38747] Failed