Re: Review Request 38837: CMake: Disable slave build on Windows.

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/#review100933 --- Patch looks great! Reviews applied: [38825, 38826, 38827, 38837]

Re: Review Request 38816: add test case for docker remotePuller

2015-09-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38816/#review100928 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 47)

Re: Review Request 38810: poll_socket: fix a file descriptor leak under error condition.

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38810/#review100847 --- Patch looks great! Reviews applied: [38810] All tests passed. -

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

2015-09-28 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review100848 --- I'll get this in today :) Thanks Neil! - Niklas Nielsen On

Re: Review Request 38819: Fixed a bug in cgroups test filter.

2015-09-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38819/#review100853 --- Ship it! Much appreciated :) - Ben Mahler On Sept. 28, 2015,

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review100854 --- Patch looks great! Reviews applied: [38809] All tests passed. -

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/#review100821 --- Ship it! Ship It! - haosdent huang On Sept. 28, 2015, 5:08

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- (Updated Sept. 28, 2015, 5:08 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/#review100824 --- Haosdent, are you going to close these two now that they have been

Re: Review Request 38747: Adding digest utilities

2015-09-28 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100850 --- High-level comments: - This implementation relies on

Review Request 38819: Fixed a bug in cgroups test filter.

2015-09-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38819/ --- Review request for mesos, Ben Mahler and Paul Brett. Repository: mesos

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-09-28 Thread Jie Yu
> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backends/overlay.cpp, line 58 > > > > > > You also want to check if overlay fs is supported or not. Not every > > linux kernel

Review Request 38814: add test cases for sha512 digest verifier

2015-09-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38814/ --- Review request for mesos, Jojy Varghese and Timothy Chen. Repository: mesos

Re: Review Request 38597: Added URL within http::Request.

2015-09-28 Thread Ben Mahler
> On Sept. 23, 2015, 9:10 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/decoder.hpp, line 157 > > > > > > not needed anymore? Yes not needed, not totally obvious but if you look at the ifdef'ed

Re: Review Request 38160: Documented how to expedite event firing.

2015-09-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/#review100820 --- Ship it! Ship It! - haosdent huang On Sept. 28, 2015, 5:09

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

2015-09-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37502/#review100822 --- Haosdent, are you going to close these two now that they have been

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100823 --- Ship it! support/apply-reviews.py (line 8)

Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/ --- Review request for mesos. Bugs: MESOS-3391

Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3519

Re: Review Request 38160: Documented how to expedite event firing.

2015-09-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/ --- (Updated Sept. 28, 2015, 5:09 p.m.) Review request for mesos, Bernd Mathiske

Review Request 38810: poll_socket: fix a file descriptor leak under error condition.

2015-09-28 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38810/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3519

Re: Review Request 38160: Documented how to expedite event firing.

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/#review100833 --- Patch looks great! Reviews applied: [38161, 38160] All tests

Review Request 38816: make changes corresponding to the change in remote_puller.cpp

2015-09-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38816/ --- Review request for mesos, Jojy Varghese and Timothy Chen. Bugs: MESOS-3494

Re: Review Request 38816: add test case for docker remotePuller

2015-09-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38816/ --- (Updated Sept. 28, 2015, 6:27 p.m.) Review request for mesos, Jojy Varghese

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review100831 --- 3rdparty/libprocess/src/socket.cpp (line 40)

Re: Review Request 38747: Adding digest utilities

2015-09-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100835 --- 3rdparty/libprocess/include/process/digest.hpp (line 191)

Re: Review Request 38747: Adding digest utilities

2015-09-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100839 --- 3rdparty/libprocess/include/process/digest.hpp (lines 210 - 226)

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Alex Clemmer
> On Sept. 28, 2015, 8:43 p.m., Alex Clemmer wrote: > > Can you add this comment to the CMake build system as well? > > > > The file you need to change is here: > > https://github.com/apache/mesos/blob/master/3rdparty/CMakeLists.txt Should > > be line 40, above `PATCH_CMD`. > > Chris Chen

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
> On Sept. 28, 2015, 8:43 p.m., Alex Clemmer wrote: > > Can you add this comment to the CMake build system as well? > > > > The file you need to change is here: > > https://github.com/apache/mesos/blob/master/3rdparty/CMakeLists.txt Should > > be line 40, above `PATCH_CMD`. > > Chris Chen

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Neil Conway
> On Sept. 28, 2015, 6:03 p.m., Neil Conway wrote: > > 3rdparty/libprocess/src/socket.cpp, line 77 > > > > > > Why is this conditional on socketFd? > > Chi Zhang wrote: > The idea is I am only responsible for

Re: Review Request 38823: io: fixed a file descriptor leak in io::redirect.

2015-09-28 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38823/ --- (Updated Sept. 28, 2015, 9:34 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38823: io: fixed a file descriptor leak in io::redirect.

2015-09-28 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38823/ --- (Updated Sept. 28, 2015, 9:36 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38443: Added layerid information to ManifestResponse

2015-09-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/#review100856 --- src/slave/containerizer/provisioner/docker/registry_client.cpp

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
> On Sept. 28, 2015, 8:43 p.m., Alex Clemmer wrote: > > Can you add this comment to the CMake build system as well? > > > > The file you need to change is here: > > https://github.com/apache/mesos/blob/master/3rdparty/CMakeLists.txt Should > > be line 40, above `PATCH_CMD`. I don't see that

Re: Review Request 38814: add test cases for sha512 digest verifier

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38814/#review100859 --- Bad patch! Reviews applied: [38443] Failed command:

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/#review100860 --- Can you add this comment to the CMake build system as well? The

Re: Review Request 38774: state: fix file descriptor leak

2015-09-28 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38774/ --- (Updated Sept. 28, 2015, 8:42 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/ --- (Updated Sept. 28, 2015, 9:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38580: Added docker registry RemotePuller

2015-09-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review100869 --- src/slave/containerizer/provisioner/docker/remote_puller.cpp

Review Request 38823: io: fixed a file descriptor leak in io::redirect.

2015-09-28 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38823/ --- Review request for mesos. Repository: mesos Description --- io: fixed a

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-09-28 Thread Klaus Ma
> On Sept. 28, 2015, 9:11 a.m., Jan Schlicht wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 762 > > > > > > Because this code has been changed from a constructor to a function, we >

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-09-28 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Sept. 28, 2015, 11:42 a.m.) Review request for mesos, Adam B,

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-09-28 Thread Jan Schlicht
> On Sept. 25, 2015, 3:35 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 609 > > > > > > 1. You can also use `inline`, that's what we usually do. > > 2.

Re: Review Request 37996: Added property manager

2015-09-28 Thread Alexander Rojas
> On Sept. 25, 2015, 11:12 a.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/properties.hpp, line 67 > > > > > > Why use a string instead of a stout::Path? I created the issue MESOS-3531 to

Re: Review Request 38747: Adding digest utilities

2015-09-28 Thread Neil Conway
> On Sept. 28, 2015, 6:32 p.m., Neil Conway wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 222 > > > > > > Why do we initialize this to `{0}`? > > Jojy Varghese wrote: > initialization of auto

Re: Review Request 38817: Added a SIGPIPE handler for the libprocess tests.

2015-09-28 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38817/#review100881 --- 3rdparty/libprocess/src/tests/main.cpp (line 41)

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/ --- (Updated Sept. 28, 2015, 11:45 p.m.) Review request for mesos and Jiang Yan

Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38828/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3519

Re: Review Request 38443: Added layerid information to ManifestResponse

2015-09-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/ --- (Updated Sept. 28, 2015, 10:50 p.m.) Review request for mesos and Timothy

Review Request 38826: CMake: Added support for libevent for Unix builds.

2015-09-28 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38826/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38827: CMake: Expanded support for compiling much of the master.

2015-09-28 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38827/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

2015-09-28 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38817: Added a SIGPIPE handler for the libprocess tests.

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38817/#review100873 --- Patch looks great! Reviews applied: [38817] All tests passed. -

Re: Review Request 38747: Adding digest utilities

2015-09-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 28, 2015, 10:14 p.m.) Review request for mesos, Gilbert Song

Re: Review Request 38747: Adding digest utilities

2015-09-28 Thread Jojy Varghese
> On Sept. 28, 2015, 7:17 p.m., Jiang Yan Xu wrote: > > High-level comments: > > > > - This implementation relies on USE_SSL_SOCKET which is tied to > > `--enable_ssl`. Conceptually the two should be decoupled. Ian Downes has an > > implementation which uses the system commands that are

Re: Review Request 38817: Added a SIGPIPE handler for the libprocess tests.

2015-09-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38817/#review100883 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 28, 2015,

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

2015-09-28 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- (Updated Sept. 28, 2015, 10:58 p.m.) Review request for mesos, Artem

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

2015-09-28 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38826/ --- (Updated Sept. 28, 2015, 10:58 p.m.) Review request for mesos, Artem

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/#review100888 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
> On Sept. 28, 2015, 11:18 p.m., Mesos ReviewBot wrote: > > Bad review! > > > > Reviews applied: [] > > > > Error: > > No reviewers specified. Please find a reviewer by asking on JIRA or the > > mailing list. FINE. - Chris --- This

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Jiang Yan Xu
> On Sept. 28, 2015, 4:18 p.m., Mesos ReviewBot wrote: > > Bad review! > > > > Reviews applied: [] > > > > Error: > > No reviewers specified. Please find a reviewer by asking on JIRA or the > > mailing list. > > Chris Chen wrote: > FINE. Doesn't look like the change to

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/#review100851 --- Ship it! LGTM. Will commit it after reviewbot gives it a pass. -

Review Request 38817: Added a SIGPIPE handler for the libprocess tests.

2015-09-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38817/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 37703: Add docker exec command.

2015-09-28 Thread haosdent huang
> On Sept. 29, 2015, 1:24 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 1164 > > > > > > We're now supporting optional docker socket (-H), if you look at other > > commands. > > > > Perhaps we

Re: Review Request 38835: Ignore SIGPIPE when finalizing libevent.

2015-09-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38835/ --- (Updated Sept. 29, 2015, 1:46 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38835: Ignore SIGPIPE when finalizing libevent.

2015-09-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38835/#review100919 --- Ship it! Thanks! 3rdparty/libprocess/src/libevent.cpp (line

Review Request 38837: CMake: Disable slave build on Windows.

2015-09-28 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38827: CMake: Expanded support for compiling much of the master.

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38827/#review100921 --- Patch looks great! Reviews applied: [38825, 38826, 38827] All

Re: Review Request 38817: Added a SIGPIPE handler for the libprocess tests.

2015-09-28 Thread Ben Mahler
> On Sept. 28, 2015, 10:52 p.m., Cong Wang wrote: > > 3rdparty/libprocess/src/tests/main.cpp, line 41 > > > > > > Here you probably want a signal string (strsignal ()) instead of a raw > > value. >From what I can

Re: Review Request 38822: Added default upgrade steps to 0.24.X to 0.25.X section

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38822/#review100902 --- Patch looks great! Reviews applied: [38822] All tests passed. -

Re: Review Request 38814: add test cases for sha512 digest verifier

2015-09-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38814/#review100893 --- 3rdparty/libprocess/src/tests/digest_tests.cpp (line 82)

Re: Review Request 38774: state: fix file descriptor leak

2015-09-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38774/#review100907 --- Ship it! I'll get this committed shortly, thanks!

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38828/#review100908 --- src/slave/containerizer/docker.cpp

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/#review100910 --- 3rdparty/CMakeLists.txt (line 41)

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review100909 --- 3rdparty/libprocess/include/process/socket.hpp (lines 64 - 65)

Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253

2015-09-28 Thread Chris Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/ --- (Updated Sept. 29, 2015, 12:50 a.m.) Review request for mesos and Jiang Yan

Re: Review Request 38747: Adding digest utilities

2015-09-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 29, 2015, 12:19 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 38823: io: fixed a file descriptor leak in io::redirect.

2015-09-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38823/#review100906 --- Ship it! Ship It! - Ben Mahler On Sept. 28, 2015, 9:36 p.m.,

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Chi Zhang
> On Sept. 29, 2015, 12:31 a.m., Ben Mahler wrote: > > src/slave/containerizer/docker.cpp, lines 926-928 > > > > > > I believe these were in place to terminate the subprocess, so perhaps a > > killtree with SIGTERM

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Chi Zhang
> On Sept. 29, 2015, 12:31 a.m., Ben Mahler wrote: > > src/slave/containerizer/docker.cpp, lines 926-928 > > > > > > I believe these were in place to terminate the subprocess, so perhaps a > > killtree with SIGTERM

Review Request 38835: Ignore SIGPIPE when finalizing libevent.

2015-09-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38835/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3540

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38828/#review100913 --- src/slave/containerizer/docker.cpp

Re: Review Request 37703: Add docker exec command.

2015-09-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review100914 --- src/docker/docker.cpp (line 1164)

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review100915 --- Patch looks great! Reviews applied: [38809] All tests passed. -

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-09-28 Thread Klaus Ma
> On Sept. 28, 2015, 9:11 a.m., Jan Schlicht wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 762 > > > > > > Because this code has been changed from a constructor to a function, we >

Review Request 38822: Added default upgrade steps to 0.24.X to 0.25.X section

2015-09-28 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38822/ --- Review request for mesos, Joris Van Remoortere, switched to 'mcypark', and

Re: Review Request 38580: Added docker registry RemotePuller

2015-09-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review100867 --- src/slave/containerizer/provisioner/docker/remote_puller.cpp

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-09-28 Thread Jan Schlicht
> On Sept. 28, 2015, 11:11 a.m., Jan Schlicht wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 762 > > > > > > Because this code has been changed from a constructor to a function, we >