Re: Review Request 37703: Add docker exec command.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review101402 --- Patch looks great! Reviews applied: [37703] All tests passed. -

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/ --- (Updated Oct. 3, 2015, 3:55 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/ --- (Updated Oct. 3, 2015, 1:26 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review101405 --- IMHO, we keep both apply-reviews.py and apply-reviews.sh and call

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/#review101404 --- Patch looks great! Reviews applied: [38932] All tests passed. -

Re: Review Request 37703: Add docker exec command.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/ --- (Updated Oct. 3, 2015, 9:09 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36816: Support HTTP checks in Mesos health check program

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Oct. 3, 2015, 5:49 p.m.) Review request for mesos, Adam B, Michael

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-03 Thread Vaibhav Khanduja
> On Sept. 25, 2015, 6:18 p.m., Timothy Chen wrote: > > Can you add a test for this logic? > > haosdent huang wrote: > Could, but because volume-driver depends on flocker, my test ideas for > this is verify the docker run command is correct. Docker also supports "local" as a volume

Re: Review Request 37023: Add an endpoint that exposes component flags.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/ --- (Updated Oct. 3, 2015, 4:49 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 36181: Port CFS support to Docker Containerizer

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36181/ --- (Updated Oct. 3, 2015, 5:14 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36431: Show stdout/stderr when using mesos-execute.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/#review101417 --- Patch looks great! Reviews applied: [36431] All tests passed. -

Re: Review Request 38337: Extract gz file in fetcher.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38337/ --- (Updated Oct. 3, 2015, 4:05 p.m.) Review request for mesos, Adam B and Timothy

Re: Review Request 36838: Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36838/ --- (Updated Oct. 3, 2015, 5:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38532: Add error message when cgroup don't support memory.pressure_level.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38532/ --- (Updated Oct. 3, 2015, 4 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review101406 --- Patch looks great! Reviews applied: [38338] All tests passed. -

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/ --- (Updated Oct. 3, 2015, 4:52 p.m.) Review request for mesos, Adam B, Ian

Re: Review Request 35711: Disallow special characters in role name.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review101411 --- Patch looks great! Reviews applied: [35711] All tests passed. -

Re: Review Request 36431: Show stdout/stderr when using mesos-execute.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/ --- (Updated Oct. 3, 2015, 4:12 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 35711: Disallow special characters in role name.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated Oct. 3, 2015, 4:11 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 38532: Add error message when cgroup don't support memory.pressure_level.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38532/#review101408 --- Patch looks great! Reviews applied: [38532] All tests passed. -

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38164/ --- (Updated Oct. 3, 2015, 4:17 p.m.) Review request for mesos, Ian Downes and Jie

Re: Review Request 38527: Fix UserCgroupIsolatorTest failed on CentOS 6.6.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38527/ --- (Updated Oct. 3, 2015, 4:15 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

2015-10-03 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/#review101413 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 29, 2015,

Re: Review Request 36816: Support HTTP checks in Mesos health check program

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Oct. 3, 2015, 6:01 p.m.) Review request for mesos, Adam B, Michael

Re: Review Request 38337: Extract gz file in fetcher.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38337/#review101409 --- Patch looks great! Reviews applied: [38337] All tests passed. -

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

2015-10-03 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38826/ --- (Updated Oct. 3, 2015, 11:36 p.m.) Review request for mesos, Artem

Review Request 38976: CMake: Removed unused libsvn binaries from `FindSvn.cmake`.

2015-10-03 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38976/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38976: CMake: Removed unused libsvn binaries from `FindSvn.cmake`.

2015-10-03 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38976/#review101419 --- Ship it! - Joris Van Remoortere On Oct. 3, 2015, 10:03 p.m.,

Re: Review Request 38827: CMake: Expanded support for compiling much of the master.

2015-10-03 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38827/#review101415 --- Ship it! - Joris Van Remoortere On Sept. 29, 2015, 8:21 p.m.,

Re: Review Request 38837: CMake: Disable agent build on Windows.

2015-10-03 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/#review101416 --- Ship it! - Joris Van Remoortere On Sept. 29, 2015, 8:21 p.m.,

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

2015-10-03 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38826/#review101414 --- Ship it! - Joris Van Remoortere On Oct. 3, 2015, 11:45 p.m.,

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Oct. 4, 2015, 5:35 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38900: Update command executor to support rootfs.

2015-10-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review101430 --- src/slave/slave.cpp (line 3312)

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38164/#review101420 --- Patch looks great! Reviews applied: [38164] All tests passed. -

Re: Review Request 38826: CMake: Added support for libevent for Unix builds.

2015-10-03 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38826/ --- (Updated Oct. 3, 2015, 11:45 p.m.) Review request for mesos, Artem

Re: Review Request 38825: CMake: Plumb `ENABLE_LIBEVENT` through libprocess config scripts.

2015-10-03 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38825/ --- (Updated Oct. 3, 2015, 11:45 p.m.) Review request for mesos, Artem

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/#review101422 --- Patch looks great! Reviews applied: [36180] All tests passed. -

Re: Review Request 36838: Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36838/#review101424 --- Patch looks great! Reviews applied: [36838] All tests passed. -

Review Request 38977: Add reason for declineOffer

2015-10-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38977/ --- Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-10-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 十月 4, 2015, 4:24 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review101429 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 38977: Add reason for declineOffer

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38977/#review101427 --- Patch looks great! Reviews applied: [38977] All tests passed. -

Re: Review Request 38527: Fix UserCgroupIsolatorTest failed on CentOS 6.6.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38527/#review101418 --- Patch looks great! Reviews applied: [38527] All tests passed. -

Re: Review Request 36816: Support HTTP checks in Mesos health check program

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review101426 --- Patch looks great! Reviews applied: [36816] All tests passed. -

Re: Review Request 37023: Add an endpoint that exposes component flags.

2015-10-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/#review101428 --- For the description, I think that the current endpoint does not

Re: Review Request 38579: Refactored registry client

2015-10-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101401 --- src/slave/containerizer/provisioner/docker/registry_client.cpp