Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/ --- Review request for mesos, Benjamin Bannier, Ben Mahler, and Till Toenshoff.

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review102774 --- src/tests/fault_tolerance_tests.cpp (line 721)

Review Request 39340: RegistryClient: Added streaming response read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/#review102777 --- src/slave/containerizer/fetcher.cpp (line 703)

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/#review102779 --- Ship it! src/slave/containerizer/fetcher.cpp (line 703)

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review102822 ---

Review Request 39363: Fixed a double deletion race in ProcessManager::wait.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39363/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-3728

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/ --- (Updated Oct. 15, 2015, 5:03 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39340: RegistryClient: Added streaming response read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/ --- (Updated Oct. 16, 2015, 12:15 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review102857 --- Patch looks great! Reviews applied: [39013, 38443, 39184, 39155,

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Oct. 15, 2015, 10:54 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review102836 --- Patch looks great! Reviews applied: [39353] All tests passed. -

Re: Review Request 39250: Puller refactor: moved untar to a common place

> On Oct. 15, 2015, 10:51 p.m., Timothy Chen wrote: > > Ship It! > > Timothy Chen wrote: > This doesn't seem to depend on anything from 38747. I'll be merging this > without the previous one. > > Timothy Chen wrote: > Btw please rebase this patch. The dependency is because

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review102839 --- Ship it! Ship It! - Gilbert Song On Oct. 15, 2015, 12:17 p.m.,

Re: Review Request 39340: RegistryClient: Added streaming response read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/#review102852 --- Patch looks great! Reviews applied: [39013, 38443, 39184, 39155,

Re: Review Request 38051: Only update the task status when its old status is not terminal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated 十月 16, 2015, 2:36 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102860 --- Patch looks great! Reviews applied: [39365] All tests passed. -

Re: Review Request 39368: Updated /state.json to show revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39368/#review102861 --- Ship it! src/common/http.cpp (line 68)

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Oct. 16, 2015, 12:17 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38051: Only update the task status when its old status is not terminal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated 十月 16, 2015, 2:03 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102856 --- Ship it! Ship It! - Guangya Liu On 十月 16, 2015, 12:30 a.m.,

Re: Review Request 39363: Fixed a double deletion race in ProcessManager::wait.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39363/#review102835 --- Ship it! Ship It! - Jie Yu On Oct. 15, 2015, 11:32 p.m., Ben

Re: Review Request 39250: Puller refactor: moved untar to a common place

> On Oct. 15, 2015, 10:51 p.m., Timothy Chen wrote: > > Ship It! > > Timothy Chen wrote: > This doesn't seem to depend on anything from 38747. I'll be merging this > without the previous one. Btw please rebase this patch. - Timothy

Re: Review Request 39250: Puller refactor: moved untar to a common place

> On Oct. 15, 2015, 10:51 p.m., Timothy Chen wrote: > > Ship It! This doesn't seem to depend on anything from 38747. I'll be merging this without the previous one. - Timothy --- This is an automatically generated e-mail. To reply,

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102837 --- Ship it! LGTM - Anand Mazumdar On Oct. 16, 2015, 12:03 a.m.,

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Oct. 16, 2015, 12:20 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/ --- (Updated Oct. 15, 2015, 5:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38051: Only update the task status when its old status is not terminal.

> On 十月 15, 2015, 6:38 p.m., Vinod Kone wrote: > > src/tests/status_update_manager_tests.cpp, line 844 > > > > > > new line. Do you mean to add an another new line? I found two new lines are added before all

Re: Review Request 39368: Updated /state.json to show revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39368/#review102858 --- Ship it! Ship It! - Jian Qiu On Oct. 16, 2015, 12:48 a.m.,

Re: Review Request 39358: Network monitoring metrics table has common style

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39358/#review102830 --- Patch looks great! Reviews applied: [39358] All tests passed. -

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39360/ --- (Updated Oct. 15, 2015, 4:23 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102841 --- src/scheduler/scheduler.cpp (line 170)

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

> On Oct. 15, 2015, 5:13 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 170 > > > > > > For posterity, can you add a blurb in the review on what the exact > > issue is? > > > > Also, are the

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39360/#review102849 --- Patch looks great! Reviews applied: [39360] All tests passed. -

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/#review102848 --- Ship it! Ship It! - Marco Massenzio On Oct. 15, 2015, 1:11

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 16, 2015, 1:45 a.m.) Review request for mesos, Ben Mahler,

Review Request 39372: Introduced a callback interface for testing the Scheduler Library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39372/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 15, 2015, 8:36 p.m.) Review request for mesos, Artem

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/ --- (Updated Oct. 15, 2015, 8:31 p.m.) Review request for mesos, Artem

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/ --- (Updated Oct. 15, 2015, 8:31 p.m.) Review request for mesos, Artem

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review102827 --- Ship it! Ship It!

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

> On Oct. 15, 2015, 8:28 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/message.hpp, line 51 > > > > > > Would this also allow @@ or @@@ ? Wondering if we can use a regular > > expression

Review Request 39358: Network monitoring metrics table has common style

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39358/ --- Review request for mesos, Dave Lester and Jie Yu. Repository: mesos

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

> On Oct. 13, 2015, 8:32 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp, > > lines 34-37 > > > > > > Which header defines the `environ` macro on Windows? And why

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review102816 --- src/slave/containerizer/provisioner/docker/message.hpp (line 46)

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

> On Oct. 15, 2015, 8:28 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/message.hpp, line 46 > > > > > > How about handling parse errors ? Maybe change this to a Try? Agreed, did you see

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 15, 2015, 8:33 p.m.) Review request for mesos, Artem

Re: Review Request 39288: [WIP] Quota: Added authentication of quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39288/ --- (Updated Oct. 15, 2015, 11:15 p.m.) Review request for mesos and Alexander

Re: Review Request 39340: RegistryClient: Added streaming response read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/ --- (Updated Oct. 15, 2015, 9:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 15, 2015, 9:24 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/ --- (Updated Oct. 15, 2015, 8:31 p.m.) Review request for mesos, Artem

Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39202/ --- (Updated Oct. 15, 2015, 8:31 p.m.) Review request for mesos, Artem

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

> On Oct. 15, 2015, 8:28 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/message.hpp, line 46 > > > > > > How about handling parse errors ? Maybe change this to a Try? > > Ben Mahler wrote:

Review Request 39360: Relocate MesosContainerizer specific files to the correct location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39360/ --- Review request for mesos, Ben Mahler, Jie Yu, Jojy Varghese, and Timothy Chen.

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

> On Oct. 15, 2015, 8:58 p.m., James Peach wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ftruncate.hpp, > > line 30 > > > > > > Should this be ```_chsize_s``` so you can use a large offset?

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

> On Oct. 9, 2015, 8:12 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioner/docker/spec.hpp, line 22 > > > > > > Do we need this ? If not, remove this include. > > Gilbert Song wrote: > Ditto. It

Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39381/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39385: Fixed link conversion regexp in website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39385/ --- Review request for mesos and Dave Lester. Repository: mesos Description

Re: Review Request 38919: Validation of Docker Image Manifests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102866 --- Mesos style checker didn't pass for this patch. I'll fix this for

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 16, 2015, 4:45 a.m.) Review request for mesos, Artem

Review Request 39376: Windows: Prepared agent for Windows support of `process/socket.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39376/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39375: Windows: Introduced socket flag interop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39375/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39379: Windows: Prepared agent for Windows changes to `stout/flags/flags.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39379/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39377: Windows: Add Windows support to `process/socket.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39377/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39385: Fixed link conversion regexp in website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39385/ --- (Updated Oct. 16, 2015, 4:42 a.m.) Review request for mesos and Dave Lester.

Review Request 39386: Fix uncorrect launcher dir in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3738

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

> On Oct. 13, 2015, 8:32 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp, > > lines 34-37 > > > > > > Which header defines the `environ` macro on Windows? And why

Re: Review Request 38051: Only update the task status when its old status is not terminal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review102870 --- Patch looks great! Reviews applied: [38051] All tests passed. -

Re: Review Request 39340: RegistryClient: Added streaming response read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/#review102793 --- Patch looks great! Reviews applied: [39013, 38443, 39184, 39155,

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review102795 --- Bad patch! Reviews applied: [39345] Failed command:

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

> On Oct. 14, 2015, 2:17 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/process.cpp, line 2354 > > > > > > Let's clean this up a little bit. IIUC this is the only place in the > > code where we dispatch

Review Request 39345: Enable build on FreeBSD, start porting components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- Review request for mesos and Ian Downes. Bugs:

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 15, 2015, 5:16 p.m.) Review request for mesos and Ian Downes.

Review Request 39350: Adopt os::pipe in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39350/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2079

Re: Review Request 39259: Enable scheduler driver can use Call::REQUEST to request resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39259/#review102804 --- Ship it! Ship It! - Vinod Kone On Oct. 13, 2015, 1:29 p.m.,

Re: Review Request 38051: Only update the task status when its old status is not terminal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review102731 --- Ship it! src/master/master.cpp (line 6022)

Review Request 39348: Fix signal blocking race condition on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39348/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2079

Review Request 39349: Add a Stout wrapper for pipe(2).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39349/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2079

Review Request 39353: Fixed and added tests for docker image name parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/ --- Review request for mesos, Jojy Varghese and Timothy Chen. Repository: mesos

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 15, 2015, 6:50 p.m.) Review request for mesos, Alexander

Review Request 39347: Add stout wrappers for toggling NOSIGPIPE on file descriptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39347/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2079

Review Request 39351: Adopt os::pipe in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39351/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2079