Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-10-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review102938 --- Ship it! Ship It! - Vinod Kone On Oct. 16, 2015, 2:36 a.m.,

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-16 Thread Neil Conway
> On Oct. 15, 2015, 12:31 a.m., Jie Yu wrote: > > src/messages/log.proto, line 148 > > > > > > I am just thinking about the rolling upgrade case. What happens if the > > old coordinator receives a response from a

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-10-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 16, 2015, 6:43 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/#review102947 --- Ship it! Ship It! - Joseph Wu On Oct. 15, 2015, 1:31 p.m.,

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Ben Mahler
> On Oct. 16, 2015, 7:29 a.m., Adam B wrote: > > src/slave/containerizer/fetcher.cpp, line 794 > > > > > > What's this string parameter that you're ignoring? If it's the Failure > > message, I'd think you'd want to

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

2015-10-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review102956 --- src/docker/docker.cpp (line 427)

Review Request 39404: Updated pre-commit hook to exit on style or split errors.

2015-10-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39404/ --- Review request for mesos, Ben Mahler and Artem Harutyunyan. Repository: mesos

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-16 Thread Neil Conway
> On Oct. 16, 2015, 6:21 p.m., Ben Mahler wrote: > > Thanks Neil! It looks like we have overlap between this and the effective > > code review doc here: > > http://mesos.apache.org/documentation/latest/effective-code-reviewing/ > > > > Should we just link to this from the submitting a patch

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

2015-10-16 Thread Marco Massenzio
> On Oct. 16, 2015, 5:30 p.m., Marco Massenzio wrote: > > Thanks for doing this. > > > > I think you will need to document the flags' usage in `configuration.md` > > (or wherever appropriate) and state clearly that it's **required** and what > > it should point to (in other words, what

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review102948 --- Ship it! Can you also update the summary/description of this

Re: Review Request 39404: Updated pre-commit hook to exit on style or split errors.

2015-10-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39404/#review102962 --- Ship it! Ship It! - Ben Mahler On Oct. 16, 2015, 6:25 p.m.,

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

2015-10-16 Thread Niklas Nielsen
> On Oct. 16, 2015, 11:18 a.m., Niklas Nielsen wrote: > > Also, let's get a test wired up to verify that this works :) - Niklas --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 39398: Sync TaskStatus::Reason enumerations in v1 API.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39398/#review102940 --- Patch looks great! Reviews applied: [39398] All tests passed. -

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review102945 --- src/slave/containerizer/provisioner/docker/store.cpp (line 169)

Re: Review Request 38117: Export per container SNMP statistics

2015-10-16 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review102933 --- include/mesos/mesos.proto (lines 702 - 720)

Re: Review Request 39347: Add stout wrappers for toggling NOSIGPIPE on file descriptors.

2015-10-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39347/#review102928 ---

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102930 --- Ship it! Ship It! - Joseph Wu On Oct. 15, 2015, 9:41 p.m.,

Review Request 39406: Removed no longer valid TODO around Heartbeat events in the Scheduler API protobuf

2015-10-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39406/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 39406: Removed no longer valid TODO around Heartbeat events in the Scheduler API protobuf

2015-10-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39406/#review102963 --- Ship it! Ship It! - Vinod Kone On Oct. 16, 2015, 6:36 p.m.,

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/#review102967 --- Ship it! Ship It! - Joseph Wu On Oct. 15, 2015, 1:33 p.m.,

Re: Review Request 39217: Windows: Added `stout/os/ftruncate.hpp`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 16, 2015, 7:54 p.m.) Review request for mesos, Artem

Re: Review Request 39380: Windows: Added support for `stout/flags/flags.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39380/#review102978 --- Ship it!

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102994 --- Ship it! Ship It! - Anand Mazumdar On Oct. 16, 2015, 9:25

Re: Review Request 39379: Windows: Prepared agent for Windows changes to `stout/flags/flags.hpp`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39379/ --- (Updated Oct. 16, 2015, 7:50 p.m.) Review request for mesos, Artem

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 16, 2015, 7:50 p.m.) Review request for mesos, Artem

Re: Review Request 39377: Windows: Add Windows support to `process/socket.hpp`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39377/ --- (Updated Oct. 16, 2015, 7:50 p.m.) Review request for mesos, Artem

Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39383: [OOPS, SORRY, I PUSHED THIS ONE BY ACCIDENT] Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/ --- (Updated Oct. 16, 2015, 7:51 p.m.) Review request for mesos, Artem

Re: Review Request 39375: Windows: Introduced socket flag interop.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39375/ --- (Updated Oct. 16, 2015, 7:50 p.m.) Review request for mesos, Artem

Re: Review Request 39383: [OOPS, SORRY, I PUSHED THIS ONE BY ACCIDENT] Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-16 Thread Alex Clemmer
> On Oct. 16, 2015, 8:23 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39383] > > > > Failed command: ./support/apply-review.sh -n -r 39383 > > > > Error: > > 2015-10-16 20:19:45 URL:https://reviews.apache.org/r/39383/diff/raw/ > > [6017/6017] -> "39383.patch" [1] >

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/ --- (Updated Oct. 16, 2015, 9:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39217: Windows: Added `stout/os/ftruncate.hpp`.

2015-10-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review102973 --- Ship it! Ship It! - James Peach On Oct. 16, 2015, 7:54 p.m.,

Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39378/#review102975 --- Ship it! Ship It! - Joseph Wu On Oct. 16, 2015, 12:50 p.m.,

Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.

2015-10-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39365/#review102995 --- Ship it! It's unfortunate to do EXITs for bad user inputs in a

Re: Review Request 39375: Windows: Introduced socket flag interop.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39375/#review102970 --- Ship it! Ship It! - Joseph Wu On Oct. 15, 2015, 9:34 p.m.,

Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39378/ --- (Updated Oct. 16, 2015, 7:50 p.m.) Review request for mesos, Artem

Re: Review Request 39377: Windows: Add Windows support to `process/socket.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39377/#review102974 --- Ship it! 3rdparty/libprocess/include/process/socket.hpp (line

Re: Review Request 39383: [OOPS, SORRY, I PUSHED THIS ONE BY ACCIDENT] Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/ --- (Updated Oct. 16, 2015, 8:03 p.m.) Review request for mesos, Artem

Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39381/#review102979 --- Ship it! Ship It! - Joseph Wu On Oct. 16, 2015, 12:50 p.m.,

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

2015-10-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102969 --- include/mesos/mesos.proto (lines 1104 - )

Re: Review Request 39217: Windows: Added `stout/os/ftruncate.hpp`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 16, 2015, 8 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39217: Windows: Added `stout/os/ftruncate.hpp`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- (Updated Oct. 16, 2015, 8 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39379: Windows: Prepared agent for Windows changes to `stout/flags/flags.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39379/#review102977 --- Ship it! Ship It! - Joseph Wu On Oct. 16, 2015, 12:50 p.m.,

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-16 Thread Alex Clemmer
> On Oct. 16, 2015, 5:51 p.m., Joseph Wu wrote: > > Can you also update the summary/description of this review? > > (s/chsize/ftruncate/) Good idea. I'll update it to use the commit message currently on the review. - Alex --- This is

Re: Review Request 39383: [OOPS, SORRY, I PUSHED THIS ONE BY ACCIDENT] Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/#review102981 --- Bad patch! Reviews applied: [39383] Failed command:

Re: Review Request 39368: Updated /state.json to show revocable resources.

2015-10-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39368/ --- (Updated Oct. 16, 2015, 7:33 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review102980 --- Ship it! Ship It! - Joseph Wu On Oct. 16, 2015, 12:50 p.m.,

Re: Review Request 39377: Windows: Add Windows support to `process/socket.hpp`.

2015-10-16 Thread Alex Clemmer
> On Oct. 16, 2015, 8:03 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/socket.hpp, line 20 > > > > > > Is this include used? > > > > I didn't see (an obvious) use through `socket.hpp`,

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review102993 --- Bad patch! Reviews applied: [39076, 39091, 39092, 39093, 39096,

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/ --- (Updated Oct. 16, 2015, 9:25 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-16 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review102877 --- Thanks for all the tips, Marco\! I learned a lot of Python here

Re: Review Request 39348: Fix signal blocking race condition on OS X.

2015-10-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39348/#review102884 --- Ship it! Ship It! - haosdent huang On Oct. 15, 2015, 6:03

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Artem Harutyunyan
> On Oct. 14, 2015, 9:45 a.m., Marco Massenzio wrote: > > Again lots of nit-picking, feel free to ignore what you disagree with > > strongly :) > > > > Also, instead of using your homemade `shell()` method and `Subprocess`, > > given the usage pattern I've noticed, you may want to consider

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 16, 2015, 12:03 a.m.) Review request for mesos, Benjamin

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-16 Thread Artem Harutyunyan
> On Oct. 14, 2015, 5:55 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 7 > > > > > > uhm... could we use `requests` instead? > > much more modern API and widespread use. `requests` looks great,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-16 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 15, 2015, 11:50 p.m.) Review request for mesos, Benjamin

Re: Review Request 39347: Add stout wrappers for toggling NOSIGPIPE on file descriptors.

2015-10-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39347/#review102882 --- Ship it! Ship It! - haosdent huang On Oct. 15, 2015, 6:02

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102885 --- Patch looks great! Reviews applied: [39384] All tests passed. -

Re: Review Request 39372: Introduced a callback interface for testing the Scheduler Library

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39372/#review102874 --- Patch looks great! Reviews applied: [39372] All tests passed. -

Re: Review Request 39368: Updated /state.json to show revocable resources.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39368/#review102879 --- Patch looks great! Reviews applied: [39368] All tests passed. -

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Adam B
> On Oct. 15, 2015, 6:24 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/fetcher.cpp, line 799 > > > > > > It would probably be better to stream the full message into the `LOG` > > object to get the full

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review102881 --- Bad patch! Reviews applied: [39076, 39091, 39092, 39093, 39096,

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-10-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/ --- (Updated Oct. 16, 2015, 9:28 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 39387: Make health check run outside for docker container task.

2015-10-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39387/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3599

Re: Review Request 39347: Add stout wrappers for toggling NOSIGPIPE on file descriptors.

2015-10-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39347/#review102883 ---

Re: Review Request 39349: Add a Stout wrapper for pipe(2).

2015-10-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39349/#review102889 ---

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Bernd Mathiske
> On Oct. 16, 2015, 12:29 a.m., Adam B wrote: > > src/slave/containerizer/fetcher.cpp, line 794 > > > > > > What's this string parameter that you're ignoring? If it's the Failure > > message, I'd think you'd want

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-16 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/ --- (Updated Oct. 16, 2015, 9:56 a.m.) Review request for mesos, Alexander

Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

2015-10-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-3740

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Bernd Mathiske
> On Oct. 16, 2015, 12:29 a.m., Adam B wrote: > > src/slave/containerizer/fetcher.cpp, line 794 > > > > > > What's this string parameter that you're ignoring? If it's the Failure > > message, I'd think you'd want

Re: Review Request 39350: Adopt os::pipe in libprocess.

2015-10-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39350/#review102887 --- Ship it! Ship It! - haosdent huang On Oct. 15, 2015, 6:04

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102893 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 16, 2015, 4:41

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102904 --- Bad patch! Reviews applied: [38705, 38883] Failed command:

Re: Review Request 39349: Add a Stout wrapper for pipe(2).

2015-10-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39349/#review102886 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/Makefile.am

Re: Review Request 39351: Adopt os::pipe in Mesos.

2015-10-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39351/#review102890 --- Ship it! Ship It! - haosdent huang On Oct. 15, 2015, 6:05

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/ --- (Updated Oct. 16, 2015, 1:56 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Adam B
> On Oct. 16, 2015, 12:29 a.m., Adam B wrote: > > src/slave/containerizer/fetcher.cpp, line 794 > > > > > > What's this string parameter that you're ignoring? If it's the Failure > > message, I'd think you'd want

Re: Review Request 39385: Fixed link conversion regexp in website.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39385/#review102895 --- Patch looks great! Reviews applied: [39385] All tests passed. -

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review102901 --- Patch looks great! Reviews applied: [39386] All tests passed. -

Re: Review Request 39387: Make health check run outside for docker container task.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39387/#review102911 --- Patch looks great! Reviews applied: [39387] All tests passed. -

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review102907 --- Patch looks great! Reviews applied: [39276] All tests passed. -

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-10-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/ --- (Updated Oct. 16, 2015, 11:44 a.m.) Review request for mesos, Benjamin

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-10-16 Thread Alexander Rukletsov
> On Oct. 15, 2015, 11:37 a.m., Benjamin Bannier wrote: > > src/tests/fault_tolerance_tests.cpp, line 721 > > > > > > I don't think hardcoding specific timeouts here is optimal ... there's > > nothing here that

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102867 --- - Timothy Chen On Oct. 9, 2015, 11:39 p.m., Gilbert Song wrote:

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review102915 --- Patch looks great! Reviews applied: [39388] All tests passed. -

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 16, 2015, 8:29 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Marco Massenzio
> On Oct. 16, 2015, 4:15 p.m., Marco Massenzio wrote: > > Ship It! Thanks for addressing comments! - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102921

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Marco Massenzio
> On Oct. 14, 2015, 4:45 p.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 40 > > > > > > (setting aside for a second that we should use `requests.get()` instead > > :) > > > > can you please

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102921 --- Ship it! Ship It! - Marco Massenzio On Oct. 16, 2015, 3:29

Review Request 39410: Added support for github to apply-reviews.py.

2015-10-16 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review103001 --- Patch looks great! Reviews applied: [39384] All tests passed. -

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review103006 --- Patch looks great! Reviews applied: [38705, 38883, 39410] All

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-10-16 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Oct. 16, 2015, 11:03 p.m.) Review request for mesos, Joris Van

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-10-16 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Oct. 16, 2015, 11:05 p.m.) Review request for mesos, Joris Van

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

2015-10-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review103005 --- src/docker/executor.cpp

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Marco Massenzio
> On Oct. 16, 2015, 4:15 p.m., Marco Massenzio wrote: > > Ship It! > > Marco Massenzio wrote: > Thanks for addressing comments! hey, minor nit: I've just noticed you insert whitespaces around named args: ``` "".format(url = USER_URL, user = username) ``` PEP8[0] requires that there are

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

2015-10-16 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review102939 --- Ship it! Thanks for doing this. I think you will need to

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102955 --- Thanks Neil! It looks like we have overlap between this and the