Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review103220 --- Patch looks great! Reviews applied: [39194] All tests passed. -

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-20 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review103227 --- Ship it! Worked flawlessly for me the first time! So much simpler

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-20 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 20, 2015, 12:28 a.m.) Review request for mesos, Benjamin

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-20 Thread Artem Harutyunyan
> On Oct. 19, 2015, 1:04 p.m., Vinod Kone wrote: > > support/apply-reviews.py, lines 49-52 > > > > > > i don't follow what's happening here. you are appending the same > > pair multiple times to the

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review103231 --- Bad patch! Reviews applied: [38342, 38335] Failed command:

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37998/ --- (Updated Oct. 20, 2015, 10:44 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 20, 2015, 6:09 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review103216 --- Ship it! Thanks for the update! - Guangya Liu On Oct. 20,

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Oct. 20, 2015, 12:09 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Oct. 20, 2015, 12:17 p.m.) Review request for mesos, Adam B, Bernd

Review Request 39472: Added the helper container InheritanceTree where nodes inherit values from their ancestors.

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39472/ --- Review request for mesos, Bernd Mathiske and Till Toenshoff. Bugs: MESOS-3231

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103234 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420]

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Oct. 20, 2015, noon) Review request for mesos, Adam B, Benjamin

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Oct. 20, 2015, 12:18 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-10-20 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review103235 --- 3rdparty/libprocess/src/authenticator.cpp (lines 81 - 84)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Oct. 20, 2015, 12:30 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103238 --- Patch looks great! Reviews applied: [39472, 39276, 37998, 37999,

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Oct. 20, 2015, 3:52 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-20 Thread Alexander Rojas
> On Oct. 12, 2015, 2:54 p.m., Marco Massenzio wrote: > > src/tests/module.hpp, lines 76-77 > > > > > > same comment here - it would be great to have fully-documented, > > properly-formatted javadoc here, also

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Oct. 20, 2015, 2:07 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-20 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 20, 2015, 12:42 a.m.) Review request for mesos, Benjamin

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103229 --- Patch looks great! Reviews applied: [39452] All tests passed. -

Re: Review Request 39457: Document messages in messages.proto.

2015-10-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/#review103218 --- src/messages/messages.proto (line 77)

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-20 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 20, 2015, 7:45 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-20 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 20, 2015, 12:45 a.m.) Review request for mesos, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-20 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 20, 2015, 12:45 a.m.) Review request for mesos, Adam B, Joris

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

2015-10-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39386/#review103255 --- Ship it! Ship It! - Timothy Chen On Oct. 19, 2015, 2:59 a.m.,

Re: Review Request 39472: Added the helper container InheritanceTree where nodes inherit values from their ancestors.

2015-10-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39472/ --- (Updated Oct. 20, 2015, 4:24 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-10-20 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review103291 --- Sorry for not finding the below in the first pass ...

Review Request 39490: Always create non-IP egress filters

2015-10-20 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-20 Thread Greg Mann
> On Oct. 20, 2015, 7:28 a.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, lines 744-748 > > > > > > I'm getting confused between `last_char` and `end`, since `end` isn't > > really

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/ --- (Updated Oct. 20, 2015, 5:13 p.m.) Review request for mesos, Adam B and Joseph

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-10-20 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 20, 2015, 7:06 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 20, 2015, 7:20 p.m.) Review request for mesos, Artem

Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

2015-10-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39381/ --- (Updated Oct. 20, 2015, 7:21 p.m.) Review request for mesos, Artem

Re: Review Request 39457: Document messages in messages.proto.

2015-10-20 Thread Joseph Wu
> On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote: > > For now, I'll keep "agent". I'm fairly certain we refer to agents as agents now. > On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote: > > src/messages/messages.proto, lines 132-137 > >

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39463/#review103293 --- It might be worth splitting out the "logical" changes from the

Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39381/#review103296 --- This review is no longer necessary. - Joris Van Remoortere On

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39484/#review103288 --- Patch looks great! Reviews applied: [39484] All tests passed. -

Re: Review Request 39457: Document messages in messages.proto.

2015-10-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/ --- (Updated Oct. 20, 2015, 10:26 a.m.) Review request for mesos, Artem

Re: Review Request 39457: Document messages in messages.proto.

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/#review103297 --- Patch looks great! Reviews applied: [39457] All tests passed. -

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio
> On Oct. 19, 2015, 10:34 p.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 44 > > > > > > Nit: Can we just check for `200` here (since the response from > > `Subscribe` should be `200` for a good

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/ --- (Updated Oct. 20, 2015, 4:22 p.m.) Review request for mesos, Adam B and Joseph

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103267 --- Ship it! docs/scheduler-http-api.md (line 36)

Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-10-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39484/ --- Review request for mesos, Michael Park and Timothy Chen. Bugs: MESOS-3113

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Oct. 20, 2015, 4:34 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39472: Added the helper container InheritanceTree where nodes inherit values from their ancestors.

2015-10-20 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39472/#review103266 --- Ship it! This code has already been reviewed in this RR:

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103276 --- Patch looks great! Reviews applied: [39452] All tests passed. -

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

2015-10-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39463/ --- (Updated Oct. 20, 2015, 8:10 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- (Updated Oct. 20, 2015, 2:22 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39380: Windows: Added support for `stout/flags/flags.hpp`.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39380/#review103281 --- Ship it! - Joris Van Remoortere On Oct. 19, 2015, 11:27 p.m.,

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review103283 --- Ship it! I added a patch before this similar to the other

Re: Review Request 38978: Add post-rewrite hook.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38978/#review103299 --- Ship it! Thanks so much haosdent! This will save many people

Re: Review Request 39490: Always create non-IP egress filters

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/#review103304 --- Patch looks great! Reviews applied: [39490] All tests passed. -

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 20, 2015, 8:45 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39457: Document messages in messages.proto.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/#review103307 --- Ship it! This looks great Joseph! Can you stay consistent with

Review Request 39496: Clarified libevent config error messages.

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39496/ --- Review request for mesos, Joris Van Remoortere and Neil Conway. Bugs:

Review Request 39494: Added libevent and ssl flags to config docs.

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-20 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/ --- (Updated Oct. 20, 2015, 1:51 p.m.) Review request for mesos, Adam B and Dave

Review Request 39495: Fix SSL flag cleanup for tests.

2015-10-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39495/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

2015-10-20 Thread Neil Conway
> On Oct. 20, 2015, 7:13 p.m., Joris Van Remoortere wrote: > > It might be worth splitting out the "logical" changes from the textual. > > As in the dispatch and test position variable. > > Otherwise we should update the commit message as that is not all that is > > happening in this patch. I

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

2015-10-20 Thread Neil Conway
> On Oct. 20, 2015, 7 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/owned.hpp, lines 202-203 > > > > > > In libprocess we use `snake_case`. > > You can also consider removing the

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

2015-10-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/ --- (Updated Oct. 20, 2015, 8:18 p.m.) Review request for mesos and Joris Van

Review Request 39493: Added yum update to CentOS 6.6 install docs.

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/ --- Review request for mesos, Adam B and haosdent huang. Bugs: MESOS-3506

Re: Review Request 39375: Windows: Introduced socket flag interop.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39375/#review103272 --- Ship it!

Re: Review Request 39376: Windows: Prepared agent for Windows support of `process/socket.hpp`.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39376/#review103275 --- Ship it! - Joris Van Remoortere On Oct. 19, 2015, 11:25 p.m.,

Re: Review Request 39379: Windows: Prepared agent for Windows changes to `stout/flags/flags.hpp`.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39379/#review103280 --- Ship it! - Joris Van Remoortere On Oct. 19, 2015, 11:27 p.m.,

Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39378/#review103279 --- Ship it! - Joris Van Remoortere On Oct. 19, 2015, 11:31 p.m.,

Re: Review Request 39377: Windows: Add Windows support to `process/socket.hpp`.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39377/#review103273 --- Ship it! 3rdparty/libprocess/include/process/socket.hpp (lines

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Oct. 20, 2015, 9:30 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39463/#review103303 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 20, 2015,

Re: Review Request 39457: Document messages in messages.proto.

2015-10-20 Thread Joseph Wu
> On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote: > > > > Joseph Wu wrote: > For now, I'll keep "agent". I'm fairly certain we refer to agents as > agents now. > > Guangya Liu wrote: > Joseph, do you have any reasons for why not update "slave" to "agent" in > the comments? When I

Re: Review Request 39494: Added libevent and ssl flags to config docs.

2015-10-20 Thread Greg Mann
> On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote: > > Not really related, but do you know if markdown-style tables are supported > > here? Hmmm... not sure. > On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote: > > docs/configuration.md, line 1768 > >

Re: Review Request 39494: Added libevent and ssl flags to config docs.

2015-10-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103319 --- Ship it! Ship It! - Gilbert Song On Oct. 20, 2015, 2:58 p.m.,

Re: Review Request 39493: Added yum update to CentOS 6.6 install docs.

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/#review103321 --- Patch looks great! Reviews applied: [39493] All tests passed. -

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review103320 --- src/slave/slave.cpp (line 1938)

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Ben Whitehead
> On Oct. 20, 2015, 9:38 a.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 66 > > > > > > Do we need this line anymore now ? This can be killed in favor of the > > following lines that we added around

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Ben Whitehead
> On Oct. 19, 2015, 3:34 p.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 59 > > > > > > Should we also mention why just encoding one event per chunk won't > > suffice and why we needed this ? > >

Re: Review Request 39494: Added libevent and ssl flags to config docs.

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- (Updated Oct. 20, 2015, 9:58 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-20 Thread Gilbert Song
> On Oct. 19, 2015, 2:05 p.m., Cong Wang wrote: > > You probably want to move src/tests/containerizer too? Seems too much things under src/tests/, we may want to rearrange all of them together. - Gilbert --- This is an automatically

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-20 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103312 --- Ship it! I guess you want to retain apply-reviews.sh for backward

Re: Review Request 39494: Added libevent and ssl flags to config docs.

2015-10-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103313 --- Ship it! Not really related, but do you know if markdown-style

Re: Review Request 39494: Added libevent and ssl flags to config docs.

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- (Updated Oct. 20, 2015, 9:55 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 39457: Document messages in messages.proto.

2015-10-20 Thread Guangya Liu
> On Oct. 20, 2015, 8:23 a.m., Guangya Liu wrote: > > > > Joseph Wu wrote: > For now, I'll keep "agent". I'm fairly certain we refer to agents as > agents now. Joseph, do you have any reasons for why not update "slave" to "agent" in the comments? When I was fixing

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-20 Thread Gilbert Song
> On Oct. 19, 2015, 1:05 p.m., Jie Yu wrote: > > This is great! Thanks! The current patch does not apply, can you do a > > rebase? Thanks. Rebased. - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Ben Whitehead
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103314 --- docs/scheduler-http-api.md (lines 29 - 34)

Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3772

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

2015-10-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- (Updated Oct. 20, 2015, 10:27 p.m.) Review request for mesos, Artem

Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

2015-10-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere,

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

2015-10-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/#review103334 --- Ship it! Ship It! - Guangya Liu On 十月 21, 2015, 1:04 a.m.,

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review103327 --- Patch looks great! Reviews applied: [39331] All tests passed. -

Re: Review Request 39457: Document messages in messages.proto.

2015-10-20 Thread Guangya Liu
> On Oct. 20, 2015, 8:23 a.m., Guangya Liu wrote: > > > > Joseph Wu wrote: > For now, I'll keep "agent". I'm fairly certain we refer to agents as > agents now. > > Guangya Liu wrote: > Joseph, do you have any reasons for why not update "slave" to "agent" in > the comments? When I

Re: Review Request 39496: Clarified libevent config error messages.

2015-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39496/#review103332 --- Patch looks great! Reviews applied: [39496] All tests passed. -

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review103331 --- Hey Mandeep, Thanks for taking on this important work! Some high

Re: Review Request 39494: Added libevent and ssl flags to config docs.

2015-10-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103340 --- docs/configuration.md (line 1655)

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-20 Thread Artem Harutyunyan
> On Oct. 20, 2015, 3:02 p.m., Adam B wrote: > > support/site-docker/Dockerfile, line 3 > > > > > > Where'd this version number come from? What does it mean? When do we > > increment it? I removed the comment line.

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-10-20 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review103336 --- 3rdparty/libprocess/src/process.cpp (line 2339)

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/#review103337 --- 3rdparty/libprocess/README.md (line 371)

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-10-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review103339 --- src/tests/fault_tolerance_tests.cpp (line 728)

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio
> On Oct. 20, 2015, 10:03 p.m., Ben Whitehead wrote: > > docs/scheduler-http-api.md, lines 36-48 > > > > > > The proposed grammar I made was based of the ABNF of the HTTP 1.1 spec > > here:

  1   2   >