Re: Review Request 40035: TemporaryDirectoryTest Merge: Elevate `TemporaryDirectoryTest::sandbox` from private to protected.

2015-11-06 Thread Jie Yu
> On Nov. 6, 2015, 10:31 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp, line 35 > > > > > > There's a subtle difference here. This one uses os::mkdtemp() while the > >

Re: Review Request 40017: Add Docker Image type to Container Image for v1 API.

2015-11-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40017/#review105522 --- Ship it! Ship It! - Timothy Chen On Nov. 6, 2015, 12:16 p.m.,

Re: Review Request 40002: Fixed Rootfs in tests to handle symlink directories.

2015-11-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40002/#review105525 --- Ship it! - Jie Yu On Nov. 6, 2015, 2:29 a.m., Timothy Chen

Re: Review Request 39102: Added documentation for JSON resources.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105540 --- Bad patch! Reviews applied: [39211, 39018] Failed command:

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105554 --- Patch looks great! Reviews applied: [39594, 39595] All tests

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39484/#review105562 --- docs/containerizer.md (line 94)

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

2015-11-06 Thread Joseph Wu
> On Nov. 6, 2015, 5:50 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39948] > > > > Failed command: ./support/apply-review.sh -n -r 39948 > > > > Error: > > 2015-11-07 01:50:12 URL:https://reviews.apache.org/r/39948/diff/raw/ > > [2087/2087] -> "39948.patch" [1] > >

Re: Review Request 40035: TemporaryDirectoryTest Merge: Elevate `TemporaryDirectoryTest::sandbox` from private to protected.

2015-11-06 Thread Joseph Wu
> On Nov. 6, 2015, 2:31 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp, line 35 > > > > > > There's a subtle difference here. This one uses os::mkdtemp() while the > > other

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 8:03 a.m., Guangya Liu wrote: > > src/tests/reservation_endpoints_tests.cpp, lines 874-877 > > > > > > remove this Ahh, sorry!! Thanks Guangya :-) - Greg

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 9:08 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 2986 > > > > > > Why not "const TaskInfo& task"? Good catch! - Greg ---

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 6, 2015, 11:58 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 6, 2015, 11:58 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Marco Massenzio
> On Nov. 7, 2015, 1:15 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39452] > > > > Failed command: ./support/apply-review.sh -n -r 39452 > > > > Error: > > 2015-11-07 01:15:41 URL:https://reviews.apache.org/r/39452/diff/raw/ > > [2542/2542] -> "39452.patch" [1] > >

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review105547 --- src/master/master.hpp (line 981)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review105549 --- Also need to update the docs. src/tests/reservation_tests.cpp

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 6, 2015, 11:53 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 12:07 a.m., Till Toenshoff wrote: > > src/tests/authorization_tests.cpp, line 411 > > > > > > You already did a great job commenting your tests but could you also > > please add 1-2 lines of

Re: Review Request 40001: TemporaryDirectoryTest Merge: Remove non-Stout version of `TemporaryDirectoryTest`.

2015-11-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40001/#review105553 --- Ship it! I fixed the above issue for you. THanks for the patches!

Re: Review Request 40001: TemporaryDirectoryTest Merge: Remove non-Stout version of `TemporaryDirectoryTest`.

2015-11-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40001/#review105552 --- src/tests/containerizer/filesystem_isolator_tests.cpp (line 109)

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-11-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review105544 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 42)

Review Request 40044: Remove unused parameter in moveLayers()

2015-11-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40044/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 40035: TemporaryDirectoryTest Merge: Elevate `TemporaryDirectoryTest::sandbox` from private to protected.

2015-11-06 Thread Jie Yu
> On Nov. 6, 2015, 10:31 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp, line 35 > > > > > > There's a subtle difference here. This one uses os::mkdtemp() while the > >

Re: Review Request 39769: Fix MESOS-3810 - Include ContainerInfo in command ExecutorInfo

2015-11-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39769/#review105520 --- src/tests/slave_tests.cpp (line 575)

Re: Review Request 40029: Fixed hyphenation, typos in configuration docs and command-line flags.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40029/#review105526 --- Patch looks great! Reviews applied: [39886, 40029] All tests

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 7:22 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote: >

Re: Review Request 39018: Added JSON parsing for Resources.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Nov. 7, 2015, 12:17 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39102: Added documentation for JSON resources.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Nov. 7, 2015, 12:18 a.m.) Review request for mesos, Adam B and Neil

Re: Review Request 40036: Added TaskStatus.container_status to reconcialiation updates.

2015-11-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40036/ --- (Updated Nov. 6, 2015, 8:47 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39769: Fix MESOS-3810 - Include ContainerInfo in command ExecutorInfo

2015-11-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39769/#review105516 --- src/slave/slave.cpp (line 3268)

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 7:35 a.m., Guangya Liu wrote: > > src/tests/authorization_tests.cpp, lines 426-429 > > > > > > Need a request test for this acl. Good catch, thanks Guangya! > On Nov. 6, 2015, 7:35 a.m.,

Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/ --- (Updated Nov. 6, 2015, 11:57 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.

2015-11-06 Thread Greg Mann
> On Nov. 6, 2015, 7:38 a.m., Guangya Liu wrote: > > src/master/master.hpp, lines 688-690 > > > > > > Can the comments be limitted to 70 chars? As discussed in other reviews, we are currently wrapping comments at

Re: Review Request 40035: TemporaryDirectoryTest Merge: Elevate `TemporaryDirectoryTest::sandbox` from private to protected.

2015-11-06 Thread Joseph Wu
> On Nov. 6, 2015, 2:31 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp, line 35 > > > > > > There's a subtle difference here. This one uses os::mkdtemp() while the > > other

Re: Review Request 40036: Added TaskStatus.container_status to reconcialiation updates.

2015-11-06 Thread Kapil Arya
> On Nov. 6, 2015, 5:23 p.m., Ben Mahler wrote: > > src/common/protobuf_utils.cpp, lines 178-187 > > > > > > You don't need the 'if' with the way you've structured your loop, I > > assume it's just here from copy

Re: Review Request 40035: TemporaryDirectoryTest Merge: Elevate `TemporaryDirectoryTest::sandbox` from private to protected.

2015-11-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40035/#review105515 --- 3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/ --- (Updated Nov. 6, 2015, 11:52 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39923: Cleaned up configuration.md.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/ --- (Updated Nov. 7, 2015, 12:20 a.m.) Review request for mesos, Jojy Varghese,

Re: Review Request 38580: Added docker registry RemotePuller

2015-11-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 7, 2015, 12:11 a.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 40000: TemporaryDirectoryTest Merge: Point tests to the Stout version of the `TemporaryDirectoryTest`.

2015-11-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review105542 --- Ship it! Ship It! - Jie Yu On Nov. 6, 2015, 10:10 p.m., Joseph

Re: Review Request 39250: Puller refactor: moved untar to a common place

2015-11-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Nov. 7, 2015, 12:12 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105551 --- Bad patch! Reviews applied: [39594] Failed command:

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-11-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Nov. 7, 2015, 1:07 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 39297: Added support for recovering RunState for HTTP based executors

2015-11-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39297/ --- (Updated Nov. 7, 2015, 1:07 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38876: Added functionality to store a marker file to denote HTTP based executors

2015-11-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38876/ --- (Updated Nov. 7, 2015, 1:07 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review10 --- Bad patch! Reviews applied: [39452] Failed command:

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/#review105564 --- Patch looks great! Reviews applied: [39948, 39949] All tests

Re: Review Request 39250: Puller refactor: moved untar to a common place

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review105565 --- Bad patch! Reviews applied: [38747] Failed command:

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/#review105527 ---

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-06 Thread Greg Mann
> On Nov. 7, 2015, 1:16 a.m., Neil Conway wrote: > > src/master/master.hpp, line 981 > > > > > > Should update the comment for new function parameter. Derp. Thanks Neil! - Greg

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 7, 2015, 1:48 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/#review105561 --- Bad patch! Reviews applied: [39948] Failed command:

Re: Review Request 39102: Added documentation for JSON resources.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105568 --- Bad patch! Reviews applied: [39211, 39018] Failed command:

Re: Review Request 39102: Added documentation for JSON resources.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review105570 --- Patch looks great! Reviews applied: [39211, 39018, 39102] All

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review105572 --- Patch looks great! Reviews applied: [39985, 39986, 39987, 39988,

Re: Review Request 40036: Added TaskStatus.container_status to reconcialiation updates.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40036/#review105574 --- Bad patch! Reviews applied: [40036] Failed command:

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review105571 --- Bad patch! Reviews applied: [37336] Failed command:

Re: Review Request 40044: Remove unused parameter in moveLayers()

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40044/#review105573 --- Bad patch! Reviews applied: [40044] Failed command:

Re: Review Request 39400: Quota: Implemented quota API.

2015-11-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review105575 --- Ship it! Ship It! - Klaus Ma On Nov. 6, 2015, 2:25 a.m.,

Re: Review Request 39923: Cleaned up configuration.md.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/#review105569 --- Bad patch! Reviews applied: [39923] Failed command:

Re: Review Request 37022: Allow Visibility per port in DiscoveryInfo.

2015-11-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37022/ --- (Updated Nov. 7, 2015, 7:15 a.m.) Review request for mesos, Adam B, Christos

Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.

2015-11-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review105381 --- src/master/master.cpp (line 2735)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review105380 --- src/tests/reservation_endpoints_tests.cpp (lines 871 - 874)

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Adam B
> On Nov. 5, 2015, 11:22 p.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. We actually

Review Request 40010: Put authorize logic for teardown into a common function.

2015-11-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40010/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Guangya Liu
> On 十一月 6, 2015, 7:22 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote: >

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Guangya Liu
> On 十一月 6, 2015, 7:22 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote: >

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Adam B
> On Nov. 5, 2015, 11:22 p.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote:

Re: Review Request 40005: Added princial field to /master/framework and /master/state endpoint.

2015-11-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40005/#review105392 --- Ship it! LGTM ! - Anand Mazumdar On Nov. 6, 2015, 5:37 a.m.,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review105390 --- src/master/master.cpp (line 2977)

Re: Review Request 39944: Add prefix option for os::environment.

2015-11-06 Thread haosdent huang
> On Nov. 5, 2015, 4:40 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp, line 34 > > > > > > Where do we need to use this now? > > I rather not add regex if we

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review105385 --- Ship it! Please verify your test results from rendering the

Re: Review Request 35711: Disallow special characters in role name.

2015-11-06 Thread Adam B
> On Nov. 5, 2015, 3:59 p.m., Neil Conway wrote: > > Can we add an end-to-end unit test that verifies that attempting to > > register as a framework with an invalid role name results in an error? Attempting to register with an unrecognized role name will fail long before we get to creating a

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-06 Thread Guangya Liu
> On 十一月 6, 2015, 7:22 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 28 > > > > > > We have some discussions want to reduce the comments to 70 chars per > > line. > > Adam B wrote: >

Re: Review Request 39886: Added documentation about roles.

2015-11-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review105393 --- Ship it! Remove the unrelated configuration.md changes and I'll

Re: Review Request 40010: Put authorize logic for teardown into a common function.

2015-11-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40010/ --- (Updated 十一月 6, 2015, 10:41 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39991: fetcher should extract from .tar archive

2015-11-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39991/#review105404 --- src/tests/fetcher_tests.cpp (line 542)

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39594/ --- (Updated Nov. 6, 2015, 11:04 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
> On Nov. 5, 2015, 1:29 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/fetcher.cpp, line 254 > > > > > > Why no longer static? > > When you bring back static, you can also bring back the old param > >

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 6, 2015, 11:04 a.m.) Review request for mesos, Bernd Mathiske,

Review Request 40013: Stout: Corrected style of Makefiles.

2015-11-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40013/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 40011: Mesos: Corrected style of Makefiles.

2015-11-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40011/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 40012: Libprocess: Corrected style of Makefiles.

2015-11-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40012/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 37022: Allow Visibility per port in DiscoveryInfo.

2015-11-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37022/#review105408 --- Ship it! Sorry this slipped through the cracks. Somehow the patch

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 6, 2015, 6:56 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese
> On Nov. 6, 2015, 6:05 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line > > 394 > > > > > > We used Shared<> instead of std::shared_ptr in our code base.

Re: Review Request 40030: Fix for some style issues.

2015-11-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40030/ --- (Updated Nov. 6, 2015, 7:25 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40030: Fix for some style issues.

2015-11-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40030/#review105495 --- Ship it! Ship It! - Timothy Chen On Nov. 6, 2015, 7:25 p.m.,

Re: Review Request 39702: Fixed incorrect signed vs. unsigned comparisons.

2015-11-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39702/#review105496 --- AFAIK this should be marked as submitted. - Neil Conway On Oct.

Re: Review Request 40017: Add Docker Image type to Container Image for v1 API.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40017/#review105497 --- Patch looks great! Reviews applied: [40017] All tests passed. -

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105422 --- include/mesos/master/allocator.hpp (line 357)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review105425 --- src/master/quota_handler.cpp (line 1)

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-11-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/#review105427 --- Ship it! Ship It! - Klaus Ma On Nov. 6, 2015, 2:23 a.m.,

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-06 Thread Klaus Ma
> On Oct. 25, 2015, 8:10 a.m., Klaus Ma wrote: > > include/mesos/master/allocator.hpp, line 358 > > > > > > It said Mesos master will also validate the quota request in design > > document; should we clarify which

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105431 --- Ship it! Ship It! - Klaus Ma On Nov. 6, 2015, 3:29 a.m.,

Re: Review Request 39285: Added Quota Request Validation.

2015-11-06 Thread Joerg Schad
> On Nov. 5, 2015, 9:59 p.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, lines 102-110 > > > > > > What do you think about using helpers from > > `include/mesos/resources.hpp`? A bunch of these checks

Re: Review Request 39285: Added Quota Request Validation.

2015-11-06 Thread Joerg Schad
> On Nov. 3, 2015, 1:37 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 123 > > > > > > Suggest to change ```if``` to ```else if```, in this way, for the first > > resource, we do not need to compare

Re: Review Request 39285: Added Quota Request Validation.

2015-11-06 Thread Joerg Schad
> On Oct. 25, 2015, 2:45 a.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 115 > > > > > > It said the role maybe not set in allocator interface's comments > > (`setQuota`); so any case that the role

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-11-06 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review105421 --- 3rdparty/libprocess/src/process.cpp (line 533)

Re: Review Request 39285: Added Quota Request Validation.

2015-11-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 6, 2015, 3:23 p.m.) Review request for mesos, Alexander

Re: Review Request 39340: RegistryClient: Added streaming response read

2015-11-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/ --- (Updated Nov. 6, 2015, 3:50 p.m.) Review request for mesos, Ben Mahler and

  1   2   >