Re: Review Request 40046: Include SSL related environment variables.

2015-11-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40046/#review105578 --- Bad patch! Reviews applied: [40046] Failed command:

Re: Review Request 40012: Libprocess: Corrected style of Makefiles.

2015-11-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40012/ --- (Updated Nov. 7, 2015, 12:50 p.m.) Review request for mesos and Till

Re: Review Request 40013: Stout: Corrected style of Makefiles.

2015-11-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40013/ --- (Updated Nov. 7, 2015, 12:50 p.m.) Review request for mesos and Till

Re: Review Request 39923: Cleaned up configuration.md.

2015-11-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/#review105585 --- Ship it! Ship It! - Till Toenshoff On Nov. 7, 2015, 12:20

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-07 Thread Klaus Ma
> On Oct. 26, 2015, 10:07 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1004 > > > > > > Just check the code, dynamically reserved resource are included in > > allocation. > > Qian

Re: Review Request 40036: Added TaskStatus.container_status to reconcialiation updates.

2015-11-07 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40036/ --- (Updated Nov. 7, 2015, 10:04 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 40011: Mesos: Corrected style of Makefiles.

2015-11-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40011/ --- (Updated Nov. 7, 2015, 12:50 p.m.) Review request for mesos and Till

Re: Review Request 40046: Include SSL related environment variables.

2015-11-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40046/ --- (Updated Nov. 7, 2015, 9:28 a.m.) Review request for mesos, Ben Mahler, Jojy

Re: Review Request 40046: Include SSL related environment variables.

2015-11-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40046/#review105580 --- Patch looks great! Reviews applied: [40046] All tests passed. -

Re: Review Request 37022: Allow Visibility per port in DiscoveryInfo.

2015-11-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37022/#review105577 --- Patch looks great! Reviews applied: [37022] All tests passed. -

Review Request 40046: Include SSL related environment variables.

2015-11-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40046/ --- Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen. Bugs:

Re: Review Request 37022: Allow Visibility per port in DiscoveryInfo.

2015-11-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37022/#review105576 --- Patch looks great! Reviews applied: [37022] All tests passed. -

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-07 Thread Till Toenshoff
> On Nov. 7, 2015, 1:15 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39452] > > > > Failed command: ./support/apply-review.sh -n -r 39452 > > > > Error: > > 2015-11-07 01:15:41 URL:https://reviews.apache.org/r/39452/diff/raw/ > > [2542/2542] -> "39452.patch" [1] > >

Re: Review Request 40005: Added principal field to /master/framework and /master/state endpoint.

2015-11-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40005/ --- (Updated Nov. 7, 2015, 7:08 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/#review105596 --- Ship it! Ship It! - Guangya Liu On 十一月 6, 2015, 11:52 p.m.,

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/#review105597 --- src/tests/authorization_tests.cpp (line 473)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review105599 --- Ship it! Ship It! - Guangya Liu On 十一月 7, 2015, 1:48 a.m.,

Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.

2015-11-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review105598 --- src/master/master.cpp (line 2793)

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review105600 --- src/tests/master_quota_tests.cpp (lines 209 - 210)

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

2015-11-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/#review105602 --- 3rdparty/libprocess/src/process.cpp (lines 742 - 770)

Re: Review Request 40053: Add URL::parse function.

2015-11-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40053/ --- (Updated Nov. 8, 2015, 6:56 a.m.) Review request for mesos, Bernd Mathiske and

Review Request 40054: Fix fetch parsing problem for URL with query.

2015-11-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40054/ --- Review request for mesos, Bernd Mathiske and Ben Mahler. Bugs: MESOS-3367

Review Request 40053: Add URL::parse function.

2015-11-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40053/ --- Review request for mesos, Bernd Mathiske and Ben Mahler. Bugs: MESOS-3367

Re: Review Request 40054: Fix fetch parsing problem for URL with query.

2015-11-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40054/ --- (Updated Nov. 8, 2015, 6:57 a.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 40054: Fix fetch parsing problem for URL with query.

2015-11-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40054/ --- (Updated Nov. 8, 2015, 7 a.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 40054: Fix fetch parsing problem for URL with query.

2015-11-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40054/#review105603 --- Bad patch! Reviews applied: [40053] Failed command:

Re: Review Request 40054: Fix fetch parsing problem for URL with query.

2015-11-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40054/ --- (Updated Nov. 8, 2015, 7:18 a.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 40053: Add URL::parse function.

2015-11-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40053/ --- (Updated Nov. 8, 2015, 7:17 a.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 40054: Fix fetch parsing problem for URL with query.

2015-11-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40054/#review105604 --- Bad patch! Reviews applied: [40053] Failed command: