Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review106390 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 12, 2015,

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review106397 --- Should also update reservation.md and persistent-volume.md (at

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106403 --- Patch looks great! Reviews applied: [40285] All tests passed. -

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review106402 --- src/master/quota_handler.cpp (lines 95 - 102)

Re: Review Request 39594: [stout]: Extended os::stat::mtime to optionally follow links.

> On Nov. 12, 2015, 1:16 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 130 > > > > > > Strictly speaking, "file" is pushing assumptions into this. > >

Re: Review Request 39595: Took mtime into account in the fetcher cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 13, 2015, 12:16 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 40283: Fixed layer untar in registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40283/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Review Request 40286: Fix registry puller to return correct rootfs path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/ --- Review request for mesos and Jojy Varghese. Repository: mesos Description

Re: Review Request 40284: Disabled SSL for launching mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40284/#review106388 --- Can we fix the underlying problem, as opposed to disabling SSL? -

Re: Review Request 40054: Fix fetch parsing problem for URL with query.

> On Nov. 13, 2015, 12:17 a.m., Bernd Mathiske wrote: > > Did you run all the fetcher tests? Ah, I guess ReviewBot did :-) - Bernd --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 40054: Fix fetch parsing problem for URL with query.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40054/#review106379 --- Ship it! Did you run all the fetcher tests? - Bernd Mathiske

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/#review106241 --- Will review this again after you refactor. src/master/master.hpp

Review Request 40284: Disabled SSL for launching mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40284/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 39800: Fix HDFS du output parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39800/#review106377 --- src/tests/fetcher_tests.cpp (line 602)

Re: Review Request 40283: Fixed layer untar in registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40283/#review106387 --- Patch looks great! Reviews applied: [40283] All tests passed. -

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Nov. 13, 2015, 4:10 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106435 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line

Re: Review Request 40241: Fixed a bug with hanging editor reported by Ben Mahler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40241/#review106429 --- support/apply-reviews.py (line 95)

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

> On Nov. 13, 2015, 4:49 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 78 > > > > > > This would then print the whole untar structure on every layer and > > every

Re: Review Request 40284: Disabled SSL for launching mesos executor.

> On Nov. 13, 2015, 9:59 a.m., Joris Van Remoortere wrote: > > Can we fix the underlying problem, as opposed to disabling SSL? Not sure if we should enforce SSL sockets in an executor unless being explicitly asked for (say using a flag) - Jojy

Re: Review Request 40284: Disabled SSL for launching mesos executor.

> On Nov. 13, 2015, 9:59 a.m., Joris Van Remoortere wrote: > > Can we fix the underlying problem, as opposed to disabling SSL? > > Jojy Varghese wrote: > Not sure if we should enforce SSL sockets in an executor unless being > explicitly asked for (say using a flag) I don't think hard

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review106426 --- src/master/quota_handler.cpp (lines 107 - 111)

Re: Review Request 39285: Added Quota Request Validation.

> On Nov. 13, 2015, 12:03 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 95-102 > > > > > > Not your fault, but here is one thing that bothers me a bit. > > > > It looks like we

Re: Review Request 40284: Disabled SSL for launching mesos executor.

> On Nov. 13, 2015, 9:59 a.m., Joris Van Remoortere wrote: > > Can we fix the underlying problem, as opposed to disabling SSL? > > Jojy Varghese wrote: > Not sure if we should enforce SSL sockets in an executor unless being > explicitly asked for (say using a flag) > > Timothy Chen wrote:

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

> On Nov. 13, 2015, 3:48 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 145 > > > > > > We need root preveliges to untar since it could do "mknod" for device > >

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/ --- (Updated Nov. 13, 2015, 4:46 p.m.) Review request for mesos and Jojy Varghese.

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review106389 --- Ship it! Currently os.hpp is an all-encompassing header for

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/#review106431 --- Ship it! Thanks! src/files/files.cpp (lines 350 - 351)

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/#review106445 --- Ship it! Thanks! I'll remove the os/strerror.hpp if os.hpp is

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/#review106444 --- Ship it! Looks good, we won't need the os/strerror.hpp includes

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106423 --- src/slave/containerizer/mesos/provisioner/docker/puller.hpp (line

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

> On Nov. 13, 2015, 10:33 a.m., Neil Conway wrote: > > include/mesos/mesos.proto, line 623 > > > > > > Note that this will require changes in the HTTP endpoint patch. (Just > > observing that whichever patch gets

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106457 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106492 --- Ship it! This patch looks good to me. We should use putLayer()

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

> On Nov. 13, 2015, 4:49 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 78 > > > > > > This would then print the whole untar structure on every layer and > > every

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

> On Nov. 13, 2015, 5:31 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 78 > > > > > > But the user then have to search the log around to see what's the tar's > >

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106468 --- Patch looks great! Reviews applied: [40286] All tests passed. -

Re: Review Request 39800: Fix HDFS du output parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39800/#review106495 --- Patch looks great! Reviews applied: [39799, 39800] All tests

Review Request 40305: Added URI fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40305/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Repository:

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40169/ --- (Updated Nov. 13, 2015, 6:30 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40251: Style fixes for Java and Python protobuf generation rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40251/#review106482 --- Ship it! Ship It! - Vinod Kone On Nov. 12, 2015, 8:18 p.m.,

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

> On Nov. 13, 2015, 10:58 a.m., Neil Conway wrote: > > Should also update reservation.md and persistent-volume.md (at minimum, to > > remove "_Coming Soon_" from the notes about ACLs.) Thanks, good call - added docs Re: authorization to those files. - Greg

Re: Review Request 40252: Consistency fixes on style in src/Makefile.am

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40252/#review106483 --- Ship it! Ship It! - Vinod Kone On Nov. 13, 2015, 1:09 a.m.,

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

> On Nov. 13, 2015, 10:52 a.m., Neil Conway wrote: > > src/master/master.cpp, line 3128 > > > > > > Seems like this change shouldn't be included in this review. i.e., the > > state of the tree after any patch in a

Re: Review Request 40250: Consolidated all the CXX protobuf generation rules in src/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40250/#review106480 --- Ship it! src/Makefile.am (line 197)

Re: Review Request 40284: Disabled SSL for launching mesos executor.

> On Nov. 13, 2015, 9:59 a.m., Joris Van Remoortere wrote: > > Can we fix the underlying problem, as opposed to disabling SSL? > > Jojy Varghese wrote: > Not sure if we should enforce SSL sockets in an executor unless being > explicitly asked for (say using a flag) > > Timothy Chen wrote:

Re: Review Request 39800: Fix HDFS du output parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39800/ --- (Updated Nov. 13, 2015, 5:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review106508 --- Bad patch! Reviews applied: [39985, 39986, 39987, 39988, 39989,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

> On Nov. 13, 2015, 9:59 p.m., Jie Yu wrote: > > include/mesos/authorizer/authorizer.proto, line 75 > > > > > > Can we call it ReserveResources to match other ACLs? (also, in case we > > have other things that we

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/ --- (Updated Nov. 13, 2015, 11:11 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 13, 2015, 11:17 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 13, 2015, 11:16 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 13, 2015, 9:15 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review106514 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 1402)

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/ --- (Updated Nov. 13, 2015, 11:15 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 40284: Disabled SSL for launching mesos executor.

> On Nov. 13, 2015, 9:59 a.m., Joris Van Remoortere wrote: > > Can we fix the underlying problem, as opposed to disabling SSL? > > Jojy Varghese wrote: > Not sure if we should enforce SSL sockets in an executor unless being > explicitly asked for (say using a flag) > > Timothy Chen wrote:

Re: Review Request 40305: Added URI fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40305/#review106500 --- Patch looks great! Reviews applied: [40250, 40251, 40252, 40274,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/#review106509 --- Ship it! include/mesos/authorizer/authorizer.proto (line 73)

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review106518 --- src/master/master.cpp (lines 2737 - 2738)

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 13, 2015, 11:12 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review106502 --- Bad patch! Reviews applied: [39985, 39986, 39987, 39988, 39989,

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/ --- (Updated Nov. 13, 2015, 9:31 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/#review106512 --- Ship it! Ship It! - Jie Yu On Nov. 13, 2015, 4:46 a.m., Greg

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/ --- (Updated Nov. 14, 2015, 12:25 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40168/ --- (Updated Nov. 14, 2015, 12:23 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40167: [2/7] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40167/ --- (Updated Nov. 14, 2015, 12:22 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/ --- (Updated Nov. 14, 2015, 3:04 a.m.) Review request for mesos and Joris Van

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40256/ --- (Updated Nov. 14, 2015, 12:26 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/ --- (Updated Nov. 14, 2015, 12:27 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review106526 --- src/master/http.cpp (line 853)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review106534 --- src/master/master.cpp (lines 3028 - 3040)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Nov. 13, 2015, 11:38 p.m., Jie Yu wrote: > > src/master/http.cpp, line 853 > > > > > > This looks problematic to me. 'this' will become invalid once this > > function returns. That means when `_reserve` is

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40169/ --- (Updated Nov. 14, 2015, 12:18 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

> On Nov. 13, 2015, 11:11 p.m., Jie Yu wrote: > > src/master/master.cpp, lines 2737-2738 > > > > > > This temp variable does not seem to be necessary. Can you just do: > > > > ``` > > LOG(INFO) <<

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 14, 2015, 12:01 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40118/ --- (Updated Nov. 14, 2015, 12:21 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/#review106391 --- src/master/master.hpp (line 1978)

Re: Review Request 40284: Disabled SSL for launching mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40284/#review106395 --- Patch looks great! Reviews applied: [40284] All tests passed. -

Re: Review Request 37022: Allow Visibility per port in DiscoveryInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37022/#review106398 --- This patch should also have updated v1/mesos.proto, I'd think? -

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40118/#review106393 --- include/mesos/mesos.proto (line 623)

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40169/#review106396 --- src/master/master.cpp

Re: Review Request 37022: Allow Visibility per port in DiscoveryInfo.

> On Nov. 13, 2015, 11:04 a.m., Neil Conway wrote: > > This patch should also have updated v1/mesos.proto, I'd think? Because I found we have some inconsistents between mesos.proto and v1/mesos.proto. Should we update v1/mesos.proto? - haosdent

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Nov. 13, 2015, 11:19 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40246: Removed unused "using" statement from test code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40246/ --- (Updated Nov. 13, 2015, 12:43 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40244: Clarified comments in Master::Http::_operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40244/ --- (Updated Nov. 13, 2015, 12:45 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review106413 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245,

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40242/ --- (Updated Nov. 13, 2015, 12:45 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

> On Nov. 13, 2015, 3:02 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, lines 583-585 > > > > > > I think that the v1 part should also be updated Good catch! Thanks. - Neil

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40243/ --- (Updated Nov. 13, 2015, 12:45 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40245: Fixed typos in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40245/ --- (Updated Nov. 13, 2015, 12:43 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 13, 2015, 12:47 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review106405 --- src/master/master.hpp (line 878)

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106407 --- Patch looks great! Reviews applied: [40286] All tests passed. -