Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
> On Nov. 16, 2015, 3:37 p.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 315 > > > > > > VLog? I'm trying to be consistent with other logs of this kind (e.g. in `master.cpp`), which are all

Re: Review Request 38110: Quota: Introduced capacity heuristic for quota set requests.

2015-11-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/#review106670 --- src/master/master.hpp (line 880)

Re: Review Request 40349: Added tests for use of mtime in fetcher cache.

2015-11-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40349/ --- (Updated Nov. 16, 2015, 3:44 p.m.) Review request for mesos and Bernd

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

2015-11-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Nov. 16, 2015, 5:25 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Nov. 16, 2015, 4:48 p.m.) Review request for mesos, Alexander

Re: Review Request 40345: [1/4] Quota Authorization: Added "RequestQuota" message to ACL protobuf.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/ --- (Updated Nov. 16, 2015, 4:47 p.m.) Review request for mesos, Alexander

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-11-16 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/#review106681 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 11, 2015,

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 16, 2015, 4:46 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38110: Quota: Introduced capacity heuristic for quota set requests.

2015-11-16 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/#review10 --- Ship it! src/master/quota_handler.cpp (line 133)

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Nov. 16, 2015, 4:50 p.m.) Review request for mesos, Alexander

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-11-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 16, 2015, 5:28 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 40342: Quota: Exposed agent resources string from the `MesosTest` fixture.

2015-11-16 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40342/#review106682 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 16, 2015,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review106683 --- Bad patch! Reviews applied: [40226, 40227, 39276, 37998, 37999,

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
> On Nov. 16, 2015, 3:37 p.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 239 > > > > > > I see that this is consistent witht the rest of the code, but in my > > opinion the realm should be `Mesos`.

Re: Review Request 40349: Added tests for use of mtime in fetcher cache.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40349/#review106677 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-11-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Nov. 16, 2015, 5:23 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/ --- (Updated Nov. 16, 2015, 4:49 p.m.) Review request for mesos, Alexander

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2015-11-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 16, 2015, 5:28 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-11-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 16, 2015, 5:26 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 40349: Added tests for use of mtime in fetcher cache.

2015-11-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40349/ --- (Updated Nov. 16, 2015, 3:36 p.m.) Review request for mesos and Bernd

Re: Review Request 40349: WIP Added tests for use of mtime in fetcher cache.

2015-11-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40349/ --- (Updated Nov. 16, 2015, 3:35 p.m.) Review request for mesos and Bernd

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 16, 2015, 4:47 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 16, 2015, 3:21 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere,

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
> On Nov. 16, 2015, 3:37 p.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 239 > > > > > > I see that this is consistent witht the rest of the code, but in my > > opinion the realm should be `Mesos`.

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review106672 --- Bad patch! Reviews applied: [39211, 39018, 39102, 36913] Failed

Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-11-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Nov. 16, 2015, 1:13 p.m.) Review request for mesos, Alexander

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

2015-11-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37998/#review106649 --- Ship it! Ship It! - Bernd Mathiske On Nov. 16, 2015, 1:48

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-11-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review106660 --- include/mesos/authorizer/authorizer.hpp (line 136)

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 16, 2015, 12:24 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 40342: Quota: Exposed agent resources string from the `MesosTest` fixture.

2015-11-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40342/ --- Review request for mesos, Joerg Schad, Joris Van Remoortere, and Joseph Wu.

Re: Review Request 39289: Quota: Added authorization of quota requests.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/ --- (Updated Nov. 16, 2015, 1:41 p.m.) Review request for mesos, Alexander

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Nov. 16, 2015, 2:53 p.m.) Review request for mesos, Alexander

Re: Review Request 40345: [1/4] Quota Authorization: Added "RequestQuota" message to ACL protobuf.

2015-11-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review106659 --- include/mesos/authorizer/authorizer.proto (line 74)

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/#review106661 --- Bad patch! Reviews applied: [39211, 39018, 39102, 36913] Failed

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 16, 2015, 12:48 p.m.) Review request for mesos, Alexander

Re: Review Request 40342: Quota: Exposed agent resources string from the `MesosTest` fixture.

2015-11-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40342/#review106657 --- Ship it! Ship It! - Joerg Schad On Nov. 16, 2015, 12:24 p.m.,

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review106662 --- src/master/master.hpp (line 910)

Re: Review Request 39289: Quota: Added authorization of quota requests.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/#review106653 --- Bad patch! Reviews applied: [39211, 39018, 39102, 36913] Failed

Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till

Review Request 40345: [1/4] Quota Authorization: Added "RequestQuota" message to ACL protobuf.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till

Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till

Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-11-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Joseph Wu
> On Nov. 11, 2015, 1:47 p.m., Joseph Wu wrote: > > bootstrap.bat, line 40 > > > > > > `mklink` only works with the Windows command prompt, run as an > > administrator. Is that correct? > > > > (At least,

Re: Review Request 40253: Added URI protobuf definition.

2015-11-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40253/#review106700 --- I just realized that I need to access this in a 3rdparty fetcher

Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-11-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review106701 --- include/mesos/quota/quota.proto (lines 54 - 57)

Re: Review Request 40305: Added URI fetcher interface.

2015-11-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40305/ --- (Updated Nov. 16, 2015, 7:06 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 40253: Added URI protobuf definition.

2015-11-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40253/ --- (Updated Nov. 16, 2015, 7:06 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40291/ --- (Updated Nov. 16, 2015, 5:31 p.m.) Review request for mesos and Bernd

Re: Review Request 40211: Add mesos provisioner doc.

2015-11-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40211/#review106703 --- I would suggest we have a single doc explaining the whole "unified

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
> On Nov. 11, 2015, 9:47 p.m., Joseph Wu wrote: > > bootstrap.bat, line 40 > > > > > > `mklink` only works with the Windows command prompt, run as an > > administrator. Is that correct? > > > > (At least,

Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40367/#review106755 --- Patch looks great! Reviews applied: [40367] All tests passed. -

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40131/ --- (Updated Nov. 16, 2015, 9:32 p.m.) Review request for mesos, Artem

Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40367/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-3786

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
> On Nov. 11, 2015, 9:47 p.m., Joseph Wu wrote: > > bootstrap.bat, line 52 > > > > > > The second argument to `mklink` is relative to the first argument, so > > the `\ ` will be incorrect. > > > > Ditto

Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40367/#review106747 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 16, 2015, 9:31

Re: Review Request 40253: Added URI protobuf definition.

2015-11-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40253/ --- (Updated Nov. 16, 2015, 8:09 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106732 --- Bad patch! Reviews applied: [40285] Failed command:

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
> On Nov. 11, 2015, 9:47 p.m., Joseph Wu wrote: > > bootstrap.bat, line 40 > > > > > > `mklink` only works with the Windows command prompt, run as an > > administrator. Is that correct? > > > > (At least,

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Joseph Wu
> On Nov. 11, 2015, 1:47 p.m., Joseph Wu wrote: > > bootstrap.bat, line 40 > > > > > > `mklink` only works with the Windows command prompt, run as an > > administrator. Is that correct? > > > > (At least,

Re: Review Request 40305: Added URI fetcher interface.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40305/#review106728 --- Patch looks great! Reviews applied: [40250, 40251, 40252, 40274,

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/ --- (Updated Nov. 16, 2015, 8:49 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40253: Added URI protobuf definition.

2015-11-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40253/#review106761 --- Ship it! Ship It! - Vinod Kone On Nov. 16, 2015, 8:09 p.m.,

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

2015-11-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/ --- (Updated Nov. 16, 2015, 11:48 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/ --- (Updated Nov. 16, 2015, 11:15 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review106762 --- Bad patch! Reviews applied: [40285] Failed command:

Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

2015-11-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40372/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.

2015-11-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106775 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review106768 --- src/cli/execute.cpp (line 116)

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

2015-11-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40372/ --- (Updated Nov. 16, 2015, 4:22 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40372/#review106774 --- Bad patch! Reviews applied: [40372] Failed command: export

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review106643 --- Bad patch! Reviews applied: [38627, 40226, 40227, 39276, 37998,

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/ --- (Updated Nov. 17, 2015, 4:43 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106794 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line

Review Request 40378: Added link to upgrade guide to documentation page.

2015-11-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40378/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere.

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 16, 2015, 11:47 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 16, 2015, 11:53 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/ --- (Updated Nov. 17, 2015, 2:52 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Jojy Varghese
> On Nov. 16, 2015, 11:55 p.m., Timothy Chen wrote: > > src/cli/execute.cpp, line 421 > > > > > > Instead of failing here and checking again in the Framework, how about > > just putting this check and wanring

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/ --- (Updated Nov. 17, 2015, 2:52 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/ --- (Updated Nov. 17, 2015, 3:01 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review106789 --- src/cli/execute.cpp (lines 216 - 228)

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review106790 --- Bad patch! Reviews applied: [40285] Failed command:

Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-11-16 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/ --- (Updated Nov. 17, 2015, 1:22 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/ --- (Updated Nov. 17, 2015, 1:46 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40291/#review106781 --- docs/c++-style-guide.md (line 124)

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review106782 --- Bad patch! Reviews applied: [40284, 40285] Failed command:

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-11-16 Thread Guangya Liu
> On 十一月 16, 2015, 2:23 p.m., Joerg Schad wrote: > > src/tests/mesos.hpp, line 1245 > > > > > > This looks somehow weird... Who is satisfying the expect_call? I also have the same question, seems no one will

Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40367/#review106779 --- Ship it! Ship It! - Guangya Liu On 十一月 16, 2015, 9:31 p.m.,

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-11-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review106783 --- Ship it! Ship It! - Guangya Liu On 十一月 16, 2015, 3:49 p.m.,

Re: Review Request 40187: Fixed and formatted JSON examples.

2015-11-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review106797 --- This should also update docs/configuration.md - Neil Conway On

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/ --- (Updated Nov. 17, 2015, 6:10 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review106799 --- src/master/quota_handler.cpp (line 171)

Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-11-16 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- Review request for mesos. Bugs: MESOS-3930

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40131/ --- (Updated Nov. 16, 2015, 8:30 a.m.) Review request for mesos, Artem

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40131/ --- (Updated Nov. 16, 2015, 8:30 a.m.) Review request for mesos, Artem

Review Request 40195: Changed commit hook linting to ignore empty diffs.

2015-11-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40195/ --- Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-16 Thread Alex Clemmer
> On Nov. 11, 2015, 9:47 p.m., Joseph Wu wrote: > > bootstrap.bat, line 40 > > > > > > `mklink` only works with the Windows command prompt, run as an > > administrator. Is that correct? > > > > (At least,

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

2015-11-16 Thread Neil Conway
> On Nov. 16, 2015, 8:02 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 216 > > > > > > I think it would make sense to also update the mesos `CMakeLists.txt`. We should, but it

  1   2   >