Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-20 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Nov. 20, 2015, 10:55 a.m.) Review request for mesos, Alexander

Re: Review Request 39449: Documented order of includes.

2015-11-20 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/ --- (Updated Nov. 20, 2015, 12:17 p.m.) Review request for mesos, Marco Massenzio

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107371 --- Patch looks great! Reviews applied: [40371] Passed command:

Re: Review Request 37999: Introduced an Authenticator interface and an AuthenticationRouter in libprocess.

2015-11-20 Thread Ben Mahler
> On Nov. 20, 2015, 2 p.m., Ben Mahler wrote: > > For transparency we pulled out the libprocess integration because we > > realized that requests sent to the authentication router need to have > > authentication results satisfied in the same order in which the requests > > were sent. We're

Re: Review Request 37999: Introduced an Authenticator interface and an AuthenticationRouter in libprocess.

2015-11-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review107365 --- Ship it! For transparency we pulled out the libprocess

Re: Review Request 40539: Removed socket from HttpEvent.

2015-11-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40539/#review107364 --- Ship it! - Ben Mahler On Nov. 20, 2015, 12:34 p.m., Alexander

Re: Review Request 40532: WIP: Added notion of evictable task to RunTaskMessage.

2015-11-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 十一月 20, 2015, 1 p.m.) Review request for mesos and Klaus Ma. Bugs:

Re: Review Request 40529: WIP: Added helper function to get stateless resources.

2015-11-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 十一月 20, 2015, 12:59 p.m.) Review request for mesos and Klaus Ma.

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review107345 --- Patch looks great! Reviews applied: [40431, 40469] Passed

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-20 Thread Joerg Schad
> On Nov. 19, 2015, 7:06 p.m., Neil Conway wrote: > > docs/c++-style-guide.md, line 118 > > > > > > The point is that the for loop condition should be defined over > > multiple lines, right? Yes > On Nov. 19,

Re: Review Request 39449: Documented order of includes.

2015-11-20 Thread Jan Schlicht
> On Nov. 3, 2015, 10:56 p.m., Joerg Schad wrote: > > docs/c++-style-guide.md, line 262 > > > > > > This should be the first include (see my other comments and the Google > > Styleguide ( > >

Re: Review Request 39614: Quota: Added Status Validation Tests.

2015-11-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Nov. 20, 2015, 10:05 a.m.) Review request for mesos, Alexander

Re: Review Request 40531: Added the public Mesos events calendar to the Community page.

2015-11-20 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40531/#review107344 --- Ship it! Kickass! site/source/community.html.md (line 56)

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 20, 2015, 9:49 a.m.) Review request for mesos, Alexander

Review Request 40532: WIP: Added notion of evictable task to RunTaskMessage.

2015-11-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- Review request for mesos and Klaus Ma. Bugs: MESOS-3890

Re: Review Request 40529: WIP: Added helper function to get stateless resources.

2015-11-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 十一月 20, 2015, 11:51 a.m.) Review request for mesos and Klaus Ma.

Re: Review Request 40524: WIP: Enabled resources.cpp and resources.hpp use std::string

2015-11-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/ --- (Updated 十一月 20, 2015, 11:51 a.m.) Review request for mesos and Klaus Ma.

Review Request 40539: Removed socket from HttpEvent.

2015-11-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40539/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 40339: WIP: Added a flag to master to enable oversubscription for reservations.

2015-11-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十一月 20, 2015, 12:59 p.m.) Review request for mesos, Artem

Re: Review Request 40524: WIP: Enabled resources.cpp and resources.hpp use std::string

2015-11-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/ --- (Updated 十一月 20, 2015, 12:59 p.m.) Review request for mesos and Klaus Ma.

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-20 Thread Alexander Rukletsov
> On Nov. 18, 2015, 7:51 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 20, 2015, 9:39 a.m.) Review request for mesos, Alexander

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/#review107340 --- Patch looks great! Reviews applied: [39780, 39781, 39782] Passed

Re: Review Request 39449: Documented order of includes.

2015-11-20 Thread Jan Schlicht
> On Nov. 3, 2015, 10:53 p.m., Joerg Schad wrote: > > docs/c++-style-guide.md, line 251 > > > > > > Could we add a short comment above every new section describing the > > representative meaning of each? (e.g. here

Re: Review Request 37999: Introduced an Authenticator interface and an AuthenticationRouter in libprocess.

2015-11-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Nov. 20, 2015, 1:53 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107375 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913,

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40291/ --- (Updated Nov. 20, 2015, 4:55 p.m.) Review request for mesos, Bernd Mathiske

Review Request 40456: MESOS-3950: show running task count in web ui

2015-11-20 Thread Ian Babrou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40456/ --- Review request for mesos. Repository: mesos Description --- MESOS-3950:

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-11-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review107374 --- include/mesos/authorizer/authorizer.proto (line 74)

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-11-20 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/ --- (Updated Nov. 20, 2015, 5:13 p.m.) Review request for mesos, Alexander

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-11-20 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/ --- (Updated Nov. 20, 2015, 4:52 p.m.) Review request for mesos, Alexander

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-11-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review107376 --- Ship it! Ship It! - Alexander Rojas On Nov. 20, 2015, 4:52

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

2015-11-20 Thread Benjamin Bannier
> On Nov. 20, 2015, 2:16 a.m., Neil Conway wrote: > > Good find. I wonder: > > > > (a) is there some general advice we should give to people implementing > > Processes (e.g., "always provide a destructor that does terminate/wait" -- > > that is probably too broad though). Would be nice to add

Re: Review Request 40531: Added the public Mesos events calendar to the Community page.

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40531/#review107381 --- Patch looks great! Reviews applied: [40531] Passed command:

Review Request 40546: MESOS-3972: fix framework cpu counters on slave page

2015-11-20 Thread Ian Babrou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40546/ --- Review request for mesos. Repository: mesos Description --- MESOS-3972:

Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-20 Thread Ian Babrou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40545/ --- Review request for mesos. Repository: mesos Description --- MESOS-3970:

Re: Review Request 40497: Add hex number support to numify()

2015-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/#review107370 --- 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp (line

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

2015-11-20 Thread Joerg Schad
> On Nov. 17, 2015, 8:18 a.m., Alexander Rukletsov wrote: > > What is the motivation for this? Are there any studies proving it > > facilitates preception? > > Joerg Schad wrote: > Motivation is the current inconsistent writing of numbers e.g. in the c++ > styleguide. > > Alexander

Re: Review Request 40507: Cleanup leaked containerizer and potentially orphaned process in SlaveTest.LaunchTaskInfoWithContainerInfo.

2015-11-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40507/#review107383 --- Ship it! Ship It! - Gilbert Song On Nov. 19, 2015, 3:38 p.m.,

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

2015-11-20 Thread Joseph Wu
> On Nov. 19, 2015, 6:16 p.m., Neil Conway wrote: > > Good find. I wonder: > > > > (a) is there some general advice we should give to people implementing > > Processes (e.g., "always provide a destructor that does terminate/wait" -- > > that is probably too broad though). Would be nice to add

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-20 Thread Neil Conway
> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote: > > docs/persistent-volume.md, lines 255-280 > > > > > > This looks to be formatted weird, could you double check? Here and below I previewed with

Re: Review Request 39449: Documented order of includes.

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review107387 --- Patch looks great! Reviews applied: [39449] Passed command:

Re: Review Request 40339: WIP: Added a flag to master to enable oversubscription for reservations.

2015-11-20 Thread Joseph Wu
> On Nov. 19, 2015, 9:59 a.m., Joseph Wu wrote: > > Overall notes: > > * Looks like everything is in place (to my knowledge) for this change :) > > * (Mentioned in the last working group sync) We **may** want to rename the > > feature to something else, like "oversubscription for reservations".

Review Request 40553: Enable mesos tests installation

2015-11-20 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-3608

Re: Review Request 40532: WIP: Added notion of evictable task to RunTaskMessage.

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/#review107393 --- Patch looks great! Reviews applied: [40339, 40524, 40529, 40532]

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39948/ --- (Updated Nov. 20, 2015, 11:16 a.m.) Review request for mesos, Benjamin

Re: Review Request 40461: Changed HDFS wrapper from a struct to a class.

2015-11-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40461/ --- (Updated Nov. 20, 2015, 7:23 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40461: Changed HDFS wrapper from a struct to a class.

2015-11-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40461/#review107402 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 7:23 p.m.,

Re: Review Request 40293: Applied consistent number syle in c++ styleguide.

2015-11-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40293/ --- (Updated Nov. 20, 2015, 8:42 p.m.) Review request for mesos and Bernd

Re: Review Request 40293: Applied consistent number style in c++ styleguide.

2015-11-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40293/ --- (Updated Nov. 20, 2015, 8:42 p.m.) Review request for mesos and Bernd

Re: Review Request 40418: Added curl based URI fetcher plugin.

2015-11-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40418/#review107398 --- Ship it! src/uri/fetcher.cpp (line 40)

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/ --- (Updated Nov. 20, 2015, 11:16 a.m.) Review request for mesos, Benjamin

Review Request 40264: Libprocess Reinitialization: Implement Clock::finalize for cleaning up timers

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40264/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Re: Review Request 40268: Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/ --- (Updated Nov. 20, 2015, 11:29 a.m.) Review request for mesos, Artem

Review Request 40512: Libprocess Reinitialization: Add a test-only method to reinitialize libprocess.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Re: Review Request 40462: Fixed the license header in hdfs.hpp.

2015-11-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40462/#review107403 --- Ship it! Ship It! - Vinod Kone On Nov. 19, 2015, 12:26 a.m.,

Review Request 40513: [DO NOT COMMIT] Parameterizes existing scheduler tests to run with varieties of SSL enabled.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40513/ --- Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Joris Van

Re: Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40557/ --- (Updated Nov. 20, 2015, 11:52 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40463: Moved HDFS wrapper implementation to a cpp file.

2015-11-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40463/#review107407 --- Ship it! Ship It! - Vinod Kone On Nov. 19, 2015, 12:27 a.m.,

Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40557/ --- Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Neil Conway.

Review Request 40413: Libprocess Reinitialization: Move ReaperProcess instantiation into process::intialize.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Review Request 40411: Libprocess Reinitialization: Modify test to use PID instead of a process pointer.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Re: Review Request 40546: MESOS-3972: fix framework cpu counters on slave page

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40546/#review107405 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 40498: Used factory method to create HDFS client.

2015-11-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40498/#review107410 --- Ship it! Ship It! - Vinod Kone On Nov. 19, 2015, 8:22 p.m.,

Review Request 40556: Added a test filter for CURL tests.

2015-11-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40556/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3924

Re: Review Request 40557: Add documentation about using terminate/wait on Processes when deallocating them.

2015-11-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40557/#review107395 --- Ship it! 3rdparty/libprocess/README.md (line 139)

Re: Review Request 40268: Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/ --- (Updated Nov. 20, 2015, 11:19 a.m.) Review request for mesos, Artem

Review Request 40266: Libprocess Reinitialization: Cleanup SocketManager along side ProcessManager.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Re: Review Request 40556: Added a test filter for CURL tests.

2015-11-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40556/#review107397 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 7:01 p.m.,

Review Request 40410: Libprocess Reinitialization: Move MetricsProcess instantiation into process::initialize.

2015-11-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Re: Review Request 40464: Fixed a few style issues in HDFS wrapper code.

2015-11-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40464/#review107409 --- Ship it! Ship It! - Vinod Kone On Nov. 19, 2015, 10:16 p.m.,

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/#review107415 --- Patch looks great! Reviews applied: [40501] Passed command:

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

2015-11-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review107420 --- src/common/resources.cpp (lines 879 - 881)

Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40367/#review107423 --- Ship it! Ship It! - Joerg Schad On Nov. 16, 2015, 9:31 p.m.,

Re: Review Request 40497: Add hex number support to numify()

2015-11-20 Thread Cong Wang
> On Nov. 20, 2015, 3:23 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp, line 30 > > > > > > I believe giving these proper names would make e.g., the ordering here > >

Re: Review Request 37336: Added `execute()` method to process::Subprocess

2015-11-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review107421 --- 3rdparty/libprocess/include/process/subprocess.hpp (lines 53 -

Review Request 40562: Added validation for 'uuid' field being present

2015-11-20 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40562/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Re: Review Request 40497: Add hex number support to numify()

2015-11-20 Thread Cong Wang
> On Nov. 20, 2015, 3:23 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp, line 26 > > > > > > Would be nice to add a couple more positives here, e.g., to catch > >

Re: Review Request 40559: Added a wait() function to Subprocess.

2015-11-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/ --- (Updated Nov. 20, 2015, 9:06 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 40293: Applied consistent number style in c++ styleguide.

2015-11-20 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40293/#review107419 --- Ship it! Ship It! - Till Toenshoff On Nov. 20, 2015, 8:42

Review Request 40563: Added functionality for handling status updates from HTTP based executors

2015-11-20 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Review Request 40561: Added an overload for createStatusUpdate(...) function

2015-11-20 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40561/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Review Request 40560: Removed redundant fields from Update message in Executor API Protobuf

2015-11-20 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40560/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Bugs:

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

2015-11-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107443 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107446 --- Thanks Jojy, I'll fix these myself and merge. - Timothy Chen On

Re: Review Request 40562: Added validation for 'uuid' field being present

2015-11-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40562/#review107451 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 10:47 p.m.,

Re: Review Request 40561: Added an overload for createStatusUpdate(...) function

2015-11-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40561/#review107450 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 10:47 p.m.,

Re: Review Request 39490: Always create non-IP egress filters

2015-11-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/#review107453 --- Ship it!

Re: Review Request 39490: Always create non-IP egress filters

2015-11-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/#review107455 --- I'll fix this for you. - Jie Yu On Nov. 20, 2015, 11:36 p.m.,

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 20, 2015, 8:48 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

2015-11-20 Thread Alexander Rukletsov
> On Nov. 19, 2015, 11:10 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 460 > > > > > > Could you please restore this blank line? > > Joerg Schad wrote: > Sure, but FYI this style

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

2015-11-20 Thread Alexander Rukletsov
> On Nov. 17, 2015, 8:18 a.m., Alexander Rukletsov wrote: > > What is the motivation for this? Are there any studies proving it > > facilitates preception? > > Joerg Schad wrote: > Motivation is the current inconsistent writing of numbers e.g. in the c++ > styleguide. Sorry for not being

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

2015-11-20 Thread Alexander Rukletsov
> On Nov. 17, 2015, 8:18 a.m., Alexander Rukletsov wrote: > > What is the motivation for this? Are there any studies proving it > > facilitates preception? > > Joerg Schad wrote: > Motivation is the current inconsistent writing of numbers e.g. in the c++ > styleguide. > > Alexander

Re: Review Request 40378: Added link to upgrade guide to documentation page.

2015-11-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40378/ --- (Updated Nov. 20, 2015, 10:54 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38117: Export per container SNMP statistics

2015-11-20 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Nov. 20, 2015, 11:25 p.m.) Review request for mesos, Jie Yu, Paul

Re: Review Request 37336: Added `execute()` method to process::Subprocess

2015-11-20 Thread Jie Yu
> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 119-130 > > > > > > Why not just use a single `int status` field here. The users can use > > WEXITSTATUS

Re: Review Request 39490: Always create non-IP egress filters

2015-11-20 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/ --- (Updated Nov. 20, 2015, 11:36 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 40506: Add stdout/tests/numify_tests.cpp into Makefile.am

2015-11-20 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40506/ --- (Updated Nov. 20, 2015, 10:27 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

2015-11-20 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Nov. 20, 2015, 10:27 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 40497: Add hex number support to numify()

2015-11-20 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- (Updated Nov. 20, 2015, 10:26 p.m.) Review request for mesos, Ben Mahler and

  1   2   >