Re: Review Request 40665: Clean up redundant os exists check before mkdir.

2015-11-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40665/#review107859 --- Ship it! Ship It! - Timothy Chen On Nov. 24, 2015, 7:22 p.m.,

Re: Review Request 40641: Increase launch and wait timeout in LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.

2015-11-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40641/#review107857 --- Ship it! Ship It! - Timothy Chen On Nov. 24, 2015, 1:45 p.m.,

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

2015-11-24 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/ --- (Updated Nov. 24, 2015, 11:04 p.m.) Review request for mesos, Artem

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

2015-11-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/#review107861 --- Ship it! Ship It! - Timothy Chen On Nov. 24, 2015, 6:52 a.m.,

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

2015-11-24 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/#review107866 --- Ship it! Ship It! - Alex Clemmer On Nov. 24, 2015, 11:04 p.m.,

Review Request 40681: Changed mesos-local to use posix launcher as default.

2015-11-24 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40681/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Review Request 40679: Added filtering of CFS cgroup tests.

2015-11-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40679/ --- Review request for mesos, Bernd Mathiske, Marco Massenzio, and Till Toenshoff.

Re: Review Request 40679: Added filtering of CFS cgroup tests.

2015-11-24 Thread Greg Mann
> On Nov. 25, 2015, 1:35 a.m., haosdent huang wrote: > > src/tests/environment.cpp, line 129 > > > > > > use `/sys/fs/cgroup` maybe have some problems. centos 6 mount cgroup > > under `/cgroup` directly. Could

Re: Review Request 38989: Update docker-containerizer.md.

2015-11-24 Thread haosdent huang
> On Nov. 24, 2015, 1:26 a.m., Timothy Chen wrote: > > Can you rebase your patch? Hi, @tnachen. Thanks for you reviews. After rebase, I find all my changes have been fixed in current document. So let me discard this patch. - haosdent

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-24 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 25, 2015, 1:57 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 38201: [WIP] precision errors with allocation calculations

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38201/ --- (Updated Nov. 25, 2015, 10:04 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-24 Thread Guangya Liu
> On 十一月 24, 2015, 9:38 p.m., Michael Park wrote: > > Ship It! @mcypark and @Neil, shall we clarify that the dynamic reservation works for both enabling and not enabling authorization in the document? - Guangya --- This is an

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/ --- (Updated Nov. 25, 2015, 9:54 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40679: Added filtering of CFS cgroup tests.

2015-11-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40679/#review107892 --- src/tests/environment.cpp (line 129)

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/#review107899 --- src/tests/authentication_tests.cpp (line 311)

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Neil Conway
> On Nov. 25, 2015, 2:25 a.m., Guangya Liu wrote: > > src/tests/authentication_tests.cpp, line 311 > > > > > > Not yours but do you mind to update s/Try/Try > > and the following? Sure -- although I

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/ --- (Updated Nov. 25, 2015, 2:32 a.m.) Review request for mesos and Ben Mahler.

Review Request 40690: Cleaned up ">>" style in test file.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40690/ --- Review request for mesos. Repository: mesos Description --- Cleaned up

Re: Review Request 40681: Changed mesos-local to use posix launcher as default.

2015-11-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40681/#review107890 --- Ship it! Ship It! - haosdent huang On Nov. 25, 2015, 12:38

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-24 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 25, 2015, 1:35 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review107901 --- Ship it! Ship It! - Guangya Liu On 十一月 24, 2015, 3:57 p.m.,

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review107903 --- include/mesos/role/role.proto (line 38)

Re: Review Request 40690: Cleaned up ">>" style in test file.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40690/#review107904 --- Ship it! Ship It! - Guangya Liu On 十一月 25, 2015, 2:32 a.m.,

Re: Review Request 40690: Cleaned up ">>" style in test file.

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40690/#review107905 --- src/tests/authentication_tests.cpp (line 55)

Re: Review Request 40690: Cleaned up ">>" style in test file.

2015-11-24 Thread Neil Conway
> On Nov. 25, 2015, 2:52 a.m., Klaus Ma wrote: > > src/tests/authentication_tests.cpp, line 55 > > > > > > Should we also handle the same issue in other files? > > > > ``` > > $grep -rn "> >" src/* | wc

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107913 --- Ship it! Looks good overall! Some nit-picks, some thoughts on

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review107919 --- src/v1/resources.cpp (line 95)

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review107923 --- src/tests/resources_tests.cpp (line 1982)

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107924 --- As we discussed, since we already resolved the compatibility

Re: Review Request 40690: Cleaned up ">>" style in test file.

2015-11-24 Thread Guangya Liu
> On 十一月 25, 2015, 2:52 a.m., Klaus Ma wrote: > > src/tests/authentication_tests.cpp, line 55 > > > > > > Should we also handle the same issue in other files? > > > > ``` > > $grep -rn "> >" src/* | wc

Re: Review Request 40660: Linked against executor PID's to ensure ordered message delivery

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40660/#review107926 --- Patch looks great! Reviews applied: [40660] Passed command:

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated Nov. 25, 2015, 2:16 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 40690: Cleaned up ">>" style in test file.

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40690/#review107929 --- Ship it! Ship It! - Klaus Ma On Nov. 25, 2015, 10:32 a.m.,

Re: Review Request 40690: Cleaned up ">>" style in test file.

2015-11-24 Thread Klaus Ma
> On Nov. 25, 2015, 10:52 a.m., Klaus Ma wrote: > > src/tests/authentication_tests.cpp, line 55 > > > > > > Should we also handle the same issue in other files? > > > > ``` > > $grep -rn "> >" src/* | wc

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- (Updated Nov. 25, 2015, 2:35 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 40524: Used string directly in resources.cpp.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/ --- (Updated 十一月 25, 2015, 6:41 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40529: Added helper function to get stateless resources.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 十一月 25, 2015, 6:41 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review107865 --- Patch looks great! Reviews applied: [40631] Passed command:

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/#review107833 --- Patch looks great! Reviews applied: [40431, 40424] Passed

Re: Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40672/ --- (Updated Nov. 24, 2015, 9:04 p.m.) Review request for mesos, Joris Van

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40242/#review107853 --- Ship it! Ship It! - Michael Park On Nov. 23, 2015, 11:44 a.m.,

Re: Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40672/ --- (Updated Nov. 24, 2015, 9:07 p.m.) Review request for mesos, Joris Van

Re: Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40672/#review107844 --- src/tests/master_maintenance_tests.cpp

Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40672/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-3916

Re: Review Request 40641: Increase launch and wait timeout in LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40641/#review107849 --- Patch looks great! Reviews applied: [40641] Passed command:

Review Request 40667: Fixed flakiness in reservation endpoint tests

2015-11-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40667/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-4002

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

2015-11-24 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Nov. 24, 2015, 9:57 p.m.) Review request for mesos, Artem

Re: Review Request 40679: Added filtering of CFS cgroup tests.

2015-11-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40679/#review107933 --- src/tests/environment.cpp (line 147)

Re: Review Request 40529: Added helper function to get stateless resources.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 十一月 25, 2015, 7:31 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 十一月 25, 2015, 7:31 a.m.) Review request for mesos and Klaus Ma.

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/#review107934 --- Patch looks great! Reviews applied: [40647] Passed command:

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 十一月 25, 2015, 7:31 a.m.) Review request for mesos, Artem Harutyunyan,

Review Request 40660: Linked against executor PID's to ensure ordered message delivery

2015-11-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40660/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3851

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review107800 --- Ship it! Ship It! - Neil Conway On Nov. 24, 2015, 3:57 p.m.,

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Neil Conway
> On Nov. 24, 2015, 3:58 p.m., Neil Conway wrote: > > src/tests/fault_tolerance_tests.cpp, line 720 > > > > > > I'd remove this comment -- various other places use the same pattern. > > I'd also remove the newline

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-24 Thread Alexander Rukletsov
> On Nov. 18, 2015, 7:51 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 24, 2015, 4:30 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40524: Enabled resources.cpp and resources.hpp use std::string

2015-11-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/#review107808 --- include/mesos/resources.hpp (lines 53 - 54)

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-24 Thread Alexander Rukletsov
> On Nov. 23, 2015, 4:09 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, line 542 > > > > > > Add ASSERT here to make sure no offers? Could you please elaborate what exactly do you propose? -

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Alexander Rukletsov
> On Nov. 24, 2015, 3:58 p.m., Neil Conway wrote: > > src/tests/fault_tolerance_tests.cpp, line 720 > > > > > > I'd remove this comment -- various other places use the same pattern. > > I'd also remove the newline

Re: Review Request 40396: Quota: Added a test for offer rescinding.

2015-11-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/ --- (Updated Nov. 24, 2015, 4:29 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

2015-11-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 24, 2015, 4:29 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-24 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/#review107817 --- Ship it! Ship It! - Cong Wang On Nov. 24, 2015, 2:50 p.m.,

Re: Review Request 40445: Added linter for license headers in some file types.

2015-11-24 Thread Vinod Kone
> On Nov. 18, 2015, 6:21 p.m., Vinod Kone wrote: > > support/hooks/post-rewrite, line 33 > > > > > > instead of calling this script directly, i would recommend calling it > > from mesos-style.py. this way users and

Re: Review Request 40010: Put authorize logic for teardown into a common function.

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40010/#review107804 --- Patch looks great! Reviews applied: [40010] Passed command:

Review Request 40665: Clean up redundant os exists check before mkdir.

2015-11-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40665/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 十一月 24, 2015, 8:09 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40545/#review107734 --- src/webui/master/static/js/services.js (line 130)

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/#review107735 --- Patch looks great! Reviews applied: [40424] Passed command:

Re: Review Request 40529: Added helper function to get stateless resources.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 十一月 24, 2015, 8:08 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review107732 --- include/mesos/mesos.proto (line 649)

Review Request 40630: Upgrade pip to 7.1.2

2015-11-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40630/ --- Review request for mesos, Bernd Mathiske, Joseph Wu, and Till Toenshoff. Bugs:

Re: Review Request 38527: Fix UserCgroupIsolatorTest failed on CentOS 6.6.

2015-11-24 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38527/#review107736 --- Ship it! Ship It! - Alexander Rojas On Oct. 6, 2015, 6:47

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-24 Thread Ian Babrou
> On Nov. 24, 2015, 8:14 a.m., Klaus Ma wrote: > > src/webui/master/static/js/services.js, line 130 > > > > > > Do we know why timestamp is NaN? Because mesos slaves do not supply it in metrics. It's not NaN, it's

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

2015-11-24 Thread Bernd Mathiske
> On Oct. 6, 2015, 5:42 p.m., Klaus Ma wrote: > > src/common/resources.cpp, line 879 > > > > > > This fix is ok for this ticket; but how to handle other part about > > cpu()? Here's some question from me: > >

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review107742 --- src/tests/mesos.hpp (line 87)

Re: Review Request 40010: Put authorize logic for teardown into a common function.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40010/ --- (Updated 十一月 24, 2015, 9:50 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

2015-11-24 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 24, 2015, 10:11 a.m.) Review request for mesos, Adam B, Guangya

Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- Review request for mesos and Klaus Ma. Repository: mesos Description ---

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review107748 --- Ship it! Ship It! - Bernd Mathiske On Nov. 23, 2015, 9:52

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

2015-11-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40602/#review107751 --- Ship it! Ship It! - Bernd Mathiske On Nov. 23, 2015, 5:20

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Klaus Ma
> On Nov. 24, 2015, 5:42 p.m., Benjamin Bannier wrote: > > src/tests/mesos.hpp, line 87 > > > > > > This seems like a weird addition for this patch: while the existing > > `using` decls above could be justified

Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/ --- Review request for mesos. Bugs: MESOS-3963

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40545/#review107739 --- Ship it! Ship It! - Klaus Ma On Nov. 21, 2015, 1:01 a.m., Ian

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-11-24 Thread Klaus Ma
> On Nov. 23, 2015, 8:58 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4419 > > > > > > I think that the oversubscribable resources should always > > has_revocable()? For which case does the

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- (Updated Nov. 24, 2015, 7:02 p.m.) Review request for mesos and Guangya Liu.

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review107741 --- src/tests/mesos.hpp (line 87)

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/#review107746 --- Patch looks great! Reviews applied: [39712] Passed command:

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-11-24 Thread Klaus Ma
> On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote: > > Seems the rebase caused some problem for your patch, some files are lost. There's only file for this patch; if still issue, please ping me online. > On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4460 > >

Re: Review Request 40647: Updated centos6.6 installation instructions.

2015-11-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/ --- (Updated Nov. 24, 2015, 2:50 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-11-24 Thread Guangya Liu
> On 十一月 23, 2015, 12:58 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4419 > > > > > > I think that the oversubscribable resources should always > > has_revocable()? For which case does the

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107786 --- Seems the rebase caused some problem for your patch, some files

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

2015-11-24 Thread Alexander Rukletsov
> On Nov. 24, 2015, 1:52 p.m., Benjamin Bannier wrote: > > src/tests/fault_tolerance_tests.cpp, line 778 > > > > > > You should just use `master::Flags().allocation_interval` to simplify > > this. Do you think it

Review Request 40647: Updated centos6.6 installation instructions.

2015-11-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40647/ --- Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated Nov. 24, 2015, 10:48 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 24, 2015, 3:07 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

2015-11-24 Thread Klaus Ma
> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 1982 > > > > > > EXPECT_TRUE((r3 - r3).empty()); This is added the previous code, so i'd like to drop this issue. > On

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated Nov. 24, 2015, 7:35 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40545/#review107763 --- Bad review! Reviews applied: [] Error: No reviewers specified.

  1   2   >