Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review108655 --- src/master/master.cpp (lines 2769 - 2770)

Re: Review Request 40266: Libprocess Reinitialization: Cleanup SocketManager along side ProcessManager.

2015-12-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review108650 --- 3rdparty/libprocess/src/process.cpp (line 461)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review108653 --- src/master/http.cpp (lines 1034 - 1037)

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review108645 --- include/mesos/quota/quota.proto (lines 43 - 45)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review108654 --- src/master/master.cpp (lines 3029 - 3030)

Review Request 40873: SimpleRegistryPullerTest: Moved blob response preparation to the top.

2015-12-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-4025

Re: Review Request 40874: Restructured comments in authorizer.proto

2015-12-02 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40874/#review108659 --- Ship it! Ship It! - Till Toenshoff On Dec. 2, 2015, 4:25 p.m.,

Review Request 40872: Changed RegistryClientTest to use instance work directory.

2015-12-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40872/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-4025

Re: Review Request 40874: Restructured comments in authorizer.proto

2015-12-02 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40874/#review108661 --- Ship it! Ship It! - Jan Schlicht On Dec. 2, 2015, 5:25 p.m.,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review108639 --- src/master/master.hpp (lines 1089 - 1094)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Jie Yu
> On Dec. 2, 2015, 4:05 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 3041-3043 > > > > > > We validate later on that in `principal` is `None`, reserve is aborted. > > IIUC, if `FrameworkInfo`

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

2015-12-02 Thread Greg Mann
> On Dec. 2, 2015, 4:02 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 2769-2770 > > > > > > Is my understanding is correct, we do not allow reserving resources > > neither for operators nor

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-12-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review108679 --- docs/authorization.md (line 13)

Re: Review Request 40818: Fixed flaky test (AvailableResourcesAfterRescinding).

2015-12-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40818/#review108682 --- Ship it! After our discussion offline, I suggest we remove these

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-12-02 Thread Jie Yu
> On Dec. 2, 2015, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 1035-1038 > > > > > > Let's leave a comment here, that `principal` matches > > `reservation().principal()` for each resource

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Bernd Mathiske
> On Nov. 30, 2015, 6:15 a.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 248 > > > > > > s/RESERVE/UNRESERVE/ ? > > > > What is the intention here? Please explain. > > Avinash

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

2015-12-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review108697 --- src/master/master.cpp (lines 2804 - 2805)

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/#review108673 --- docs/authorization.md (lines 9 - 11)

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/ --- (Updated Dec. 2, 2015, 6 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

2015-12-02 Thread Jie Yu
> On Dec. 2, 2015, 4:02 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 2769-2770 > > > > > > Is my understanding is correct, we do not allow reserving resources > > neither for operators nor

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review108671 --- Minor nits. docs/authorization.md (line 13)

Re: Review Request 37540: Add perf event API

2015-12-02 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review108686 --- Ping - Cong, is there anything you need to close the last issues?

Re: Review Request 40873: SimpleRegistryPullerTest: Moved blob response preparation to the top.

2015-12-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/#review108662 --- @jojy, Do we know why preparing the response was taking so long

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

2015-12-02 Thread Greg Mann
> On Dec. 2, 2015, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 2775 > > > > > > I believe you inherited the TODO from MPark. Do you want to preserve > > his name or change to yours? I

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108696 --- src/tests/reservation_tests.cpp (line 237)

Re: Review Request 40874: Restructured comments in authorizer.proto

2015-12-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40874/#review108674 --- Ship it! Ship It! - Michael Park On Dec. 2, 2015, 4:25 p.m.,

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review108675 --- Do you think it makes sense to update "src/master/flags.cpp" as

Re: Review Request 40849: Fix flaky MemoryPressureMesosTests

2015-12-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40849/ --- (Updated Dec. 2, 2015, 11:25 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Dec. 2, 2015, 7:55 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 40873: SimpleRegistryPullerTest: Moved blob response preparation to the top.

2015-12-02 Thread Anand Mazumdar
> On Dec. 2, 2015, 4:40 p.m., Anand Mazumdar wrote: > > @jojy, Do we know why preparing the response was taking so long that was > > causing the socket to timeout previously ? > > Jojy Varghese wrote: > @anand: The observed behavior is that the server socket gets a RST. This > is ususally

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
> On Dec. 2, 2015, 6:32 p.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 248 > > > > > > More customary indentation: > > > > EXPECT_CALL(sched, resourceOffers(, _)) > >

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-12-02 Thread Greg Mann
> On Dec. 2, 2015, 2:26 p.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1089-1095 > > > > > > Do you want to do this cleanup as a separate patch? I believe we tend > > not to conflate semantic

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Dec. 2, 2015, 7:53 p.m.) Review request for mesos, Adam B, Jie Yu,

Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

2015-12-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40880/ --- Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Greg Mann
> On Dec. 2, 2015, 4:05 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 3041-3043 > > > > > > We validate later on that in `principal` is `None`, reserve is aborted. > > IIUC, if `FrameworkInfo`

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108704 --- Some minor comments modulo comments from Bernd earlier.

Re: Review Request 40745: Cleaned up `RemoveSingleQuota` test and corrected formatting issues.

2015-12-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40745/#review108705 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 27, 2015,

Re: Review Request 40873: SimpleRegistryPullerTest: Moved blob response preparation to the top.

2015-12-02 Thread Jojy Varghese
> On Dec. 2, 2015, 4:40 p.m., Anand Mazumdar wrote: > > @jojy, Do we know why preparing the response was taking so long that was > > causing the socket to timeout previously ? @anand: The observed behavior is that the server socket gets a RST. This is ususally when the peer side of the socket

Re: Review Request 40746: Quota: Removed quota from registry for remove request.

2015-12-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40746/#review108712 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 26, 2015,

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Dec. 2, 2015, 8:23 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
> On Nov. 30, 2015, 2:15 p.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 176 > > > > > > Also see the indentations in various other statements involving > > argument passing, etc. Best to sit

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108621 --- Bad patch! Reviews applied: [40730, 40732, 40731] Failed

Re: Review Request 40524: Used string directly in resources.cpp.

2015-12-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/#review108736 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 1, 2015, 2:13

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
> On Dec. 2, 2015, 8:02 p.m., Anand Mazumdar wrote: > > src/tests/reservation_tests.cpp, line 213 > > > > > > Is this comment needed ? I think this a copy-paste issue. This must have come from the previous test

Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

2015-12-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40838/ --- (Updated Dec. 2, 2015, 2:09 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

2015-12-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40372/ --- (Updated Dec. 2, 2015, 2:46 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39938: Document OS X SIGPIPE delivery.

2015-12-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39938/#review108727 --- Ship it! Thanks!

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-12-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review108391 --- I see a very basic test in the next review. Are you planning to

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Dec. 2, 2015, 10:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review108731 --- src/tests/executor_http_api_tests.cpp (line 749)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-12-02 Thread Greg Mann
> On Dec. 2, 2015, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 1035-1038 > > > > > > Let's leave a comment here, that `principal` matches > > `reservation().principal()` for each resource

Review Request 40884: Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer.

2015-12-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40884/ --- Review request for mesos, Artem Harutyunyan and Timothy Chen. Bugs: MESOS-4051

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-12-02 Thread Anand Mazumdar
> On Dec. 2, 2015, 10:24 p.m., Vinod Kone wrote: > > I see a very basic test in the next review. Are you planning to write more > > comprehensive tests? Is that plan to templatize slave recovery tests for > > both pid based and http executors? For now, I added just a basic test for testing

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-12-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Dec. 2, 2015, 10:41 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Dec. 2, 2015, 10:47 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated Dec. 3, 2015, 1:05 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40888: Add volume driver plugin to mesos v1 proto.

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40888/#review108763 --- Patch looks great! Reviews applied: [40888] Passed command:

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Alexander Rukletsov
> On Dec. 2, 2015, 4:05 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 3041-3043 > > > > > > We validate later on that in `principal` is `None`, reserve is aborted. > > IIUC, if `FrameworkInfo`

Re: Review Request 40266: Libprocess Reinitialization: Cleanup SocketManager along side ProcessManager.

2015-12-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/ --- (Updated Dec. 2, 2015, 4:50 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40266: Libprocess Reinitialization: Cleanup SocketManager along side ProcessManager.

2015-12-02 Thread Joseph Wu
> On Dec. 2, 2015, 8:08 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/process.cpp, line 2200 > > > > > > I find adding another manual iteration index manipulation here makes > > this even harder to

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-02 Thread Guangya Liu
> On Dec. 1, 2015, 1:03 a.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, line 96 > > > > > > Suggestion: rename the variable to `enableReservationOversubscription`. Done. > On Dec. 1, 2015, 1:03

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated Dec. 3, 2015, 1:01 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

2015-12-02 Thread Guangya Liu
> On 十二月 1, 2015, 1:31 a.m., Joseph Wu wrote: > > src/messages/messages.proto, lines 326-329 > > > > > > The design doc comment doesn't quite work without the context > > surrounding it. :) > > > > --- >

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/ --- (Updated Dec. 3, 2015, 6:28 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Neil Conway
> On Dec. 3, 2015, 4:26 a.m., Michael Park wrote: > > Could you also create a clean-up patch to get rid of the unnecessary > > `struct` disambiguators in this file? I kinda like leaving "struct" as-is, because we're interfacing with C-style APIs where "struct" is syntactically significant --

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review108770 --- Patch looks great! Reviews applied: [40435] Passed command:

Re: Review Request 40529: Added helper function to get stateless resources.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 十二月 3, 2015, 4:35 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 十二月 3, 2015, 4:35 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 3, 2015, 4:35 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

2015-12-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 十二月 3, 2015, 4:34 a.m.) Review request for mesos and Klaus Ma.

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review108783 --- Bad patch! Reviews applied: [40632] Failed command:

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/ --- (Updated Dec. 3, 2015, 6:48 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

2015-12-02 Thread Anand Mazumdar
> On Dec. 2, 2015, 10:29 p.m., Vinod Kone wrote: > > src/tests/executor_http_api_tests.cpp, line 757 > > > > > > Hmm. this test is a bit convoluted. you start a pid based executor > > first, wait for its update to

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/#review108789 --- Patch looks great! Reviews applied: [40339, 40529, 40532] Passed

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review108773 --- Ship it! Could you also create a clean-up patch to get rid of the

Re: Review Request 40445: Added linter for license headers in some file types.

2015-12-02 Thread Michael Park
> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote: > > support/mesos-style.py, line 6 > > > > > > Why the introduction of the `print` function? Can't we just use `print` > > and `.format`? > > Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

2015-12-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108772 --- support/mesos-style.py (lines 126 - 127)

Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40487/#review108774 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 40888: Add volume driver plugin to mesos v1 proto.

2015-12-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40888/ --- Review request for mesos, haosdent huang, Artem Harutyunyan, and Timothy Chen.

Re: Review Request 40445: Added linter for license headers in some file types.

2015-12-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Dec. 3, 2015, 12:02 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40873: SimpleRegistryPullerTest: Moved blob response preparation to the top.

2015-12-02 Thread Jojy Varghese
> On Dec. 2, 2015, 4:40 p.m., Anand Mazumdar wrote: > > @jojy, Do we know why preparing the response was taking so long that was > > causing the socket to timeout previously ? > > Jojy Varghese wrote: > @anand: The observed behavior is that the server socket gets a RST. This > is ususally

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

2015-12-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40372/#review108746 --- Ship it! src/tests/containerizer/mesos_containerizer_tests.cpp

Re: Review Request 40445: Added linter for license headers in some file types.

2015-12-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108745 --- support/mesos-style.py (line 5)

Re: Review Request 40788: Added lambda function in resources.cpp.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40788/ --- (Updated Dec. 2, 2015, 11:19 p.m.) Review request for mesos, Michael Park and

Re: Review Request 40884: Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer.

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40884/#review108750 --- Patch looks great! Reviews applied: [40838, 40884] Passed

Re: Review Request 40445: Added linter for license headers in some file types.

2015-12-02 Thread Benjamin Bannier
> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote: > > support/mesos-style.py, line 6 > > > > > > Why the introduction of the `print` function? Can't we just use `print` > > and `.format`? This was some drive-by

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108754 --- Bad patch! Reviews applied: [40730, 40732, 40731] Failed

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40118/ --- (Updated Dec. 2, 2015, 9:42 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Dec. 2, 2015, 9:41 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review108632 --- include/mesos/authorizer/authorizer.proto (line 76)

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-02 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/ --- (Updated Dec. 2, 2015, 12:44 p.m.) Review request for mesos, Alexander

Re: Review Request 40445: Added linter for license headers in some file types.

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108634 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40445: Added linter for license headers in some file types.

2015-12-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Dec. 2, 2015, 11:18 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/#review108635 --- Bad patch! Reviews applied: [39211, 39018, 39102, 36913, 38059,

Re: Review Request 40873: SimpleRegistryPullerTest: Moved blob response preparation to the top.

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/#review108723 --- Patch looks great! Reviews applied: [40872, 40873] Passed

Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40880/#review108733 --- Patch looks great! Reviews applied: [40849, 40880] Passed

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

2015-12-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/ --- (Updated Dec. 2, 2015, 10:38 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-12-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review108637 --- Ship it! include/mesos/authorizer/authorizer.hpp (lines 136 -

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/ --- (Updated Dec. 3, 2015, 1:45 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

2015-12-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40487/#review108765 --- Hey Ian thanks for your patch! While this is pretty trivial,

  1   2   >