Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Bartek Plotka
> On Dec. 9, 2015, 10:46 p.m., Vinod Kone wrote: > > src/Makefile.am, line 1600 > > > > > > Great to see a default QoS controller! Thx, can i `fix` that? =DDD - Bartek

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Bartek Plotka
> On Dec. 9, 2015, 6:32 p.m., Niklas Nielsen wrote: > > src/slave/qos_controllers/load.hpp, lines 39-45 > > > > > > Awesome comment! Let's make it a doxygen style one. Hmm, i followed all mesos style guidelines e.g

Re: Review Request 40567: Windows: 1/3 Added zlib definitions for Windows.

2015-12-10 Thread Dario Bazan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40567/ --- (Updated Dec. 10, 2015, 6:07 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

2015-12-10 Thread Cong Wang
> On Dec. 10, 2015, 12:27 a.m., Jie Yu wrote: > > This is more like a question: do we need to turn off tx side as well? This is not needed, because 1) the physical interface can finally checksum it after it moves out of the container to the gateway interface; 2) if the physcial interface is

Re: Review Request 41215: Added test case for quota behavior in the presence of empty roles.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41215/ --- (Updated Dec. 10, 2015, 6:37 p.m.) Review request for mesos, Alexander

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

2015-12-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Dec. 10, 2015, 6:46 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41211: Aggregated Http as member in Master.

2015-12-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41211/#review109844 --- Ship it! Ship It! - Michael Park On Dec. 10, 2015, 5:32 p.m.,

Re: Review Request 41209: Replace Docker with MockDocker in HealthCheckTest.

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41209/#review109840 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-12-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/#review109841 --- Ship it! Thanks for cleaning this up James! I've touched up a few

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109842 --- src/slave/qos_controllers/load.cpp (line 76)

Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-12-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39288/#review109796 --- Ship it! Rebased on https://reviews.apache.org/r/41211. This

Re: Review Request 41113: Added `IsolatorRecoveryInfo` message as the sole parameter to `Isolator::recover()`.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41113/#review109786 --- Re: "facilating the addition of new parameters without breaking

Review Request 41211: Aggregated Http as member in Master.

2015-12-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41211/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109799 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Review Request 41215: Added test case for quota behavior in the presence of empty roles.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41215/ --- Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

2015-12-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 十二月 10, 2015, 8:31 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40872: Changed RegistryClientTest to use instance work directory.

2015-12-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40872/#review109713 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 527)

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109719 --- Patch looks great! Reviews applied: [41158] Passed command:

Re: Review Request 39848: Validate revocable resources

2015-12-10 Thread Guangya Liu
> On 十二月 5, 2015, 12:21 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 1503 > > > > > > I think at this point it's worthwhile to factor out the validations in > > this function into slave/validation.cpp

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

2015-12-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 十二月 10, 2015, 8:34 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40873: RegistryClientTests: Created separate server to serve blobs.

2015-12-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/#review109716 --- Ship it! Ship It! - Timothy Chen On Dec. 3, 2015, 5:20 p.m.,

Re: Review Request 41078: Fixed tests to call socket accept before sending response.

2015-12-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41078/#review109717 --- Ship it! Ship It! - Timothy Chen On Dec. 8, 2015, 7:03 a.m.,

Re: Review Request 40872: Changed RegistryClientTest to use instance work directory.

2015-12-10 Thread Timothy Chen
> On Dec. 10, 2015, 8:37 a.m., Timothy Chen wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 526 > > > > > > How about just use os::getcwd? And why do we even need a uuid based > > working

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Bartek Plotka
> On Dec. 9, 2015, 10:46 p.m., Vinod Kone wrote: > > Are you also planning to update > > https://github.com/apache/mesos/blob/master/docs/oversubscription.md ? Already in review: https://reviews.apache.org/r/41042/ (: Thx for detailed review i will fix the issues soon. > On Dec. 9, 2015,

Re: Review Request 40872: Changed RegistryClientTest to use instance work directory.

2015-12-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40872/#review109709 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 526)

Re: Review Request 41212: Adjust timeout value in HealthCheckTest.CheckCommandTimeout.

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41212/#review109850 --- Patch looks great! Reviews applied: [41212] Passed command:

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-12-10 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Dec. 10, 2015, 1:35 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 41075: Added support for implicit roles.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109878 --- src/master/http.cpp (line 1588)

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-12-10 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Dec. 10, 2015, 1:42 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread James Peach
> On Dec. 10, 2015, 3:30 p.m., Till Toenshoff wrote: > > src/tests/utils.cpp, lines 71-77 > > > > > > I still don't understand why the oversubscription tests need to have > > this installed in the LIBDIR and not in

Review Request 41225: Added test cases for implicit roles.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/ --- Review request for mesos. Repository: mesos Description --- Added test

Review Request 41223: Cleaned up creation of HTTP auth headers in tests.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41223/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 41075: Added support for implicit roles.

2015-12-10 Thread Neil Conway
> On Dec. 10, 2015, 10:13 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.hpp, lines 367-368 > > > > > > I'm not sure how badly we need to clean up this map. What happens if we > > leave a role in

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Dec. 10, 2015, 9:28 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 41075: Added support for implicit roles.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/ --- (Updated Dec. 10, 2015, 10:09 p.m.) Review request for mesos, Adam B,

Re: Review Request 40995: Added test cases for role behavior.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/ --- (Updated Dec. 10, 2015, 10:08 p.m.) Review request for mesos, Adam B,

Re: Review Request 41225: Added test cases for implicit roles.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/ --- (Updated Dec. 10, 2015, 11:07 p.m.) Review request for mesos, Adam B,

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

2015-12-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/#review109894 --- Ship it! Ship It! - Klaus Ma On Dec. 10, 2015, 10:26 p.m.,

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-12-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review109902 --- Can you please rebase this patch? I cannot apply this for test now

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-12-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated Dec. 11, 2015, 9:21 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

2015-12-10 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109903 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Re: Review Request 41223: Cleaned up creation of HTTP auth headers in tests.

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41223/#review109898 --- Patch looks great! Reviews applied: [41223] Passed command:

Review Request 41234: Close leaked FD in RegistryClientTest.SimpleRegistryPuller.

2015-12-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41234/ --- Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.

Re: Review Request 41159: Corrected a comment in reservation endpoint tests.

2015-12-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41159/#review109733 --- Ship it! Ship It! - Michael Park On Dec. 9, 2015, 11:22 p.m.,

Re: Review Request 41156: Employed a better macro in tests, cleaned up formatting.

2015-12-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41156/#review109742 --- Ship it! Ship It! - Michael Park On Dec. 9, 2015, 11:36 p.m.,

Re: Review Request 41075: Added support for implicit roles.

2015-12-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109708 --- Seems like the right overall approach, but I've realized that we

Re: Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.

2015-12-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41001/#review109732 --- Ship it! Ship It! - Michael Park On Dec. 10, 2015, 2:02 a.m.,

Re: Review Request 41185: CMake: Updated LFLAG for dl library to defined label

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41185/#review109745 --- Patch looks great! Reviews applied: [41096, 41185] Passed

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review109706 --- This looks like just the interface change; where's the

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review109704 --- I'm not sure exactly why you needed to move RoleInfo out of

Re: Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41001/#review109735 --- Patch looks great! Reviews applied: [40999, 41001] Passed

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Bartek Plotka
> On Dec. 9, 2015, 10:46 p.m., Vinod Kone wrote: > > src/tests/oversubscription_tests.cpp, lines 1163-1176 > > > > > > push this inside the lamba below? Can i ask why? (: From the computation perspective now i

Review Request 41212: Adjust timeout value in HealthCheckTest.CheckCommandTimeout.

2015-12-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41212/ --- Review request for mesos, Ben Mahler and Timothy Chen. Bugs: MESOS-4024

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109798 --- Ship it! Looking great! Will let Vinod have one more look, but

Review Request 41216: Cleaned up DRF allocator tests.

2015-12-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41216/ --- Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.

Re: Review Request 41096: CMake: Added LFLAGs need for linux cmake build

2015-12-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41096/#review109804 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 10, 2015,

Review Request 41209: Replace Docker with MockDocker in HealthCheckTest.

2015-12-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41209/ --- Review request for mesos. Repository: mesos Description --- Replace

Re: Review Request 41185: CMake: Updated LFLAG for dl library to defined label

2015-12-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41185/#review109805 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 10, 2015,

Re: Review Request 41216: Cleaned up DRF allocator tests.

2015-12-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41216/#review109809 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 10, 2015,

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review109817 --- Bad patch! Reviews applied: [39780, 39781, 39782, 40553] Failed

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2015-12-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Dec. 10, 2015, 6:45 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Niklas Nielsen
> On Dec. 9, 2015, 10:32 a.m., Niklas Nielsen wrote: > > src/slave/qos_controllers/load.hpp, lines 39-45 > > > > > > Awesome comment! Let's make it a doxygen style one. > > Bartek Plotka wrote: > Hmm, i followed

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Niklas Nielsen
> On Dec. 9, 2015, 2:46 p.m., Vinod Kone wrote: > > src/Makefile.am, line 1600 > > > > > > Great to see a default QoS controller! > > Bartek Plotka wrote: > Thx, can i `fix` that? =DDD @vinod - maybe wasn't

Re: Review Request 40568: Windows: 2/3 Added zlib compilation steps for Windows.

2015-12-10 Thread Dario Bazan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40568/ --- (Updated Dec. 10, 2015, 6:12 p.m.) Review request for mesos, Artem

Re: Review Request 41215: Added test case for quota behavior in the presence of empty roles.

2015-12-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41215/#review109819 --- Ship it! src/tests/hierarchical_allocator_tests.cpp (lines 1773

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2015-12-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Dec. 10, 2015, 6:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-10 Thread Yongqiao Wang
> On Dec. 10, 2015, 10:40 a.m., Adam B wrote: > > include/mesos/master/allocator.proto, line 19 > > > > > > Shouldn't this file have `java_package` and `java_outer_classname` just > > like the other protos? > >

Re: Review Request 41209: Replace Docker with MockDocker in HealthCheckTest.

2015-12-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41209/ --- (Updated Dec. 11, 2015, 3:59 a.m.) Review request for mesos, Ben Mahler, Greg

Review Request 41236: Some consistency style fixes in Docker puller.

2015-12-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41236/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy

Review Request 41237: Renamed a function parameter in Docker puller.

2015-12-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41237/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy

Re: Review Request 41225: Added test cases for implicit roles.

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/#review109909 --- Patch looks great! Reviews applied: [40995, 41075, 41225] Passed

Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-10 Thread Yongqiao Wang
> On Dec. 10, 2015, 10:46 a.m., Adam B wrote: > > This looks like just the interface change; where's the (default/reference) > > implementation? > > Justify/delete the removeRole call. > > Consider (the lack of) backwards-compatibility for your allocator module > > API change. Refer to some

Re: Review Request 39848: Validate revocable resources

2015-12-10 Thread Guangya Liu
> On 十二月 5, 2015, 12:21 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 1503 > > > > > > I think at this point it's worthwhile to factor out the validations in > > this function into slave/validation.cpp

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review109752 --- Patch looks great! Reviews applied: [41187, 41188] Passed

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-10 Thread Yong Qiao Wang
> On Dec. 10, 2015, 10:40 a.m., Adam B wrote: > > I'm not sure exactly why you needed to move RoleInfo out of > > allocator.proto. The RoleInfo we use for the allocator module API doesn't > > need to be (and perhaps shouldn't be) the same class that we use to display > > role information like

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 10, 2015, 5:03 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-10 Thread Bartek Plotka
> On Gru 9, 2015, 10:46 po południu, Vinod Kone wrote: > > src/Makefile.am, line 1600 > > > > > > Great to see a default QoS controller! > > Bartek Plotka wrote: > Thx, can i `fix` that? =DDD > > Niklas

Re: Review Request 41113: Added `IsolatorRecoveryInfo` message as the sole parameter to `Isolator::recover()`.

2015-12-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41113/#review109812 --- NOTE: this patch may not be necessary, as a simpler workaround has

Re: Review Request 40582: Windows: 3/3 Enabled zlib compression tests.

2015-12-10 Thread Dario Bazan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40582/ --- (Updated Dec. 10, 2015, 6:14 p.m.) Review request for mesos, Artem

Re: Review Request 41113: Added `IsolatorRecoveryInfo` message as the sole parameter to `Isolator::recover()`.

2015-12-10 Thread Greg Mann
> On Dec. 10, 2015, 5:18 p.m., Neil Conway wrote: > > Re: "facilating the addition of new parameters without breaking the > > interface", is the goal to ensure ABI compatibility or API compatibility? > > If the former, a protobuf is not sufficient (you typically need to use the > > PIML idiom

Re: Review Request 41234: Close leaked FD in RegistryClientTest.SimpleRegistryPuller.

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41234/#review109929 --- Patch looks great! Reviews applied: [41234] Passed command:

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread Benjamin Bannier
> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote: > > src/tests/containerizer/memory_test_helper.cpp, line 197 > > > > > > Should probably be passed as an arg (`bool` or even better an `enum` > > value). You

Re: Review Request 41185: CMake: Updated LFLAG for dl library to defined label

2015-12-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41185/#review109764 ---

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/#review109765 --- Patch looks great! Reviews applied: [40375, 40339, 40529, 40632,

Review Request 41243: Update how we find the .git directory in bootstrap

2015-12-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-4125

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

2015-12-10 Thread Cong Wang
> On Dec. 11, 2015, 1:16 a.m., David Robinson wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, lines > > 1097-1098 > > > > > > This writes to stderr, which can end up in the logs. > >

Review Request 41245: Use ethtool -k lo to check ethtool command

2015-12-10 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41245/ --- Review request for mesos, David Robinson, Ian Downes, and Jie Yu. Repository:

Re: Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed` for all HTTP requests with unsupported methods.

2015-12-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40906/#review109757 --- Patch looks great! Reviews applied: [40905, 40913, 40906] Passed

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

2015-12-10 Thread Alexander Rojas
> On Dec. 8, 2015, 8:52 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/process.hpp, lines 65-86 > > > > > > Why isn't this in the http header? It looks like firewall belongs there > > too since

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

2015-12-10 Thread Alexander Rojas
> On Dec. 9, 2015, 12:19 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 1339-1343 > > > > > > Hm.. it looks like you're using the principals here to check that the > > requests

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

2015-12-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 十二月 10, 2015, 2:26 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2015-12-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Dec. 10, 2015, 3:32 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

2015-12-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 10, 2015, 3:25 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 10, 2015, 3:28 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-12-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 10, 2015, 3:34 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2015-12-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review109153 --- src/examples/test_http_authenticator_module.cpp (lines 49 - 50)

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review107994 --- Great work James, much appreciated. And yes, it is tedious and

Re: Review Request 40872: Changed RegistryClientTest to use instance work directory.

2015-12-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40872/#review109759 --- Ship it! Ship It! - Timothy Chen On Dec. 2, 2015, 4:23 p.m.,

Re: Review Request 41096: CMake: Added LFLAGs need for linux cmake build

2015-12-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41096/#review109768 --- 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (line

  1   2   >