Re: Review Request 40469: Update Allocator interface to support dynamic weight

2015-12-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Dec. 11, 2015, 10:08 a.m.) Review request for mesos, Adam B, Guangya

Review Request 40966: Corrected termination of Docker containers.

2015-12-11 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40966/ --- Review request for mesos, Greg Mann, haosdent huang, Jojy Varghese, and Till

Re: Review Request 40469: Update Allocator interface to support dynamic weight

2015-12-11 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review109938 --- include/mesos/role/role.hpp (line 24)

Re: Review Request 41252: RegistryClientTests: added explicit content-length header.

2015-12-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41252/ --- (Updated Dec. 11, 2015, 12:40 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-11 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 11, 2015, 12:45 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

2015-12-11 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review109962 --- Ship it! Ship It! - Bernd Mathiske On Dec. 11, 2015, 6:01

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 11, 2015, 3:01 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 40759: Command executor can overcommit the slave

2015-12-11 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40759/ --- (Updated Dec. 11, 2015, 10:06 p.m.) Review request for Ben Mahler, Guangya

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-12-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 11, 2015, 3:06 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-11 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109954 --- Ship it! 3rdparty/libprocess/src/authenticator.cpp (line 49)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-12-11 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109955 --- src/master/flags.cpp (line 438)

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

2015-12-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 11, 2015, 3:01 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 41245: Use ethtool -k lo to check ethtool command

2015-12-11 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41245/#review109965 --- Ship it! Ship It! - David Robinson On Dec. 11, 2015, 5:20

Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-11 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41286/ --- Review request for mesos and Neil Conway. Bugs: MESOS-4118

Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

2015-12-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39620/#review110025 --- Ship it!

Review Request 41281: Added output operator to output call/event types in the Executor V1 API.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41281/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550

Review Request 41280: Fixed header include order.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41280/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550

Review Request 41285: Initialized `pid` to None() instead of `UPID()` in Slave

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/ --- Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Bugs: MESOS-3550

Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550

Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550

Re: Review Request 41278: Add note to site-docker doc about tunneling

2015-12-11 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41278/ --- (Updated Dec. 11, 2015, 11:18 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review110048 --- Hey Jan, would you mind rebasing this chain? I just got a "patch

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/#review110042 --- Just a note that depending on the order of commits, this diff may

Re: Review Request 36879: Added disk size on slave flag in Reservation Test

2015-12-11 Thread Brenden Matthews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36879/#review110035 --- Ship it! Ship It! - Brenden Matthews On July 28, 2015, 6:42

Review Request 41277: Added environment variables to be used by HTTP executors for connection/retrying disconnections.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41277/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550

Review Request 41275: Introduced a field for specifying grace period in Shutdown Event for Executor V1 API.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41275/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550

Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41290/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550

Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550

Review Request 41282: Added the interface for the V1 Executor HTTP Library.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41282/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550

Re: Review Request 23747: check missing apache headers script

2015-12-11 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23747/#review110045 --- test - Isabel Jimenez On July 22, 2014, 1:37 a.m., Isabel

Review Request 41292: Corrected `Event::Error` documentation for the HTTP Scheduler API.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41292/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-12-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review110049 --- include/mesos/authorizer/authorizer.proto (line 127)

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-12-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review110034 --- Looking good! Minor nit below.

Review Request 41278: Add note to site-docker doc about tunneling

2015-12-11 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41278/ --- Review request for mesos. Repository: mesos Description --- If we are

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 11, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41168: Logger Module: Add ContainerLogger support to the MesosTest helpers

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41168/ --- (Updated Dec. 11, 2015, 4:40 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41061: Logger Module: Add executor_logger and executor_logger_options flags to the agent.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41061/ --- (Updated Dec. 11, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41166: Logger Module: Adds the ContainerLogger as a component for the containerizer and explicitly disallow use of the ContainerLogger with the External Containerizer.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41166/ --- (Updated Dec. 11, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41111: Logger Module: Add test for default executor/task stdout/stderr logging behavior (to sandbox).

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- (Updated Dec. 11, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41004: Logger Module: Introduce the ContainerLogger module.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41004/ --- (Updated Dec. 11, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/ --- (Updated Dec. 11, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/ --- (Updated Dec. 11, 2015, 4:40 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 12, 2015, 6:34 a.m.) Review request for mesos and Adam B.

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 12, 2015, 7:37 a.m.) Review request for mesos and Adam B.

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review110060 --- Thanks for the test, main question is why BasicAuthenticator is

Re: Review Request 41114: Showed disk resources in the WebUI.

2015-12-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41114/#review110062 --- Ship it! Long overdue, thanks! - Ben Mahler On Dec. 9, 2015,

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/ --- (Updated Dec. 11, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2015-12-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/ --- (Updated Dec. 12, 2015, 2:15 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41292: Corrected `Event::Error` documentation for the HTTP Scheduler API.

2015-12-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41292/#review110065 --- Patch looks great! Reviews applied: [41292] Passed command:

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

2015-12-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review110006 --- Ship it! I'll make the changes below in order to avoid more round

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-11 Thread Avinash sridharan
> On Dec. 10, 2015, 4:52 a.m., Anand Mazumdar wrote: > > 1. We badly need a unit test for this. :-) > > 2. If I understand correctly, the reason you did not use the automated > > protobuf to JSON converters and had to use `model(...)` is that `labels` is > > populated in a custom way in the

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

2015-12-11 Thread Alexander Rukletsov
> On Dec. 3, 2015, 5:10 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 582 > > > > > > hmmm , why do we need another constructor with no response body ? > > > > We have

Review Request 41252: RegistryClientTests: added explicit content-length header.

2015-12-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41252/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Review Request 41248: Enabled master get USAGE_SLACK metrics.

2015-12-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41248/ --- Review request for mesos and Klaus Ma. Bugs: MESOS-4123

Review Request 41246: Enabled slave get USAGE_SLACK metrics.

2015-12-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41246/ --- Review request for mesos and Klaus Ma. Bugs: MESOS-4123

Review Request 41254: Enable master get ALLOCATION_SLACK metrics.

2015-12-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41254/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu,

Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

2015-12-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41250/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu,

Re: Review Request 41248: Enabled master get USAGE_SLACK metrics.

2015-12-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41248/ --- (Updated 十二月 11, 2015, 8:50 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41251: Added some eclipse files to gitignore.

2015-12-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41251/ --- (Updated 十二月 11, 2015, 8:55 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40469: Update Allocator interface to support dynamic weight

2015-12-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Dec. 11, 2015, 8:59 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 41237: Renamed a function parameter in Docker puller.

2015-12-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41237/#review109933 --- Patch looks great! Reviews applied: [41235, 41236, 41237] Passed

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Jie Yu
> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 96 > > > > > > The pattern I have seen in the code is that we dont log failures and it > > pops

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Jojy Varghese
> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 96 > > > > > > The pattern I have seen in the code is that we dont log failures and it > > pops

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Jie Yu
> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117 > > > > > > If the future is not expected to be ready when we reach here, should we > > do

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review109993 --- src/common/resources.cpp (line 103)

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/ --- (Updated Dec. 11, 2015, 7:51 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41236: Some consistency style fixes in Docker puller.

2015-12-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41236/ --- (Updated Dec. 11, 2015, 7:52 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2015-12-11 Thread Joseph Wu
> On Dec. 3, 2015, 1:19 p.m., Joseph Wu wrote: > > It would be a good idea to start writing tests for each of these changes. > > You should probably do so in a new `master__test.cpp` file. > > > > We have tests for master flags like this: > >

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-12-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/ --- (Updated Dec. 11, 2015, 7:56 p.m.) Review request for mesos, Artem

Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

2015-12-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39620/ --- (Updated Dec. 11, 2015, 7:56 p.m.) Review request for mesos, Artem

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Jojy Varghese
> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117 > > > > > > If the future is not expected to be ready when we reach here, should we > > do

Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

2015-12-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39620/ --- (Updated Dec. 11, 2015, 8 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

2015-12-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/ --- (Updated Dec. 11, 2015, 8 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-12-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/ --- (Updated Dec. 11, 2015, 8:03 p.m.) Review request for mesos, Artem

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Jie Yu
> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117 > > > > > > If the future is not expected to be ready when we reach here, should we > > do

Review Request 41268: Avoided passing a negative error code to exit(3).

2015-12-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41268/ --- Review request for mesos and Jie Yu. Bugs: MESOS-2209

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/#review109973 --- Ship it! Ship It! - Gilbert Song On Dec. 10, 2015, 5:35 p.m.,

Re: Review Request 41237: Renamed a function parameter in Docker puller.

2015-12-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41237/#review109976 --- Ship it! Ship It! - Gilbert Song On Dec. 10, 2015, 6:01 p.m.,

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Gilbert Song
> On Dec. 11, 2015, 10:06 a.m., Gilbert Song wrote: > > Ship It! Tested. Checked that logic does not change, but more clearer. - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 41236: Some consistency style fixes in Docker puller.

2015-12-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41236/#review109975 --- Ship it! Ship It! - Gilbert Song On Dec. 10, 2015, 6:01 p.m.,

Re: Review Request 39622: CMake: Pointed Stout test linker flags at correct gtest directory.

2015-12-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39622/ --- (Updated Dec. 11, 2015, 6:11 p.m.) Review request for mesos, Artem

Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

2015-12-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/ --- (Updated Dec. 11, 2015, 6:11 p.m.) Review request for mesos, Artem

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-12-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/ --- (Updated Dec. 11, 2015, 6:12 p.m.) Review request for mesos, Artem

Review Request 41251: Added some eclipse files to gitignore.

2015-12-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41251/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-12-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39288/#review109930 --- src/master/quota_handler.cpp (line 19)

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-11 Thread Bartek Plotka
> On Dec. 10, 2015, 7:58 p.m., Vinod Kone wrote: > > src/slave/qos_controllers/load.cpp, lines 236-241 > > > > > > if you do `return`s above, this could just be else block > > > > ``` > > } else { > >

Re: Review Request 41245: Use ethtool -k lo to check ethtool command

2015-12-11 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41245/#review109990 --- Ship it! Ship It! - Ian Downes On Dec. 10, 2015, 9:20 p.m.,

Re: Review Request 41268: Avoided passing a negative error code to exit(3).

2015-12-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41268/#review110009 --- Ship it! Ship It! - Jie Yu On Dec. 11, 2015, 8:04 p.m., Neil

Re: Review Request 41263: Cleaned up docker metadata manager.

2015-12-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41263/#review110010 --- Ship it! Great! Thanks Gilbert!! - Jie Yu On Dec. 11, 2015,

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Jojy Varghese
> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117 > > > > > > If the future is not expected to be ready when we reach here, should we > > do

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-12-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/ --- (Updated Dec. 11, 2015, 8:10 p.m.) Review request for mesos, Artem

Re: Review Request 41270: Fixed error reporting when recovering log storage fails.

2015-12-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41270/#review110008 --- Ship it! Ship It! - Jie Yu On Dec. 11, 2015, 8:04 p.m., Neil

Re: Review Request 41244: Use 'git rev-parse --git-dir' in post-reviews.py

2015-12-11 Thread Kevin Klues
> On Dec. 11, 2015, 7:05 p.m., Joseph Wu wrote: > > LGTM! Double-checked that `post-reviews.py` correctly rebases amended > > commits. > > > > --- > > > > Can you also add `hartem` and `vinodkone` to this review? Added - Kevin ---

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review110014 --- include/mesos/slave/resource_estimator.hpp (lines 61 - 63)

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review110017 --- Ship it! src/slave/qos_controllers/load.cpp (line 206)

Re: Review Request 41234: Close leaked FD in RegistryClientTest.SimpleRegistryPuller.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41234/ --- (Updated Dec. 11, 2015, 10:21 a.m.) Review request for mesos, Artem

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/#review109978 --- Ship it! Thanks Jie!!

Re: Review Request 41235: Cleaned up the untar method in docker puller.

2015-12-11 Thread Jie Yu
> On Dec. 11, 2015, 6:33 p.m., Ben Mahler wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 37 > > > > > > We've been trying to eliminate these in favor of non-namespace using > >

Re: Review Request 41236: Some consistency style fixes in Docker puller.

2015-12-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41236/#review109979 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp

Re: Review Request 41236: Some consistency style fixes in Docker puller.

2015-12-11 Thread Jie Yu
> On Dec. 11, 2015, 6:41 p.m., Ben Mahler wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, lines 174-175 > > > > > > This should be a 4 space indent rather than 2, but why bother wrapping > >

  1   2   >