Re: Review Request 39456: Documentation: added containerizer internals

2015-12-15 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/ --- (Updated Dec. 15, 2015, 6:22 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-15 Thread Joseph Wu
> On Dec. 14, 2015, 11:28 a.m., Joseph Wu wrote: > > FYI, I'm making conflicting changes as part of work on a "logging module". > > I published an incomplete patch so you can see the conflicts: > > https://reviews.apache.org/r/41294/ > > haosdent huang wrote: > Thank you very much. Should

Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

2015-12-15 Thread Joseph Wu
> On Dec. 14, 2015, 8:07 p.m., Timothy Chen wrote: > > src/tests/environment.cpp, line 226 > > > > > > If we expect NULL to be a valid option we should make it an Option. NULL is not a valid argument. But for some

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-15 Thread Avinash sridharan
> On Dec. 15, 2015, 4:35 a.m., Anand Mazumdar wrote: > > src/tests/slave_tests.cpp, line 2147 > > > > > > I am assuming that we are testing that port labels are populated > > correctly in the `DiscoveryInfo`

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/ --- (Updated Dec. 15, 2015, 4:32 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

2015-12-15 Thread Joseph Wu
> On Dec. 14, 2015, 8:06 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 603 > > > > > > Just a general question, what is the reasoning behind allowing the > > logger to modify the path and argv of the

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 15, 2015, 4:35 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 15, 2015, 4:28 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41386: Logger Module: Add regression test for docker containerizer logging to sandbox.

2015-12-15 Thread Joseph Wu
> On Dec. 14, 2015, 8:08 p.m., Timothy Chen wrote: > > src/tests/container_logger_tests.cpp, line 158 > > > > > > Not against adding more tests, but we already have an identical test in > > the docker containerizer

Re: Review Request 40956: Reduced HealthCheckTest.CheckCommandTimeout test duration.

2015-12-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40956/#review110515 --- Ship it! Ship It! src/tests/health_check_tests.cpp (line 866)

Re: Review Request 41398: Added expectation for call to mocked function.

2015-12-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41398/#review110501 --- Patch looks great! Reviews applied: [41398] Passed command:

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
> On Dec. 15, 2015, 1:01 a.m., Guangya Liu wrote: > > include/mesos/v1/mesos.proto, line 1567 > > > > > > It is always recommeded to add some comments here. The whole Port message was missing comments so I

Re: Review Request 40946: Made HDFS::du asynchrounous.

2015-12-15 Thread Jie Yu
> On Dec. 15, 2015, 8:25 a.m., Timothy Chen wrote: > > src/slave/containerizer/fetcher.cpp, line 287 > > > > > > Shouldn't we need to check for isDiscard as well? Good catch! I'll change all of them. - Jie

Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function.

2015-12-15 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39852/#review110539 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:15 a.m.,

Re: Review Request 41004: Logger Module: Introduce the ContainerLogger module.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41004/ --- (Updated Dec. 15, 2015, 11:25 a.m.) Review request for mesos, Benjamin

Re: Review Request 41398: Added expectation for call to mocked function.

2015-12-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41398/#review110510 --- Ship it! LGTM Also, can we add a bit more context into the

Re: Review Request 41075: Added support for implicit roles.

2015-12-15 Thread Neil Conway
> On Dec. 15, 2015, 3:10 a.m., Yongqiao Wang wrote: > > src/master/http.cpp, line 1556 > > > > > > Roles with a non-default quota are shown in /roles endpoint, but their > > quota infromation does not be shown, is

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/#review110536 ---

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2015-12-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review110547 --- Initial CFS parameters should be specified to Docker using the

Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

2015-12-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39850/ --- (Updated Dec. 15, 2015, 7:40 p.m.) Review request for mesos, Artem

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/#review110538 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:15 a.m.,

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 15, 2015, 11:25 a.m.) Review request for mesos, Benjamin

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/ --- (Updated Dec. 15, 2015, 11:24 a.m.) Review request for mesos, Benjamin

Re: Review Request 41061: Logger Module: Add container_logger and container_logger_options flags to the agent.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41061/ --- (Updated Dec. 15, 2015, 11:25 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41004: Logger Module: Introduce the ContainerLogger module.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41004/ --- (Updated Dec. 15, 2015, 12:10 p.m.) Review request for mesos, Benjamin

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review110525 --- Ship it! src/master/quota_handler.cpp (lines 330 - 333)

Re: Review Request 41384: Added tests for HDFS client.

2015-12-15 Thread Jie Yu
> On Dec. 15, 2015, 2:44 a.m., Till Toenshoff wrote: > > src/tests/hdfs_tests.cpp, lines 47-48 > > > > > > This confused me initially as it seems this does not really apply. > > The tests serialize bash scripts

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

2015-12-15 Thread Joseph Wu
> On Dec. 14, 2015, 8:02 p.m., Timothy Chen wrote: > > include/mesos/slave/container_logger.hpp, line 120 > > > > > > What `captureOutput` are you referring to here? Oops :) This was renamed (twice) to `prepare`.

Re: Review Request 39889: Windows: Added support for `files/files.hpp`.

2015-12-15 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39889/#review110540 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:15 a.m.,

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-15 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41372/#review110545 --- Hey Kevin, This is a great addition. Can you be more specific

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2015-12-15 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated Dec. 15, 2015, 8:14 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-15 Thread haosdent huang
> On Dec. 14, 2015, 7:28 p.m., Joseph Wu wrote: > > FYI, I'm making conflicting changes as part of work on a "logging module". > > I published an incomplete patch so you can see the conflicts: > > https://reviews.apache.org/r/41294/ Thank you very much. Should I discard my patch first?

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

2015-12-15 Thread Joseph Wu
> On Dec. 14, 2015, 7:51 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 139 > > > > > > Why not let the create also initialize? This was an artifact of one of the approaches (now discarded)

Re: Review Request 41299: Allow DockerContainerizer log to console.

2015-12-15 Thread haosdent huang
> On Dec. 14, 2015, 7:28 p.m., Joseph Wu wrote: > > FYI, I'm making conflicting changes as part of work on a "logging module". > > I published an incomplete patch so you can see the conflicts: > > https://reviews.apache.org/r/41294/ > > haosdent huang wrote: > Thank you very much. Should

Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

2015-12-15 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39850/#review110542 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:14 a.m.,

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-15 Thread Jojy Varghese
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 15-23 > > > > > > What about moveing this after ### Type of containerizers > > Jojy Varghese wrote: > Since this

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-15 Thread Jojy Varghese
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 6-10 > > > > > > Does this still needed? As this was already mentioned in > >

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

2015-12-15 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40102/#review110518 --- Ship it! did a diff and build to verify nothing changed. - Joris

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-15 Thread Jojy Varghese
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 6-10 > > > > > > Does this still needed? As this was already mentioned in > >

Re: Review Request 41075: Added support for implicit roles.

2015-12-15 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review110449 --- Good progress. I'm more confident now in the removal of RoleInfo

Re: Review Request 41212: Adjust timeout value in HealthCheckTest.CheckCommandTimeout.

2015-12-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41212/#review110448 --- This seems identical to my fix here:

Re: Review Request 40946: Made HDFS::du asynchrounous.

2015-12-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40946/#review110451 --- src/slave/containerizer/fetcher.cpp (line 287)

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review110472 --- Ship it! Looks good, but needs a little documentation.

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review110474 --- Lookin good include/mesos/mesos.proto (line 1569)

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/ --- (Updated Dec. 15, 2015, 12:08 p.m.) Review request for mesos, Alexander

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-12-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 15, 2015, 12:06 p.m.) Review request for mesos, Alexander

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Dec. 15, 2015, 12:07 p.m.) Review request for mesos, Alexander

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39520/ --- (Updated Dec. 15, 2015, 11:13 a.m.) Review request for mesos, Alexander

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2015-12-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review110468 --- bootstrap (lines 16 - 23)

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-15 Thread Jan Schlicht
> On Dec. 14, 2015, 11:13 p.m., Greg Mann wrote: > > docs/authorization.md, line 31 > > > > > > In the case of `set_quotas`, this is an operator username isn't it? Good catch! Yes, it an operator username. - Jan

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-15 Thread Jan Schlicht
> On Dec. 14, 2015, 4:52 p.m., Till Toenshoff wrote: > > src/tests/master_quota_tests.cpp, lines 78-79 > > > > > > Comma, really? 8] Hm, even an Oxford comma doesn't count here :D - Jan

Re: Review Request 35711: Disallow special characters in role name.

2015-12-15 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review110461 --- Thanks for reviving this, and sorry it's taken so long to get back

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39520/ --- (Updated Dec. 15, 2015, 12:09 p.m.) Review request for mesos, Alexander

Re: Review Request 35711: Disallow special characters in role name.

2015-12-15 Thread Adam B
> On Dec. 15, 2015, 2:45 a.m., Adam B wrote: > > Thanks for reviving this, and sorry it's taken so long to get back to it. You'll also need to add some documentation about what the valid/invalid role names are, and when they'll be rejected. - Adam

Re: Review Request 40995: Added test cases for role behavior.

2015-12-15 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review110460 --- Thanks for validating the expected `--roles` behavior with tests,

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-15 Thread Alexander Rukletsov
> On Dec. 14, 2015, 4:18 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 1002 > > > > > > This could fail if we ever enforce `MIN_MEM` check. How about > > "cpus:1;mem:512", which we

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review110484 --- Bad patch! Reviews applied: [41380] Failed command:

Re: Review Request 41169: Logger Module: Update tests that use the MesosContainerizer to pass in an ContainerLogger

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/ --- (Updated Dec. 15, 2015, 12:40 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

2015-12-15 Thread Joseph Wu
> On Dec. 14, 2015, 7:54 p.m., Timothy Chen wrote: > > src/docker/executor.hpp, line 89 > > > > > > Why default to an empty string? I forgot about module parameters when adding this flag. The `options` have now

Re: Review Request 41168: Logger Module: Add ContainerLogger support to the MesosTest helpers

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41168/ --- (Updated Dec. 15, 2015, 12:40 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41075: Added support for implicit roles.

2015-12-15 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/ --- (Updated Dec. 15, 2015, 8:56 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40167: [2/7] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.

2015-12-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40167/ --- (Updated Dec. 15, 2015, 9:18 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-15 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41372/ --- (Updated Dec. 15, 2015, 9:26 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41411: Added flags to update summary / desc for reviews.

2015-12-15 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41411/ --- (Updated Dec. 15, 2015, 10:38 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/ --- (Updated Dec. 15, 2015, 12:40 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/ --- (Updated Dec. 15, 2015, 12:41 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41075: Added support for implicit roles.

2015-12-15 Thread Neil Conway
> On Dec. 15, 2015, 9:56 a.m., Adam B wrote: > > Good progress. I'm more confident now in the removal of RoleInfo in favor > > of a weights map. > > - I'm liking the idea of naming this a role "whitelist" rather than > > "validRoles". > > - We need to decide if /roles should care about quota.

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

2015-12-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40169/ --- (Updated Dec. 15, 2015, 9:18 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 38117: Export per container SNMP statistics

2015-12-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review110563 --- Looks good, I just want to pull that parsing code out so it can be

Re: Review Request 40168: [3/7] Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.

2015-12-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40168/ --- (Updated Dec. 15, 2015, 9:18 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function.

2015-12-15 Thread Alex Clemmer
> On Nov. 17, 2015, 8:06 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 58-66 > > > > > > I'm wondering what the alternatives are. > > > > `GetMessage` seems

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/ --- (Updated Dec. 15, 2015, 12:38 p.m.) Review request for mesos, Benjamin

Re: Review Request 41061: Logger Module: Add container_logger and container_logger_options flags to the agent.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41061/ --- (Updated Dec. 15, 2015, 12:39 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/ --- (Updated Dec. 15, 2015, 12:39 p.m.) Review request for mesos, Benjamin

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/ --- (Updated Dec. 15, 2015, 12:41 p.m.) Review request for mesos, Benjamin

Re: Review Request 41225: Added test cases for implicit roles.

2015-12-15 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/ --- (Updated Dec. 15, 2015, 8:57 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40995: Added test cases for role behavior.

2015-12-15 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/ --- (Updated Dec. 15, 2015, 8:56 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 15, 2015, 9:13 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/ --- (Updated Dec. 15, 2015, 10:11 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
> On Dec. 15, 2015, 11:08 a.m., Adam B wrote: > > include/mesos/v1/mesos.proto, lines 1560-1567 > > > > > > I agree with Guangya. Could you improve the comment for this protobuf > > message, explaining what

Re: Review Request 41004: Logger Module: Introduce the ContainerLogger module.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41004/ --- (Updated Dec. 15, 2015, 12:39 p.m.) Review request for mesos, Benjamin

Review Request 41410: Export CFS metrics for docker containers

2015-12-15 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41410/ --- Review request for mesos and Ian Downes. Repository: mesos Description

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/ --- (Updated Dec. 15, 2015, 9:11 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 15, 2015, 9:13 p.m.) Review request for mesos, Adam B and Anand

Review Request 41411: Added flags to post_reviews.py to update summary.

2015-12-15 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41411/ --- Review request for mesos and Neil Conway. Bugs: MESOS-4180

Re: Review Request 41371: Fixed getting started instructions for centos 7.1.

2015-12-15 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41371/ --- (Updated Dec. 15, 2015, 10:17 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39852/#review110573 --- Ship it! Comment looks good! - Joseph Wu On Dec. 15, 2015,

Re: Review Request 41414: Exit nicely when a pid gets reused

2015-12-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41414/#review110585 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Review Request 41424: Install picojson.h if we are using the bundled version.

2015-12-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.

Re: Review Request 41275: Introduced a field for specifying grace period in Shutdown Event for Executor V1 API.

2015-12-15 Thread Qian Zhang
> On Dec. 14, 2015, 7:47 a.m., Qian Zhang wrote: > > include/mesos/executor/executor.proto, line 96 > > > > > > Just a quicky question, how will agent fill this field when it asks the > > executor to shutdown? Is

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/ --- (Updated Dec. 15, 2015, 11:30 p.m.) Review request for mesos, Adam B and Anand

Review Request 41414: Exit nicely when a pid gets reused

2015-12-15 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41414/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
> On Dec. 15, 2015, 11:32 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, lines 1561-1567 > > > > > > Can you please split the comments to different fields just like others. > > > > // Represents

Re: Review Request 41414: Exit nicely when a pid gets reused

2015-12-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41414/#review110580 --- Ship it!

Re: Review Request 41410: Export CFS metrics for docker containers

2015-12-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41410/#review110589 --- Patch looks great! Reviews applied: [33174, 41410] Passed

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review110576 --- include/mesos/mesos.proto (lines 1561 - 1567)

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Clemmer
> On Dec. 15, 2015, 6:57 p.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp, > > line 37 > > > > > > Returning NULL without setting errno is probably not a good

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/ --- (Updated Dec. 15, 2015, 11:36 p.m.) Review request for mesos, Artem

Re: Review Request 41414: Exit nicely when a pid gets reused

2015-12-15 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41414/ --- (Updated Dec. 15, 2015, 11:48 p.m.) Review request for mesos, Ian Downes and

Review Request 41425: Fix the Mesos pkg-config.

2015-12-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41425/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Niklas

  1   2   >