Review Request 41463: Fixed documentation by removing duplicate document.

2015-12-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41463/ --- Review request for mesos, Bernd Mathiske and Neil Conway. Repository: mesos

Review Request 41461: stout: Added SFINAE-friendly `result_of`.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Review Request 41462: libprocess: Used SFINAE-friendly `result_of`.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41462/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ --- (Updated Dec. 16, 2015, 8:03 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ --- (Updated Dec. 16, 2015, 8:05 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41459/ --- (Updated Dec. 16, 2015, 7:38 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2015-12-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Dec. 16, 2015, 8:14 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41346: WIP: Evict some executors if there are not enough reserved resources.

2015-12-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41346/#review110744 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 41075: Added support for implicit roles.

2015-12-16 Thread Alexander Rukletsov
> On Dec. 15, 2015, 9:56 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1016-1031 > > > > > > If the allocator's roleSorter doesn't know about the role (i.e. no > > frameworks are

Re: Review Request 41075: Added support for implicit roles.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/ --- (Updated Dec. 16, 2015, 9:08 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41424: Install picojson.h if we are using the bundled version.

2015-12-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/#review110679 --- Looks like this might be problematic on a clean build (reviewbot

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2015-12-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Dec. 16, 2015, 8:17 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2015-12-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Dec. 16, 2015, 8:17 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

2015-12-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Dec. 16, 2015, 8:17 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41454: Added initial draft of executor HTTP API user doc.

2015-12-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41454/ --- (Updated Dec. 16, 2015, 7:38 p.m.) Review request for mesos and Vinod Kone.

Review Request 41460: Used `is_bind_expression` to SFINAE correctly.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41460/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ --- (Updated Dec. 16, 2015, 7:50 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ --- (Updated Dec. 16, 2015, 7:57 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41446: Fixed character encoding in docs.

2015-12-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41446/ --- (Updated Dec. 16, 2015, 8:32 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 41454: Added initial draft of executor HTTP API user doc.

2015-12-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41454/ --- (Updated Dec. 16, 2015, 8:40 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 41467: Added docs/mesos-provisioner.md to docs/home.md

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41467/#review110749 --- Ship it! Style-wise, the file should probably be named

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41460/ --- (Updated Dec. 16, 2015, 7:44 p.m.) Review request for mesos, Alex Clemmer and

Review Request 41467: Added docs/mesos-provisioner.md to docs/home.md

2015-12-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41467/ --- Review request for mesos, Bernd Mathiske, Neil Conway, and Timothy Chen.

Re: Review Request 41075: Added support for implicit roles.

2015-12-16 Thread Neil Conway
> On Dec. 15, 2015, 9:56 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1016-1031 > > > > > > If the allocator's roleSorter doesn't know about the role (i.e. no > > frameworks are

Re: Review Request 40995: Added test cases for role behavior.

2015-12-16 Thread Neil Conway
> On Dec. 15, 2015, 10:18 a.m., Adam B wrote: > > Thanks for validating the expected `--roles` behavior with tests, but I > > think you're mixing up the scheduler reservation/volume API (where only the > > framework's role is valid) with the operator API (where any whitelisted > > role is

Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

2015-12-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41459/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Re: Review Request 41463: Fixed documentation by removing duplicate document.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41463/#review110733 --- Ship it! Ship It! - Neil Conway On Dec. 16, 2015, 7:47 p.m.,

Re: Review Request 41463: Fixed documentation by removing duplicate document.

2015-12-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41463/#review110737 --- Ship it! Ship It! - Bernd Mathiske On Dec. 16, 2015, 11:47

Re: Review Request 41225: Added test cases for implicit roles.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/ --- (Updated Dec. 16, 2015, 9:06 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40995: Added test cases for role behavior.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/ --- (Updated Dec. 16, 2015, 9:05 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41425: Fix the Mesos pkg-config.

2015-12-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41425/ --- (Updated Dec. 16, 2015, 5:26 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2015-12-16 Thread Steve Niemitz
> On Dec. 15, 2015, 7:36 p.m., Ian Downes wrote: > > Initial CFS parameters should be specified to Docker using the appropriate > > flags, not tacked onto the end of launch() where we don't yet know the > > cgroup. Subsequent updates done by Mesos in update(). As per our offline conversation,

Review Request 41454: Added initial draft of executor HTTP API user doc.

2015-12-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41454/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 41424: Install picojson.h if we are using the bundled version.

2015-12-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/ --- (Updated Dec. 16, 2015, 5:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41411: Added flags to update summary / desc for reviews.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41411/#review110690 --- Ship it! Ship It! - Neil Conway On Dec. 15, 2015, 10:38 p.m.,

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review110681 --- Overall nit: add backticks around code/syscalls :)

Re: Review Request 41467: Added docs/mesos-provisioner.md to docs/home.md

2015-12-16 Thread Till Toenshoff
> On Dec. 16, 2015, 9:19 p.m., Neil Conway wrote: > > Style-wise, the file should probably be named "provisioner.md" for > > consistency with the other documentation files. But it is fine to commit > > this RR as-is for the time being. Thanks a bunch - do you think my summary (used behind the

Re: Review Request 41075: Added support for implicit roles.

2015-12-16 Thread Adam B
> On Dec. 15, 2015, 1:56 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1016-1031 > > > > > > If the allocator's roleSorter doesn't know about the role (i.e. no > > frameworks are

Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41472/ --- Review request for mesos, Adam B and Michael Park. Bugs: MESOS-4143

Re: Review Request 41361: Wrote cmd to create WANdiscoSVN file for centos.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41361/#review110787 --- Ship it! Seems fine as far as it goes, but it would be great to

Re: Review Request 41467: Added docs/mesos-provisioner.md to docs/home.md

2015-12-16 Thread Neil Conway
> On Dec. 16, 2015, 9:19 p.m., Neil Conway wrote: > > Style-wise, the file should probably be named "provisioner.md" for > > consistency with the other documentation files. But it is fine to commit > > this RR as-is for the time being. > > Till Toenshoff wrote: > Thanks a bunch - do you

Re: Review Request 41467: Added docs/mesos-provisioner.md to docs/home.md

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41467/#review110757 --- Ship it! Ship It! - Gilbert Song On Dec. 16, 2015, 1:27 p.m.,

Re: Review Request 41364: Added NOTE to Examples in Getting Started on prod.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110790 --- Ship it! Ship It! docs/getting-started.md (line 194)

Re: Review Request 41362: Added note in docs for installing wget, tar, git.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41362/#review110788 --- Ship it! Ship It! - Neil Conway On Dec. 16, 2015, 11:09 p.m.,

Re: Review Request 41363: Reworded NOTE in Examples for Getting Started doc.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41363/#review110789 --- Ship it! Ship It! - Neil Conway On Dec. 16, 2015, 11:09 p.m.,

Re: Review Request 41476: Updated getting started for 0.26 release.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41476/#review110799 --- Ship it! Ship It! - Neil Conway On Dec. 16, 2015, 11:51 p.m.,

Re: Review Request 41360: Aligned the code blocks in Getting Started better.

2015-12-16 Thread Kevin Klues
> On Dec. 16, 2015, 11:36 p.m., Neil Conway wrote: > > Looks good! While we're at it, can we update the example version in the > > first `wget` command to be 0.26? > > Kevin Klues wrote: > I'll do that, but as a separate commit. https://reviews.apache.org/r/41476/ - Kevin

Re: Review Request 41075: Added support for implicit roles.

2015-12-16 Thread Neil Conway
> On Dec. 15, 2015, 9:56 a.m., Adam B wrote: > > src/master/http.cpp, line 316 > > > > > > I'm in agreement with Yong. This form of `model(role, name, weight)` > > isn't used anywhere, and is confusing alongside

Re: Review Request 41360: Aligned the code blocks in Getting Started better.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41360/#review110793 --- Ship it! Looks good! While we're at it, can we update the example

Re: Review Request 41467: Added docs/mesos-provisioner.md to docs/home.md

2015-12-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41467/ --- (Updated Dec. 16, 2015, 9:27 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 41468: Removed MesosCon Europe from site index page.

2015-12-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41468/ --- Review request for mesos, Bernd Mathiske and Neil Conway. Bugs: MESOS-3742

Re: Review Request 41463: Fixed documentation by removing duplicate document.

2015-12-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41463/#review110785 --- Ship it! Ship It! - Guangya Liu On Dec. 16, 2015, 7:47 p.m.,

Re: Review Request 41278: Added note to site-docker doc about tunneling.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41278/#review110784 --- Ship it! Ship It! - Neil Conway On Dec. 15, 2015, 1:06 a.m.,

Re: Review Request 41371: Fixed getting started instructions for centos 7.1.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41371/#review110796 --- Ship it! Ship It! - Gilbert Song On Dec. 16, 2015, 3:06 p.m.,

Re: Review Request 41467: Added docs/mesos-provisioner.md to docs/home.md

2015-12-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41467/ --- (Updated Dec. 16, 2015, 9:40 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/ --- (Updated Dec. 16, 2015, 9:48 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 41467: Added docs/mesos-provisioner.md to docs/home.md

2015-12-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41467/#review110772 --- Ship it! Ship It! - Timothy Chen On Dec. 16, 2015, 9:40 p.m.,

Re: Review Request 41468: Removed MesosCon Europe from site index page.

2015-12-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41468/#review110773 --- Ship it! I didn't preview with mesos-website-containerizer --

Re: Review Request 41468: Removed MesosCon Europe from site index page.

2015-12-16 Thread Till Toenshoff
> On Dec. 16, 2015, 10:34 p.m., Neil Conway wrote: > > I didn't preview with mesos-website-containerizer -- someone should do that > > at some point. But otherwise LGTM. Yes, I am in the process of upgrading the site using the mesos-site docker container from `support/site-docker/`. Will do

Re: Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41383/#review110800 --- Ship it! Ship It! - Jojy Varghese On Dec. 16, 2015, 11:06

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41372/#review110797 --- Ship it! Ship It! - Gilbert Song On Dec. 16, 2015, 3:07 p.m.,

Review Request 41476: Updated getting started for 0.26 release.

2015-12-16 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41476/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Neil Conway, and

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review110764 --- Ship it! docs/containerizer-internals.md (lines 54 - 55)

Re: Review Request 41462: libprocess: Used SFINAE-friendly `result_of`.

2015-12-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41462/#review110780 --- Patch looks great! Reviews applied: [41459, 41460, 41461, 41462]

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-16 Thread Adam B
> On Nov. 24, 2015, 6:48 p.m., Klaus Ma wrote: > > include/mesos/role/role.proto, line 38 > > > > > > I'm thinke whether we need to enhance weight to `int`. Any case that we > > has to use `double` as weight? If we

Re: Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41383/#review110792 --- Ship it! Totally agreed with ensuring this package installed,

Review Request 41474: Added documentation for `defer` in libprocess README.

2015-12-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Joris Van Remoortere,

Re: Review Request 41360: Aligned the code blocks in Getting Started better.

2015-12-16 Thread Kevin Klues
> On Dec. 16, 2015, 11:36 p.m., Neil Conway wrote: > > Looks good! While we're at it, can we update the example version in the > > first `wget` command to be 0.26? I'll do that, but as a separate commit. - Kevin --- This is an

Re: Review Request 41446: Fixed character encoding in docs.

2015-12-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41446/#review110803 --- Patch looks great! Reviews applied: [41446] Passed command:

Re: Review Request 40167: [2/7] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.

2015-12-16 Thread Greg Mann
> On Dec. 16, 2015, 2:35 p.m., Alexander Rukletsov wrote: > > Thanks for the reviews, AlexR!! > On Dec. 16, 2015, 2:35 p.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/authorizer.proto, line 106 > > > >

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-16 Thread Adam B
> On Dec. 10, 2015, 2:40 a.m., Adam B wrote: > > include/mesos/master/allocator.proto, line 19 > > > > > > Shouldn't this file have `java_package` and `java_outer_classname` just > > like the other protos? > >

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-16 Thread Anand Mazumdar
> On Dec. 17, 2015, 12:12 a.m., Anand Mazumdar wrote: > > src/tests/common/http_tests.cpp, lines 130-140 > > > > > > Can you confirm that other objects that have labels that are exposed > > via `/state` endpoint

Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.

2015-12-16 Thread Greg Mann
> On Dec. 16, 2015, 2:36 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 2870-2871 > > > > > > Looks like a copy-paste-induced typo slipped in : ), I believe you mean > > "volume is created".

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Kevin Klues
> On Dec. 17, 2015, 12:09 a.m., Jojy Varghese wrote: > > docs/getting-started.md, line 146 > > > > > > I would emphaise versions with backtics. This doesn't appear to add any special empahsis (in the markdown that

Re: Review Request 41003: Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.

2015-12-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/#review110827 --- Ship it! src/slave/container_loggers/sandbox.hpp (line 44)

Re: Review Request 41468: [site] Removed MesosCon Europe from index page.

2015-12-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41468/ --- (Updated Dec. 17, 2015, 1:22 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-16 Thread Yongqiao Wang
> On Dec. 10, 2015, 10:40 a.m., Adam B wrote: > > include/mesos/master/allocator.proto, line 19 > > > > > > Shouldn't this file have `java_package` and `java_outer_classname` just > > like the other protos? > >

Re: Review Request 41364: Added NOTE to Examples in Getting Started on prod.

2015-12-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110845 --- Ship it! Ship It! - Till Toenshoff On Dec. 17, 2015, 1:26

Re: Review Request 41011: Unified Container: Implemented interface for runtime configure to be returned from provisioner to mesos containerizer.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41011/ --- (Updated Dec. 16, 2015, 6:38 p.m.) Review request for mesos, Artem

Re: Review Request 41194: Unified Container: Cleanup uneccessary JSON parse in local puller.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41194/ --- (Updated Dec. 16, 2015, 6:38 p.m.) Review request for mesos, Artem

Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 41479: [site] Updated index page for 0.26.0.

2015-12-16 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41479/#review110861 --- Ship it! Ship It! - Kevin Klues On Dec. 17, 2015, 1:29 a.m.,

Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41489/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41490/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 41407: Unified Container: Save all docker image information on disk instead of rootfs only.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41407/ --- (Updated Dec. 16, 2015, 6:38 p.m.) Review request for mesos, Artem

Re: Review Request 41406: Unified Container: Added path helper method to get image layer manifest on local store.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41406/ --- (Updated Dec. 16, 2015, 6:38 p.m.) Review request for mesos, Artem

Review Request 41488: Provisioner: Added docker v1 manifest protobuf message.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41488/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 41361: Wrote cmd to create WANdiscoSVN file for centos.

2015-12-16 Thread Till Toenshoff
> On Dec. 16, 2015, 11:22 p.m., Neil Conway wrote: > > Seems fine as far as it goes, but it would be great to find a more standard > > source for the packages than WANdisco. For example, 'devtoolset-3' appears > > to have what we need. Yes, overall it seems we need to revisit this entire

Re: Review Request 41362: Added note in docs for installing wget, tar, git.

2015-12-16 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41362/ --- (Updated Dec. 17, 2015, 2:44 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41075: Added support for implicit roles.

2015-12-16 Thread Neil Conway
> On Dec. 17, 2015, 2:54 a.m., Yongqiao Wang wrote: > > src/master/http.cpp, line 1543 > > > > > > I am not sure /roles will return the reserved resources of role, as far > > as I know, it will return the used

Re: Review Request 41454: Added initial draft of executor HTTP API user doc.

2015-12-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41454/#review110876 --- Patch looks great! Reviews applied: [41454] Passed command:

Re: Review Request 41011: Unified Container: Implemented interface for runtime configure to be returned from provisioner to mesos containerizer.

2015-12-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41011/#review110875 --- Ship it! Ship It! - Timothy Chen On Dec. 17, 2015, 2:38 a.m.,

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-16 Thread Avinash sridharan
> On Dec. 17, 2015, 12:12 a.m., Anand Mazumdar wrote: > > src/tests/common/http_tests.cpp, lines 130-140 > > > > > > Can you confirm that other objects that have labels that are exposed > > via `/state` endpoint

Re: Review Request 41485: [site] Updated downloads-page for 0.26.0.

2015-12-16 Thread Till Toenshoff
> On Dec. 17, 2015, 2:54 a.m., Kevin Klues wrote: > > site/source/downloads.html.md, line 75 > > > > > > Is this link supposed to trigger a download? It just seems to take me > > to a mirrors site. Appears to be

Re: Review Request 41406: Unified Container: Added path helper method to get image layer manifest on local store.

2015-12-16 Thread Gilbert Song
> On Dec. 16, 2015, 9:38 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/paths.hpp, line 40 > > > > > > VERSION This is only relevant for local puller right? Currently yes. I am

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/#review110909 --- Ship it! Ship It!

Re: Review Request 40167: [2/7] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.

2015-12-16 Thread Greg Mann
> On Dec. 16, 2015, 2:35 p.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/authorizer.proto, line 96 > > > > > > I see that you ensure this when you create requests in > > `authorizeCreateVolume`, but

Re: Review Request 41244: Using 'git rev-parse --git-dir' in post-reviews.py.

2015-12-16 Thread Till Toenshoff
> On Dec. 17, 2015, 3:43 a.m., Till Toenshoff wrote: > > Ship It! I noted some of your recent reviews contain the review-request link in the description shown on RB (this one doesnt) - can you please make sure its not anything your own recent changes are related to, thanks. - Till

Re: Review Request 41485: [site] Updated downloads-page for 0.26.0.

2015-12-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41485/#review110890 --- Patch looks great! Reviews applied: [41467, 41468, 41479, 41480,

  1   2   3   >