Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 18, 2015, 10:09 a.m.) Review request for mesos, Alexander

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/ --- (Updated Dec. 18, 2015, 10:09 a.m.) Review request for mesos, Alexander

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Gilbert Song
> On Dec. 17, 2015, 11:46 a.m., Jie Yu wrote: > > Since you're on it. Can you rename docker::DockerImageManifest to > > docker::v2::ImageManifest? Done. - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Jan Schlicht
> On Dec. 14, 2015, 5:18 p.m., Alexander Rukletsov wrote: > > I would suggest to add some more test cases: > > - Request does not contain a principal (in absence of authz quota can be > > set); > > - Request does not contain a principal, ACLs allow `ANY` to set quota for > > role "prod"

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- (Updated Dec. 18, 2015, 1:19 a.m.) Review request for mesos, Artem

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Jan Schlicht
> On Dec. 14, 2015, 4:52 p.m., Till Toenshoff wrote: > > src/tests/authorization_tests.cpp, lines 591-592 > > > > > > Why would we check a request with multiple principals in this > > integration test? > > Greg

Re: Review Request 41488: Provisioner: Added docker v1 manifest protobuf message.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41488/ --- (Updated Dec. 18, 2015, 1:20 a.m.) Review request for mesos, Artem

Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41489/ --- (Updated Dec. 18, 2015, 1:20 a.m.) Review request for mesos, Artem

Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41490/ --- (Updated Dec. 18, 2015, 1:21 a.m.) Review request for mesos, Artem

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Dec. 18, 2015, 1:21 a.m.) Review request for mesos, Artem

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Greg Mann
> On Dec. 16, 2015, 2:38 p.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_tests.cpp, line 790 > > > > > > Do you think it makes sense to extract "role1" into a constant? Since this role name appears

Re: Review Request 40903: Ported approximated Option CPU resource number comparison to v1 and improved the check expression for this.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40903/#review54 --- src/v1/resources.cpp (line 39)

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-12-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40256/ --- (Updated Dec. 18, 2015, 9:38 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-12-18 Thread Greg Mann
> On Dec. 16, 2015, 2:39 p.m., Alexander Rukletsov wrote: > > docs/authorization.md, line 43 > > > > > > As I have already mentioned in a previous review, we do not really > > enforce it, do we? That's why I think

Re: Review Request 41444: Cleaned up Authorizer interface.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review59 --- Patch looks great! Reviews applied: [41444] Passed command:

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-18 Thread Jan Schlicht
> On Dec. 14, 2015, 11:13 p.m., Greg Mann wrote: > > docs/authorization.md, line 30 > > > > > > I wonder if there should be some mention of the behavior of > > `set_quotas` when no principal is set? I added a more

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/#review58 --- src/master/master.cpp (lines 3346 - 3350)

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/ --- (Updated Dec. 18, 2015, 10:10 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Greg Mann
> On Dec. 18, 2015, 9:58 a.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 3346-3350 > > > > > > How about a TODO, that we may want to retry instead of giving up > > straight away? Yea, sounds

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41472/#review48 --- Patch looks great! Reviews applied: [40995, 41075, 41225, 41408,

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Dec. 18, 2015, 10:10 a.m.) Review request for mesos, Alexander

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/ --- (Updated Dec. 18, 2015, 9:33 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 41444: Cleaned up Authorizer interface.

2015-12-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review42 --- Thank you for cleaning this up. It looked like an overwhelming

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39520/ --- (Updated Dec. 18, 2015, 10:12 a.m.) Review request for mesos, Alexander

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/ --- (Updated Dec. 18, 2015, 9:28 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/ --- (Updated Dec. 18, 2015, 9:37 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Alexander Rukletsov
> On Dec. 16, 2015, 2:38 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 3348 > > > > > > You are following the pattern here, but are we sure that the framework > > has the principal? I also do

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/ --- (Updated Dec. 18, 2015, 10:55 a.m.) Review request for mesos, Alexander

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-12-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/ --- (Updated Dec. 18, 2015, 9:54 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/#review63 --- src/tests/persistent_volume_tests.cpp (lines 887 - 890)

Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

2015-12-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40880/#review70 --- Ship it! Looks good to me. Testing something on the containerizer

Re: Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.

2015-12-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40880/#review71 --- Ship it! Ship It! - Joerg Schad On Dec. 3, 2015, 7:02 p.m.,

Re: Review Request 40429: Report executor exit to framework schedulers.

2015-12-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review110348 --- You've got the basics down, but you need to put your EXPECT calls

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39520/ --- (Updated Dec. 18, 2015, 1:18 p.m.) Review request for mesos, Alexander

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Jan Schlicht
> On Dec. 18, 2015, 12:32 p.m., Alexander Rukletsov wrote: > > I would like to see one more test, where both authn and authz are disabled > > and quota set request succeeds. While having this test makes sense, it would test neither authentication nor authorization, but the actual quota

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Alexander Rukletsov
> On Dec. 14, 2015, 4:18 p.m., Alexander Rukletsov wrote: > > I would suggest to add some more test cases: > > - Request does not contain a principal (in absence of authz quota can be > > set); > > - Request does not contain a principal, ACLs allow `ANY` to set quota for > > role "prod"

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39520/#review66 --- I would like to see one more test, where both authn and authz are

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Jan Schlicht
> On Dec. 18, 2015, 12:32 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 1070 > > > > > > quota set request; > > backtick `ROLE1` > > s/ that can be authorized././ > > >

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39520/ --- (Updated Dec. 18, 2015, 1:27 p.m.) Review request for mesos, Alexander

Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.

2015-12-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41510/#review80 --- Ship it! src/slave/containerizer/external_containerizer.cpp

Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.

2015-12-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41509/#review86 --- Ship it! - Benjamin Bannier On Dec. 17, 2015, 2:37 p.m.,

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2015-12-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/#review81 --- Ship it! include/mesos/type_utils.hpp (line 26)

Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.

2015-12-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/#review85 --- Ship it! - Benjamin Bannier On Dec. 17, 2015, 2:37 p.m.,

Re: Review Request 41513: Cleaned up STL I/O includes.

2015-12-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/#review84 --- Ship it! - Benjamin Bannier On Dec. 17, 2015, 2:38 p.m.,

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/ --- (Updated Dec. 18, 2015, 3:43 p.m.) Review request for mesos, Alexander

Re: Review Request 41554: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41554/ --- (Updated Dec. 18, 2015, 2 p.m.) Review request for mesos. Repository: mesos

Re: Review Request 41544: Quota: Verified quota requests succeed when authn and authz are disabled.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41544/ --- (Updated Dec. 18, 2015, 4:14 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/ --- (Updated Dec. 18, 2015, 1:45 p.m.) Review request for mesos and Bernd

Review Request 41554: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41554/ --- Review request for mesos. Repository: mesos Description --- just a test

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-12-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/ --- (Updated Dec. 18, 2015, 3:38 p.m.) Review request for mesos, Alexander

Review Request 41544: Quota: Verified quota requests succeed when authn and authz are disabled.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41544/ --- Review request for mesos, Bernd Mathiske, Greg Mann, Jan Schlicht, and Till

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Shuai Lin
> On Dec. 17, 2015, 11:12 a.m., Bernd Mathiske wrote: > > docs/fetcher.md, line 244 > > > > > > Did you not have to write "export" in front? > > I know of a case where nothing worked unless you did. It works

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review83 --- Bad patch! Reviews applied: [41011, 41125, 41194, 41406, 41407]

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/ --- (Updated Dec. 18, 2015, 1:43 p.m.) Review request for mesos and Bernd

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review87 --- Ship it! Ship It! - Till Toenshoff On Dec. 18, 2015, 11:43

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review93 --- Patch looks great! Reviews applied: [39985, 39986, 39987, 39988,

Re: Review Request 41544: Quota: Verified quota requests succeed when authn and authz are disabled.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41544/ --- (Updated Dec. 18, 2015, 4:23 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41544: Quota: Verified quota requests succeed when authn and authz are disabled.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41544/ --- (Updated Dec. 18, 2015, 4:54 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/#review111204 --- Ship it!

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/#review111214 --- Ship it! src/messages/messages.proto (line 38)

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/#review111219 --- Ship it! Ship It! - Jie Yu On Dec. 17, 2015, 7:59 p.m., Artem

Re: Review Request 41556: Updated comments in quota tests for clarity.

2015-12-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41556/#review95 --- Ship it! Ship It! - Till Toenshoff On Dec. 18, 2015, 4:15

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Gilbert Song
> On Dec. 18, 2015, 9:16 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/docker/spec.hpp, line 35 > > > > > > s/validateManifest/validate/ This is fixed in https://reviews.apache.org/r/41489/ >

Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.

2015-12-18 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41509/#review111218 --- Ship it! Ship It! - Joerg Schad On Dec. 17, 2015, 2:37 p.m.,

Re: Review Request 40429: Report executor exit to framework schedulers.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review111202 --- Patch looks great! Reviews applied: [40429] Passed command:

Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41489/#review111212 --- Ship it! Ship It! - Jie Yu On Dec. 18, 2015, 9:20 a.m.,

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Jie Yu
> On Dec. 18, 2015, 5:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/docker/spec.hpp, line 35 > > > > > > s/validateManifest/validate/ > > Gilbert Song wrote: > This is fixed in

Review Request 41556: Updated comments in quota tests for clarity.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41556/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 41544: Quota: Verified quota requests succeed when authn and authz are disabled.

2015-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41544/ --- (Updated Dec. 18, 2015, 4:24 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41253: Changed ownership semantics of ssl connect socket.

2015-12-18 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41253/ --- (Updated Dec. 18, 2015, 5:52 p.m.) Review request for mesos, Joris Van

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review111217 --- Patch looks great! Reviews applied: [41438] Passed command:

Re: Review Request 41075: Added support for implicit roles.

2015-12-18 Thread Neil Conway
> On Dec. 18, 2015, 6:04 a.m., Yongqiao Wang wrote: > > src/master/master.cpp, line 597 > > > > > > If the value of the specified weight is default value 1.0, do we still > > need to put it in weights hashmap and

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 18, 2015, 11:29 a.m.) Review request for mesos, Artem

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

2015-12-18 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Dec. 18, 2015, 8:25 p.m.) Review request for mesos, Artem

Re: Review Request 41253: Changed ownership semantics of ssl connect socket.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41253/#review111263 --- Patch looks great! Reviews applied: [41253] Passed command:

Re: Review Request 41422: Removed manual construction of Task in master.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/#review111220 --- Ship it! Ship It! - Jie Yu On Dec. 17, 2015, 7:58 p.m., Artem

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111221 --- Ship it! src/tests/containerizer/docker_containerizer_tests.cpp

Review Request 41560: Change Docker::run to take Subprocess::IO instead of Option

2015-12-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41560/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joris

Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41490/ --- (Updated Dec. 18, 2015, 12:11 p.m.) Review request for mesos, Artem

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- (Updated Dec. 18, 2015, 12:10 p.m.) Review request for mesos, Artem

Re: Review Request 41554: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41554/#review111225 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 41488: Provisioner: Added docker v1 manifest protobuf message.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41488/ --- (Updated Dec. 18, 2015, 10:57 a.m.) Review request for mesos, Artem

Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41489/ --- (Updated Dec. 18, 2015, 10:58 a.m.) Review request for mesos, Artem

Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41490/ --- (Updated Dec. 18, 2015, 10:58 a.m.) Review request for mesos, Artem

Re: Review Request 41408: Updated documentation for implicit roles.

2015-12-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/ --- (Updated Dec. 18, 2015, 8 p.m.) Review request for mesos, Adam B and Yongqiao

Re: Review Request 41225: Added test cases for implicit roles.

2015-12-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/ --- (Updated Dec. 18, 2015, 8:01 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40256/#review111249 --- Ship it! src/tests/persistent_volume_tests.cpp (line 99)

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

2015-12-18 Thread Michael Park
> On Dec. 17, 2015, 1:17 a.m., Michael Park wrote: > > src/master/http.cpp, lines 1000-1006 > > > > > > Hm, should this be added to `validation::operation::validate` instead? > > That way if/when we have

Re: Review Request 39520: Quota: Added authentication, authorization tests.

2015-12-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39520/#review111234 --- src/tests/master_quota_tests.cpp (line 1018)

Re: Review Request 41488: Provisioner: Added docker v1 manifest protobuf message.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41488/#review111228 --- Ship it! Ship It! - Jie Yu On Dec. 18, 2015, 6:57 p.m.,

Re: Review Request 41556: Updated comments in quota tests for clarity.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41556/#review111240 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913,

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review111252 --- Ship it! docs/authorization.md (line 11)

Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

2015-12-18 Thread Gilbert Song
> On Dec. 18, 2015, 11:04 a.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 386 > > > > > > s/v1DockerImageManifest/manifest/ v2 fixed as well. - Gilbert

Re: Review Request 41108: Add curl, sasl and dl link flags and add protobuf library directory

2015-12-18 Thread Diana Arroyo
> On Dec. 9, 2015, 5:59 p.m., Alex Clemmer wrote: > > src/slave/cmake/SlaveConfigure.cmake, line 62 > > > > > > Same comment about the include directories, but with libraries. We > > probably want to include

Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41490/#review111229 --- Ship it! src/tests/containerizer/provisioner_docker_tests.cpp

Re: Review Request 41408: Updated documentation for implicit roles.

2015-12-18 Thread Neil Conway
> On Dec. 18, 2015, 6:25 a.m., Adam B wrote: > > src/master/flags.cpp, lines 187-189 > > > > > > Don't forget to update configuration.md to match your change to the > > flags. This was already done as far as I can

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/#review111233 --- Ship it! src/master/master.cpp (line 3425)

Re: Review Request 41426: Changed MergeFrom() to CopyFrom() in protobuf::createTask().

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41426/ --- (Updated Dec. 18, 2015, 3:12 p.m.) Review request for mesos and Artem

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 3:12 p.m.) Review request for mesos, Artem Harutyunyan

Review Request 41573: Added DEFAULT_ALLOCATION_INTERVAL to master constants.

2015-12-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41573/ --- Review request for mesos, Jie Yu and Michael Park. Repository: mesos

  1   2   >