Re: Review Request 41683: Added links to individual containerizers in containerizer-internal.md.

2015-12-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41683/#review111760 --- Ship it! Ship It! - Bernd Mathiske On Dec. 23, 2015, 1:32

Re: Review Request 41682: Reflected deprecation of external containerizer in documentation.

2015-12-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41682/#review111761 --- Ship it! Ship It! - Bernd Mathiske On Dec. 23, 2015, 1:30

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 23, 2015, 9:44 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behavior

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Dec. 23, 2015, 9:44 a.m.) Review request for mesos, Adam B and Neil

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-12-23 Thread Alex Clemmer
> On Dec. 15, 2015, 3:54 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 39 > > > > > > What if the path ends with multiple '\' chars to begin with? Good

Re: Review Request 41680: Reduced LogLevel in order to avoid overflowing logs.

2015-12-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41680/#review111767 --- Patch looks great! Reviews applied: [41680] Passed command:

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-12-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review111775 --- Bad patch! Reviews applied: [39621, 39620, 39583, 39584] Failed

Re: Review Request 41593: stout: Added `jsonify` function.

2015-12-23 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 23, 2015, 5:57 p.m.) Review request for mesos and Benjamin

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-12-23 Thread Alex Clemmer
> On Dec. 15, 2015, 3:54 a.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 51 > > > > > > Calling FindClose on an invalid handle is not the best idea. At

Re: Review Request 41593: stout: Added `jsonify` function.

2015-12-23 Thread Michael Park
> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 536 > > > > > > Do you think the comment over `WriterProxy` will be sufficient to > >

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review111818 --- src/master/allocator/mesos/hierarchical.cpp (line 1055)

Re: Review Request 41680: Reduced LogLevel in order to avoid overflowing logs.

2015-12-23 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41680/#review111815 --- Ship it! Ship It! - Cody Maloney On Dec. 23, 2015, 9:06 a.m.,

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 24, 2015, 2:46 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 24, 2015, 2:41 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behavior

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Dec. 24, 2015, 2:49 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behavior

2015-12-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review111819 --- Patch looks great! Reviews applied: [41597, 41672] Passed

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-12-23 Thread Alex Clemmer
> On Dec. 10, 2015, 4:12 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 109 > > > > > > Can you explain / comment why here (as well as on L139)

Re: Review Request 41425: Fix the Mesos pkg-config.

2015-12-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41425/#review111806 --- Ship it! Just as a short note here, `pkg-config` doesn't work

Re: Review Request 41425: Fix the Mesos pkg-config.

2015-12-23 Thread Alex Clemmer
> On Dec. 23, 2015, 9:15 p.m., Alex Clemmer wrote: > > Just as a short note here, `pkg-config` doesn't work well with the rest of > > the Windows tool chain, so it's worth wondering what our distribution story > > should be there. > > > > If the consumer is using CMake, then this information

Re: Review Request 41697: Fixed a documentation bug in containerizer internals doc.

2015-12-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41697/#review111813 --- Patch looks great! Reviews applied: [41697] Passed command:

Re: Review Request 41424: Install picojson.h if we are using the bundled version.

2015-12-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/#review111807 --- Ship it! Much in the spirit of my review of #41425, it's

Review Request 41697: Fixed a documentation bug in containerizer internals doc.

2015-12-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41697/ --- Review request for mesos, Jie Yu and Jojy Varghese. Repository: mesos

Review Request 41704: WIP: Added support for checking whether a given path is absolute.

2015-12-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4198

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review111824 --- Ship it! Ship It! - Qian Zhang On Dec. 24, 2015, 10:46 a.m.,

Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4198

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2015-12-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review111770 --- Bad patch! Reviews applied: [41597, 41681] Failed command:

Review Request 41680: Reduced LogLevel in order to avoid overflowing logs.

2015-12-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41680/ --- Review request for mesos and Bernd Mathiske. Bugs: MESOS-4181

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 23, 2015, 9:05 a.m.) Review request for mesos, Adam B, Neil

Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Bugs:

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 23, 2015, 9:18 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
> On Dec. 23, 2015, 8:22 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1057 > > > > > > Do we support updating weight for an inactive role? If yes, I think > > this `CHECK` will

Review Request 41682: Reflected deprecation of external containerizer in documentation.

2015-12-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41682/ --- Review request for mesos and Bernd Mathiske. Bugs: MESOS-3370

Re: Review Request 41680: Reduced LogLevel in order to avoid overflowing logs.

2015-12-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41680/#review111757 --- Ship it! Ship It! - Bernd Mathiske On Dec. 23, 2015, 1:06

Review Request 41683: Added links to individual containerizers in containerizer-internal.md.

2015-12-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41683/ --- Review request for mesos, Bernd Mathiske and Jojy Varghese. Bugs: MESOS-3370

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review111749 --- src/master/allocator/mesos/hierarchical.cpp (line 1051)