Re: Review Request 41731: Removed docker puller flag.

2015-12-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41731/#review111924 --- src/slave/flags.cpp

Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/#review111927 --- docs/containerizer.md (line 5)

Re: Review Request 41661: Added documentation for API versioning.

2015-12-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/ --- (Updated Dec. 27, 2015, 9:08 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 41661: Added documentation for API versioning.

2015-12-27 Thread Anand Mazumdar
> On Dec. 27, 2015, 3:25 a.m., Jojy Varghese wrote: > > docs/versioning.md, line 7 > > > > > > ephasize 0.24.0 (in quotes). Same in other places. I tried to be consistent to other docs and they did not have quotes.

Re: Review Request 41728: Removed docker provisioner port slave flags.

2015-12-27 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41728/#review111928 --- Basically all the same: Let us try to keep the documentation in

Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-27 Thread Jojy Varghese
> On Dec. 27, 2015, 2:39 p.m., Joerg Schad wrote: > > docs/containerizer.md, line 26 > > > > > > What do you mean by "own native container technology"? Isn't that > > highly platform dependent? Not sure what you

Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-27 Thread Jojy Varghese
> On Dec. 28, 2015, 12:33 a.m., Qian Zhang wrote: > > docs/containerizer.md, line 13 > > > > > > Isolate task or executor or both? For task, I think it is up to > > executor for how to launch it. Here the bullet

Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-27 Thread Jojy Varghese
> On Dec. 27, 2015, 2:39 p.m., Joerg Schad wrote: > > docs/containerizer.md, line 30 > > > > > > container technologies? Maybe something like: Mesos currently supports > > the following containerizer? Since this

Re: Review Request 41661: Added documentation for API versioning.

2015-12-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41661/#review111943 --- Patch looks great! Reviews applied: [41661] Passed command:

Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/#review111947 --- docs/containerizer.md (line 13)

Re: Review Request 41731: Removed docker puller flag.

2015-12-27 Thread Timothy Chen
> On Dec. 27, 2015, 2:38 a.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp, line 79 > > > > > > You might have to validate the flag for its format and maybe valid path.

Re: Review Request 41731: Removed docker puller flag.

2015-12-27 Thread Timothy Chen
> On Dec. 27, 2015, 5:42 a.m., Gilbert Song wrote: > > src/slave/flags.cpp, lines 145-146 > > > > > > Could we use pure directory only for local puller? > > > > Instead of adding `file://` to the flag &

Re: Review Request 41731: Removed docker puller flag.

2015-12-27 Thread Timothy Chen
> On Dec. 27, 2015, 8:16 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 146 > > > > > > Do I understand correctly that we change the default from "Pull from > > docker registry" to "pull from a local file

Re: Review Request 41731: Removed docker puller flag.

2015-12-27 Thread Joerg Schad
> On Dec. 27, 2015, 8:16 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 146 > > > > > > Do I understand correctly that we change the default from "Pull from > > docker registry" to "pull from a local file