Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

2016-01-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/ --- (Updated Jan. 13, 2016, 3:07 a.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 40553: Enable mesos tests installation.

2016-01-12 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 13, 2016, 4:06 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review114150 --- Started to look at this review. A few minor comments here, I'll

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/#review114111 --- Patch looks great! Reviews applied: [41704, 41705, 41818] Passed

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 13, 2016, 2:24 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/#review114140 --- src/tests/master_validation_tests.cpp

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-12 Thread Greg Mann
> On Jan. 13, 2016, 2:56 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, lines 368-381 > > > > > > Sorry, I should have propsed my comments in one review. Seems we need > > validate both reserve

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-12 Thread Guangya Liu
> On 一月 13, 2016, 2:56 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, lines 368-381 > > > > > > Sorry, I should have propsed my comments in one review. Seems we need > > validate both reserve

Re: Review Request 42165: Removed `hasPrincipal` parameter from unreserve validation.

2016-01-12 Thread Greg Mann
> On Jan. 13, 2016, 2:13 a.m., Guangya Liu wrote: > > I think that you may also want a coming patch to address the document > > issue: reservation.md. Update the document to clarify how to use > > (un)reserve without principal. Yep, thanks Guangya! I'll follow up soon with a patch for the

Re: Review Request 41847: Updated allocation slack when slave was updated.

2016-01-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41847/ --- (Updated 一月 13, 2016, 2:32 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review114153 --- src/master/master.cpp (line 3048)

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 13, 2016, 2:37 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 13, 2016, 2:53 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review114148 --- Patch looks great! Reviews applied: [41806] Passed command:

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/#review114149 --- src/master/validation.cpp (line 699)

Review Request 42234: Added test case on re-using evicting executors.

2016-01-12 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42234/ --- Review request for mesos, Guangya Liu and Jian Qiu. Bugs: MESOS-3897

Re: Review Request 42234: WIP: Added test case on re-using evicting executors.

2016-01-12 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42234/ --- (Updated Jan. 13, 2016, 2:14 p.m.) Review request for mesos, Guangya Liu and

Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

2016-01-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy

Re: Review Request 40553: Enable mesos tests installation

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review114144 --- Bad patch! Reviews applied: [39780, 39781, 39782, 40553] Failed

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/#review114151 --- Patch looks great! Reviews applied: [42030] Passed command:

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/ --- (Updated Jan. 13, 2016, 2:45 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-12 Thread Greg Mann
> On Jan. 13, 2016, 2:17 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, line 294 > > > > > > Can you update the test case to verify that those validation still > > passed even without a

Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy

Re: Review Request 41961: Added an HTTP decode response method.

2016-01-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/ --- (Updated Jan. 13, 2016, 6:36 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42209: Updated getting started page to install Java on OSX.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114142 --- Patch looks great! Reviews applied: [42209] Passed command:

Review Request 42236: Added a utility function to create https URI.

2016-01-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy

Review Request 42237: Added docker image manifest parsing functions for strings.

2016-01-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy

Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

2016-01-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42235/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy

Re: Review Request 39805: Moved filesystems tests to their own file.

2016-01-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/ --- (Updated Jan. 12, 2016, 8:17 a.m.) Review request for mesos, Artem

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-12 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 12, 2016, 8:54 a.m.) Review request for mesos, Alexander

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-12 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 12, 2016, 9:56 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-12 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 12, 2016, 8:42 a.m.) Review request for mesos, Alexander

Review Request 42183: Introduced HttpEvent based filters in libprocess.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42183/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4255

Review Request 42185: Added an example executor based on the new V1 API.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42185/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4255

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/ --- (Updated Jan. 12, 2016, 9:22 a.m.) Review request for mesos, Ben Mahler and

Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4255

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Jan. 12, 2016, 9:21 a.m.) Review request for mesos, Ben Mahler and

Review Request 42182: Removed the erroneous check that did not allow HTTP based executors to subscribe upon agent process restart.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42182/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4255

Review Request 42181: Added a Slave constructor to pass process ID manually.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42181/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4255

Review Request 42184: Introduced `FUTURE_HTTP_*` for filtering HTTP based events.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42184/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4255

Re: Review Request 41672: Test case(s) for weights + allocation behavior

2016-01-12 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Jan. 12, 2016, 9:35 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-12 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 12, 2016, 9:34 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/ --- (Updated Jan. 12, 2016, 9:51 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/#review113965 --- src/master/validation.cpp (line 692)

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-12 Thread Joerg Schad
> On Jan. 12, 2016, 3 a.m., Alexander Rukletsov wrote: > > docs/quota.md, line 313 > > > > > > Is there a trailing blank line? In my patch yes. Not sure what rb does... - Joerg

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/#review113963 --- Bad patch! Reviews applied: [42047] Failed command:

Re: Review Request 39805: Moved filesystems tests to their own file.

2016-01-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/ --- (Updated Jan. 12, 2016, 8:41 a.m.) Review request for mesos, Artem

Re: Review Request 41285: Initialized `pid` to None() instead of `UPID()` in Slave

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/ --- (Updated Jan. 12, 2016, 9:21 a.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 41275: Introduced a field for specifying grace period in Shutdown Event for Executor V1 API.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41275/ --- (Updated Jan. 12, 2016, 9:20 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 12, 2016, 9:21 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

2016-01-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113962 --- I thought we said we'd leave info.set_checkpoint(true); in the

Re: Review Request 41672: Test case(s) for weights + allocation behavior

2016-01-12 Thread Yongqiao Wang
> On Jan. 11, 2016, 10:13 a.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2218-2219 > > > > > > Why hardcode 3? I'd think you could just run a while loop and actually > > assert the size

Review Request 42191: Added parameters to apply patches quiet.

2016-01-12 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42191/ --- Review request for mesos and Artem Harutyunyan. Bugs: MESOS-4342

Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.

2016-01-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42149/#review113981 --- src/tests/fetcher_cache_tests.cpp (lines 813 - 816)

Re: Review Request 42040: Added Quota Operator Documentation.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113982 --- Patch looks great! Reviews applied: [42040] Passed command:

Re: Review Request 41672: Test case(s) for weights + allocation behavior

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review113990 --- Bad patch! Reviews applied: [41597, 41672] Failed command:

Re: Review Request 42191: Added parameters to apply patches quiet.

2016-01-12 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42191/ --- (Updated Jan. 12, 2016, 9:54 p.m.) Review request for mesos and Artem

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review113983 --- Bad patch! Reviews applied: [41275] Failed command:

Re: Review Request 41937: Factored out parsing `QuotaInfo` from JSON into a function.

2016-01-12 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41937/#review113987 --- Ship it! Ship It! - Joerg Schad On Jan. 5, 2016, 6:08 p.m.,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-12 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review113989 --- src/tests/hierarchical_allocator_tests.cpp (line 223)

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Joseph Wu
> On Jan. 9, 2016, 1:02 a.m., Klaus Ma wrote: > > src/master/master.cpp, line 3078 > > > > > > If both `offerError.isSome()` and `inverseOfferError.isSome()`, should > > we return `Error()`? > > Joseph Wu wrote:

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 6:37 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 6:36 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42182: Fixed check thereby allowing HTTP executors to reconnect.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42182/ --- (Updated Jan. 12, 2016, 5:46 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
> On Jan. 12, 2016, 1:38 a.m., Ben Mahler wrote: > > Looks great, thanks! Just a few trivial comments below, and we can commit > > this once the unit test is in place. I've addressed the two issues below and pushed a new patch. Patch for unit test forthcoming. - Kevin

Re: Review Request 42194: WIP: Handle unreserve logic for dynamic reservation (2/2).

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/#review114033 --- Patch looks great! Reviews applied: [40375, 41334, 41333, 40529,

Re: Review Request 42165: Removed `hasPrincipal` parameter from unreserve validation.

2016-01-12 Thread Greg Mann
> On Jan. 12, 2016, 2:33 a.m., Guangya Liu wrote: > > Greg, I think that the document of reservation.md should also be updated. > > > > BTW: Did you test your patch? I did some test as this and mesos-master core > > dump. > > > > curl -i -d slaveId="4c737d19-e3b2-41c0-b4d0-ffc60190b8eb-S0"

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/#review114018 --- docs/logging.md (line 21)

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/#review114040 --- Ship it! Ship It! - Neil Conway On Jan. 12, 2016, 7:24 p.m.,

Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42149/#review114043 --- Patch looks great! Reviews applied: [42149] Passed command:

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/ --- (Updated Jan. 12, 2016, 6:53 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Benjamin Bannier
> On Jan. 12, 2016, 3:43 p.m., Benjamin Bannier wrote: > > src/master/master.cpp, line 3084 > > > > > > Since there's a clean separation among offers and inverse offers, it > > seems we could begin logging unknown

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/ --- (Updated Jan. 12, 2016, 6 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Joseph Wu
> On Jan. 12, 2016, 6:43 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, line 3084 > > > > > > Since there's a clean separation among offers and inverse offers, it > > seems we could begin logging unknown

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-12 Thread Joseph Wu
> On Jan. 12, 2016, 10:03 a.m., Neil Conway wrote: > > docs/logging.md, line 39 > > > > > > Do we want or back-ticks? Back-ticks would probably be more > > consistent with the other doc pages. This is an

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/ --- (Updated Jan. 12, 2016, 11:24 a.m.) Review request for mesos, Benjamin

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/ --- (Updated Jan. 12, 2016, 5:53 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 41949: Replaced `QuotaInfo` with `Quota` in allocator.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41949/ --- (Updated Jan. 12, 2016, 9:33 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/ --- (Updated Jan. 12, 2016, 9:34 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41947: Changed signature of `QuotaInfo` validation.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41947/ --- (Updated Jan. 12, 2016, 9:32 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41938: Cleaned up quota tests.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41938/ --- (Updated Jan. 12, 2016, 9:33 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41948: Ensured `QuotaInfo` is valid in registrar tests.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41948/ --- (Updated Jan. 12, 2016, 9:33 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 10:05 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.

2016-01-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/ --- (Updated Jan. 12, 2016, 10:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 10:06 p.m.) Review request for mesos and Ben Mahler.

Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3307

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2016-01-12 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Jan. 12, 2016, 10:14 p.m.) Review request for mesos, Benjamin

Re: Review Request 41648: Used initializer list c-tor for brevity.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41648/ --- (Updated Jan. 12, 2016, 9:33 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41937: Factored out parsing `QuotaInfo` from JSON into a function.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41937/ --- (Updated Jan. 12, 2016, 9:32 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review114073 --- Bad patch! Reviews applied: [41275, 41277, 41280, 41281] Failed

Re: Review Request 41936: Required role in set quota request explicitly.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41936/ --- (Updated Jan. 12, 2016, 9:32 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 42209: Updated getting started page to install Java on OSX.

2016-01-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/ --- Review request for mesos, Ben Mahler and Kevin Klues. Repository: mesos

Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox.

2016-01-12 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 12, 2016, 1:48 p.m.) Review request for mesos and Artem

Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox.

2016-01-12 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 12, 2016, 1:50 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 42121: Replaced `Clock::settle()` with `os::sleep` in test case.

2016-01-12 Thread Neil Conway
> On Jan. 11, 2016, 8:09 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, lines 280-283 > > > > > > Just some thoughts: > > > > The downstream event you're waiting for is a call

Re: Review Request 42209: Updated getting started page to install Java on OSX.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114075 --- Can you veirfy that this doesn't break things for Yosemite? -

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/ --- (Updated Jan. 12, 2016, 10:12 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

2016-01-12 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Jan. 12, 2016, 10:14 p.m.) Review request for mesos, Benjamin

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2016-01-12 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Jan. 12, 2016, 10:14 p.m.) Review request for mesos, Benjamin

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 10:15 p.m.) Review request for mesos and Ben Mahler.

  1   2   >