Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

2016-01-15 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Jan. 15, 2016, 10:47 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-15 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 15, 2016, 10:46 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

2016-01-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 15, 2016, 11:40 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

2016-01-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 15, 2016, 12:19 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 15, 2016, 1:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: Added `jsonify` function to stout.

2016-01-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 15, 2016, 1:26 p.m.) Review request for mesos and Benjamin

Re: Review Request 41594: Added support for `jsonify` result to `OK` response in libprocess.

2016-01-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41594/ --- (Updated Jan. 15, 2016, 1:26 p.m.) Review request for mesos and Benjamin

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41595/ --- (Updated Jan. 15, 2016, 1:27 p.m.) Review request for mesos and Benjamin

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2016-01-15 Thread Bernd Mathiske
> On Jan. 13, 2016, 5:18 a.m., Joerg Schad wrote: > > docs/fetcher.md, line 231 > > > > > > does protocol here has the same limitation as below in line 241 > > (socks4/socks5/http/https)? Yes. I made that explicit

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

2016-01-15 Thread Adam B
> On Jan. 15, 2016, 1:34 a.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2093-2096 > > > > > > We rarely (only 67 times) use `unsigned`. Usually it's `int` (909 > > times) for signed

Re: Review Request 41595: Updated `Master::Http::state` to use `jsonify` in mesos.

2016-01-15 Thread Michael Park
> On Dec. 21, 2015, 5:04 a.m., Michael Park wrote: > > src/common/http.cpp, lines 443-450 > > > > > > Currently in the `model` function for `CommandInfo`, the `extract` and > > `cache` fields of `CommandInfo::URI`

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review114709 --- docs/fetcher.md (line 236)

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

2016-01-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 15, 2016, 3:38 p.m.) Review request for mesos, Benjamin Bannier

Review Request 42353: Correctted typo in fetcher.md.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42353/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 42246: Fixed support for non-HDFS URIs by Hadoop client.

2016-01-15 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42246/#review114716 --- src/hdfs/hdfs.cpp (line 313)

Re: Review Request 42246: Fixed support for non-HDFS URIs by Hadoop client.

2016-01-15 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42246/#review114720 --- Ship it! (after my previous issues are resolved). In addition it

Re: Review Request 41617: Added a new category called whitespace/mesos-comments to capture missing, leading, white-space in comments

2016-01-15 Thread Avinash sridharan
> On Jan. 14, 2016, 8:46 p.m., Michael Park wrote: > > Please update the `Summary` to be < 72 chars to make Reviewbot happy. Could > > you also submit a patch for the places that violate the rule we're > > enforcing here and make this patch depend on it? Again, so that this way > > Reviewbot

Re: Review Request 41617: Added a new category called whitespace/mesos-comments to capture missing, leading, white-space in comments

2016-01-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41617/ --- (Updated Jan. 15, 2016, 5:41 p.m.) Review request for mesos and Michael Park.

Re: Review Request 41617: Enabled whitespace-comments category in mesos-style.py

2016-01-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41617/ --- (Updated Jan. 15, 2016, 5:42 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42211: Added filters to disable NetClsIsolator tests.

2016-01-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/ --- (Updated Jan. 15, 2016, 5:42 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class.

2016-01-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42047/ --- (Updated Jan. 15, 2016, 5:42 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 40731: Adding test fixture for checking floating point arithmetic

2016-01-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 15, 2016, 5:44 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

2016-01-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review114726 --- Ship it! When committing, I will s/framework1/framework/ and

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class.

2016-01-15 Thread Cong Wang
> On Jan. 15, 2016, 6 a.m., Cong Wang wrote: > > Why do we need netcls to regulate framework traffic on a per-container > > basis? Given the fact that a) the port range based filters already work and > > the code (see egress fq_codel) already exists b) we only have port range > > based

Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.

2016-01-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42149/#review114701 --- src/tests/fetcher_cache_tests.cpp (lines 803 - 804)

Re: Review Request 41617: Added a new category called whitespace/mesos-comments to capture missing, leading, white-space in comments

2016-01-15 Thread Michael Park
> On Jan. 14, 2016, 8:46 p.m., Michael Park wrote: > > Please update the `Summary` to be < 72 chars to make Reviewbot happy. Could > > you also submit a patch for the places that violate the rule we're > > enforcing here and make this patch depend on it? Again, so that this way > > Reviewbot

Re: Review Request 42347: Fixed broken link in scheduler-http-api.md and added anchor.

2016-01-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42347/#review114715 --- Ship it! Ship It! - Anand Mazumdar On Jan. 15, 2016, 10:02

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-15 Thread Michael Park
> On Jan. 15, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 166-169 > > > > > > Is this supposed to return `int` like the ones below? or are they > >

Re: Review Request 42246: Fixed support for non-HDFS URIs by Hadoop client.

2016-01-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42246/#review114736 --- Ship it! src/hdfs/hdfs.cpp (line 313)

Re: Review Request 42342: Added a new test cases for revive offer.

2016-01-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review114747 --- src/tests/hierarchical_allocator_tests.cpp (line 1906)

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-15 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated Jan. 15, 2016, 6:20 p.m.) Review request for mesos, Alexander

Re: Review Request 40553: Enable mesos tests installation.

2016-01-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 15, 2016, 6:44 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 15, 2016, 6:49 p.m.) Review request for mesos, Artem

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class.

2016-01-15 Thread Avinash sridharan
> On Jan. 15, 2016, 6 a.m., Cong Wang wrote: > > Why do we need netcls to regulate framework traffic on a per-container > > basis? Given the fact that a) the port range based filters already work and > > the code (see egress fq_codel) already exists b) we only have port range > > based

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

2016-01-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Jan. 15, 2016, 11:04 a.m.) Review request for mesos, Artem

Re: Review Request 39805: Moved filesystems tests to their own file.

2016-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/ --- (Updated Jan. 15, 2016, 7:34 p.m.) Review request for mesos, Artem

Review Request 42358: Logger Module: Refactored Sandbox logger initialization.

2016-01-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42358/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs:

Re: Review Request 41781: Logger Module: Add test for the rotating container logger module.

2016-01-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41781/ --- (Updated Jan. 15, 2016, 11:34 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-15 Thread Alex Clemmer
> On Jan. 15, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, lines > > 41-42 > > > > > > Add new line. The POSIX version of this code has the same

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-15 Thread Alex Clemmer
> On Jan. 15, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 166-169 > > > > > > Is this supposed to return `int` like the ones below? or are they > >

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-15 Thread Michael Park
> On Jan. 14, 2016, midnight, Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp, > > line 104 > > > > > > This looks like it should return a `Try`? > > Alex

Re: Review Request 40010: Put authorize logic for teardown into a common function.

2016-01-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40010/#review114751 --- Patch looks great! Reviews applied: [40010] Passed command:

Re: Review Request 42048: Defined the CgroupNetClsIsolatorProcess.

2016-01-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42048/ --- (Updated Jan. 15, 2016, 7:06 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Jan. 15, 2016, 7:29 p.m.) Review request for mesos, Artem

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-15 Thread Alex Clemmer
> On Jan. 15, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 166-169 > > > > > > Is this supposed to return `int` like the ones below? or are they > >

Re: Review Request 42275: Added utility functions to create docker URI.

2016-01-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42275/#review114753 --- Ship it! Do we need some comments on we are mapping `tag` to

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class.

2016-01-15 Thread Cong Wang
> On Jan. 15, 2016, 6 a.m., Cong Wang wrote: > > Why do we need netcls to regulate framework traffic on a per-container > > basis? Given the fact that a) the port range based filters already work and > > the code (see egress fq_codel) already exists b) we only have port range > > based

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/ --- (Updated Jan. 15, 2016, 7:21 p.m.) Review request for mesos, Artem

Re: Review Request 40553: Enable mesos tests installation.

2016-01-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 15, 2016, 8:17 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 41937: Factored out parsing `QuotaInfo` from JSON into a function.

2016-01-15 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41937/#review114759 --- I still don't like the fact that we are taking a generic helper

Re: Review Request 42097: Added cgroup/net_cls to the mesos containerizer isolation flags.

2016-01-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42097/#review114756 --- Ship it! Ship It! - Jie Yu On Jan. 12, 2016, 6:28 a.m.,

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

2016-01-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review114757 --- Patch looks great! Reviews applied: [41597, 41672] Passed

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

2016-01-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/#review114758 --- src/uri/fetchers/docker.cpp (lines 31 - 32)

Re: Review Request 42048: Defined the CgroupNetClsIsolatorProcess.

2016-01-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42048/#review114617 --- Ship it! I would rename the summary to be "Implemented the cgroup

Re: Review Request 42353: Correctted typo in fetcher.md.

2016-01-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42353/#review114763 --- Patch looks great! Reviews applied: [42353] Passed command:

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114762 --- src/tests/hook_tests.cpp (line 389)

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/#review114765 --- src/uri/fetchers/docker.cpp (lines 598 - 601)

Re: Review Request 40731: Adding test fixture for checking floating point arithmetic

2016-01-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review114772 --- Bad patch! Reviews applied: [40731] Failed command:

Re: Review Request 41936: Required role in set quota request explicitly.

2016-01-15 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41936/#review114773 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 12, 2016,

Re: Review Request 41947: Changed signature of `QuotaInfo` validation.

2016-01-15 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41947/#review114774 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 12, 2016,

Re: Review Request 41870: Added ref-qualifiers to Option::get().

2016-01-15 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/#review114764 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 13, 2016,

Re: Review Request 41962: Add test for ContainerLogger recovery after agent failover.

2016-01-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 15, 2016, 1:03 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/#review114766 --- Ship it! Ship It! - Timothy Chen On Jan. 13, 2016, 11:14 p.m.,

Re: Review Request 42275: Added utility functions to create docker URI.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42275/#review114767 --- Ship it! Ship It! - Timothy Chen On Jan. 13, 2016, 11:12 p.m.,

Re: Review Request 41948: Ensured `QuotaInfo` is valid in registrar tests.

2016-01-15 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41948/#review114775 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 12, 2016,

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

2016-01-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review114783 --- Patch looks great! Reviews applied: [41491] Passed command:

Re: Review Request 42362: Added persistent volume endpoint test without authorization.

2016-01-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 15, 2016, 11:56 p.m.) Review request for mesos, Michael Park and

Re: Review Request 42361: Added dynamic reservation test with no principal.

2016-01-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/ --- (Updated Jan. 15, 2016, 11:55 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 42370: Accept the 3-field version of HDFS du output.

2016-01-15 Thread James Peach
> On Jan. 16, 2016, 12:06 a.m., Jie Yu wrote: > > src/tests/hdfs_tests.cpp, line 117 > > > > > > 2 lines apart please. > > Jie Yu wrote: > I'll just fix it for you and commit. Thanks James! Thanks Jie! -

Re: Review Request 41847: Updated allocation slack when slave was updated.

2016-01-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41847/#review114832 --- Test looks good. Just a suggestion:

Review Request 42384: Correctted a typo in test case DeactivateAndReactivateFramework.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42384/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 40731: Adding test fixture for checking floating point arithmetic

2016-01-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 16, 2016, 5:48 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review114796 --- Ship it!

Re: Review Request 42277: Add mount_all to linux fs.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42277/ --- (Updated Jan. 16, 2016, 1:32 a.m.) Review request for mesos and Jie Yu.

Review Request 42379: Add reverse_foreach in libprocess.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42379/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-15 Thread Joseph Wu
> On Jan. 7, 2016, 12:22 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1305-1313 > > > > > > If you make the changes above, this recalculation will be unnecessary. > >

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 一月 16, 2016, 4:36 a.m.) Review request for mesos, Ben Mahler, Artem

Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.

2016-01-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42334/ --- Review request for mesos, Jie Yu, Michael Park, and Vinod Kone. Bugs:

Review Request 42336: Documented endpoint failure when HTTP authentication disabled.

2016-01-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42336/ --- Review request for mesos, Jie Yu, Michael Park, and Vinod Kone. Bugs:

Re: Review Request 42361: Added dynamic reservation test with no principal.

2016-01-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/ --- (Updated Jan. 15, 2016, 11:17 p.m.) Review request for mesos, Jie Yu, Michael

Review Request 42362: Added persistent volume endpoint test without authorization.

2016-01-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-4395

Re: Review Request 41962: Add test for ContainerLogger recovery after agent failover.

2016-01-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 15, 2016, 5:02 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review114831 --- src/master/allocator/mesos/hierarchical.cpp (lines 1291 - 1319)

Review Request 42361: Added dynamic reservation test with no principal.

2016-01-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/ --- Review request for mesos, Jie Yu, Michael Park, and Vinod Kone. Bugs:

Review Request 42368: Added reservation endpoint test without auth and principal.

2016-01-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/ --- Review request for mesos, Jie Yu, Michael Park, and Vinod Kone. Bugs:

Re: Review Request 42370: Accept the 3-field version of HDFS du output.

2016-01-15 Thread Jie Yu
> On Jan. 16, 2016, 12:06 a.m., Jie Yu wrote: > > src/tests/hdfs_tests.cpp, line 117 > > > > > > 2 lines apart please. I'll just fix it for you and commit. Thanks James! - Jie

Re: Review Request 42370: Accept the 3-field version of HDFS du output.

2016-01-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42370/#review114803 --- Ship it! src/tests/hdfs_tests.cpp (line 117)

Re: Review Request 40731: Adding test fixture for checking floating point arithmetic

2016-01-15 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 16, 2016, 1:55 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42342: Added a new test cases for revive offer.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/ --- (Updated 一月 16, 2016, 2:52 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42342: Added a new test cases for revive offer.

2016-01-15 Thread Guangya Liu
> On 一月 15, 2016, 6:46 p.m., Vinod Kone wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1933 > > > > > > s/filter1000s/filters/ I want to hightlight that this is a 1000s filter as I saw that we also

Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 16, 2016, 4:12 a.m.) Review request for mesos, Ben Mahler, Artem

Review Request 42386: Updated createFrameworkInfo for hierarchical_allocator_tests.cpp.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere,

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks.

2016-01-15 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41306/ --- (Updated Jan. 16, 2016, 1:38 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42342: Added a new test cases for revive offer.

2016-01-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review114844 --- Patch looks great! Reviews applied: [39628, 42342] Passed

Re: Review Request 42325: Fixed non-conformance of whitespace in comments, for mesos.

2016-01-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42325/#review114809 --- Ship it! Ship It! - Michael Park On Jan. 14, 2016, 10:54 p.m.,

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review114808 --- Ship it! Ship It! - Timothy Chen On Jan. 15, 2016, 5:09 a.m.,

Re: Review Request 42274: Added common command utils file.

2016-01-15 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42274/ --- (Updated Jan. 16, 2016, 12:21 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42325: Fixed non-conformance of whitespace in comments, for mesos.

2016-01-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42325/#review114810 --- Ship it! Ship It! - Michael Park On Jan. 14, 2016, 10:54 p.m.,

Re: Review Request 42277: Add mount_all to linux fs.

2016-01-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42277/#review114818 --- Ship it! src/linux/fs.hpp (line 343)

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-15 Thread Alex Clemmer
> On Jan. 13, 2016, 6:01 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 37-40 > > > > > > We typically don't use typedefs in Mesos. Can we just use > >

  1   2   >