Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-21 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review115623 --- Ship it! After addressing Joerg's remaining issues, ship it! -

Review Request 42594: Introduced framework registry operations.

2016-01-21 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42594/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.

2016-01-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41932/#review115598 --- Ship it! Ship it! I can make this minor change when I commit, so

Re: Review Request 42594: Introduced framework registry operations.

2016-01-21 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42594/ --- (Updated Jan. 21, 2016, 9:45 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-21 Thread Guangya Liu
> On 一月 19, 2016, 11:34 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 676 > > > > > > I see several places where you overwrite changes from this review in > > the subsequent two. Did

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41979/#review115599 --- Ship it! I'll also update the upgrades guide and CHANGELOG. -

Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.

2016-01-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41932/#review115593 --- Looks great. Create a separate test for shutdown vs. teardown

Re: Review Request 42590: Removed reserved() API.

2016-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review115597 --- Patch looks great! Reviews applied: [42590] Passed command:

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41979/#review115595 --- Ship it! Looks great! docs/authorization.md (line 45)

Re: Review Request 42591: Added Framework protobufs to registry.

2016-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42591/#review115604 --- Patch looks great! Reviews applied: [42591] Passed command:

Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41932/ --- (Updated 一月 21, 2016, 8:52 a.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 41979: Updated document for teardown_frameworks.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41979/ --- (Updated 一月 21, 2016, 9:04 a.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-21 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 21, 2016, 9:57 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41789: Expose the http::internal::request function.

2016-01-21 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 21, 2016, 9:56 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 42559: Allocated resources as revocable beyond quota.

2016-01-21 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/#review115605 --- src/master/allocator/mesos/hierarchical.cpp (lines 1342 - 1344)

Re: Review Request 42355: Removed the timeout from the filter.

2016-01-21 Thread Alexander Rukletsov
> On Jan. 21, 2016, 7:17 a.m., Ben Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 449-451 > > > > > > Why mention expiration between two consecutive allocations here? The > > way I had been

Re: Review Request 42470: Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.

2016-01-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42470/#review115646 --- Ship it! Ship It! - Jie Yu On Jan. 21, 2016, 7:35 a.m., Joris

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

2016-01-21 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/ --- (Updated Jan. 21, 2016, 4:58 p.m.) Review request for mesos, Artem

Re: Review Request 42355: Removed the timeout from the filter.

2016-01-21 Thread Alexander Rukletsov
> On Jan. 21, 2016, 7:17 a.m., Ben Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 544-560 > > > > > > In the bottom section of this test, I'm not sure folks without our > > context will

Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

2016-01-21 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42605/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4449

Re: Review Request 42590: Removed reserved() API.

2016-01-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review115640 --- include/mesos/v1/resources.hpp (line 224)

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

2016-01-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115648 --- src/common/resources.cpp (lines 102 - 108)

Re: Review Request 41847: Updated allocation slack when slave was updated.

2016-01-21 Thread Joseph Wu
> On Jan. 15, 2016, 6:21 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 529-535 > > > > > > What if you did this? > > ``` > > slaves[slaveId]total =

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

2016-01-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review115502 --- src/executor/executor.cpp (line 170)

Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume based on 'DiskInfo.Source'.

2016-01-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42472/#review115681 --- src/slave/slave.cpp (lines 2260 - 2272)

Review Request 42615: mesos: Cleaned up usage of namespace-qualified identifiers.

2016-01-21 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42615/ --- Review request for mesos. Repository: mesos Description --- For

Review Request 42623: Reduced severity level for 'HTTP GET for ...' messages.

2016-01-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42623/ --- Review request for mesos, Cody Maloney and Joris Van Remoortere. Bugs:

Re: Review Request 42361: Added dynamic reservation test with no authentication.

2016-01-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/ --- (Updated Jan. 21, 2016, 11:21 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 42368: Added reservation endpoint test without authentication.

2016-01-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/#review115715 --- src/tests/reservation_endpoints_tests.cpp (lines 1159 - 1160)

Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.

2016-01-21 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/ --- Review request for mesos. Repository: mesos Description --- For

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 21, 2016, 9:03 p.m.) Review request for mesos, Michael Park and

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

2016-01-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review115685 --- I was expecting a `mesos-slave` executable, but I don't see any

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

2016-01-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/#review115703 --- General questions: - Besides removing the possibility for

Re: Review Request 42590: Removed reserved() API.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 一月 22, 2016, 3:37 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42368: Added reservation endpoint test without authentication.

2016-01-21 Thread Greg Mann
> On Jan. 21, 2016, 10:42 p.m., Michael Park wrote: > > Thanks MPark! Per our discussion, I've removed all of the requests from this test except the reserve and unreserve requests which contain no authentication headers as well as no principal in `ReservationInfo`, since the other requests

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review115781 --- Bad patch! Reviews applied: [41950] Failed command:

Re: Review Request 42368: Added reservation endpoint test without authentication.

2016-01-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/ --- (Updated Jan. 22, 2016, 3:33 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 42274: Added common command utils file.

2016-01-21 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42274/ --- (Updated Jan. 22, 2016, 12:55 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 41847: Updated allocation slack when slave was updated.

2016-01-21 Thread Guangya Liu
> On 一月 16, 2016, 2:21 a.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 529-535 > > > > > > What if you did this? > > ``` > > slaves[slaveId]total =

Re: Review Request 42605: Fixed a NULL pointer dereference bug in Slave.

2016-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42605/#review115751 --- Patch looks great! Reviews applied: [42605] Passed command:

Review Request 42634: Updated a comment for consistency.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42634/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 42636: Replaced term 'periodic allocation' for consistency.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42636/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 42632: Cleaned up formatting in the allocator.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42632/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 42631: Renamed resource offer timeout for clarity.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42631/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 42629: Added tests for offer filters.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42629/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4302

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

2016-01-21 Thread Anand Mazumdar
> On Jan. 21, 2016, 7:33 p.m., Vinod Kone wrote: > > Moved the code to: `connected`: Invoke this callback after `Subscribe`/non subscribe connection have been established. `disconnected`: Invoke this callback after any of `Subscribe`/non subscribe connection is broken. > On Jan. 21, 2016,

Re: Review Request 41648: Used initializer list c-tor for brevity.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41648/#review115758 --- Ship it! Ship It! - Guangya Liu On 一月 22, 2016, 1:24 a.m.,

Re: Review Request 42633: Corrected a comment in the allocator.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/#review115760 --- Ship it! Ship It! - Guangya Liu On 一月 22, 2016, 1:24 a.m.,

Re: Review Request 42637: Cleaned up formatting in allocator tests.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42637/#review115762 --- src/tests/hierarchical_allocator_tests.cpp (line 795)

Re: Review Request 41648: Used initializer list c-tor for brevity.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41648/ --- (Updated Jan. 22, 2016, 1:24 a.m.) Review request for mesos, Bernd Mathiske,

Review Request 42633: Corrected a comment in the allocator.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 42623: Reduced severity level for 'HTTP GET for ...' messages.

2016-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42623/#review115776 --- Patch looks great! Reviews applied: [42606, 42623] Passed

Re: Review Request 42632: Cleaned up formatting in the allocator.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42632/#review115759 --- Ship it! Ship It! src/master/allocator/mesos/hierarchical.cpp

Re: Review Request 42547: Added helper function to get non usage slack resources.

2016-01-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42547/ --- (Updated 一月 22, 2016, 3:15 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/ --- (Updated Jan. 22, 2016, 1:20 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42368: Added reservation endpoint test without authentication.

2016-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/#review115764 --- Patch looks great! Reviews applied: [42530, 42361, 42368] Passed

Re: Review Request 42157: Changed ProvisionerAppcTest to use AppcStoreTest suite.

2016-01-21 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42157/ --- (Updated Jan. 22, 2016, 6:48 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42274: Added common command utils file.

2016-01-21 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42274/ --- (Updated Jan. 22, 2016, 6:52 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-21 Thread Joseph Wu
> On Jan. 20, 2016, 2:54 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 662 > > > > > > Have you considered modifying `Resources::apply` to "create" allocation > > slack upon a

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-21 Thread Joseph Wu
> On Jan. 19, 2016, 3:34 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 676 > > > > > > I see several places where you overwrite changes from this review in > > the subsequent two.