Re: Review Request 41299: Allow DockerContainerizer log to console.

> On Jan. 24, 2016, 8:21 a.m., Guangya Liu wrote: > > I saw that all of the unit test are using `false` for `local`, can you > > please write some test scenarios in `Testing Done` area? Sure, I test this local before. Add a new unit test would be better. - haosdent

Re: Review Request 41299: Allow DockerContainerizer log to console.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review116013 --- I saw that all of the unit test are using `false` for `local`,

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 25, 2016, 1:51 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review116041 --- Fix it, then Ship it! I'll fix up the issue below and commit,

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/#review116039 --- Ship it! Ship It! - haosdent huang On Jan. 21, 2016, 6:18

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review116040 --- Bad patch! Reviews applied: [41597] Failed command:

Review Request 42695: Correct typo when create docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42695/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 42704: Fixed non-linux build involving glog drop_log_meory flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42704/#review116043 --- Ship it! Ship It! - Neil Conway On Jan. 25, 2016, 5:44

Re: Review Request 41590: Modulize the containerizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41590/#review116051 --- @haosdent, it is really a big patch, can you please highlight

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/#review116054 --- src/tests/slave_tests.cpp (line 704)

Review Request 42704: Fixed non-linux build involving glog drop_log_meory flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42704/ --- Review request for mesos and Jie Yu. Bugs: MESOS-920

Re: Review Request 42705: Update docs for --weights flag and authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/#review116046 --- Patch looks great! Reviews applied: [42705] Passed command:

Review Request 42710: Moved docker containerizer to docker folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42710/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Review Request 42705: Update docs for --weights flag and authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/ --- Review request for mesos and Adam B. Bugs: MESOS-3945

Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- Review request for mesos and Bernd Mathiske. Bugs: MESOS-4486

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42697/ --- (Updated Jan. 24, 2016, 3:26 p.m.) Review request for mesos, Adam B and Joerg

Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42697/ --- Review request for mesos, Adam B and Joerg Schad. Bugs: MESOS-4340

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42697/#review116018 --- We planned to wait for this deprecation cycle, any reason to

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote: > > include/mesos/mesos.proto, line 482 > > > > > > We planned to wait for this deprecation cycle, any reason to change > > this right now? I saw ``` //

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote: > > include/mesos/mesos.proto, line 482 > > > > > > We planned to wait for this deprecation cycle, any reason to change > > this right now? > > haosdent huang

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote: > > include/mesos/mesos.proto, line 482 > > > > > > We planned to wait for this deprecation cycle, any reason to change > > this right now? > > haosdent huang

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote: > > include/mesos/mesos.proto, line 482 > > > > > > We planned to wait for this deprecation cycle, any reason to change > > this right now? > > haosdent huang

Re: Review Request 42353: Correctted typo in fetcher.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42353/#review116032 --- Ship it! Ship It! - Bernd Mathiske On Jan. 22, 2016, 4:54

Re: Review Request 42695: Correct typo when create docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42695/#review116017 --- Patch looks great! Reviews applied: [42695] Passed command:

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review116022 --- Patch looks great! Reviews applied: [42696] Passed command: