Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42786/ --- (Updated Jan. 29, 2016, 10:24 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Klaus Ma
> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > > > > > Just check the code on `setQuota-->rescindOffer`, why not let allocator > > to do the `rescindOffer`? It

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42786/ --- (Updated Jan. 29, 2016, 10:13 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/ --- (Updated Jan. 29, 2016, 10:34 a.m.) Review request for mesos, Michael Park and

Re: Review Request 42910: Added a note about revocable resources beyond quota in the user doc.

2016-01-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42910/ --- (Updated Jan. 29, 2016, 10:58 a.m.) Review request for mesos, Joris Van

Re: Review Request 42910: Added a note about revocable resources beyond quota in the user doc.

2016-01-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42910/#review116944 --- Ship it! Ship It! - Guangya Liu On 一月 29, 2016, 10:58 a.m.,

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Alexander Rukletsov
> On Jan. 29, 2016, 8:42 a.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > > > > > Just check the code on `setQuota-->rescindOffer`, why not let allocator > > to do the `rescindOffer`? It

Review Request 42957: Added remove() calls to process::Help.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Bugs:

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review116908 --- src/tests/master_quota_tests.cpp (line 957)

Review Request 42956: Added variadic template for process::await.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42956/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Bugs:

Re: Review Request 42955: Added variadic template for process::collect.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42955/ --- (Updated Jan. 29, 2016, 10:10 a.m.) Review request for mesos, Joris Van

Review Request 42958: Added a unit test for manipulating strings in the global help process.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42958/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Bugs:

Review Request 42955: Added variadic template for process::collect.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42955/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Repository:

Re: Review Request 42946: Replaced tabs with spaces in configure.ac.

2016-01-29 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/ --- (Updated Jan. 29, 2016, 4:19 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-01-29 Thread Klaus Ma
> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > > > > > Just check the code on `setQuota-->rescindOffer`, why not let allocator > > to do the `rescindOffer`? It

Re: Review Request 42832: Added a status method to the Isolator interface.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42832/#review116960 --- Ship it! Can you also add a test to the test suite? - Kapil

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116964 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2016, 1:32 a.m.,

Re: Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42928/#review116958 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2016, 12:06 a.m.,

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/#review116967 --- A couple of fixes you can make to the help strings and then

Re: Review Request 42794: URL query string order is defined.

2016-01-29 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/ --- (Updated Jan. 29, 2016, 5:15 p.m.) Review request for mesos, Kapil Arya and

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 5:41 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116968 --- Fix it, then Ship it! support/verify_reviews.py (line 150)

Re: Review Request 42927: Deleted Dockerfile in favor of `support/docker_build.sh`.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42927/#review116969 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2016, 12:05 a.m.,

Re: Review Request 42794: URL query string order is defined.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review116971 --- Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (line

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116966 --- Ship it! Ship It! - Kapil Arya On Jan. 28, 2016, 12:59

Re: Review Request 42957: Added remove() calls to process::Help.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- (Updated Jan. 29, 2016, 10:30 p.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

2016-01-29 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/ --- (Updated Jan. 29, 2016, 11:16 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42956: Added variadic template for process::await.

2016-01-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42956/#review117061 --- LGTM, but it would be nice to include a pointer to the GCC bug

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42990/ --- (Updated Jan. 29, 2016, 6:55 p.m.) Review request for mesos. Summary

Review Request 42981: Rename `IO::DUPLICATE` to avoid conflict with Windows macro.

2016-01-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42981/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Repository:

Re: Review Request 42539: Support image specified Entrypoint and Cmd.

2016-01-29 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42539/ --- (Updated Jan. 29, 2016, 2:15 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- (Updated Jan. 30, 2016, midnight) Review request for mesos and Joris Van

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42990/ --- (Updated Jan. 29, 2016, 7 p.m.) Review request for mesos. Repository: mesos

Re: Review Request 42955: Added variadic template for process::collect.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42955/ --- (Updated Jan. 29, 2016, 10:34 p.m.) Review request for mesos, Jie Yu, Joris

Review Request 42980: Increased the default registry_store_timeout.

2016-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42980/ --- Review request for mesos, David Robinson and Vinod Kone. Repository: mesos

Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

2016-01-29 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4489

Review Request 42986: Updated webui to show count for tasks in `TASK_RUNNING` state.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42986/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Bugs:

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42990/ --- (Updated Jan. 29, 2016, 7:05 p.m.) Review request for mesos. Repository:

Re: Review Request 42928: Updated docker_build.sh to generate xml output for all OSes.

2016-01-29 Thread Vinod Kone
> On Jan. 29, 2016, 12:11 a.m., Anand Mazumdar wrote: > > Can we also set up the Jenkins xUnit Plugin to find the XML files we are > > now generating? AFAICT, we don't seem to be doing that currently. Yes. Tracked at https://issues.apache.org/jira/browse/MESOS-4258. - Vinod

Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4546

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/#review117063 --- src/zookeeper/group.cpp (line 366)

Review Request 42997: [6 of 7] Offer shareable resources to frameworks only if opted in.

2016-01-29 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42997/ --- Review request for mesos and Adam B. Bugs: MESOS-4325

Review Request 42995: [4 of 7] Allow tasks to set persistent volume as readonly or readwrite resource.

2016-01-29 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42995/ --- Review request for mesos and Adam B. Bugs: MESOS-4324

Review Request 42996: [5 of 7] Add unit tests for sharing of resources.

2016-01-29 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42996/ --- Review request for mesos and Adam B. Bugs: MESOS-4324

Review Request 42998: [7 of 7] Added docs for shareable resources.

2016-01-29 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42998/ --- Review request for mesos and Adam B. Bugs: MESOS-4325

Re: Review Request 42956: Added variadic template for process::await.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42956/ --- (Updated Jan. 30, 2016, 1:43 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 42956: Added variadic template for process::await.

2016-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42956/#review117078 --- Ship it! Thanks for fixing this debt!

Re: Review Request 42955: Added variadic template for process::collect.

2016-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42955/#review117077 --- Ship it! Thanks for fixing this debt!

Re: Review Request 42956: Added variadic template for process::await.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42956/ --- (Updated Jan. 29, 2016, 10:35 p.m.) Review request for mesos, Jie Yu, Joris

Re: Review Request 42980: Increased the default registry_store_timeout.

2016-01-29 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42980/#review117040 --- Ship it! Ship It! - David Robinson On Jan. 29, 2016, 10:46

Review Request 43001: Ignored empty NetworkSettings.IPAddress from docker inspect.

2016-01-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43001/ --- Review request for mesos, Kapil Arya and Timothy Chen. Bugs: MESOS-4563

Re: Review Request 42539: Support image specified Entrypoint and Cmd.

2016-01-29 Thread Gilbert Song
> On Jan. 28, 2016, 6:48 p.m., haosdent huang wrote: > > src/launcher/executor.cpp, line 269 > > > > > > I could understand we need TaskCommand to combine different things. But > > because the interface is `void

Review Request 42987: Renamed a parameter for the sake of clarity.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42987/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- (Updated Jan. 29, 2016, 11:57 p.m.) Review request for mesos and Joris Van

Review Request 42993: [2 of 7] Support for multiple frameworks sharing the same resource.

2016-01-29 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42993/ --- Review request for mesos and Adam B. Bugs: MESOS-4431

Review Request 42992: [1 of 7] Support sharing of resources through reference counting of resources.

2016-01-29 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/ --- Review request for mesos and Adam B. Bugs: MESOS-4431

Review Request 42994: [3 of 7] Added a persistent volume test framework for shared volumes.

2016-01-29 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42994/ --- Review request for mesos and Adam B. Bugs: MESOS-4431

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/ --- (Updated Jan. 30, 2016, 1:16 a.m.) Review request for mesos and Joris Van

Re: Review Request 42955: Added variadic template for process::collect.

2016-01-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42955/#review117060 --- LGTM, but it would be nice to include a pointer to the GCC bug

Re: Review Request 42981: Rename `IO::DUPLICATE` to avoid conflict with Windows macro.

2016-01-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42981/#review117072 --- Ship it! Ship It! - Joseph Wu On Jan. 29, 2016, 4:30 p.m.,

Re: Review Request 42955: Added variadic template for process::collect.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42955/ --- (Updated Jan. 30, 2016, 1:43 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-01-29 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42557/ --- (Updated Jan. 30, 2016, 2:06 a.m.) Review request for mesos and Jie Yu.

Review Request 43003: Moved Appc spec protobuf messages to its own file.

2016-01-29 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43003/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 42841: WIP: Introducing appc image fetcher.

2016-01-29 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Jan. 30, 2016, 2:07 a.m.) Review request for Jie Yu. Repository:

Re: Review Request 42981: Rename `IO::DUPLICATE` to avoid conflict with Windows macro.

2016-01-29 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42981/#review117080 --- Ship it! Ship It! - Michael Park On Jan. 30, 2016, 12:30

Re: Review Request 43003: Moved Appc spec protobuf messages to its own file.

2016-01-29 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43003/ --- (Updated Jan. 30, 2016, 2:13 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42998: [7 of 7] Added docs for shareable resources.

2016-01-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42998/#review117096 --- Bad patch! Reviews applied: [42992] Failed command:

Re: Review Request 42998: [7 of 7] Added docs for shareable resources.

2016-01-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42998/#review117099 --- docs/shareable-resources.md (line 19)

Re: Review Request 43001: Ignored empty NetworkSettings.IPAddress from docker inspect.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43001/#review117079 --- Ship it! Ship It! - Kapil Arya On Jan. 29, 2016, 9:03 p.m.,

Re: Review Request 42990: Suppressed AngularJS "Interpolation Error" in browser console.

2016-01-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42990/#review117081 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 42988: Changed ZooKeeper reconnection logic to retry more aggressively.

2016-01-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42988/#review117093 --- Patch looks great! Reviews applied: [42987, 42988] Passed

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

2016-01-29 Thread Avinash sridharan
> On Jan. 15, 2016, 6 a.m., Cong Wang wrote: > > Why do we need netcls to regulate framework traffic on a per-container > > basis? Given the fact that a) the port range based filters already work and > > the code (see egress fq_codel) already exists b) we only have port range > > based

Re: Review Request 42992: [1 of 7] Support sharing of resources through reference counting of resources.

2016-01-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/#review117089 --- I think that you also need to update all of the summary of the

Re: Review Request 42992: [1 of 7] Support sharing of resources through reference counting of resources.

2016-01-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/#review117085 --- Just some early comments, I was that most of your comments do not

Re: Review Request 42980: Increased the default registry_store_timeout.

2016-01-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42980/#review117039 --- Ship it! Ship It! - Vinod Kone On Jan. 29, 2016, 10:46

Review Request 42990: Suppressed Interpolation Error in browser console.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42990/ --- Review request for mesos. Repository: mesos Description --- Suppressed

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

2016-01-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/#review117075 --- Bad patch! Reviews applied: [42947] Failed command:

Re: Review Request 42538: Supported image specified env var.

2016-01-29 Thread Gilbert Song
> On Jan. 29, 2016, 11:09 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 931 > > > > > > s/Overwrting/Overwriting/g > > > > I also wonder if this is too verbose? Should

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 9:31 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-29 Thread Kevin Klues
> On Jan. 29, 2016, 1:01 a.m., Kevin Klues wrote: > > Ship It! Actually, would it be possible to make the --no-cache=true option configurable as well? This is useful when running locally to speed up the build process when I know nothing significant has changed. - Kevin

Re: Review Request 42955: Added variadic template for process::collect.

2016-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42955/#review117021 --- Looks good, would be great if you could get some feedback from

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-29 Thread Vinod Kone
> On Jan. 29, 2016, 1:01 a.m., Kevin Klues wrote: > > Ship It! > > Kevin Klues wrote: > Actually, would it be possible to make the --no-cache=true option > configurable as well? This is useful when running locally to speed up the > build process when I know nothing significant has

Re: Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0

2016-01-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42968/#review116979 --- Ship it! Ship It! - Jie Yu On Jan. 29, 2016, 6:32 p.m.,

Re: Review Request 42900: Fixed some typos.

2016-01-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42900/#review116978 --- Ship it! Ship It! - Jie Yu On Jan. 28, 2016, 7:26 a.m.,

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 7:16 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
> On Jan. 29, 2016, 5:56 p.m., Joseph Wu wrote: > > docs/configuration.md, lines 350-352 > > > > > > Does this render correctly for you? Adjacent `` blocks are > > rendered inline. Good catch, thanks Joseph! -

Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42968/ --- Review request for mesos. Bugs: MESOS-4555

Re: Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0

2016-01-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42968/#review116977 --- Ship it! - Benjamin Bannier On Jan. 29, 2016, 7:32 p.m.,

Re: Review Request 42968: Fixed broken build due to signed comparison warning with GCC 5.3.0

2016-01-29 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42968/#review116981 --- Ship it! Thanks Neil. Repeated field should compare with

Re: Review Request 42936: Edited flag help strings for style.

2016-01-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/#review116982 --- Fix it, then Ship it! src/master/main.cpp (line 126)

Review Request 42973: libprocess: Mark some unused function parameters appropriately.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42973/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 42936: Edited flag help strings for style.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/ --- (Updated Jan. 29, 2016, 7:42 p.m.) Review request for mesos and Vinod Kone.

Review Request 42974: libprocess: Remove unused variable.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42974/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 42971: stout: Mark an unused function parameter appropriately.

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42971/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42972/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 42936: Edited flag help strings for style.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42936/ --- (Updated Jan. 29, 2016, 8:02 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

2016-01-29 Thread Anand Mazumdar
> On Jan. 29, 2016, 7:50 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 624 > > > > > > Not yours: Should we add a `CHECK_NOTNULL` before this statement now? >

Re: Review Request 42940: Removed command-line flags from 'logging.md'.

2016-01-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42940/#review117001 --- Ship it! Ship It! - Vinod Kone On Jan. 29, 2016, 2:18 a.m.,

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 8:18 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
> On Jan. 29, 2016, 7:52 p.m., Vinod Kone wrote: > > My only question is about line wrapping. Doesn't seem to be consistent > > across the file. Is the plan to wrap them all at 80 chars? The current wrapping is based on the help strings found in the various `flags.cpp` files. Backticks are

  1   2   >