Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117597 --- src/docker/docker.cpp (line 304)

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117605 --- Patch looks great! Reviews applied: [43136] Passed command:

Re: Review Request 43134: Added output operator for unversioned executor protobuf.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43134/#review117598 --- Patch looks great! Reviews applied: [43134] Passed command:

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117595 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp

Review Request 43135: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Andy Pang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43135/ --- Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Bugs:

Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Andy Pang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/ --- Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117602 --- src/docker/docker.cpp (line 326)

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

2016-02-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review117593 --- Ship it! Ship It! - Bernd Mathiske On Jan. 28, 2016, 4:45

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117609 --- Patch looks great! Reviews applied: [43032] Passed command:

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117608 --- Fix it, then Ship it! Ship It! src/docker/docker.cpp (line

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117600 --- src/docker/docker.cpp (line 316)

Re: Review Request 43003: Moved Appc spec protobuf messages to its own file.

2016-02-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43003/#review117092 --- include/mesos/appc/spec.proto (line 31)

Re: Review Request 42586: Defined the NetClsHandleManager class.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 3, 2016, 8:43 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-02-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review117675 --- Ship it! After previous issues are resolved :-). - Joerg

Re: Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42750/#review117681 --- Ship it! Ship It! - Michael Park On Jan. 25, 2016, 10:49

Re: Review Request 43056: Fixed typo in 'verify_reviews.py'.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43056/#review117682 --- Ship it! Ship It! - Michael Park On Feb. 3, 2016, 9:52

Review Request 43148: Fixed typos in scheduler HTTP API docs.

2016-02-03 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43148/ --- Review request for mesos. Repository: mesos Description --- Fixed typos

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

2016-02-03 Thread Avinash sridharan
> On Feb. 3, 2016, 7:50 a.m., Anand Mazumdar wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, line 58 > > > > > > We generally leave a line before the comment and the TODO to correctly > >

Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-03 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43149/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-4592

Re: Review Request 43144: Added env var to set upper bound on number of worker threads.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review117677 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43149/#review117693 --- Bad patch! Reviews applied: [43149] Failed command:

Re: Review Request 42754: Added support for labels to resource reservations.

2016-02-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/#review117667 --- src/tests/reservation_endpoints_tests.cpp (line 754)

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/#review117678 --- src/slave/main.cpp (line 211)

Re: Review Request 43151: Added 0.27.0 blog post.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43151/#review117685 --- Fix it, then Ship it!

Re: Review Request 43036: Plugged in docker runtime isolator.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43036/ --- (Updated Feb. 3, 2016, 12:41 p.m.) Review request for mesos, Artem

Re: Review Request 43037: Support env var in docker runtime isolator.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43037/ --- (Updated Feb. 3, 2016, 12:41 p.m.) Review request for mesos, Artem

Re: Review Request 43081: Supported entrypoint and cmd in docker runtime isolator.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43081/ --- (Updated Feb. 3, 2016, 12:41 p.m.) Review request for mesos, Artem

Re: Review Request 43022: Added protobuf fields for docker runtime isolator.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43022/ --- (Updated Feb. 3, 2016, 12:41 p.m.) Review request for mesos, Artem

Re: Review Request 43082: Added new flag to command executor for command passing.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43082/ --- (Updated Feb. 3, 2016, 12:42 p.m.) Review request for mesos, Artem

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-02-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review117674 --- docs/reservation.md (line 65)

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/ --- (Updated Feb. 3, 2016, 9:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 3, 2016, 10:14 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43151: Added 0.27.0 blog post.

2016-02-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43151/ --- (Updated Feb. 3, 2016, 5:21 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43151: Added 0.27.0 blog post.

2016-02-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43151/#review117691 --- Fix it, then Ship it!

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-02-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42557/#review117671 --- src/CMakeLists.txt (line 239)

Review Request 43144: Added env var to set upper bound on number of worker threads.

2016-02-03 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- Review request for mesos. Summary (updated) - Added env var

Review Request 43151: Added 0.27.0 blog post.

2016-02-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43151/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review117527 --- src/tests/mesos.hpp (line 839)

Re: Review Request 43148: Fixed typos in scheduler HTTP API docs.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43148/#review117694 --- Ship it! Ship It! - Vinod Kone On Feb. 3, 2016, 10:24 p.m.,

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-02-03 Thread Neil Conway
> On Jan. 29, 2016, 1:25 a.m., Qian Zhang wrote: > > docs/reservation.md, lines 80-81 > > > > > > I understand the two reservations with different labels will not be > > combined. But what about the two reservation

Re: Review Request 43021: Implemented docker runtime isolator interface.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43021/ --- (Updated Feb. 3, 2016, 12:41 p.m.) Review request for mesos, Artem

Re: Review Request 43019: Fixed non-camel case in protobuf field.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43019/ --- (Updated Feb. 3, 2016, 12:41 p.m.) Review request for mesos, Artem

Re: Review Request 43020: Exposed accurate ProvisionInfo to command executor.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43020/ --- (Updated Feb. 3, 2016, 12:41 p.m.) Review request for mesos, Artem

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/ --- (Updated Feb. 3, 2016, 9:11 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/ --- (Updated Feb. 3, 2016, 10:02 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43138: Updated a comment for oversubscribed resources for clarity.

2016-02-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/#review117616 --- src/master/allocator/mesos/hierarchical.cpp (line 514)

Review Request 43138: Updated a comment for oversubscribed resources for clarity.

2016-02-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 42753: Allowed `createLabel` to take an optional "value".

2016-02-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42753/#review117704 --- Ship it! Ship It! - Kapil Arya On Jan. 25, 2016, 6 p.m.,

Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-03 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43165/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-03 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43165/ --- (Updated Feb. 4, 2016, 12:17 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 43083: Supported working dir in docker runtime isolator.

2016-02-03 Thread Gilbert Song
> On Feb. 2, 2016, 4:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1029-1034 > > > > > > We shouldn't allow executor to cd into an arbitrary directory if > > filesystem

Re: Review Request 42753: Allowed `createLabel` to take an optional "value".

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42753/#review117702 --- Ship it! Ship It! - Michael Park On Jan. 25, 2016, 11 p.m.,

Re: Review Request 42754: Added support for labels to resource reservations.

2016-02-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/ --- (Updated Feb. 3, 2016, 11:05 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42752: Fixed some typos in test case comments.

2016-02-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42752/ --- (Updated Feb. 3, 2016, 11:05 p.m.) Review request for mesos and Michael Park.

Review Request 43168: Added working dir flag to command executor.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43168/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Review Request 43166: Renamed 'directory' flag to 'sandbox' in mesos containerizer launch.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43166/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Review Request 43167: Added working dir flag to mesos containerizer launch.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43167/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-02-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/ --- (Updated Feb. 3, 2016, 10:40 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/ --- (Updated Feb. 3, 2016, 10:41 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/ --- (Updated Feb. 3, 2016, 10:40 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/ --- (Updated Feb. 3, 2016, 11:04 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42754: Added support for labels to resource reservations.

2016-02-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/ --- (Updated Feb. 3, 2016, 11:32 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43019: Fixed non-camel case in protobuf field.

2016-02-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43019/#review117711 --- Ship it! Ship It! - Jie Yu On Feb. 3, 2016, 8:41 p.m.,

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/#review117703 --- src/tests/scheduler_tests.cpp (line 201)

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-03 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43149/ --- (Updated Feb. 4, 2016, 12:14 a.m.) Review request for mesos and Benjamin

Re: Review Request 43134: Added output operator for unversioned executor protobuf.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43134/#review117700 --- Ship it! Looks like the output operator for call is already

Re: Review Request 43160: Made `JSON::parse` disallow duplicate keys in stout.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43160/ --- (Updated Feb. 3, 2016, 11:12 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review117723 --- Patch looks great! Reviews applied: [42750, 42751, 42752, 42753,

Re: Review Request 43083: Supported working dir in docker runtime isolator.

2016-02-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43083/ --- (Updated Feb. 3, 2016, 4:49 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 42752: Fixed some typos in test case comments.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42752/#review117699 --- Ship it! Ship It! - Michael Park On Feb. 3, 2016, 5:50

Review Request 43161: Made `JSON::parse` disallow duplicate keys in libprocess.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43161/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Bugs:

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review117729 --- Fix it, then Ship it! docs/reservation.md (line 84)

Re: Review Request 42754: Added support for labels to resource reservations.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/#review117730 --- src/tests/reservation_endpoints_tests.cpp (lines 752 - 757)

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 4, 2016, 1:42 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/ --- (Updated Feb. 4, 2016, 1:48 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Michael Park
> On Feb. 3, 2016, 10:45 p.m., Michael Park wrote: > > src/tests/resources_tests.cpp, line 957 > > > > > > We used to have a `Resources::size()` function which essentially did > > this, but intentionally removed it

Re: Review Request 42615: Cleaned up usage of namespace-qualified identifiers in Mesos.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42615/#review117744 --- Fix it, then Ship it! src/cli/execute.cpp (lines 201 - 203)

Re: Review Request 42616: Cleaned up usage of namespace-qualified identifiers in libprocess.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42616/#review117747 --- Ship it! Ship It! - Michael Park On Feb. 1, 2016, 10:07

Re: Review Request 42617: Cleaned up usage of namespace-qualified identifiers in stout.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/#review117748 --- Ship it! Ship It! - Michael Park On Feb. 1, 2016, 10:07

Re: Review Request 43127: Introduced Appc image cache.

2016-02-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43127/ --- (Updated Feb. 4, 2016, 2:55 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-03 Thread Guangya Liu
> On Feb. 4, 2016, 1:11 a.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2207-2208 > > > > > > Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so > > it's clear that we

Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43107/ --- (Updated Feb. 4, 2016, 1:52 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review117743 --- src/tests/resources_tests.cpp (line 185)

Re: Review Request 42841: WIP: Introducing appc image fetcher.

2016-02-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42841/ --- (Updated Feb. 4, 2016, 2:55 a.m.) Review request for Jie Yu. Changes ---

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43165/#review117759 --- docs/configuration.md (line 1680)

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-03 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43149/#review117725 --- 3rdparty/libprocess/src/process.cpp (line 2203)

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

2016-02-03 Thread Avinash sridharan
> On Feb. 3, 2016, 8:12 p.m., Jie Yu wrote: > > src/slave/constants.cpp, line 55 > > > > > > I am thinking about whether we should introduce a default here or not. > > > > I think I also want the option that

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43165/#review117745 --- Patch looks great! Reviews applied: [43149, 43165] Passed

Re: Review Request 42557: Moved CachedImage to a separate file.

2016-02-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42557/ --- (Updated Feb. 4, 2016, 2:53 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43003: Moved Appc spec proto messages to its own spec file.

2016-02-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43003/ --- (Updated Feb. 4, 2016, 2:52 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43083: Supported working dir in docker runtime isolator.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43083/#review117758 --- Patch looks great! Reviews applied: [43019, 43020, 43021, 43022,

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-03 Thread haosdent huang
> On Feb. 4, 2016, 1:11 a.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2207-2208 > > > > > > Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so > > it's clear that we

Re: Review Request 43161: Made `JSON::parse` disallow duplicate keys in libprocess.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43161/#review117733 --- Patch looks great! Reviews applied: [43159, 43160, 43161]

Re: Review Request 43138: Updated a comment for oversubscribed resources for clarity.

2016-02-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/#review117620 --- Patch looks great! Reviews applied: [42633, 42636, 42657, 42658,

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

2016-02-03 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/#review117161 --- src/tests/slave_recovery_tests.cpp (line 404)

Re: Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs.

2016-02-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42750/#review117626 --- Ship it! Ship It! - Joerg Schad On Jan. 25, 2016, 10:49

Re: Review Request 43151: Added 0.27.0 blog post.

2016-02-03 Thread Kapil Arya
> On Feb. 3, 2016, 5:27 p.m., Benjamin Bannier wrote: > > site/source/blog/2016-02-02-mesos-0-27-0-released.md, line 41 > > > > > > Not sure if the policy is just taking what `git log` reports, but right > > now we

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review117698 --- Fix it, then Ship it! src/tests/resources_tests.cpp (line

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-03 Thread Neil Conway
> On Feb. 3, 2016, 10:45 p.m., Michael Park wrote: > > src/tests/resources_tests.cpp, line 957 > > > > > > We used to have a `Resources::size()` function which essentially did > > this, but intentionally removed it

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41290/#review117684 --- src/tests/containerizer.hpp (line 140)

  1   2   >