Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117792 --- Bad patch! Reviews applied: [43136] Failed command:

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2016-02-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review117796 --- include/mesos/mesos.proto (lines 643 - 649)

Re: Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43183/#review117790 --- Ship it! Please also fill the `Bug` field to `MESOS-4577` in

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/#review113842 --- Patch looks great! Reviews applied: [41871] Passed command:

Re: Review Request 43182: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43182/#review117789 --- Ship it! Actually I not sure whether use a var to replace `2`

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117884 --- Patch looks great! Reviews applied: [43032] Passed command:

Re: Review Request 43082: Added new flag to command executor for command passing.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43082/#review117889 --- Ship it! Ship It! - Jie Yu On Feb. 3, 2016, 8:42 p.m.,

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/#review117882 --- 3rdparty/libprocess/src/help.cpp (line 107)

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Feb. 4, 2016, 9:03 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 4, 2016, 11:11 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43167: Added working dir flag to mesos containerizer launch.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43167/#review117901 --- src/slave/containerizer/mesos/launch.cpp (line 56)

Review Request 43223: Pin intra-package python dependencies to the same internal version

2016-02-04 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43223/ --- Review request for mesos. Repository: mesos Description --- Avoids

Re: Review Request 43081: Supported entrypoint and cmd in docker runtime isolator.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43081/#review117888 --- Ship it! Ship It! - Jie Yu On Feb. 4, 2016, 6:58 p.m.,

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-04 Thread Travis Hegner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- (Updated Feb. 4, 2016, 9:27 p.m.) Review request for mesos, haosdent huang and

Review Request 43207: Don't remove IP from the logger's environment.

2016-02-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43207/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs:

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

2016-02-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41290/ --- (Updated Feb. 4, 2016, 11:12 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43168: Added working dir flag to command executor.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43168/#review117904 --- src/launcher/executor.cpp (line 215)

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Avinash sridharan
> On Feb. 4, 2016, 7:21 p.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 374-395 > > > > > > Hum, I don't think this test fixture is needed. Just create > > handleManager in each test. > >

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Kevin Klues
> On Feb. 4, 2016, 9:12 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/help.cpp, lines 123-129 > > > > > > Is this equivalent to just `return helps.erase(id)`? Yes, these are equivalent. Updated. > On

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- (Updated Feb. 4, 2016, 10:05 p.m.) Review request for mesos, Ben Mahler, Greg

Review Request 43225: Introduced gtest actions for subscribe, sending updates.

2016-02-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43225/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4433

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-02-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/ --- (Updated Feb. 4, 2016, 11:12 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-02-04 Thread Anand Mazumdar
> On Feb. 3, 2016, 11:41 p.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, line 201 > > > > > > s/execCallbacks/executorCallbacks/ Renamed this to `executor` now as per our discussion. > On Feb. 3, 2016,

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

2016-02-04 Thread Anand Mazumdar
> On Feb. 3, 2016, 10:55 p.m., Vinod Kone wrote: > > src/tests/containerizer.hpp, line 140 > > > > > > s/v1callbacks/v1Callbacks/ Modified it to `v1Executors` now. > On Feb. 3, 2016, 10:55 p.m., Vinod Kone wrote:

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review117894 --- Patch looks great! Reviews applied: [42181, 43131, 42844, 42185,

Re: Review Request 43166: Renamed 'directory' flag to 'sandbox' in mesos containerizer launch.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43166/#review117897 --- Ship it! You forgot to modify port mapping tests. I'll fix it

Re: Review Request 43240: Removed implicit, value changing conversion.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/#review117984 --- Patch looks great! Reviews applied: [43240] Passed command:

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Klaus Ma
> On Feb. 4, 2016, 9:38 p.m., Klaus Ma wrote: > > 3rdparty/libprocess/src/process.cpp, line 2211 > > > > > > Just `os::getenv("LIB...")` is OK. > > Maged Michael wrote: > The string is used in two places:

Re: Review Request 43168: Added working dir flag to command executor.

2016-02-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43168/ --- (Updated Feb. 4, 2016, 5:24 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43217: Added ability to return the /help endpoint as a JSON object.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43217/#review117934 --- 3rdparty/libprocess/src/help.cpp (lines 187 - 188)

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Feb. 5, 2016, 2:16 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Guangya Liu
> On 二月 5, 2016, 2:51 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2212-2213 > > > > > > Why not > > > > Option value = os::getenv("LIBPROCESS_MAX_WORKER_THREADS"); I see what

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117953 --- src/docker/docker.cpp (lines 533 - 538)

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/#review117952 --- Patch looks great! Reviews applied: [41288, 43225, 41290, 41291]

Re: Review Request 43200: Updated role documentation.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review117978 --- docs/roles.md (line 21)

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- (Updated Feb. 5, 2016, 7:15 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43083: Supported working dir in docker runtime isolator.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43083/#review117906 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/#review117914 --- Fix it, then Ship it!

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/#review117915 --- Fix it, then Ship it! src/linux/cgroups.cpp (line 2471)

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/ --- (Updated Feb. 5, 2016, 3:08 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43215: Added code to remove a process's endpoint help strings upon termination.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43215/ --- (Updated Feb. 5, 2016, 3:21 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread Andy Pang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43183/ --- (Updated 二月 5, 2016, 1:13 a.m.) Review request for mesos, BenjaminVW

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

2016-02-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/ --- (Updated Feb. 5, 2016, 1:22 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117956 --- src/docker/docker.cpp (lines 540 - 543)

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/#review117957 --- Ship it! We need a centralized solution here. Same as

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- (Updated Feb. 5, 2016, 3:20 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 42754: Added support for labels to resource reservations.

2016-02-04 Thread Neil Conway
> On Feb. 4, 2016, 1:32 a.m., Michael Park wrote: > > src/tests/resources_tests.cpp, line 35 > > > > > > Should come after `std` using declarations. Happy to change this, but I notice that a few other places don't

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/ --- (Updated Feb. 5, 2016, 2:19 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42754: Added support for labels to resource reservations.

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/ --- (Updated Feb. 5, 2016, 2:19 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Shuai Lin
> On Feb. 4, 2016, 7:44 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, line 756 > > > > > > I just found a bug related to removing this env var. > > > > See this:

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review117954 --- lgtm src/tests/master_quota_tests.cpp (line 901)

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/#review117911 --- Patch looks great! Reviews applied: [43177] Passed command:

Re: Review Request 43167: Added working dir flag to mesos containerizer launch.

2016-02-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43167/ --- (Updated Feb. 4, 2016, 5:24 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117936 --- Bad patch! Reviews applied: [43093] Failed command:

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-04 Thread Neil Conway
> On Feb. 3, 2016, 10:45 p.m., Michael Park wrote: > > src/tests/resources_tests.cpp, line 957 > > > > > > We used to have a `Resources::size()` function which essentially did > > this, but intentionally removed it

Re: Review Request 42753: Allowed `createLabel` to take an optional "value".

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42753/ --- (Updated Feb. 5, 2016, 2:18 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42755: Added documentation for labeled reserved resources.

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/ --- (Updated Feb. 5, 2016, 2:18 a.m.) Review request for mesos and Michael Park.

Review Request 43239: Added Resources::size().

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43239/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 42752: Fixed some typos in test case comments.

2016-02-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42752/ --- (Updated Feb. 5, 2016, 2:19 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43207: Don't remove IP from the logger's environment.

2016-02-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43207/#review117945 --- Ship it! As a fix, this seems fine. We should think about a

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review117947 --- The document should also be updated `docs/configuration.md` by

Re: Review Request 43221: Updated Rakefile to support subdirectories in /docs folder.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43221/#review117948 --- site/Rakefile (lines 30 - 37)

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117916 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp

Re: Review Request 43216: Added json() function for jsonification of the global help process.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43216/#review117922 --- 3rdparty/libprocess/src/help.cpp (lines 146 - 160)

Re: Review Request 42791: Added link to HTTP Endpoints doc in home.md.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42791/#review117929 --- Patch looks great! Reviews applied: [42955, 42956, 42957, 43215,

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

2016-02-04 Thread Avinash sridharan
> On Feb. 5, 2016, 12:04 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, line 382 > > > > > > IntervalSet here is not needed. Just do > > > > ``` > > NetClsHandleManager manager( >

Re: Review Request 43217: Added ability to return the /help endpoint as a JSON object.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43217/#review117938 --- 3rdparty/libprocess/src/help.cpp (lines 185 - 192)

Re: Review Request 43239: Added Resources::size().

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43239/#review117944 --- Ship it! I saw the test case was already covered in

Re: Review Request 43239: Added Resources::size().

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43239/#review117943 --- Can you please add a test case for size()? - Guangya Liu On 二月

Re: Review Request 42751: Tweaked some resource test cases.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review117946 --- src/tests/resources_tests.cpp (lines 326 - 327)

Re: Review Request 43217: Added ability to return the /help endpoint as a JSON object.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43217/ --- (Updated Feb. 5, 2016, 3:23 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/#review117958 --- Ship it! Ship It! - Ben Mahler On Feb. 5, 2016, 3:20 a.m.,

Re: Review Request 42911: Removed extra blank line.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42911/#review117819 --- Ship it! Ship It! - Guangya Liu On Jan. 28, 2016, 1:13

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2016-02-04 Thread Klaus Ma
> On Feb. 4, 2016, 7:43 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, lines 643-649 > > > > > > This looks like an internal information, the *source* of a revocable > > resource. While we

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

2016-02-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43149/#review117805 --- 3rdparty/libprocess/src/process.cpp (line 2204)

Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/#review117817 --- Ship it! Ship It! - Guangya Liu On Feb. 3, 2016, 12:39

Re: Review Request 43124: Clarified units (megabytes) for "disk" and "mem" resource types.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43124/#review117818 --- docs/attributes-resources.md (lines 94 - 96)

Re: Review Request 43216: Added json() function for jsonification of the global help process.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43216/ --- (Updated Feb. 5, 2016, 3:22 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 43215: Added code to remove a process's endpoint help strings upon termination.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43215/#review117959 --- Ship it! Ship It! - Ben Mahler On Feb. 5, 2016, 3:21 a.m.,

Re: Review Request 43221: Updated Rakefile to support subdirectories in /docs folder.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43221/#review117970 --- Ship it! site/Rakefile (lines 31 - 34)

Re: Review Request 42791: Added link to HTTP Endpoints doc in home.md.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42791/#review117971 --- Ship it! Ship It! - Ben Mahler On Feb. 5, 2016, 3:28 a.m.,

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review117975 --- 3rdparty/libprocess/src/process.cpp (line )

Re: Review Request 43219: Added unit tests for hitting the /help endpoints of a process.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43219/ --- (Updated Feb. 5, 2016, 3:24 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42791: Added link to HTTP Endpoints doc in home.md.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42791/ --- (Updated Feb. 5, 2016, 3:28 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Shuai Lin
> On Feb. 5, 2016, 3:20 a.m., Till Toenshoff wrote: > > We need a centralized solution here. Same as MESOS-4598 however, this is > > fine for a fix, I believe. > > Till Toenshoff wrote: > ow. please fix this - I totally missed the fact that you are removing the > IP and not the PORT.

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/#review117964 --- src/slave/containerizer/fetcher.cpp (lines 754 - 757)

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/ --- (Updated Feb. 5, 2016, 3:36 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Till Toenshoff
> On Feb. 5, 2016, 3:38 a.m., Till Toenshoff wrote: > > src/slave/containerizer/fetcher.cpp, lines 754-757 > > > > > > Will add a blank line inbetween while committing to give this code some > > air :). > > Shuai

Re: Review Request 42790: Added documentation for all http endpoints.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42790/#review117969 --- Ship it! Ship It! - Ben Mahler On Feb. 5, 2016, 3:26 a.m.,

Re: Review Request 42908: Fixed a flaky test in quota tests.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review117981 --- Patch looks great! Reviews applied: [42908] Passed command:

Re: Review Request 43223: Pin intra-package python dependencies to the same internal version

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43223/#review117982 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 43220: Added script to generate docs from endpoint help strings.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43220/ --- (Updated Feb. 5, 2016, 3:30 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

2016-02-04 Thread Till Toenshoff
> On Feb. 5, 2016, 3:20 a.m., Till Toenshoff wrote: > > We need a centralized solution here. Same as MESOS-4598 however, this is > > fine for a fix, I believe. ow. please fix this - I totally missed the fact that you are removing the IP and not the PORT. - Till

Re: Review Request 43217: Added ability to return the /help endpoint as a JSON object.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43217/#review117961 --- Fix it, then Ship it! 3rdparty/libprocess/src/help.cpp (line

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Maged Michael
> On Feb. 5, 2016, 2:51 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2212-2213 > > > > > > Why not > > > > Option value = os::getenv("LIBPROCESS_MAX_WORKER_THREADS"); > >

Re: Review Request 42790: Added documentation for all http endpoints.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42790/ --- (Updated Feb. 5, 2016, 3:26 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 43216: Added json() function for jsonification of the global help process.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43216/#review117960 --- Ship it! 3rdparty/libprocess/src/help.cpp (lines 135 - 149)

Re: Review Request 43221: Updated Rakefile to support subdirectories in /docs folder.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43221/ --- (Updated Feb. 5, 2016, 3:27 a.m.) Review request for mesos, Ben Mahler, Greg

Review Request 43240: Removed implicit, value changing conversion.

2016-02-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-04 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 5, 2016, 3:39 a.m.) Review request for mesos and Klaus Ma.

  1   2   >