Re: Review Request 40553: Enable mesos tests installation.

2016-02-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review118233 --- Fix it, then Ship it! Thanks a bunch James, this looks great

Re: Review Request 43220: Added script to generate docs from endpoint help strings.

2016-02-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43220/#review118212 --- Ship it! Thanks! I made some minor comments but took care of

Re: Review Request 43328: Title for documentation webpages.

2016-02-08 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review118243 --- We recently added a script to generate markdown files for all

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/#review118210 --- Patch looks great! Reviews applied: [42947] Passed command:

Re: Review Request 43328: Title for documentation webpages.

2016-02-08 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review118237 --- Ship it! Ship It! - Klaus Ma On Feb. 8, 2016, 11:28 p.m.,

Re: Review Request 43324: Updated endpoints/index.md.

2016-02-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43324/#review118209 --- Ship it! docs/endpoints/index.md (lines 12 - 13)

Re: Review Request 43318: Updated release guide to include doxygen site generation.

2016-02-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43318/#review118241 --- Ship it! Ship It! - Ben Mahler On Feb. 8, 2016, 12:41 a.m.,

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

2016-02-08 Thread haosdent huang
> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 160 > > > > > > Why we not use `const` instead of `constexpr` here? > > Joris Van Remoortere wrote:

Re: Review Request 41760: Add initialization method to Anonymous module

2016-02-08 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41760/#review118242 --- I am little concerned about `Flags` being passed to the module.

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

2016-02-08 Thread Joris Van Remoortere
> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 160 > > > > > > Why we not use `const` instead of `constexpr` here? Because a parameter to a

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

2016-02-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43302/#review118215 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 160)

Re: Review Request 43305: Moved systemd executor slice initialization logic.

2016-02-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43305/#review118217 --- src/linux/systemd.cpp (line 150)

Re: Review Request 43319: Remove md files from doxygen.

2016-02-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43319/#review118214 --- Ship it! Ship It! - haosdent huang On Feb. 8, 2016, 12:40

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-08 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 9, 2016, 4:16 a.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 43353: Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43353/#review118359 --- Patch looks great! Reviews applied: [43353] Passed command:

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-02-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review118362 --- I like the reworking of the recover logic, but I'm still unclear

Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-02-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/#review118365 --- Fix it, then Ship it! Looks great! docs/configuration.md

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/ --- (Updated Feb. 9, 2016, 1:49 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 9, 2016, 1:49 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
> On Feb. 9, 2016, 1:10 a.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 948 > > > > > > looks like you forgot to pass "this" to this callback? Good catch. Fixed - Anand

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/ --- (Updated Feb. 9, 2016, 2:32 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/#review118354 --- Patch looks great! Reviews applied: [41288, 43225, 41290, 41291]

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-08 Thread Avinash sridharan
> On Feb. 8, 2016, 8:04 p.m., Avinash sridharan wrote: > > src/slave/slave.cpp, line 3178 > > > > > > Should we be destroying the container on failure of the `Future`? This > > is what we are doing in

Re: Review Request 42516: Add support for user-defined networks.

2016-02-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118349 --- src/docker/docker.cpp (line 525)

Re: Review Request 43201: Updated reservation documentation.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118352 --- Patch looks great! Reviews applied: [43201] Passed command:

Review Request 43353: Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.

2016-02-08 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43353/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4571

Re: Review Request 42689: Clarified a comment that occurs in several test cases.

2016-02-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/#review118360 --- Looks good, but the patch doesn't apply cleanly anymore with

Review Request 43328: Title for documentation webpages.

2016-02-08 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/ --- Review request for mesos and Neil Conway. Bugs: MESOS-4588

Re: Review Request 43328: Title for documentation webpages.

2016-02-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review118236 --- Ship it! Ship It! - haosdent huang On 二月 8, 2016, 3:28

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43316/#review118227 --- Ship it! Ship It! - Bernd Mathiske On Feb. 7, 2016, 10:38

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42983/#review118262 --- src/slave/containerizer/mesos/containerizer.cpp (line 1317)

Re: Review Request 40553: Enable mesos tests installation.

2016-02-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review118249 --- src/tests/script.cpp (line 112)

Re: Review Request 43328: Title for documentation webpages.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review118250 --- Patch looks great! Reviews applied: [43328] Passed command:

Re: Review Request 43199: Updated authorization documentation.

2016-02-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/ --- (Updated Feb. 8, 2016, 6:40 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43329/#review118269 --- Patch looks great! Reviews applied: [43329] Passed command:

Re: Review Request 43292: Fixed cleanup logic in `cgroups/net_cls` isolator.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43292/#review118257 --- Ship it! Ship It! - Jie Yu On Feb. 7, 2016, 1:09 a.m.,

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/#review118256 --- src/tests/containerizer/isolator_tests.cpp (line 917)

Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

2016-02-08 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43329/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-3775

Re: Review Request 42842: Fixed flakiness in ContainerLoggerTest.DefaultToSandbox

2016-02-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42842/ --- (Updated Feb. 8, 2016, 9:29 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43199: Updated authorization documentation.

2016-02-08 Thread Greg Mann
> On Feb. 6, 2016, 8:02 a.m., Guangya Liu wrote: > > docs/authorization.md, line 50 > > > > > > Do u want to add an example for quota_principals? Good idea! I added examples for quota. Also, after reading through

Re: Review Request 43200: Updated role documentation.

2016-02-08 Thread Greg Mann
> On Feb. 6, 2016, 4:14 a.m., Guangya Liu wrote: > > docs/roles.md, line 132 > > > > > > I think that the principals does not related to the operator of http > > endpoint? The principals specified in the ACLs are

Re: Review Request 43200: Updated role documentation.

2016-02-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/ --- (Updated Feb. 8, 2016, 6:56 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 43322: Exposed `ContainerStatus` in `state.json`.

2016-02-08 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43322/ --- (Updated Feb. 8, 2016, 8:33 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43335: Fixed flaky segfault in DockerFetcherPluginTest.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43335/#review118289 --- Ship it! Ship It! - Jie Yu On Feb. 8, 2016, 8:32 p.m.,

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review118285 --- I realized a tricky part in the recovery path while dealing with

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review118288 --- Patch looks great! Reviews applied: [41958, 41959, 42156, 42157,

Re: Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43286/#review118293 --- Fix it, then Ship it! src/examples/event_call_framework.cpp

Re: Review Request 42782: Added a unit-test to test net_cls primary handles set from command line.

2016-02-08 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/ --- (Updated Feb. 8, 2016, 7:13 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

2016-02-08 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/ --- (Updated Feb. 8, 2016, 7:54 p.m.) Review request for mesos and Jie Yu. Bugs:

Review Request 43336: Introduced Appc image fetcher.

2016-02-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43285: Fixed flakiness in SlaveRecoveryTest/0.CleanupHTTPExecutor.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43285/#review118290 --- Fix it, then Ship it! Great catch! Mystery solved!

Re: Review Request 42782: Added a unit-test to test net_cls primary handles set from command line.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/#review118292 --- Ship it! Ship It! - Jie Yu On Feb. 8, 2016, 7:13 p.m.,

Re: Review Request 42782: Added a unit-test to test net_cls primary handles set from command line.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42782/#review118291 --- src/tests/containerizer/isolator_tests.cpp (line 1000)

Re: Review Request 43288: Re-enabled test ExamplesTest.EventCallFramework.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43288/#review118295 --- Ship it! Ship It! - Vinod Kone On Feb. 6, 2016, 5:51 p.m.,

Re: Review Request 43287: Replaced naked pointer with Owned.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43287/#review118294 --- Ship it! Ship It! - Vinod Kone On Feb. 6, 2016, 5:51 p.m.,

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42982/#review118261 --- Fix it, then Ship it!

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42947/#review118260 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp

Re: Review Request 43308: Added systemd life-extension option to container logrotate module.

2016-02-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43308/#review118278 --- Ship it! LGTM! - Joseph Wu On Feb. 7, 2016, 5:57 a.m.,

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-08 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42982/ --- (Updated Feb. 8, 2016, 7:19 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43328: Title for documentation webpages.

2016-02-08 Thread Abhishek Dasgupta
> On Feb. 8, 2016, 4:47 p.m., Kevin Klues wrote: > > We recently added a script to generate markdown files for all http > > endpoints in the master and agent. We then commit these back to the repo. > > We probably need to modify this script to insert this header as well as > > update the

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-08 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42983/ --- (Updated Feb. 8, 2016, 8:17 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43198: Added common appc spec utilities.

2016-02-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43198/ --- (Updated Feb. 8, 2016, 8:27 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43200: Updated role documentation.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review118282 --- Patch looks great! Reviews applied: [43199, 43200] Passed

Re: Review Request 42842: Fixed flakiness in ContainerLoggerTest.DefaultToSandbox

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42842/#review118274 --- Bad patch! Reviews applied: [42842] Failed command:

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

2016-02-08 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43096/ --- (Updated Feb. 8, 2016, 7:16 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43286/ --- (Updated Feb. 8, 2016, 10:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 8, 2016, 10:15 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
> On Feb. 8, 2016, 10 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 960 > > > > > > s/executor_/executor/ > > > > we typically don't use underscores for member variables. Our style guide does

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/#review118312 --- src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-08 Thread Ian Downes
> On Feb. 8, 2016, 2:47 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines > > 132-134 > > > > > > I think you should discard the future and let it do the correct

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/#review118314 --- src/linux/perf.cpp (lines 423 - 426)

Re: Review Request 42757: Split os::memory() out into platform specific files.

2016-02-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42757/#review118301 --- Ship it! Ship It! - Ian Downes On Feb. 5, 2016, 9:35 a.m.,

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/#review118309 --- src/tests/scheduler_tests.cpp (lines 252 - 258)

Re: Review Request 43225: Introduced gtest actions for subscribe, sending updates.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43225/#review118304 --- src/tests/mesos.hpp (lines 964 - 1021)

Re: Review Request 42735: Make bash scripts portable.

2016-02-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/#review118297 --- Ship it! Ship It! - Ian Downes On Feb. 5, 2016, 8:51 a.m.,

Re: Review Request 42156: Refactored up the common image creation in appc tests.

2016-02-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42156/#review118296 --- Ship it! Ship It! - Jie Yu On Feb. 6, 2016, 1:35 a.m., Jojy

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review118299 --- src/tests/mesos.hpp (line 937)

Re: Review Request 43285: Fixed flakiness in SlaveRecoveryTest/0.CleanupHTTPExecutor.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43285/ --- (Updated Feb. 8, 2016, 10:04 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41290/#review118306 --- src/tests/containerizer.hpp (line 140)

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 9, 2016, 12:12 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43225: Introduced gtest actions for subscribe, sending updates.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43225/ --- (Updated Feb. 9, 2016, 12:12 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43225: Introduced gtest actions for subscribe, sending updates.

2016-02-08 Thread Anand Mazumdar
> On Feb. 8, 2016, 10:12 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, lines 964-1021 > > > > > > put these (using statement and actions) in v1 namespace? Added a `TODO` as per our discussion to move these

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/ --- (Updated Feb. 9, 2016, 12:14 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41290/ --- (Updated Feb. 9, 2016, 12:13 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43200: Updated role documentation.

2016-02-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review118335 --- Ship it! Ship It! - Guangya Liu On 二月 8, 2016, 6:56 p.m.,

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

2016-02-08 Thread Vinod Kone
> On Feb. 6, 2016, 2:26 p.m., Klaus Ma wrote: > > src/slave/http.cpp, line 402 > > > > > > For GUI developer, it's better to export more info when it's > > recovering, e.g. build_time, build_date. So I'd like to

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43267/ --- (Updated Feb. 9, 2016, 12:40 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

2016-02-08 Thread Vinod Kone
> On Feb. 7, 2016, 9:48 p.m., Anand Mazumdar wrote: > > src/tests/slave_tests.cpp, line 1339 > > > > > > Can we just do: > > > > `TestContainerizer containerizer1;` similar to what we do a few lines > >

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43267/#review118339 --- Ship it! LGTM - Anand Mazumdar On Feb. 9, 2016, 12:40 a.m.,

Review Request 43344: Added flag `--cgroups_net_cls_primary_handle`.

2016-02-08 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43344/ --- Review request for mesos, Jie Yu and Neil Conway. Bugs: MESOS-4622

Re: Review Request 43200: Updated role documentation.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review118327 --- Ship it! Ship It! - Vinod Kone On Feb. 8, 2016, 6:56 p.m.,

Re: Review Request 43199: Updated authorization documentation.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/#review118325 --- docs/authorization.md (lines 98 - 101)

Re: Review Request 43201: Updated reservation documentation.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118328 --- Fix it, then Ship it! docs/reservation.md (line 44)

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review118340 --- Fix it, then Ship it! src/tests/mesos.hpp (line 948)

Re: Review Request 43225: Introduced gtest actions for subscribe, sending updates.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43225/#review118341 --- Ship it! Ship It! - Vinod Kone On Feb. 9, 2016, 12:12 a.m.,

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41291/#review118343 --- Ship it! Ship It! - Vinod Kone On Feb. 9, 2016, 12:14 a.m.,

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41290/#review118342 --- Ship it! Ship It! - Vinod Kone On Feb. 9, 2016, 12:13 a.m.,

Re: Review Request 43344: Added flag `--cgroups_net_cls_primary_handle`.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43344/#review118344 --- Patch looks great! Reviews applied: [43344] Passed command: