Re: Review Request 43487: Add TASK_KILLING state.

2016-02-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43487/#review118987 --- include/mesos/mesos.proto (line )

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review118989 --- Ship it! I'll go ahead and make the fix for the above issue,

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Guangya Liu
> On 二月 12, 2016, 9:35 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, lines 136-171 > > > > > > How about the following to simplify the logic and make it consistent > >

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43520/#review118991 --- Patch looks great! Reviews applied: [43520] Passed command:

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43519/#review118986 --- Patch looks great! Reviews applied: [43518, 43519] Passed

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review118988 --- 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp

Re: Review Request 43525: Fixed an unsigned<->signed comparison.

2016-02-12 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43525/ --- (Updated Feb. 12, 2016, 12:47 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43487: Add TASK_KILLING state.

2016-02-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43487/#review118994 --- Thanks Abhishek! Please also do the following in this patch: *

Re: Review Request 43490: Added testcase for TASK_KILLING state.

2016-02-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review118992 --- src/tests/scheduler_tests.cpp (lines 476 - 483)

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

2016-02-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43524/#review118998 --- src/tests/log_tests.cpp (line 1868)

Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

2016-02-12 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43524/ --- Review request for mesos and haosdent huang. Bugs: MESOS-4160

Re: Review Request 43523: Speed up SlaveTest.MetricsSlaveLaunchErrors.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43523/#review119003 --- Patch looks great! Reviews applied: [43523] Passed command:

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Shuai Lin
> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/ --- (Updated Feb. 12, 2016, 12:15 p.m.) Review request for mesos and Alexander

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

2016-02-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43488/#review118996 --- include/mesos/mesos.proto (line 261)

Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43522/#review119000 --- Patch looks great! Reviews applied: [43521, 43522] Passed

Review Request 43525: Fixed an unsigned<->signed comparison.

2016-02-12 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43525/ --- Review request for mesos, Bernd Mathiske and Michael Park. Repository: mesos

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43524/#review119004 --- Patch looks great! Reviews applied: [43524] Passed command:

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-12 Thread Guangya Liu
On 二月 9, 2016, 7:13 p.m., Travis Hegner wrote: > > hanks > > Joerg Schad wrote: > Oh btw regarding the commit message: > We usually have commit messages stating what changed, so in your case it > could be something along the lines of 'Added support for new docker network > setting.' >

Re: Review Request 43499: Improved docs for writing HA frameworks.

2016-02-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43499/#review119009 --- Ship it! Ship It! - Guangya Liu On 二月 11, 2016, 8:21 p.m.,

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review119014 --- src/docker/docker.cpp (line 539)

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

2016-02-12 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43524/ --- (Updated Feb. 12, 2016, 2:47 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

2016-02-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43524/#review119022 --- Ship it! Ship It! - haosdent huang On Feb. 12, 2016, 2:47

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

2016-02-12 Thread Klaus Ma
> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote: > > src/master/master.cpp, lines 3770-3779 > > > > > > It should still be invalid to supply both a CommandInfo and > > ExecutorInfo in the same TaskInfo. The check

Re: Review Request 43525: Fixed an unsigned<->signed comparison.

2016-02-12 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43525/#review119027 --- Ship it! Ship It! - Bernd Mathiske On Feb. 12, 2016, 3:47

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review119006 --- Fix it, then Ship it! Ship It! src/tests/scheduler_tests.cpp

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Shuai Lin
> On Feb. 12, 2016, 1:36 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 896 > > > > > > s/dispatch/dispatched > > > > s/recoverResources/`recoverResources` - `the dispatch event` is used

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/ --- (Updated Feb. 12, 2016, 1:48 p.m.) Review request for mesos and Alexander

Re: Review Request 43525: Fixed an unsigned<->signed comparison.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43525/#review119024 --- Patch looks great! Reviews applied: [43525] Passed command:

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

2016-02-12 Thread Klaus Ma
> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote: > > src/master/master.cpp, line 2860 > > > > > > `launcher_dir` is an optional field. > > > > Same for the other fields you added (`sandbox_dir`,

Review Request 43523: Speed up SlaveTest.MetricsSlaveLaunchErrors.

2016-02-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43523/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4162

Re: Review Request 39968: Enabled http endpoint include nested paths.

2016-02-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39968/#review118990 --- Ship it! 3rdparty/libprocess/src/tests/http_tests.cpp (lines

Re: Review Request 42516: Add support for user-defined networks.

2016-02-12 Thread Travis Hegner
> On Feb. 12, 2016, 3:25 p.m., Travis Hegner wrote: > > Please have a look at https://reviews.apache.org/r/43093/. Should these > > patches be combined, or worked on together? Adding support for user defined > > networks, should also include support for proper IP address detection via > >

Re: Review Request 42516: Add support for user-defined networks.

2016-02-12 Thread Ezra Silvera
> On Feb. 12, 2016, 3:25 p.m., Travis Hegner wrote: > > Please have a look at https://reviews.apache.org/r/43093/. Should these > > patches be combined, or worked on together? Adding support for user defined > > networks, should also include support for proper IP address detection via > >

Re: Review Request 43524: Speeded up RecoverTest.AutoInitialization by advacing the clock.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43524/#review119045 --- Patch looks great! Reviews applied: [43524] Passed command:

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review119039 --- src/docker/docker.cpp (line 536)

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review119040 --- Patch looks great! Reviews applied: [43321] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

2016-02-12 Thread Travis Hegner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review119031 --- Please have a look at https://reviews.apache.org/r/43093/. Should

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review119051 --- 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp (line

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41308/#review115114 --- Bad patch! Reviews applied: [41302, 41305] Failed command:

Review Request 43536: Removed unnecessary comment from master.hpp.

2016-02-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43536/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 43371: Cleaned up docker Image::Name proto by ImageReference.

2016-02-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43371/ --- (Updated Feb. 12, 2016, 11:10 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Jie Yu
> On Feb. 12, 2016, 7:05 p.m., Jie Yu wrote: > > we should ignore the comment lines, instead of relax this check > > Cong Wang wrote: > No, the comment is at the end of the "nameserver" line, not separated. oh, ic, got it. - Jie

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/#review119072 --- Ship it! Ship It! - Jie Yu On Feb. 12, 2016, 6:57 p.m.,

Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/ --- Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/#review119065 --- we should ignore the comment lines, instead of relax this check

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Cong Wang
> On Feb. 12, 2016, 7:05 p.m., Jie Yu wrote: > > we should ignore the comment lines, instead of relax this check No, the comment is at the end of the "nameserver" line, not separated. - Cong --- This is an automatically generated

Re: Review Request 43535: Fixed name server parsing for PortMappingIsolatorTest.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43535/#review119073 --- Patch looks great! Reviews applied: [43535] Passed command:

Re: Review Request 43118: Improved docs for volume/reservation HTTP endpoints.

2016-02-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/ --- (Updated Feb. 12, 2016, 7:54 p.m.) Review request for mesos, Greg Mann and Jie

Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/ --- (Updated Feb. 12, 2016, 7:56 p.m.) Review request for mesos and Adam B.

Re: Review Request 41760: Add initialization method to Anonymous module

2016-02-12 Thread Marco Massenzio
> On Feb. 8, 2016, 4:53 p.m., Kapil Arya wrote: > > I am little concerned about `Flags` being passed to the module. Since there > > is no visibility about the allowed master/agent flags from the module's > > perspective, how does it cope with the changes to master/slave flags? Would > > we

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review119139 --- Bad patch! Reviews applied: [41096, 41185, 41108] Failed

Re: Review Request 41854: Added module initialization to Master main() method

2016-02-12 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/ --- (Updated Feb. 13, 2016, 6:32 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 41854: Added module initialization to Master main() method

2016-02-12 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/ --- (Updated Feb. 13, 2016, 7:02 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 42589: Added test case for allocator recover with Quota.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/#review119138 --- Patch looks great! Reviews applied: [42535, 42589] Passed

Re: Review Request 41760: Add initialization method to Anonymous class.

2016-02-12 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41760/ --- (Updated Feb. 13, 2016, 6:24 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 41854: Added module initialization to Master main() method

2016-02-12 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/ --- (Updated Feb. 13, 2016, 6:59 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

2016-02-12 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/ --- (Updated Feb. 13, 2016, 4:23 a.m.) Review request for mesos, Artem

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review119141 --- Patch looks great! Reviews applied: [40951, 41090, 41092]

Re: Review Request 43555: Removed extra blank line in strings_tests.cpp.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43555/#review119135 --- Patch looks great! Reviews applied: [43555] Passed command:

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/#review119081 --- Fix it, then Ship it! Looks great (besides the ambiguous

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- (Updated Feb. 12, 2016, 9:46 p.m.) Review request for mesos and Jie Yu.

Review Request 43542: Updated CHANGELOG for reservation labels.

2016-02-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43542/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.

2016-02-12 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43414/#review119096 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:13 a.m.,

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

2016-02-12 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43413/#review119095 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:03 a.m.,

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

2016-02-12 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43409/#review119093 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 6:44 a.m.,

Re: Review Request 43536: Removed unnecessary comment from master.hpp.

2016-02-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43536/#review119104 --- Ship it! Ship It! - Kevin Klues On Feb. 12, 2016, 6:57

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/ --- (Updated Feb. 12, 2016, 10:59 p.m.) Review request for mesos and Adam B.

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/ --- (Updated Feb. 12, 2016, 11:05 p.m.) Review request for mesos and Adam B.

Review Request 43546: Added common compression utilities.

2016-02-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43546/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/ --- (Updated Feb. 12, 2016, 11:01 p.m.) Review request for mesos and Adam B.

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/ --- (Updated Feb. 12, 2016, 11:06 p.m.) Review request for mesos and Adam B.

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

2016-02-12 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/#review119092 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 11:36 p.m.,

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/ --- (Updated Feb. 12, 2016, 11:03 p.m.) Review request for mesos and Adam B.

Re: Review Request 43118: Improved docs for volume/reservation HTTP endpoints.

2016-02-12 Thread Neil Conway
> On Feb. 12, 2016, 8:08 p.m., Greg Mann wrote: > > docs/endpoints/master/create-volumes.md, lines 10-13 > > > > > > Should we be editing the help strings in the code rather than these > > markdown files? The note

Re: Review Request 43536: Removed unnecessary comment from master.hpp.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43536/#review119087 --- Patch looks great! Reviews applied: [43536] Passed command:

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-12 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/#review119091 --- Ship it! Ship It! - M Lawindi On Feb. 10, 2016, 7:13 a.m.,

Re: Review Request 43410: Windows: Added support for dynamic library loading.

2016-02-12 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/#review119099 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 6:01 p.m.,

Re: Review Request 43371: Cleaned up docker Image::Name proto by ImageReference.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43371/#review119089 --- Ship it! Ship It! - Jie Yu On Feb. 12, 2016, 7:17 p.m.,

Re: Review Request 43118: Improved docs for volume/reservation HTTP endpoints.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/#review119088 --- Ship it! Ship It! - Jie Yu On Feb. 12, 2016, 7:54 p.m.,

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

2016-02-12 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/#review119097 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:13 a.m.,

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Michael Park
> On Feb. 12, 2016, 8:13 p.m., Adam B wrote: > > site/source/blog/2016-02-12-announcing-mesoscon-north-america-2016.md, line > > 25 > > > > > > Reach out to whom? dev@ or MesosCon PMC or Mesosphere? > > Maybe

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-12 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/#review119098 --- Ship it! Ship It! - Yi Sun On Feb. 10, 2016, 7:13 a.m.,

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Adam B
> On Feb. 12, 2016, 12:13 p.m., Adam B wrote: > > site/source/blog/2016-02-12-announcing-mesoscon-north-america-2016.md, line > > 25 > > > > > > Reach out to whom? dev@ or MesosCon PMC or Mesosphere? > > Maybe

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119112 --- Patch looks great! Reviews applied: [41958, 41959, 43546, 43336]

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119133 --- Patch looks great! Reviews applied: [41958, 41959, 43546, 43336]

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/#review119090 --- include/mesos/mesos.proto (line 688)

Re: Review Request 43546: Added common compression utilities.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43546/#review119100 --- Fix it, then Ship it! src/common/command_utils.hpp (line 79)

Re: Review Request 43546: Added common compression utilities.

2016-02-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43546/ --- (Updated Feb. 13, 2016, 1:42 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- (Updated Feb. 13, 2016, 1:43 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43546: Added common compression utilities.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43546/#review119124 --- src/common/command_utils.cpp (line 209)

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Guangya Liu
> On 二月 12, 2016, 6:13 p.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp, line 219 > > > > > > Whitespace error. I was following the style of

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/#review119109 --- site/source/index.html.md (line 35)

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119123 --- src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp (line

Review Request 43555: Removed extra blank line in strings_tests.cpp.

2016-02-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43555/ --- Review request for mesos, Ben Mahler and Neil Conway. Repository: mesos

Re: Review Request 42589: Added test case for allocator recover with Quota.

2016-02-12 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/ --- (Updated Feb. 13, 2016, 11:15 a.m.) Review request for mesos, Alexander

Re: Review Request 43540: Added 'Announcing MesosCon North America 2016' blog post.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/#review119122 --- Patch looks great! Reviews applied: [43540] Passed command:

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

2016-02-12 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Feb. 13, 2016, 3:53 a.m.) Review request for mesos, Artem

Re: Review Request 42516: Add support for user-defined networks.

2016-02-12 Thread Guangya Liu
> On 二月 12, 2016, 3:25 p.m., Travis Hegner wrote: > > Please have a look at https://reviews.apache.org/r/43093/. Should these > > patches be combined, or worked on together? Adding support for user defined > > networks, should also include support for proper IP address detection via > > those

  1   2   >