Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119425 --- Patch looks great! Reviews applied: [43608, 42696, 43367]

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119427 --- Ship it! Now without the checkpointing-related code which went

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 17, 2016, 9:54 a.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread haosdent huang
> On Feb. 17, 2016, 5:10 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 194 > > > > > > Can you please summary the discussion of you and bernd-mesos for why > > not using `Clock::settle()` so

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119434 --- src/tests/fetcher_cache_tests.cpp (line 197)

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread haosdent huang
> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 197 > > > > > > Having run multiple test suite runs, I am not convinced this has much > > of an effect. I got

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119436 --- src/tests/fetcher_cache_tests.cpp (lines 194 - 196)

Re: Review Request 42842: Fixed flakiness in ContainerLoggerTest.DefaultToSandbox.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42842/#review119461 --- Ship it! Ship It! - Bernd Mathiske On Feb. 10, 2016, 9:49

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43608/#review119462 --- Are a couple of seconds wirth the extra code complexity?

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Bernd Mathiske
> On Feb. 17, 2016, 2:09 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 197 > > > > > > Having run multiple test suite runs, I am not convinced this has much > > of an effect. I got results

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-17 Thread Timothy Chen
> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 161-162 > > > > > > Can you wrap using 70 char width here? Sure, I thought we removed that restriction now? - Timothy

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review119464 --- src/tests/cluster.hpp (line 77)

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

2016-02-17 Thread haosdent huang
> On Feb. 17, 2016, 3:21 p.m., Bernd Mathiske wrote: > > Are a couple of seconds wirth the extra code complexity? Opinions, please! Yes, @bernd, as you see here, this patch don't bring too much effects. How about let's discard it and reopen it if really necessary? - haosdent

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

2016-02-17 Thread Bernd Mathiske
> On Feb. 17, 2016, 7:21 a.m., Bernd Mathiske wrote: > > Are a couple of seconds wirth the extra code complexity? Opinions, please! > > haosdent huang wrote: > Yes, @bernd, as you see here, this patch don't bring too much effects. > How about let's discard it and reopen it if really

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread haosdent huang
> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 197 > > > > > > Having run multiple test suite runs, I am not convinced this has much > > of an effect. I got

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-17 Thread Timothy Chen
> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 473-488 > > > > > > There's a os::exists check in linux fs isolator which you removed. This > > is fine because we won't

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-17 Thread Timothy Chen
> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 413-414 > > > > > > Should we ignore those volumes that have absolute/nested container path > > (like we did in linux fs

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 17, 2016, 4:55 p.m.) Review request for mesos, Alexander

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mark Cavage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- (Updated Feb. 17, 2016, 4:56 p.m.) Review request for mesos and Benjamin

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mark Cavage
> On Feb. 15, 2016, 6:25 p.m., Benjamin Hindman wrote: > > src/master/contender.cpp, line 80 > > > > > > Why the removal of the `Option`? Conveying the information via an empty > > string is far less explicit and

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-17 Thread Joseph Wu
> On Feb. 17, 2016, 8:32 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 91 > > > > > > What do you mean by "some" of its state? In both of these objects, we don't do everything possible to cleanup.

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119490 --- Patch looks great! Reviews applied: [43608, 42696, 43367]

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-17 Thread Timothy Chen
> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 473-488 > > > > > > There's a os::exists check in linux fs isolator which you removed. This > > is fine because we won't

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-17 Thread Timothy Chen
> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 1701-1708 > > > > > > Why do you need to do this? Looks like we don't mount until pulling is > > done. Am I missing

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-17 Thread Timothy Chen
> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, lines 1785-1790 > > > > > > Hum, I think we shouldn't remove the volumes if the container might be > > still running. So can we

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

2016-02-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119501 --- src/slave/containerizer/docker.cpp (lines 1785 - 1790)

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 17, 2016, 10:25 a.m.) Review request for mesos, Benjamin

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Neil Conway
> On Feb. 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > >

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-17 Thread Neil Conway
> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote: > > src/common/values.cpp, line 67 > > > > > > Let's add check on overflow; it will be helpful if scalar value was > > big. Scalar is a general type, there maybe used

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-17 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/ --- (Updated Feb. 17, 2016, 6:49 p.m.) Review request for mesos, Joris Van

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

2016-02-17 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review119507 --- In general, I prefer scripts with a bunch of helper functions and

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review119512 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43546: Added common compression utilities.

2016-02-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43546/#review119514 --- Ship it! Ship It! - Jie Yu On Feb. 13, 2016, 4:30 p.m.,

Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3570

Review Request 43659: Cleaned up the previous queueing Calls logic.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43659/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3570

Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43664/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3570

Review Request 43661: Added check to not Subscribe if we are already subscribed.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43661/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3570

Review Request 43667: Modified existing scheduler tests as an aftermath of pipelining change.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43667/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3570

Review Request 43660: Renamed Connection to SubscribedResponse.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43660/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3570

Review Request 43658: Modified the received callback argument to be ref.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43658/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3570

Review Request 43657: Fixed MasterDetector pointer leak in scheduler library.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43657/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3570

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 17, 2016, 12:27 p.m.) Review request for mesos, Benjamin

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119520 --- Patch looks great! Reviews applied: [43616] Passed command:

Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-3940

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/ --- (Updated Feb. 17, 2016, 8:45 p.m.) Review request for mesos, Michael Park and

Review Request 43641: Removed unnecessary parameter from validation function.

2016-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43641/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-3940

Review Request 43642: Updated comments and docs for '/reserve' without principal.

2016-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-3940

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119522 --- Ship it! Ship It! - Jie Yu On Feb. 16, 2016, 11:36 p.m.,

Re: Review Request 43642: Updated comments and docs for '/reserve' and '/unreserve' without principal.

2016-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/ --- (Updated Feb. 17, 2016, 8:56 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43642: Updated comments and docs for '/reserve' and '/unreserve' without principal.

2016-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/ --- (Updated Feb. 17, 2016, 8:56 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43672: Introduced `Sequence` in container.

2016-02-17 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43672/ --- (Updated Feb. 17, 2016, 9:28 p.m.) Review request for mesos and Jie Yu.

Review Request 43676: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

2016-02-17 Thread Kevin Devroede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43676/ --- Review request for mesos and haosdent huang. Bugs: MESOS-4693

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mark Cavage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- (Updated Feb. 17, 2016, 10:10 p.m.) Review request for mesos and Benjamin

Re: Review Request 43673: Searialized invocation of `await` in the status method.

2016-02-17 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43673/ --- (Updated Feb. 17, 2016, 10:20 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43673: Searialized invocation of `await` in the status method.

2016-02-17 Thread Avinash sridharan
> On Feb. 17, 2016, 9:18 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1330 > > > > > > Why this change? > > Avinash sridharan wrote: > During debugging was finding it hard to

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-02-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 17, 2016, 2:34 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43642: Updated comments and docs for '/reserve' and '/unreserve' without principal.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/#review119540 --- Bad patch! Reviews applied: [43639, 43641, 43642] Failed

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

2016-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/ --- (Updated Feb. 17, 2016, 10:36 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43664/ --- (Updated Feb. 17, 2016, 10:45 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43667: Modified existing scheduler tests as an aftermath of pipelining change.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43667/ --- (Updated Feb. 17, 2016, 10:46 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43676: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43676/#review119551 --- Patch looks great! Reviews applied: [43676] Passed command:

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks.

2016-02-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41306/ --- (Updated Feb. 18, 2016, 7:45 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

2016-02-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/ --- (Updated Feb. 18, 2016, 7:45 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

2016-02-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41308/ --- (Updated Feb. 18, 2016, 7:45 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo.

2016-02-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41302/ --- (Updated Feb. 18, 2016, 7:46 a.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

2016-02-17 Thread Klaus Ma
> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote: > > General questions: > > > > - Besides removing the possibility for overcommit, does this change give us > > anything else? > > - What happens if a master sends this modified `TaskInfo` to an agent that > > does not have this chain of patches?

Review Request 43684: Cleaned up allocator benchmark code.

2016-02-17 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43684/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Repository:

Review Request 43685: Refactored test helper code.

2016-02-17 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43685/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Repository:

Review Request 43686: Added a benchmark for allocation with labeled resources.

2016-02-17 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43686/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Bugs:

Re: Review Request 43676: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

2016-02-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43676/#review119564 --- Ship it! [~kdevroede] Your patch looks nice. Could you ask

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/ --- (Updated Feb. 18, 2016, 12:59 a.m.) Review request for mesos, Joris Van

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43409/ --- (Updated Feb. 18, 2016, 12:59 a.m.) Review request for mesos, Joris Van

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- (Updated Feb. 18, 2016, 12:59 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/ --- (Updated Feb. 18, 2016, 12:59 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43414/ --- (Updated Feb. 18, 2016, 12:59 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43417/ --- (Updated Feb. 18, 2016, 12:59 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43410: Windows: Added support for dynamic library loading.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/ --- (Updated Feb. 18, 2016, 12:59 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43413/ --- (Updated Feb. 18, 2016, 12:59 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43418/ --- (Updated Feb. 18, 2016, 1:01 a.m.) Review request for mesos, Alex Naparu,

Review Request 43701: Added a command executor based on the new V1 API.

2016-02-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review119567 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

2016-02-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43489/#review119568 --- I see you send TASK_KILLING once the killTask() is invoked.

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Guangya Liu
> On 二月 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > >

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Neil Conway
> On Feb. 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > >

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-17 Thread Guangya Liu
> On 二月 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > > > > > s/Labels/One label? > > > > I think that here we should use `one label` but not `labels`, becauase > >

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/ --- (Updated Feb. 18, 2016, 2:08 a.m.) Review request for mesos, Alex Naparu,

Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43692/ --- (Updated Feb. 18, 2016, 2:26 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43667: Modified existing scheduler tests as an aftermath of pipelining change.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43667/#review119575 --- Patch looks great! Reviews applied: [43657, 43658, 43659, 43660,

Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43693/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43695/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43689: CMake: Begin to require 64-bit builds.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43689/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43700/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 43686: Added a benchmark for allocation with labeled resources.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43686/#review119581 --- Patch looks great! Reviews applied: [43684, 43685, 43686]

Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43699/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43698/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 43657: Fixed MasterDetector pointer leak in scheduler library.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43657/ --- (Updated Feb. 18, 2016, 4:54 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43701: Added a command executor based on the new V1 API.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/#review119583 --- Patch looks great! Reviews applied: [43701] Passed command:

  1   2   >