Re: Review Request 43489: KillTask introduces TASK_KILLING state.

2016-02-19 Thread Qian Zhang
> On Feb. 18, 2016, 9:44 a.m., Qian Zhang wrote: > > I see you send TASK_KILLING once the killTask() is invoked. However, > > according to the description of MESOS-4140, we may need to send such status > > update after SIGTERM is sent to the task and before SIGKILL is sent. So > > maybe you

Re: Review Request 43746: Fixed flaky AvailableResourcesAfterRescinding test.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43746/#review119836 --- Patch looks great! Reviews applied: [43746] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

2016-02-19 Thread Qian Zhang
> On Feb. 19, 2016, 6:44 a.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

2016-02-19 Thread Alexander Rukletsov
> On Feb. 17, 2016, 3:21 p.m., Bernd Mathiske wrote: > > Are a couple of seconds wirth the extra code complexity? Opinions, please! > > haosdent huang wrote: > Yes, @bernd, as you see here, this patch don't bring too much effects. > How about let's discard it and reopen it if really

Re: Review Request 43718: Added fs::supported() function.

2016-02-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119840 --- Ship it! Ship It! - Guangya Liu On 二月 19, 2016, 2:02 a.m.,

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

2016-02-19 Thread Abhishek Dasgupta
> On Feb. 18, 2016, 1:44 a.m., Qian Zhang wrote: > > I see you send TASK_KILLING once the killTask() is invoked. However, > > according to the description of MESOS-4140, we may need to send such status > > update after SIGTERM is sent to the task and before SIGKILL is sent. So > > maybe you

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-19 Thread haosdent huang
> On Feb. 19, 2016, 9:02 a.m., Alexander Rukletsov wrote: > > src/tests/fetcher_cache_tests.cpp, lines 189-191 > > > > > > Will it be more clear to explicitly advance clock in those tests? I > > think keeping

Re: Review Request 43701: Added a command executor based on the new V1 API.

2016-02-19 Thread Qian Zhang
> On Feb. 18, 2016, 1:42 p.m., Jian Qiu wrote: > > src/launcher/http_executor.cpp, line 118 > > > > > > this method and other methods not implementation of the virtual method > > should be private I think other

Re: Review Request 43718: Added fs::supported() function.

2016-02-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119845 --- src/tests/containerizer/fs_tests.cpp (line 49)

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review119839 --- src/tests/hierarchical_allocator_tests.cpp (line 2307)

Re: Review Request 43737: Fixed typo in fetcher docs.

2016-02-19 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43737/#review119846 --- Ship it! Thanks! - Bernd Mathiske On Feb. 18, 2016, 1:17

Re: Review Request 43701: Added a command executor based on the new V1 API.

2016-02-19 Thread Qian Zhang
> On Feb. 19, 2016, 12:07 a.m., Shuai Lin wrote: > > src/slave/flags.cpp, line 693 > > > > > > One space before `\n`, otherwise the word would be mixed with the first > > word of the next line. I do not think we

Re: Review Request 43718: Added fs::supported() function.

2016-02-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119847 --- src/linux/fs.cpp (line 59)

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review119848 --- src/master/allocator/mesos/hierarchical.cpp (lines 1068 - 1070)

Re: Review Request 43718: Added fs::supported() function.

2016-02-19 Thread Guangya Liu
> On 二月 19, 2016, 9:28 a.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 49 > > > > > > I use CentOS 6. But seems don't have `ext2` and `ext3` in > > `/proc/filesystems` > > > > ```

Re: Review Request 43718: Added fs::supported() function.

2016-02-19 Thread haosdent huang
> On Feb. 19, 2016, 9:28 a.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 49 > > > > > > I use CentOS 6. But seems don't have `ext2` and `ext3` in > > `/proc/filesystems` > > > >

Re: Review Request 43754: WIP: Enhance allocator performance.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43754/#review119853 --- Patch looks great! Reviews applied: [43754] Passed command:

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

2016-02-19 Thread Adam B
> On Feb. 19, 2016, 1:31 a.m., Alexander Rukletsov wrote: > > Yongqiao, since Alex didn't get his review in before I committed the patch, could you create a new patch addressing his feedback and link to it from the comments here? Thanks. - Adam

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review119857 --- I'd suggest splitting the patch into three parts: authz-related +

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

2016-02-19 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43271/#review119851 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 262)

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review119861 --- Patch looks great! Reviews applied: [42241] Passed command:

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-19 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review119858 --- First pass. Sorry, did not get through it in one seating.

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-19 Thread Abhishek Dasgupta
> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 536 > > > > > > Seems like we're increasing trying to find docker versions in our code > > base. How about let's capture the docker

Re: Review Request 43715: Title for endpoint documentation.

2016-02-19 Thread Abhishek Dasgupta
> On Feb. 19, 2016, 7:52 a.m., Kevin Klues wrote: > > support/generate-endpoint-help.py, line 147 > > > > > > What are all these whitespace changes. Is it a glitch in reviewboard? > > I don't seem them when I pull

Re: Review Request 43715: Title for endpoint documentation.

2016-02-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 19, 2016, 12:04 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 42719: Add doc for weights.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review119871 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 43716: Endpoint documents with title.

2016-02-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/ --- (Updated Feb. 19, 2016, 12:19 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-19 Thread Yongqiao Wang
> On Feb. 19, 2016, 9:36 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1068-1070 > > > > > > Why don't we need to set `rebalance` here? According to my understanding, A

Review Request 43757: Introduced signal escalation timeout in `CommandInfo`.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43757/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-1571

Review Request 43758: Made signal escalation timeout configurable in command executor.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43758/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-1571

Review Request 43759: Reduced the scope of the default signal escalation timeout.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43759/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-1571

Review Request 43761: Replaced an exit status numeral with the appropriate constant.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43761/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-1571

Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43760/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-1571

Review Request 43763: Passed `Duration` as const reference in the executor library.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43763/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-1571

Review Request 43762: Added a comment for `ShutdownProcess` in the executor library.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43762/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-1571

Review Request 43764: Extended the actual shutdown timeout for executors.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43764/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-1571

Re: Review Request 43758: Made signal escalation timeout configurable in command executor.

2016-02-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43758/#review119873 --- src/launcher/executor.cpp (lines 173 - 174)

Re: Review Request 43718: Added fs::supported() function.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119874 --- Patch looks great! Reviews applied: [43718] Passed command:

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43760/#review119875 --- src/exec/exec.cpp (lines 697 - 698)

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-19 Thread Guangya Liu
> On 二月 19, 2016, 1:38 p.m., Guangya Liu wrote: > > src/exec/exec.cpp, lines 698-699 > > > > > > Since there is already a default value for `shutdownGracePeriod` here, > > what about just log warning message here

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-19 Thread Alexander Rukletsov
> On Feb. 19, 2016, 1:38 p.m., Guangya Liu wrote: > > src/exec/exec.cpp, lines 698-699 > > > > > > Since there is already a default value for `shutdownGracePeriod` here, > > what about just log warning message here

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-19 Thread Guangya Liu
> On 二月 19, 2016, 1:38 p.m., Guangya Liu wrote: > > src/exec/exec.cpp, lines 698-699 > > > > > > Since there is already a default value for `shutdownGracePeriod` here, > > what about just log warning message here

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-19 Thread Alexander Rukletsov
> On Feb. 19, 2016, 9:36 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1068-1070 > > > > > > Why don't we need to set `rebalance` here? > > Yongqiao Wang wrote: >

Re: Review Request 43764: Extended the actual shutdown timeout for executors.

2016-02-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43764/#review119886 --- src/slave/slave.cpp (line 3682)

Re: Review Request 43764: Extended the actual shutdown timeout for executors.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43764/#review119887 --- Patch looks great! Reviews applied: [43757, 43758, 43759, 43760,

Re: Review Request 42370: Accept the 3-field version of HDFS du output.

2016-02-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42370/ --- (Updated Feb. 19, 2016, 3:29 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43715: Title for endpoint documentation.

2016-02-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/#review119893 --- Fix it, then Ship it! The summary and description will need to

Re: Review Request 43716: Endpoint documents with title.

2016-02-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review119896 --- The white space in these generated files (especially index.md) is

Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Repository:

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/#review119915 --- Patch looks great! Reviews applied: [43769] Passed command:

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/#review119920 --- src/master/master.cpp (lines 3856 - 3858)

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-19 Thread Mark Cavage
> On Feb. 18, 2016, 8:56 p.m., Joseph Wu wrote: > > Can you split up this patch into the following groups? (Its ok to run the > > tests at the end of a review chain, just add a note in the "Testing Done" > > section.) > > > > * Interfaces for the new module. > > * Modularization boilerplate

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-19 Thread Mark Cavage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- (Updated Feb. 19, 2016, 6:52 p.m.) Review request for mesos and Benjamin

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

2016-02-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43271/ --- (Updated Feb. 19, 2016, 10:54 a.m.) Review request for mesos, Benjamin

Re: Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

2016-02-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43272/ --- (Updated Feb. 19, 2016, 10:54 a.m.) Review request for mesos, Benjamin

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/ --- (Updated Feb. 19, 2016, 6:54 p.m.) Review request for mesos, Joris Van

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/#review119924 --- Ship it! Ship It! - Alexander Rojas On Feb. 19, 2016, 7:54

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/#review119925 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43409/#review119926 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review119929 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

2016-02-19 Thread Joseph Wu
> On Feb. 19, 2016, 2:32 a.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 329 > > > > > > There are so many things I'd like to comment on here, please allow me > > to just go for it and

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/#review119930 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:08

Review Request 43775: Fixed bug in appc cache's find logic.

2016-02-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43775/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43413/#review119931 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43414/#review119932 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/#review119933 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:08

Re: Review Request 43775: Fixed bug in appc cache's find logic.

2016-02-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43775/#review119934 --- Ship it! Ship It! - Jie Yu On Feb. 19, 2016, 7:12 p.m.,

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/#review119935 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43417/#review119936 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review119940 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:24

Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43418/#review119938 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 1:01

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43692/#review119941 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:26

Re: Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43693/#review119942 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:27

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/#review119943 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 206)

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/#review119944 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:28

Re: Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43695/#review119945 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:28

Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43700/#review119947 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:31

Re: Review Request 43689: CMake: Begin to require 64-bit builds.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43689/#review119946 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:29

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/#review119948 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 5:49

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43698/#review119949 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 4:34

Re: Review Request 43384: Fixed minor bug in generate-endpoint-help.py.

2016-02-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43384/ --- (Updated Feb. 19, 2016, 7:21 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43699/#review119950 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 4:35

Re: Review Request 43775: Fixed bug in appc cache's find logic.

2016-02-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43775/#review119951 --- Ship it! Ship It! - Kevin Klues On Feb. 19, 2016, 7:12

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-19 Thread Joseph Wu
> On Feb. 19, 2016, 3:16 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 205 > > > > > > Slightly unclear which is which. Attempt to clarify: > > > > ... Once this method has been called, its

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 19, 2016, 11:25 a.m.) Review request for mesos, Benjamin

Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43769/#review119953 --- Ship it! Ship It! - Vinod Kone On Feb. 19, 2016, 6:54 p.m.,

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-19 Thread Neil Conway
> On Feb. 19, 2016, 6:32 a.m., Adam B wrote: > > include/mesos/mesos.proto, line 1600 > > > > > > Is it ok for labels to contain duplicate keys even if the values are > > different? > > That sounds like

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 19, 2016, 11:36 a.m.) Review request for mesos, Benjamin

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

2016-02-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/ --- (Updated Feb. 19, 2016, 7:38 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 43715: Title for endpoint documentation.

2016-02-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 19, 2016, 7:46 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

2016-02-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43272/ --- (Updated Feb. 19, 2016, 11:48 a.m.) Review request for mesos, Benjamin

Re: Review Request 43715: Title for endpoint documentation.

2016-02-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/#review119960 --- Ship it! Ship It! - Kevin Klues On Feb. 19, 2016, 7:46

Re: Review Request 43716: Endpoint documents with title.

2016-02-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/ --- (Updated Feb. 19, 2016, 7:55 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43716: Endpoint documents with title.

2016-02-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review119963 --- Ship it! Ship It! - Kevin Klues On Feb. 19, 2016, 7:55

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-19 Thread Steve Niemitz
> On Feb. 18, 2016, 11:15 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, line 785 > > > > > > Do you need to call update for this case (command task but agent is not > > running in a docker container)?

Re: Review Request 43715: Title for endpoint documentation.

2016-02-19 Thread Abhishek Dasgupta
> On Feb. 19, 2016, 4:26 p.m., Kevin Klues wrote: > > support/generate-endpoint-help.py, line 147 > > > > > > Actually, I was wrong, when I pull down locally, all of these newlines > > are removed (and they

Re: Review Request 43715: Title for endpoint documentation.

2016-02-19 Thread Kevin Klues
> On Feb. 19, 2016, 4:26 p.m., Kevin Klues wrote: > > support/generate-endpoint-help.py, line 147 > > > > > > Actually, I was wrong, when I pull down locally, all of these newlines > > are removed (and they

Re: Review Request 43715: To include title generation in endpoint generator file.

2016-02-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/ --- (Updated Feb. 19, 2016, 8:06 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43616/#review119980 --- Ship it! Ship It! - Adam B On Feb. 17, 2016, 10:44 a.m.,

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

2016-02-19 Thread Adam B
> On Feb. 18, 2016, 10:32 p.m., Adam B wrote: > > include/mesos/mesos.proto, line 1600 > > > > > > Is it ok for labels to contain duplicate keys even if the values are > > different? > > That sounds like

  1   2   >