Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-23 Thread Jie Yu
> On Feb. 23, 2016, 7:26 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/paths.hpp, lines 38-40 > > > > > > Do we need to add layer.tar here? That's a impl. detail. We would likely to

Re: Review Request 43661: Added check to not Subscribe if we are already subscribed.

2016-02-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43661/#review120398 --- src/scheduler/scheduler.cpp (line 216)

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-23 Thread Jie Yu
- Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120273 --- On Feb. 23, 2016, 8:12 p.m., Jie Yu wrote: > >

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-23 Thread Jie Yu
> On Feb. 23, 2016, 7:41 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 258 > > > > > > Not yours but do we need a CHECK here or a graceful failure.

Re: Review Request 43912: Fixed linux fs create dev symlinks.

2016-02-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43912/#review120410 --- Ship it! Ship It! - Jie Yu On Feb. 23, 2016, 10:52 p.m.,

Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

2016-02-23 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43915/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 43880: Added allocator metrics for total and allocated scalar resources.

2016-02-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4720

Review Request 43884: Added allocator metrics for satisfied quotas.

2016-02-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4723

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-02-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review120338 --- Apologies, did you check with Alex prior to committing? We talked

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

2016-02-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review120349 --- Hi, I think the bug field for this review should be `MESOS-4746`?

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/ --- (Updated Feb. 23, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and

Review Request 43912: Fixed linux fs create dev symlinks.

2016-02-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43912/ --- Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, and Timothy

Review Request 43913: Modified `NetClsHandleManager` to take a range of secondary handles.

2016-02-23 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43913/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120408 --- Ship it! Tested with mesos-execute

Re: Review Request 43661: Added check to not Subscribe if we are already subscribed.

2016-02-23 Thread Anand Mazumdar
> On Feb. 23, 2016, 10:17 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 216 > > > > > > Subscribe contains FrameworkInfo. So this check means that a framework > > cannot update its FrameworkInfo

Re: Review Request 43913: Modified `NetClsHandleManager` to take a range of secondary handles.

2016-02-23 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43913/ --- (Updated Feb. 23, 2016, 11:16 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

2016-02-23 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43915/ --- (Updated Feb. 23, 2016, 11:21 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43822/ --- (Updated Feb. 23, 2016, 10:29 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43817: Removed no-longer-used model functions.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43817/ --- (Updated Feb. 23, 2016, 10:29 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/ --- (Updated Feb. 23, 2016, 10:29 p.m.) Review request for mesos and Michael Park.

Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/ --- (Updated Feb. 23, 2016, 10:29 p.m.) Review request for mesos and Michael Park.

Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

2016-02-23 Thread Alex Clemmer
> On Feb. 11, 2016, 9:31 p.m., M Lawindi wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 182 > > > > > > Fix spaces/tabs Lawindi and I talked on Slack, and concluded there isn't a tabs issue after

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-23 Thread Jie Yu
> On Feb. 23, 2016, 7:45 a.m., Guangya Liu wrote: > > Some doc may also need to be changed by removing the ssl related > > configurations, such as > > > > https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.json.md > >

Review Request 43914: Modified the `NetClsHandleManager` methods to work with ranges.

2016-02-23 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43914/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43914: Modified the `NetClsHandleManager` methods to work with ranges.

2016-02-23 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43914/ --- (Updated Feb. 23, 2016, 11:18 p.m.) Review request for mesos and Jie Yu.

Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

2016-02-23 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43916/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4700

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120465 --- Great work. Still missing a bit of context about what a

Review Request 43888: Updated webui to reflect the new TASK_KILLING state.

2016-02-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43888/ --- Review request for mesos and Abhishek Dasgupta. Bugs: MESOS-4547

Re: Review Request 43799: WIP: Removed race condition from libevent based poll implementation.

2016-02-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 23, 2016, 8:08 p.m.) Review request for mesos, Joris Van

Re: Review Request 43888: Updated webui to reflect the new TASK_KILLING state.

2016-02-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43888/#review120348 --- Ship it! Ship It! - haosdent huang On Feb. 23, 2016, 6:04

Re: Review Request 43384: Fixed minor bug in generate-endpoint-help.py.

2016-02-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43384/#review120350 --- Ship it! support/generate-endpoint-help.py (line 316)

Re: Review Request 43798: Added overview section to upgrades.md.

2016-02-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated Feb. 23, 2016, 7:31 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

2016-02-23 Thread Ben Mahler
> On Feb. 22, 2016, 5:44 a.m., Abhishek Dasgupta wrote: > > docs/high-availability-framework-guide.md, line 205 > > > > > > How about we put an example here? Like the following: > > This is useful for tasks that

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120356 --- Fix it, then Ship it! docs/app-framework-development-guide.md

Re: Review Request 43850: Added watis at different points in the test to ensure milestones.

2016-02-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43850/ --- (Updated Feb. 23, 2016, 7:46 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43848: Used `size_t` to track number of frameworks per role.

2016-02-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43848/#review120334 --- Ship it! Thanks! Looks like there are a few other spots in the

Re: Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

2016-02-23 Thread Ben Mahler
> On Feb. 22, 2016, 5:39 a.m., Neil Conway wrote: > > docs/high-availability-framework-guide.md, line 204 > > > > > > "has not yet been killed" ? done > On Feb. 22, 2016, 5:39 a.m., Neil Conway wrote: > >

Review Request 43882: Added allocation metrics for allocation time.

2016-02-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4721

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-02-23 Thread Bernd Mathiske
> On Feb. 23, 2016, 9:33 a.m., Ben Mahler wrote: > > Apologies, did you check with Alex prior to committing? We talked about > > this change recently but we didn't publish the comments, sorry that it > > wasn't clear! I reverted it for now, since we didn't really like the empty > > map

Re: Review Request 43864: Fix typo of roles doc.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/#review120347 --- The right place to make this fix is in `src/master/http.cpp`, and

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120364 --- The patch looks good to me. Could you rebase? I want to apply the

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review120342 --- Patch looks great! Reviews applied: [43032] Passed command:

Re: Review Request 43849: Fixed typos in subprocess.cpp comments.

2016-02-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43849/#review120345 --- Ship it! Ship It! - Bernd Mathiske On Feb. 23, 2016, 9:49

Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

2016-02-23 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Re: Review Request 43855: Added Appc fetcher support to store.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43855/#review120365 --- Patch looks great! Reviews applied: [43855] Passed command:

Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4719

Review Request 43879: Added allocator metrics for number of allocations made.

2016-02-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4718

Review Request 43883: Added allocator metrics for number of filters per framework.

2016-02-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4722

Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43827/#review120340 --- Did you test this? ;) We need to also adjust slave.html and the

Re: Review Request 43384: Fixed minor bug in generate-endpoint-help.py.

2016-02-23 Thread Neil Conway
> On Feb. 23, 2016, 6:17 p.m., Ben Mahler wrote: > > support/generate-endpoint-help.py, line 316 > > > > > > How about on_exit? Sounds good. - Neil ---

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-02-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 23, 2016, 11:29 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43859: Fix invalid usage of ATOMIC_FLAG_INIT (MESOS-4602).

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43859/#review120277 --- Patch looks great! Reviews applied: [43859] Passed command:

Re: Review Request 43863: Move the implementation of updateWeights out of header.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/#review120282 --- Patch looks great! Reviews applied: [41597, 41681, 43863]

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-23 Thread Abhishek Dasgupta
> On Feb. 23, 2016, 9:46 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 123-128 > > > > > > Can you use following logic to get docker version here? > > > > Future version_ = this->version(); > >

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review120283 --- src/docker/docker.cpp (lines 123 - 128)

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-23 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- (Updated Feb. 23, 2016, 8:44 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-23 Thread Abhishek Dasgupta
> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 536 > > > > > > Seems like we're increasing trying to find docker versions in our code > > base. How about let's capture the docker

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review120430 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43868: Add a getter for master::Flags.

2016-02-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43868/#review120429 --- src/master/master.hpp (line 545)

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

2016-02-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review120415 --- src/master/allocator/mesos/hierarchical.cpp (lines 432 - 444)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review120422 --- src/master/allocator/mesos/hierarchical.cpp (line 1197)

Re: Review Request 43799: WIP: Removed race condition from libevent based poll implementation.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120416 --- Patch looks great! Reviews applied: [43799] Passed command:

Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43854/#review120420 --- Ship it! Ship It! - Jie Yu On Feb. 22, 2016, 10:52 p.m.,

Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-23 Thread Jie Yu
> On Feb. 23, 2016, 6:40 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 354 > > > > > > Do we have tests to test the docker runtime isolator? Yeah, I think he's

Re: Review Request 43864: Fix typo of roles doc.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/#review120287 --- Patch looks great! Reviews applied: [43864] Passed command:

Re: Review Request 43868: Add a getter for master::Flags.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43868/#review120299 --- Patch looks great! Reviews applied: [43858, 43868] Passed

Re: Review Request 43868: Add a getter for master::Flags.

2016-02-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43868/#review120300 --- src/master/master.hpp (line 545)

Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.

2016-02-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42390/#review120296 --- Ship it! Ship It! - Klaus Ma On Jan. 20, 2016, 10:12 p.m.,

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

2016-02-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/#review120292 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:13 p.m.,

Re: Review Request 43848: Used `size_t` to track number of frameworks per role.

2016-02-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43848/#review120294 --- Ship it! Ship It! - Klaus Ma On Feb. 23, 2016, 3:54 a.m.,

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

2016-02-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43822/#review120291 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:12 p.m.,

Re: Review Request 43859: Fixed invalid usage of ATOMIC_FLAG_INIT in libprocess.

2016-02-23 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43859/ --- (Updated Feb. 23, 2016, 10:58 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-23 Thread Guangya Liu
> On 二月 23, 2016, 9:46 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 123-128 > > > > > > Can you use following logic to get docker version here? > > > > Future version_ = this->version(); > >

Re: Review Request 43868: Add a getter for master::Flags.

2016-02-23 Thread Jay Guo
> On Feb. 24, 2016, 1:38 a.m., Qian Zhang wrote: > > src/master/master.hpp, line 545 > > > > > > Need to return "const Flags&"? Return reference to flags causes problem: ```

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

2016-02-23 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review120452 --- support/push-reviews.py (lines 123 - 125)

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

2016-02-23 Thread Kevin Klues
> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote: > > support/push-reviews.py, lines 108-112 > > > > > > As we close the review, we should also post a comment to reviewboard > > with the commit message we actually

Re: Review Request 43868: Add a getter for master::Flags.

2016-02-23 Thread Jay Guo
> On Feb. 23, 2016, 12:45 p.m., Klaus Ma wrote: > > src/master/master.hpp, line 545 > > > > > > `getFlags() const` > > Jay Guo wrote: > OK We found that *constant member funtion* here requires a new

Re: Review Request 43864: Fix typo of roles doc.

2016-02-23 Thread Klaus Ma
> On Feb. 24, 2016, 2:06 a.m., Neil Conway wrote: > > The right place to make this fix is in `src/master/http.cpp`, and then > > rerun `support/generate-endpoint-help.py`. Seems like > > `Master::Http::ROLES_HELP` is missing commas in `DESCRIPTION`. You're right, we missed commas in

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/#review120426 --- src/scheduler/scheduler.cpp (lines 117 - 119)

Re: Review Request 43864: Fix typo of roles doc.

2016-02-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/ --- (Updated Feb. 24, 2016, 11:34 a.m.) Review request for mesos and Neil Conway.

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

2016-02-23 Thread Vinod Kone
> On Feb. 23, 2016, 12:44 a.m., Kevin Klues wrote: > > support/push-reviews.py, lines 14-15 > > > > > > I would at least pass this as a flag right now rather than jsut adding > > a TODO. Otherwise people that prefer

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43916/#review120458 --- Patch looks great! Reviews applied: [43913, 43914, 43915, 43916]

Re: Review Request 43893: Made sure that spawned processes terminated before leaving test.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43893/#review120438 --- Patch looks great! Reviews applied: [43893] Passed command:

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

2016-02-23 Thread Vinod Kone
> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote: > > support/push-reviews.py, lines 108-112 > > > > > > As we close the review, we should also post a comment to reviewboard > > with the commit message we actually

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/#review120453 --- Patch looks great! Reviews applied: [43816, 43822, 43823, 43817,

Re: Review Request 43868: Add a getter for master::Flags.

2016-02-23 Thread Jay Guo
> On Feb. 24, 2016, 1:44 a.m., Qian Zhang wrote: > > With this patch, do we still need to explicitly call `CreateMasterFlags()` > > in the test cases (e.g., > > https://github.com/apache/mesos/blob/2876b8c918814347dd56f6f87d461e414a90650a/src/tests/master_maintenance_tests.cpp#L1231-L1235)? >

Re: Review Request 43868: Add a getter for master::Flags.

2016-02-23 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43868/ --- (Updated Feb. 24, 2016, 3:42 a.m.) Review request for mesos, Guangya Liu,

Review Request 43920: Added a helper function to stout : os/which.hpp.

2016-02-23 Thread Disha Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 43798: Added overview section to upgrades.md.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review120447 --- Patch looks great! Reviews applied: [43792, 43798] Passed

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120367 ---

Re: Review Request 43893: Made sure that spawned processes terminated before leaving test.

2016-02-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43893/#review120370 --- Ship it! LGTM! - Joseph Wu On Feb. 23, 2016, 11:50 a.m.,

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-23 Thread Jie Yu
> On Feb. 23, 2016, 7:27 p.m., Gilbert Song wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 1267 > > > > > > Could we do `EXPECT_EQ(2u, imageInfo->layers.size())` ? We don't know that for

Re: Review Request 43798: Added overview section to upgrades.md.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review120374 --- docs/upgrades.md (line 13)

Review Request 43896: Removed the restriction that /tmp needs to be writable in new rootfs.

2016-02-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43896/ --- Review request for mesos, Gilbert Song, Ian Downes, Jojy Varghese, and Timothy

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/ --- (Updated Feb. 23, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/ --- (Updated Feb. 23, 2016, 8:12 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 43884: Added allocator metrics for satisfied quotas.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review120379 --- Patch looks great! Reviews applied: [43879, 43880, 43881, 43882,

Re: Review Request 43893: Made sure that spawned processes terminated before leaving test.

2016-02-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43893/ --- (Updated Feb. 23, 2016, 8:50 p.m.) Review request for mesos and Joseph Wu.

  1   2   >