Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-02-28 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review121130 --- Just a couple of suggested comment rewordings, as I've been

Re: Review Request 43824: Addressed comments of 41672.

2016-02-28 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review121132 --- Thanks for following up with this. AlexR is on vacation now, so

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-28 Thread Yongqiao Wang
> On Feb. 27, 2016, 12:21 p.m., Adam B wrote: > > Sorry this took me forever to get to. Looks pretty good except for some > > indentation and some unnecessary lines. > > I'd also like to see a couple of registrar tests, like AlexR suggested. > > Yongqiao Wang wrote: > Thanks Adam. I will

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-28 Thread Adam B
> On Feb. 27, 2016, 4:21 a.m., Adam B wrote: > > Sorry this took me forever to get to. Looks pretty good except for some > > indentation and some unnecessary lines. > > I'd also like to see a couple of registrar tests, like AlexR suggested. > > Yongqiao Wang wrote: > Thanks Adam. I will

Re: Review Request 42719: Add doc for weights.

2016-02-28 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review121129 --- Thanks! Couple of tweaks as I review it again. - How did you test

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

2016-02-28 Thread Adam B
> On Feb. 19, 2016, 1:31 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2325 > > > > > > Why post-increment? Is it consistent to the codebase? Looks like post-increment wins

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

2016-02-28 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/#review121135 --- Fix it, then Ship it! Simple enough.

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-02-28 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Feb. 28, 2016, 10:27 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/ --- (Updated Feb. 28, 2016, 11:27 a.m.) Review request for mesos and Benjamin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/ --- (Updated Feb. 28, 2016, 12:57 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/ --- (Updated Feb. 28, 2016, 12:57 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43884: Added allocator metrics for used quotas.

2016-02-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121149 --- src/master/allocator/mesos/hierarchical.hpp (line 389)

Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43846/#review121156 --- Ship it! Ship It! - Vinod Kone On Feb. 27, 2016, 4:48 a.m.,

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/#review121144 --- Patch looks great! Reviews applied: [42100] Passed command:

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review121140 --- Ship it! Ship It! - Klaus Ma On Feb. 28, 2016, 9:08 p.m.,

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/ --- (Updated Feb. 28, 2016, 4:56 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/ --- (Updated Feb. 28, 2016, 5:22 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
> On Feb. 28, 2016, 1:16 p.m., Guangya Liu wrote: > > src/linux/fs.cpp, line 60 > > > > > > I think that should `continue` here, if one line failed, other lines > > should still be tried to see if the fs is

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review121141 --- src/linux/fs.cpp (line 60)

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

2016-02-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/#review121145 --- docs/reservation.md (line 363)

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/#review121151 --- Ship it! Ship It! - Klaus Ma On Feb. 27, 2016, 8:55 a.m.,

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-28 Thread Klaus Ma
> On Feb. 26, 2016, 12:30 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 376 > > > > > > We also need to remove counter in `removeFramework`; or we'll see > > metrics of removed

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/ --- (Updated Feb. 28, 2016, 12:55 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/ --- (Updated Feb. 28, 2016, 5:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43701: Added a command executor based on the new V1 API.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/#review121155 --- src/launcher/http_executor.cpp (line 82)

Re: Review Request 43661: Added check to not Subscribe if we are already subscribed.

2016-02-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43661/#review121154 --- Ship it! Ship It! - Vinod Kone On Feb. 17, 2016, 7:22 p.m.,

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/ --- (Updated Feb. 28, 2016, 1:08 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
> On Feb. 21, 2016, 5:59 p.m., Cong Wang wrote: > > src/tests/containerizer/fs_tests.cpp, line 48 > > > > > > Well, not all kernels compile ext4 module, you can actually test > > "procfs" and "sysfs" here, they are

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Shuai Lin
> On Feb. 25, 2016, 7:53 p.m., Jie Yu wrote: > > src/linux/fs.cpp, line 60 > > > > > > Should we return an Error here? Updated. - Shuai --- This is an

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/ --- (Updated Feb. 28, 2016, 2:14 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43718: Added fs::supported() function.

2016-02-28 Thread Klaus Ma
> On Feb. 28, 2016, 9:16 p.m., Guangya Liu wrote: > > src/linux/fs.cpp, line 60 > > > > > > I think that should `continue` here, if one line failed, other lines > > should still be tried to see if the fs is

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

2016-02-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/#review121143 --- Ship it! Ship It! - Klaus Ma On Feb. 28, 2016, 6:27 p.m.,

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/#review121147 --- Patch looks great! Reviews applied: [42100] Passed command:

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

2016-02-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review121148 --- src/master/allocator/mesos/hierarchical.hpp (line 384)

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp, lines 30-31 > > > > > > can you wrap comments in 70 char width. It's less jagged IMO. done > On

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43932/#review121158 --- Patch looks great! Reviews applied: [43718, 43932] Passed

Re: Review Request 43884: Added allocator metrics for used quotas.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 28, 2016, 10:31 p.m.) Review request for mesos, Alexander

Re: Review Request 44147: Remove unused src/common/date_utils.{c, h}pp (MESOS-4792).

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44147/#review121164 --- Patch looks great! Reviews applied: [44147] Passed command:

Re: Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44071/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos. Changes

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos, Alexander

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-28 Thread Benjamin Bannier
> On Feb. 27, 2016, 1:25 a.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2432-2436 > > > > > > This looks rather hard to read. I think a better solution would look > > like this:

Re: Review Request 43882: Added allocation metrics for allocation time.

2016-02-28 Thread Benjamin Bannier
> On Feb. 25, 2016, 5:47 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1207 > > > > > > It seems a general functional class, can we move it into > > `process/metrics`? I currently

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos, Alexander

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

2016-02-28 Thread Benjamin Bannier
> On Feb. 26, 2016, 8:32 p.m., Alexander Rojas wrote: > > src/tests/main.cpp, line 75 > > > > > > I think this is using the posix `setenv(const char*, const char*, > > int)`, though the boolean as last parameter

Re: Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

2016-02-28 Thread Benjamin Bannier
> On Feb. 26, 2016, 6 p.m., Benjamin Bannier wrote: > > docs/configuration.md, line 1690 > > > > > > Rename to `LIBPROCESS_METRICS_RATE_LIMIT` and document changed > > semantics (comment in previous patch). > >

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Jie Yu
> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, lines > > 124-129 > > > > > > To be safe, can you do the same thing to mark the mount as

Review Request 44147: Remove unused src/common/date_utils.{c, h}pp (MESOS-4792).

2016-02-28 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44147/ --- Review request for mesos and Neil Conway. Bugs: MESOS-4792

Re: Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44071/#review121165 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44073/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos. Changes

Re: Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos. Changes

Re: Review Request 43882: Added allocation metrics for allocation time.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos, Alexander

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

2016-02-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos, Alexander

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

2016-02-28 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44151/#review121170 --- 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

2016-02-28 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44151/#review121174 --- 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp

Re: Review Request 43701: Added a command executor based on the new V1 API.

2016-02-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/#review121177 --- Thanks for working on this Qian! It's really hard to tell what

Re: Review Request 43932: Added overlayfs provisioning backend.

2016-02-28 Thread Shuai Lin
> On Feb. 25, 2016, 11:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, lines > > 124-129 > > > > > > To be safe, can you do the same thing to mark the mount as

Re: Review Request 44147: Remove unused src/common/date_utils.{c, h}pp (MESOS-4792).

2016-02-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44147/#review121168 --- Ship it! Ship It! - Neil Conway On Feb. 28, 2016, 7:36

Review Request 44153: Obtained uid/gids before changing filesystem root.

2016-02-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44153/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-4757

Review Request 44151: Added stout functions to get and set supplementary groud ids.

2016-02-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44151/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-4757

Review Request 44152: Added a TODO in os::su.

2016-02-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44152/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-4757

Re: Review Request 44149: Renamed a method in docker runtime isolator.

2016-02-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44149/#review121175 --- Ship it! Ship It! - Gilbert Song On Feb. 28, 2016, 4:07

Review Request 44154: Fixed build error on Mac OS.

2016-02-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44154/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4799

Re: Review Request 43884: Added allocator metrics for used quotas.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121166 --- Bad review! Reviews applied: [43884, 43883, 43882, 43881, 43880,

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

2016-02-28 Thread Jie Yu
> On Feb. 29, 2016, 12:39 a.m., James Peach wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 310 > > > > > > Darwin does have a ``gid_t`` type, why is this ifdef needed? ::getgrouplist

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

2016-02-28 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44151/#review121172 --- 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp

Re: Review Request 44153: Obtained uid/gids before changing filesystem root.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44153/#review121176 --- Patch looks great! Reviews applied: [44149, 44150, 44151, 44152,

Review Request 44150: Added stout functions to set uid and gid.

2016-02-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44150/ --- Review request for mesos, Ian Downes and Timothy Chen. Bugs: MESOS-4757

Review Request 44149: Renamed a method in docker runtime isolator.

2016-02-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44149/ --- Review request for mesos, Gilbert Song and Timothy Chen. Repository: mesos

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review121186 --- Patch looks great! Reviews applied: [43321] Passed command:

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/ --- (Updated Feb. 29, 2016, 3:11 a.m.) Review request for mesos and Alexander

Re: Review Request 44154: Fixed build error on Mac OS.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44154/#review121179 --- Patch looks great! Reviews applied: [44154] Passed command:

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

2016-02-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/ --- (Updated Feb. 29, 2016, 7:13 a.m.) Review request for mesos, Michael Park and

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

2016-02-28 Thread Neil Conway
> On Feb. 28, 2016, 3:15 a.m., Guangya Liu wrote: > > docs/persistent-volume.md, lines 372-374 > > > > > > Only the `reserved_resources_full` was mentioned here, what about > > `used_resources_full` and

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review121206 --- Patch looks great! Reviews applied: [42386] Passed command:

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-02-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/ --- (Updated Feb. 29, 2016, 7:01 a.m.) Review request for mesos and Michael Park.

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

2016-02-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/ --- (Updated Feb. 29, 2016, 7:01 a.m.) Review request for mesos, Michael Park and

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-02-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/ --- (Updated 二月 29, 2016, 7:04 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-02-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 二月 29, 2016, 7:04 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-02-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 二月 29, 2016, 7:08 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

2016-02-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/ --- (Updated Feb. 29, 2016, 7:20 a.m.) Review request for mesos, Michael Park and

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

2016-02-28 Thread Neil Conway
> On Feb. 28, 2016, 3:06 p.m., Klaus Ma wrote: > > docs/reservation.md, line 363 > > > > > > s/slave/agent/ The rest of this file uses "slave", so I think this is better as-is for now (until we do the rename). -

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43792/#review121208 --- Ship it! Ship It! - Michael Park On Feb. 22, 2016, 6 p.m.,

Re: Review Request 43798: Added overview section to upgrades.md.

2016-02-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review121209 --- Ship it! Ship It! - Michael Park On Feb. 23, 2016, 9:39

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43634/#review121207 --- Ship it! Ship It! - Michael Park On Feb. 22, 2016, 5:18

Re: Review Request 42590: Removed reserved() API.

2016-02-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 二月 29, 2016, 7:54 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

2016-02-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/ --- (Updated Feb. 29, 2016, 6:55 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-02-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/ --- (Updated Feb. 29, 2016, 6:55 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

2016-02-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- (Updated Feb. 29, 2016, 6:55 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

2016-02-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/ --- (Updated Feb. 29, 2016, 6:55 a.m.) Review request for mesos and Michael Park.