Re: Review Request 41410: Export CFS metrics for docker containers

2016-03-20 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41410/#review123942 --- Is there a JIRA ticket associated with this review? - Avinash

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/ --- (Updated March 18, 2016, 6:13 p.m.) Review request for mesos, Adam B,

Review Request 44895: Update containerizer construction in container_logger_tests.cpp.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44895/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated March 18, 2016, 5:26 p.m.) Review request for mesos and Jie Yu.

Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/ --- Review request for mesos, Jie Yu and Neil Conway. Repository: mesos

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-03-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/ --- (Updated 三月 17, 2016, 1:12 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-20 Thread Neil Conway
> On March 18, 2016, 9:47 a.m., Adam B wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Why pause so soon? You can wait until after the master is started, but > > just before you start calling

Re: Review Request 44954: Regenerated master endpoint documentation.

2016-03-20 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44954/#review124167 --- Ship it! Ship It! - Adam B On March 17, 2016, 10:33 a.m.,

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review124484 --- src/slave/containerizer/mesos/isolators/network/cni/spec.proto

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-20 Thread Jie Yu
> On March 20, 2016, 7:06 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 82 > > > > > > s/NetworkResultInfo/Info/ > > > > We typically use 'Info' to store

Re: Review Request 43712: Documented how the replicated log works.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43712/#review124487 --- docs/replicated-log-internals.md (line 105)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-20 Thread Jie Yu
> On March 20, 2016, 7:06 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 82 > > > > > > s/NetworkResultInfo/Info/ > > > > We typically use 'Info' to store

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
> On March 19, 2016, 10:03 a.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 373 > > > > > > Do we actually have to get the authenticator above if this flag is not > > set? The code directly above this line

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 21, 2016, 4:24 a.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 21, 2016, 4:50 a.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
> On March 19, 2016, 10:03 a.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 373 > > > > > > Do we actually have to get the authenticator above if this flag is not > > set? > > Greg Mann wrote: > The

Review Request 45092: Fixed containerizer potential race destroy while provisioning.

2016-03-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45092/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy

Review Request 45093: Added mesos containerizer test DestroyWhileProvisioning.

2016-03-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45093/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124497 --- Patch looks great! Reviews applied: [45046] Passed command:

Re: Review Request 44996: Fixed how we detect C++11 compiler support in libprocess.

2016-03-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44996/ --- (Updated March 17, 2016, 11:52 p.m.) Review request for mesos and Joris Van

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124253 --- docs/versioning.md (line 85)

Re: Review Request 44944: Handled chunked responses in docker URI fetcher.

2016-03-20 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/#review124027 --- Ship it! Ship It! - James Peach On March 17, 2016, 1:50

Review Request 44975: Updated cgroups test cases for cgroups device support.

2016-03-20 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/ --- Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and Niklas

Re: Review Request 44850: Added missing include in allocator/mesos/hierarchical.hpp.

2016-03-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44850/#review124054 --- Ship it! Ship It! - Ben Mahler On March 15, 2016, 2:51

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-20 Thread Ben Mahler
> On March 15, 2016, 6:39 p.m., Ben Mahler wrote: > > src/exec/exec.cpp, line 113 > > > > > > If you'd like to add the `private` qualifier, why isn't `kill` left as > > protected? > > Alexander Rukletsov wrote: >

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

2016-03-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review123962 --- src/linux/perf.cpp (lines 435 - 437)

Re: Review Request 45010: Fixed newlines for include directives.

2016-03-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45010/#review124446 --- Patch looks great! Reviews applied: [45001, 45002, 45003, 45010]

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/#review124112 --- src/docker/executor.cpp (line 226)

Re: Review Request 44852: Documented existing allocator metrics.

2016-03-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44852/ --- (Updated March 18, 2016, 5:08 p.m.) Review request for mesos, Alexander

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-20 Thread Anurag Singh
> On March 11, 2016, 9:40 p.m., Joseph Wu wrote: > > I think you should send an email to the user and dev mailing lists to ask > > for high-level feedback on this interface. We want to make sure the > > interface is broad enough to support different implementations. (And I'm > > no expert

Re: Review Request 44709: Allowed unknown flags in command and docker executors.

2016-03-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44709/ --- (Updated March 18, 2016, 5:24 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123896 --- src/tests/containerizer/port_mapping_tests.cpp

Re: Review Request 45001: Replaced const ref to temporary in tests for consistency.

2016-03-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45001/#review124130 --- Ship it! Ship It! - Jie Yu On March 18, 2016, 12:15 a.m.,

Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-20 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124096 --- src/linux/cgroups.hpp (line 645)

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-20 Thread Qian Zhang
> On March 12, 2016, 2:45 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 277 > > > > > > either s/realpath/`realpath` > > > > or s/realpath/location I see

Review Request 44912: Used the same fixture for all related tests.

2016-03-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44912/ --- Review request for mesos, Joris Van Remoortere and Yong Tang. Bugs: MESOS-4807

Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 44906: Update containerizer construction in fetcher_cache_tests.cpp.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44906/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 45014: Add /containers endpoint to return ResourceUsage.

2016-03-20 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- Review request for mesos and Jie Yu. Summary (updated) - Add

Re: Review Request 44658: Removed unused signal escalation constant.

2016-03-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44658/ --- (Updated March 18, 2016, 5:20 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44974: Added device support in cgroups abstraction.

2016-03-20 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124093 --- For reference, Ahishek and I talked offline, and he modified his

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-03-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review123945 --- This patch breaks all the ROOT DOCKER tests in our internal CI.

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/#review124126 --- src/tests/containerizer/provisioner_appc_tests.cpp (line 73)

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

2016-03-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 18, 2016, 5:19 p.m.) Review request for mesos, Ben Mahler and

Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

2016-03-20 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45081/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

2016-03-20 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45081/ --- (Updated March 20, 2016, 10:06 p.m.) Review request for mesos and Alexander

Re: Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.

2016-03-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45078/#review124455 --- Looks like you created a new review instead of updating the

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-20 Thread Vinod Kone
> On March 19, 2016, 10:07 a.m., Guangya Liu wrote: > > @michael you should mark the issues as "Fixed" or "Drop" once you address them. See http://mesos.apache.org/documentation/latest/submitting-a-patch/. - Vinod --- This is an

Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 20, 2016, 6:58 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 20, 2016, 5:27 p.m.) Review request for mesos, Adam B,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 20, 2016, 5:32 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
> On March 19, 2016, 9:16 a.m., Adam B wrote: > > src/tests/mesos.cpp, line 177 > > > > > > Why use `os::getcwd()` instead of `directory.get()` like "credential" > > and "fetch" above? Seems like

Re: Review Request 44989: Fixed a race in the resource offers tests.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/ --- (Updated March 20, 2016, 5:35 p.m.) Review request for mesos, Adam B and Joerg

Review Request 45084: [WIP] Add `Subsystem` abstraction for cgroups.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4697

Review Request 45086: [WIP] Enable cgroups unified isolator in isolation.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4697

Review Request 45087: [WIP] Add `CpuSubsystem` for cgroups unified isolator.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4697

Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-20 Thread Greg Mann
> On March 19, 2016, 10:49 a.m., Joerg Schad wrote: > > docs/configuration.md, line 1274 > > > > > > dito. Since the master's flag is '--credentials' rather than '--http_credentials', and they have slightly

Review Request 45083: [WIP] Added a any mechanism for futures.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4697

Review Request 45085: [WIP] Add cgroup unified isolator.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4697

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
> On March 19, 2016, 11:39 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 682 > > > > > > One part I don't like is that the same flag on the master has a > > different name credentials. > > I would

Re: Review Request 45073: Restructured authentication.md to group common flags.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45073/#review124452 --- Personally, I'm not convinced that this is a useful way to format

Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 20, 2016, 6:12 p.m.) Review request for mesos, Adam B,

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124456 --- Can you also add a CHANGELOG entry for this under "Additonal API

Re: Review Request 45087: [WIP] Add `CpuSubsystem` for cgroups unified isolator.

2016-03-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/#review124461 --- Bad patch! Reviews applied: [45087, 45086, 45085, 45084, 45083]

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

2016-03-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/#review124454 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Review Request 45088: Edited master's flags to match documentation.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45088/ --- Review request for mesos, Adam B and Joerg Schad. Bugs: MESOS-4849

Re: Review Request 44554: Added agent HTTP authentication to the docs.

2016-03-20 Thread Joerg Schad
> On March 19, 2016, 10:49 a.m., Joerg Schad wrote: > > docs/configuration.md, line 1274 > > > > > > dito. > > Greg Mann wrote: > Since the master's flag is '--credentials' rather than > '--http_credentials',

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 20, 2016, 6:57 p.m.) Review request for mesos, Adam B,

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/ --- (Updated March 20, 2016, 4:48 p.m.) Review request for mesos, Adam B,

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review124448 --- Ship it! Ship It! - haosdent huang On March 20, 2016, 4:19

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

2016-03-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45081/#review124449 --- Patch looks great! Reviews applied: [45081] Passed command:

Review Request 44922: Fixed the port mapping tests compile errors.

2016-03-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44922/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

2016-03-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 21, 2016, 12:27 a.m.) Review request for mesos, Avinash

Re: Review Request 45010: Fixed newlines for include directives.

2016-03-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45010/#review124447 --- Ship it! Ship It! - haosdent huang On 三月 18, 2016, 12:44

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

2016-03-20 Thread Qian Zhang
> On March 17, 2016, 11:37 a.m., Jie Yu wrote: > > src/CMakeLists.txt, line 279 > > > > > > I don't think we put headers here. I had the same concern before, because it seems most source files here are .cpp. But I

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-20 Thread Michael Browning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/ --- (Updated March 21, 2016, 12:49 a.m.) Review request for mesos, Vinod Kone and

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-20 Thread Michael Browning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/ --- (Updated March 21, 2016, 12:51 a.m.) Review request for mesos, Vinod Kone and

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124480 --- src/tests/fetcher_tests.cpp (line 646)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-20 Thread Qian Zhang
> On March 21, 2016, 3:06 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 82 > > > > > > s/NetworkResultInfo/Info/ > > > > We typically use 'Info' to store

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-03-20 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 21, 2016, 1:59 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-03-20 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 21, 2016, 2 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-03-20 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 21, 2016, 2 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

2016-03-20 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 21, 2016, 2 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

2016-03-20 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 21, 2016, 2 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45088: Edited master's flag help strings to match the agent.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45088/ --- (Updated March 20, 2016, 7:01 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review124460 --- Some initial comments. Will do a pass to finish the rest later.

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- (Updated March 20, 2016, 9:57 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- (Updated March 20, 2016, 10:07 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- (Updated March 20, 2016, 11:03 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-20 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/ --- (Updated March 20, 2016, 7:50 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45088: Edited master's flag help strings to match the agent.

2016-03-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45088/#review124466 --- Patch looks great! Reviews applied: [44678, 44703, 44515, 44523,

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review124451 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
> On March 20, 2016, 5:51 p.m., Vinod Kone wrote: > > Looks like you created a new review instead of updating the existing review > > (https://reviews.apache.org/r/45000/) ? Can you discard this and update the > > old one instead. That way the review/comment history is not lost. You can > >

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

2016-03-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/#review124468 --- Patch looks great! Reviews applied: [45057] Passed command:

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-20 Thread Michael Browning
> On March 20, 2016, 6:36 p.m., Vinod Kone wrote: > > src/slave/containerizer/fetcher.cpp, lines 156-160 > > > > > > Why are you validating the filename as an URI? IIUC, filename should be > > a simple relative

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124470 --- Patch looks great! Reviews applied: [44985, 45000] Passed

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-20 Thread Vinod Kone
> On March 20, 2016, 6:36 p.m., Vinod Kone wrote: > > src/tests/fetcher_tests.cpp, lines 645-647 > > > > > > I know you followed the existing pattern in this file but we shouldn't > > do mktemp() like this in the

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124472 --- Can you confirm that you did a manual test of this (using curl

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

2016-03-20 Thread Guangya Liu
> On 三月 20, 2016, 6:36 p.m., Vinod Kone wrote: > > src/tests/fetcher_tests.cpp, lines 645-647 > > > > > > I know you followed the existing pattern in this file but we shouldn't > > do mktemp() like this in the

  1   2   >