Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review126202 --- Fix it, then Ship it! src/cli/execute.cpp (line 483)

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review126197 --- Patch looks great! Reviews applied: [45381] Passed command:

Re: Review Request 45489: Replaced reinterpret_cast with static_cast in libprocess.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45489/#review126183 --- Patch looks great! Reviews applied: [45318, 45319, 45488, 45489]

Re: Review Request 45496: Added documentation of LIBPROCESS_NUM_WORKER_THREADS.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45496/#review126203 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 45482: Replace NULL with nullptr.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45482/#review126187 --- Bad patch! Reviews applied: [45482] Failed command:

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-03-30 Thread Michael Park
> On March 26, 2016, 8:05 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 75 > > > > > > We tried to avoid axecuting too much code between ::connect > > WSAGetLastError() calls.

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

2016-03-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review126136 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45484: Made CHANGELOG formatting more consistent.

2016-03-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45484/#review126155 --- Ship it! Thanks for the cleanup! - Vinod Kone On March 30,

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

2016-03-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45015/#review126159 --- 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp

Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Deshi Xiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- Review request for mesos and haosdent huang. Bugs: MESOS-1104

Re: Review Request 45408: Introduced a `reconnect` method on the scheduler library.

2016-03-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45408/#review126173 --- Ship it! Ship It! - Vinod Kone On March 30, 2016, 6:44

Re: Review Request 45409: Added test for `reconnect` functionality.

2016-03-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45409/#review126174 --- Ship it! Ship It! - Vinod Kone On March 30, 2016, 6:44

Review Request 45496: Added documentation of LIBPROCESS_NUM_WORKER_THREADS.

2016-03-30 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45496/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 45466: Removed the redundant `NULL` check when deleting `Credential`.

2016-03-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45466/#review126161 --- Ship it! Ship It! - Vinod Kone On March 30, 2016, 2:23

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/#review126160 --- This could break existing clients which include extra whitespace,

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-03-30 Thread Jiang Yan Xu
> On March 25, 2016, 11:43 p.m., Jiang Yan Xu wrote: > > configure.ac, lines 957-960 > > > > > > Can we put AC_MSG_CHECKING before `AC_CHECK_HEADERS` and inside `AS_IF` > > above? > > > > i.e.,

Re: Review Request 45408: Introduced a `reconnect` method on the scheduler library.

2016-03-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45408/ --- (Updated March 30, 2016, 6:44 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Deshi Xiao
> On 三月 30, 2016, 6:40 p.m., Cong Wang wrote: > > You must be joking when you say you tested this Linux change on your osx... Oops. let me testing it again on centos. - Deshi --- This is an automatically generated e-mail. To reply,

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Deshi Xiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 三月 30, 2016, 6:44 p.m.) Review request for mesos and haosdent huang.

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-03-30 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated March 30, 2016, 5:12 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/#review126158 --- Ship it! Ship It! - Vinod Kone On March 30, 2016, 5:35

Re: Review Request 45480: Replace NULL with nullptr.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45480/#review126168 --- Patch looks great! Reviews applied: [45480] Passed command:

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review126169 --- You must be joking when you say you tested this Linux change on

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-03-30 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/ --- (Updated March 30, 2016, 5:30 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Deshi Xiao
> On 三月 30, 2016, 6:40 p.m., Cong Wang wrote: > > You must be joking when you say you tested this Linux change on your osx... > > Deshi Xiao wrote: > Oops. let me testing it again on centos. Wang Cong, are u a ex-redhatter? if u have alternative linux, please help testing with the

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-03-30 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated March 30, 2016, 5:10 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Vinod Kone
> On March 30, 2016, 6:10 p.m., Greg Mann wrote: > > This could break existing clients which include extra whitespace, though it > > does seem that RFC-7230 specifically prohibits whitespace in that location. > > I wonder if a deprecation cycle is advisable for this change? > > > > Also, it's

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

2016-03-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/#review126130 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

2016-03-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review126143 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-03-30 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/#review126167 --- Fix it, then Ship it! configure.ac (line 946)

Re: Review Request 45410: Documented when to invoke `send` using the scheduler library.

2016-03-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45410/ --- (Updated March 30, 2016, 6:45 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45409: Added test for `reconnect` functionality.

2016-03-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45409/ --- (Updated March 30, 2016, 6:44 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-03-30 Thread Daniel Pravat
> On March 26, 2016, 8:05 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 75 > > > > > > We tried to avoid axecuting too much code between ::connect > > WSAGetLastError() calls.

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review126233 --- src/linux/fs.hpp

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

2016-03-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126242 --- This is a high level question: I am now sure if adding attributes

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-03-30 Thread Deshi Xiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 三月 31, 2016, 3:38 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

2016-03-30 Thread Deshi Xiao
> On 三月 31, 2016, 2:03 a.m., Jie Yu wrote: > > This is a high level question: I am now sure if adding attributes is safe > > or not. For instance, my framework has the following rule: only schedule > > tasks to agents that do not have attribute "not_safe". Now, say agent A is > > initially

Re: Review Request 45513: Fixed mount point check in port mapping isolator.

2016-03-30 Thread Jie Yu
> On March 31, 2016, 12:14 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, lines > > 1901-1909 > > > > > > Thanks for the patch! > > > > Actually, I am working on

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126244 --- Patch looks great! Reviews applied: [1] Passed command:

Review Request 45505: WIP : Providing starting implementation for appc runtime isolator.

2016-03-30 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45505/ --- Review request for mesos, Guangya Liu and Jie Yu. Repository: mesos

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/#review126259 --- Patch looks great! Reviews applied: [45520] Passed command:

Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/ --- Review request for mesos, Ian Downes and Cong Wang. Bugs: MESOS-4662

Re: Review Request 45513: Fixed mount point check in port mapping isolator.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45513/#review126234 --- Patch looks great! Reviews applied: [45513] Passed command:

Review Request 45513: Fixed mount point check in port mapping isolator.

2016-03-30 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45513/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-03-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 30, 2016, 10:18 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Zhiwei Chen
> On March 31, 2016, 2:10 a.m., Greg Mann wrote: > > This could break existing clients which include extra whitespace, though it > > does seem that RFC-7230 specifically prohibits whitespace in that location. > > I wonder if a deprecation cycle is advisable for this change? > > > > Also, it's

Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.

2016-03-30 Thread Michael Park
> On March 22, 2016, 9:16 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/pid.cpp, lines 13-23 > > > > > > Can we maybe organize it like this? > > > > ``` > > #ifndef __WINDOWS__ > > #include

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review126222 --- Patch looks great! Reviews applied: [44945, 44946, 44947, 44948,

Re: Review Request 45434: Removed unused credentials.

2016-03-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45434/#review126227 --- Ship it! Ship It! - Greg Mann On March 30, 2016, 8:20 a.m.,

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 三月 31, 2016, 1:03 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-03-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 30, 2016, 10:18 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44948: Add XFS disk resource isolator.

2016-03-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 30, 2016, 10:19 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-03-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 30, 2016, 10:18 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-03-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 30, 2016, 10:18 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 45434: Removed unused credentials.

2016-03-30 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45434/#review126228 --- Ship it! Ship It! - Adam B On March 30, 2016, 1:20 a.m.,

Re: Review Request 45513: Fixed mount point check in port mapping isolator.

2016-03-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45513/#review126229 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Re: Review Request 44454: Returned real path for PORT_MAPPING_BIND_MOUNT_ROOT.

2016-03-30 Thread Jie Yu
> On March 8, 2016, 1:22 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.hpp, lines > > 66-72 > > > > > > This is not the reliable solution. What if /var/run points to some > >

Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.

2016-03-30 Thread Daniel Pravat
> On March 26, 2016, 8:05 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 75 > > > > > > We tried to avoid axecuting too much code between ::connect > > WSAGetLastError() calls.

Re: Review Request 45419: Cleaned up ModuleManager.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45419/#review126133 --- Patch looks great! Reviews applied: [45419] Passed command:

Re: Review Request 45475: Fixed typos in isolator test comments.

2016-03-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45475/#review126063 --- Ship it! Ship It! - Alexander Rukletsov On March 30, 2016,

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

2016-03-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/ --- (Updated March 30, 2016, 5:12 p.m.) Review request for mesos, Avinash

Re: Review Request 45265: Plugged in dvd isolator into agent.

2016-03-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/ --- (Updated 三月 30, 2016, 9:12 a.m.) Review request for mesos and Jie Yu.

Review Request 45484: Made CHANGELOG formatting more consistent.

2016-03-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45484/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 45434: Removed unused credentials.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45434/#review126090 --- Patch looks great! Reviews applied: [45434] Passed command:

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-03-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review126091 --- Can you please split the review between the code update and the

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-30 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review126083 --- Fix it, then Ship it! Some minor style suggestions, and then

Re: Review Request 45434: Added test cases for '/files' endpoint authentication.

2016-03-30 Thread Jan Schlicht
> On March 30, 2016, 2:38 a.m., Greg Mann wrote: > > BenM and I discussed this while I was working on the previous patches: > > since the code paths for the authenticated and unauthenticated cases are > > the same once the handler is reached, it shouldn't be necessary to > > explicitly test

Review Request 45477: Fixed typo in stout documentation.

2016-03-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45477/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 42516: Add support for user-defined networks.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review126081 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

2016-03-30 Thread Ezra Silvera
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 30, 2016, 7:52 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 45434: Removed unused credentials.

2016-03-30 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45434/ --- (Updated March 30, 2016, 10:20 a.m.) Review request for mesos, Adam B and Greg

Review Request 45476: Fixed common typo in libprocess documentation.

2016-03-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45476/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 42516: Add support for user-defined networks.

2016-03-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review126059 --- Fix it, then Ship it! Ship It! src/docker/docker.cpp (line

Re: Review Request 45477: Fixed typo in stout documentation.

2016-03-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45477/#review126062 --- Ship it! Ship It! - Alexander Rukletsov On March 30, 2016,

Re: Review Request 45476: Fixed common typo in libprocess documentation.

2016-03-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45476/#review126061 --- Ship it! There is one more in "help.cpp", I'll fix it for you.

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

2016-03-30 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126066 --- src/tests/slave_tests.cpp (lines 3541 - 3545)

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/#review126065 --- Patch looks great! Reviews applied: [45471] Passed command:

Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.

2016-03-30 Thread Deshi Xiao
> On 三月 30, 2016, 9:08 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 3541-3545 > > > > > > Here you shutdown the slave and wait (you'll probably want to advance > > the clock rather than wait for 90s)

Re: Review Request 45423: Added note about preventing resource autodetecting to documentation.

2016-03-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45423/#review126075 --- Ship it! Ship It! - Joris Van Remoortere On March 29, 2016,

Review Request 45480: Replace NULL with nullptr.

2016-03-30 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45480/ --- Review request for mesos and Michael Park. Bugs: MESOS-3243

Review Request 45482: Replace NULL with nullptr.

2016-03-30 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45482/ --- Review request for mesos and Michael Park. Bugs: MESOS-3243

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

2016-03-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/ --- (Updated March 30, 2016, 3:45 p.m.) Review request for mesos, Avinash

Re: Review Request 45466: Removed the redundant `NULL` check when deleting `Credential`.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45466/#review126056 --- Patch looks great! Reviews applied: [45466] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

2016-03-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review126057 --- Fix it, then Ship it! Ship It! src/docker/docker.cpp (lines

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

2016-03-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/ --- (Updated March 30, 2016, 4:36 p.m.) Review request for mesos, Avinash

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

2016-03-30 Thread Qian Zhang
> On March 30, 2016, 1:35 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 103 > > > > > > Why do we need to use a hashmap over here? Why not a vector or a list?

Re: Review Request 45473: Migrate test cases for `net_cls` subsystem to cgroups unified isolator.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45473/#review126077 --- Patch looks great! Reviews applied: [45083, 45084, 45350, 45085,

Re: Review Request 45419: Cleaned up ModuleManager.

2016-03-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45419/#review126078 --- Fix it, then Ship it! src/module/manager.hpp (line 35)

Re: Review Request 45475: Fixed typos in isolator test comments.

2016-03-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45475/#review126050 --- Ship it! Thank you for your quick reply! - haosdent huang

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

2016-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review126104 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

2016-03-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/ --- (Updated March 30, 2016, 9:39 p.m.) Review request for mesos, Avinash

Re: Review Request 45489: Replaced reinterpret_cast with dynamic_cast in libprocess.

2016-03-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45489/#review126115 --- 3rdparty/libprocess/src/process.cpp (line 1531)

Re: Review Request 45489: Replaced reinterpret_cast with dynamic_cast in libprocess.

2016-03-30 Thread Neil Conway
> On March 30, 2016, 3:03 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/process.cpp, line 1531 > > > > > > Here and below: Either explicitly assert that the `dynamic_cast` does > > not return `NULL`,

Re: Review Request 45318: Added comments to some libprocess functions.

2016-03-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45318/ --- (Updated March 30, 2016, 2:48 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45319: Cleaned up various code in libprocess.

2016-03-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45319/ --- (Updated March 30, 2016, 2:49 p.m.) Review request for mesos and Ben Mahler.

Review Request 45489: Replaced reinterpret_cast with dynamic_cast in libprocess.

2016-03-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45489/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 45488: Removed an unnecessary `memset` from libprocess.

2016-03-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45488/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 45466: Removed the redundant `NULL` check when deleting `Credential`.

2016-03-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45466/#review126111 --- Ship it! Ship It! - Neil Conway On March 30, 2016, 2:23

Re: Review Request 45270: Added spec protobut for external mount.

2016-03-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 三月 30, 2016, 3:17 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 45370: Implemented prepare() for dvd isolator.

2016-03-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 三月 30, 2016, 3:14 p.m.) Review request for mesos, Gilbert Song and

  1   2   >