Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-31 Thread Yongqiao Wang
> On March 30, 2016, 11:58 a.m., Adam B wrote: > > src/tests/master_allocator_tests.cpp, line 1519 > > > > > > Don't you at least know that one of these parameters is the master's > > pid? Do you mean the

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-31 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/ --- (Updated March 31, 2016, 7:15 a.m.) Review request for mesos and Adam B.

Re: Review Request 45482: Replace NULL with nullptr.

2016-03-31 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45482/ --- (Updated March 31, 2016, 7:42 a.m.) Review request for mesos and Michael Park.

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review126281 --- Patch looks great! Reviews applied: [45202] Passed command:

Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

2016-03-31 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

2016-03-31 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Re: Review Request 45482: Replace NULL with nullptr.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45482/#review126285 --- Patch looks great! Reviews applied: [45482] Passed command:

Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

2016-03-31 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated March 31, 2016, 5:43 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45529: Do not leak roleSorter and quotaRoleSorter in Mesos allocator.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45529/#review126300 --- Patch looks great! Reviews applied: [45529] Passed command:

Review Request 45535: Fixed PersistentVolumeTest `TearDown`.

2016-03-31 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45535/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

2016-03-31 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45536/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-03-31 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/#review126454 --- Bad patch! Reviews applied: [45371, 44378] Failed command:

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-31 Thread Anurag Singh
> On March 31, 2016, 5:25 p.m., Kapil Arya wrote: > > include/mesos/master/contender.hpp, line 65 > > > > > > I am wondering if `type` can be replaced with `moduleName` or something > > more explicit. as

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

2016-03-31 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45376/ --- (Updated April 1, 2016, 5:49 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45532: Renamed 'getNetworkInfoDir' to 'getContainerDir'.

2016-03-31 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45532/#review126467 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 11:31 a.m.,

Re: Review Request 45531: Made 'ROOT_DIR' a shared mount.

2016-03-31 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45531/#review126466 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 11:30 a.m.,

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45495/#review126302 --- Patch looks great! Reviews applied: [45491, 45492, 45493, 45494,

Re: Review Request 44571: Added timeout for destroying Docker containers.

2016-03-31 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44571/ --- (Updated March 31, 2016, 3:26 p.m.) Review request for mesos and Joris Van

Re: Review Request 45539: Added Hamburg Mesos User Group to community page.

2016-03-31 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45539/ --- (Updated March 31, 2016, 1:30 p.m.) Review request for mesos and Alexander

Re: Review Request 45539: Added Hamburg Mesos User Group to community page.

2016-03-31 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45539/ --- (Updated March 31, 2016, 1:30 p.m.) Review request for mesos and Alexander

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

2016-03-31 Thread Avinash sridharan
> On March 29, 2016, 5:35 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 151 > > > > > > Should have pointed in the earlier patches, why do we need `Info` to be

Re: Review Request 45555: Fix indent in docker executor health check code.

2016-03-31 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review126479 --- Ship it! Ship It! - Timothy Chen On March 31, 2016, 6:51

Re: Review Request 45556: Minor style cleanups to docker health check code.

2016-03-31 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45556/#review126478 --- Ship it! Ship It! - Timothy Chen On March 31, 2016, 6:51

Re: Review Request 45557: Clean up the health check launcher code in docker executor.

2016-03-31 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45557/#review126480 --- Ship it! Ship It! - Timothy Chen On March 31, 2016, 6:52

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45376/#review126481 --- Ship it! Ship It! - Vinod Kone On March 31, 2016, 9:49

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-31 Thread Cong Wang
> On March 31, 2016, 5:59 p.m., Cong Wang wrote: > > Why /var/run/netns could be in the same mount peer group with its parent? > > At least on fedora21 this is not the case. > > > > Also, why do you fix two bugs in one patch? I know you don't care about > > bisect, but even so this is still

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

2016-03-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated March 31, 2016, 9:22 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

2016-03-31 Thread Zhiwei Chen
> On April 1, 2016, 1:38 a.m., Vinod Kone wrote: > > 3rdparty/zookeeper-3.4.8.patch, line 13 > > > > > > Can you explain in the description what this patch is doing? It's not > > obvious. > > > > How does

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

2016-03-31 Thread Jie Yu
> On March 30, 2016, 6:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339 > > > > > > I think this is not needed because if recover fails, slave will restart. > > Qian

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

2016-03-31 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126469 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-03-31 Thread James Peach
> On March 31, 2016, 5:12 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, line 336 > > > > > > Plural? > > > > We often use a trailing understore: `char* directory_[]`.

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

2016-03-31 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/#review126474 --- Fix it, then Ship it! docs/configuration.md (line 354)

Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/#review126343 --- Ship it! Ship It! - Vinod Kone On March 31, 2016, 9:48

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout].

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/#review126348 --- Ship it! Ship It! - Vinod Kone On March 29, 2016, 7:14

Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/#review126350 --- Ship it! Ship It! - Vinod Kone On March 29, 2016, 7:14

Re: Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45368/#review126349 --- Ship it! Ship It! - Vinod Kone On March 29, 2016, 10:47

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-03-31 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review126200 --- src/slave/containerizer/mesos/isolators/xfs/utils.hpp (line 17)

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-03-31 Thread Alex Clemmer
> On March 18, 2016, 7:27 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 118 > > > > > > This is not necessarily `LD_LIBRARY_PATH` anymore, right? Here and > > below.

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/#review126336 --- src/Makefile.am

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review126359 --- - Kapil Arya On March 23, 2016, 7:04 p.m., Anurag Singh wrote:

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review125914 --- include/mesos/master/contender.hpp (line 19)

Re: Review Request 45528: [WIP] Upgrade http-parser to v2.6.2 [mesos].

2016-03-31 Thread Vinod Kone
> On March 31, 2016, 10:02 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [45528, 45527] > > > > Failed command: ./support/apply-review.sh -n -r 45527 > > > > Error: > > 2016-03-31 10:02:51 URL:https://reviews.apache.org/r/45527/diff/raw/ > > [125760/125760] ->

Re: Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

2016-03-31 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45536/#review126346 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 12:16 p.m.,

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

2016-03-31 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/ --- (Updated March 31, 2016, 5:15 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-03-31 Thread Jiang Yan Xu
> On March 31, 2016, 10:12 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, lines 366-368 > > > > > > In this method we can just validate the projectId first and then > > >

Re: Review Request 45451: Fix the local Docker puller for private registries.

2016-03-31 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45451/ --- (Updated March 31, 2016, 4:25 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45450: Add JSON::Object::at() helper API.

2016-03-31 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45450/ --- (Updated March 31, 2016, 4:25 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45534/#review126342 --- Bad patch! Reviews applied: [45534, 45533, 45529] Failed

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126318 --- src/tests/environment.cpp (lines 767 - 771)

Re: Review Request 45535: Fixed PersistentVolumeTest `TearDown`.

2016-03-31 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45535/#review126340 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 12:15 p.m.,

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

2016-03-31 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 31, 2016, 5:14 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- (Updated March 31, 2016, 5:14 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.

2016-03-31 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44080/ --- (Updated March 31, 2016, 4:40 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45439: Completed MVP implementation of the Nvidia GPU isolator.

2016-03-31 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45439/ --- (Updated March 31, 2016, 4:48 p.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review125919 --- include/mesos/v1/scheduler.hpp (lines 31 - 33)

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/#review126329 --- src/master/contenders/contender.hpp (line 42)

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review126356 --- src/master/flags.cpp (line 483)

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/#review126355 --- src/master/contenders/contender.cpp (line 99)

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/#review126358 --- Ship it! Ship It! - Kapil Arya On March 23, 2016, 7:04

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review126353 --- Can we rename test_contender_module.cpp to

Re: Review Request 44571: Added timeout for destroying Docker containers.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44571/#review126330 --- Bad patch! Reviews applied: [44571] Failed command:

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/#review126351 --- Ship it! Ship It! - Vinod Kone On March 29, 2016, 10:28

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review126352 --- Ship it! Ship It! - Vinod Kone On March 29, 2016, 10:34

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126322 --- Patch looks great! Reviews applied: [45535, 45536, 45537]

Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

2016-03-31 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45534/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4760

Review Request 45546: Implemented status() method of "network/cni" isolator.

2016-03-31 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Review Request 45533: Explicitly typed quota role sorter in Mesos allocator.

2016-03-31 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45533/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4760

Re: Review Request 45535: Fixed PersistentVolumeTest `TearDown`.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45535/#review126314 --- Ship it! Ship It! - Vinod Kone On March 31, 2016, 12:15

Re: Review Request 42516: Add support for user-defined networks.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review126310 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45536/#review126315 --- LGTM. I'll let Jie give the final ship it.

Re: Review Request 45529: Do not leak roleSorter and quotaRoleSorter in Mesos allocator.

2016-03-31 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45529/ --- (Updated March 31, 2016, 4:34 p.m.) Review request for mesos and Joris Van

Review Request 45553: Minor cleanups in validation logic for operator endpoints.

2016-03-31 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45553/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126376 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Re: Review Request 44382: Update leveldb-1.4.patch to support PowerPC LE platform.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44382/#review126382 --- Ship it! Ship It! - Vinod Kone On March 22, 2016, 8:44

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

2016-03-31 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126388 --- Fix it, then Ship it! Ship It!

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-31 Thread Jie Yu
> On March 31, 2016, 5:59 p.m., Cong Wang wrote: > > Why /var/run/netns could be in the same mount peer group with its parent? > > At least on fedora21 this is not the case. > > > > Also, why do you fix two bugs in one patch? I know you don't care about > > bisect, but even so this is still

Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/#review126401 --- can you rebase this? - Vinod Kone On March 31, 2016, 5:14

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-03-31 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review126360 --- src/Makefile.am

Re: Review Request 45520: Fixed the bind mount root issue in port mapping isolator.

2016-03-31 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45520/#review126372 --- Why /var/run/netns could be in the same mount peer group with its

Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45376/#review126364 --- 3rdparty/zookeeper-3.4.8.patch (line 13)

Re: Review Request 45439: Completed MVP implementation of the Nvidia GPU isolator.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45439/#review126395 --- Bad patch! Reviews applied: [45439, 44364, 44366, 44365, 44363,

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126405 --- Ship it! Ship It! - Vinod Kone On March 23, 2016, 1:07

Review Request 45556: Minor style cleanups to docker health check code.

2016-03-31 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45556/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Review Request 45557: Clean up the health check launcher code in docker executor.

2016-03-31 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45557/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Review Request 45555: Fix indent in docker executor health check code.

2016-03-31 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Re: Review Request 45553: Minor cleanups in validation logic for operator endpoints.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45553/#review126445 --- Patch looks great! Reviews applied: [45553] Passed command:

Re: Review Request 45553: Minor cleanups in validation logic for operator endpoints.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45553/#review126441 --- Ship it! Ship It! - Vinod Kone On March 31, 2016, 5:53

Re: Review Request 45439: Completed MVP implementation of the Nvidia GPU isolator.

2016-03-31 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45439/#review126415 --- Ship it! Looks good! We'll add some comments to the top of

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126429 --- Can you call this out specifically in the CHANGELOG (under

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

2016-03-31 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/#review126442 --- docs/configuration.md (line 361)

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

2016-03-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated March 31, 2016, 9 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-03-31 Thread Vinod Kone
> On March 14, 2016, 10:18 p.m., Anand Mazumdar wrote: > > Qian, any updates on this? > > Qian Zhang wrote: > Sorry Anand, I am a little busy on the implementation of CNI support in > Mesos, will get back to this patch soon. Do you still have cycles to work on this? If not, I can ask

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/#review126490 --- Bad patch! Reviews applied: [45213] Failed command:

Review Request 45571: A few cleanups and simplifications in CNI isolator.

2016-03-31 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Bugs: MESOS-4759

Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-03-31 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5029

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

2016-03-31 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45354/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

2016-03-31 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-03-31 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

2016-03-31 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/ --- (Updated April 1, 2016, 2:08 a.m.) Review request for mesos and Jie Yu.

  1   2   >