Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45596/#review127395 --- Ship it! Ship It! - Jie Yu On April 6, 2016, 5:33 p.m.,

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Joseph Wu
> On April 6, 2016, 10:10 a.m., Joseph Wu wrote: > > src/examples/long_lived_framework.cpp, lines 217-221 > > > > > > Would be nice to log something here. > > Anand Mazumdar wrote: > Logging an `ERROR` would be

Re: Review Request 45623: Renamed the parameter 'override' to '_override'.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45623/#review127387 --- Ship it! Ship It! - Vinod Kone On April 3, 2016, 8:30 a.m.,

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 6, 2016, 6:42 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 6, 2016, 6:42 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated April 6, 2016, 6:43 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45795: Fixed a memory leak in long lived executor.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45795/#review127422 --- Ship it! Ship It! - Vinod Kone On April 6, 2016, 3:43 a.m.,

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review127428 --- Bad patch! Reviews applied: [44670, 44669, 44289, 44547, 44546,

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-04-06 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/ --- (Updated April 6, 2016, 6:16 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review127404 --- src/examples/long_lived_framework.cpp (line 92)

Re: Review Request 45749: Adjusted lifetimes of member variables.

2016-04-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45749/#review127421 --- Ship it! Ship It! - Michael Park On April 5, 2016, 4:01

Re: Review Request 45796: Deleted the `run` method in long lived executor.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45796/#review127423 --- Ship it! Ship It! - Vinod Kone On April 6, 2016, 3:43 a.m.,

Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45803/#review127380 --- Patch looks great! Reviews applied: [45803] Passed command:

Re: Review Request 45797: Cleaned up the virtual overloads in long lived executor.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45797/#review127424 --- Ship it! Ship It! - Vinod Kone On April 6, 2016, 3:43 a.m.,

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127398 --- Bad patch! Reviews applied: [45668] Failed command: ['bash',

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45596/ --- (Updated April 6, 2016, 10:33 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 6, 2016, 6:43 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 6, 2016, 6:43 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45808/#review127391 --- src/master/master.cpp (lines 2085 - 2088)

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-06 Thread Anand Mazumdar
> On April 6, 2016, 5 p.m., haosdent huang wrote: > > src/launcher/http_command_executor.cpp, line 264 > > > > > > May you add a comment why need add `Second(1)` here? It's pretty self-explanatory that it's the

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/ --- (Updated April 6, 2016, 5:45 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Anand Mazumdar
> On April 6, 2016, 5:10 p.m., Joseph Wu wrote: > > src/examples/long_lived_framework.cpp, line 593 > > > > > > Does the HTTP scheduler driver initialize glog (like the old scheduler > > driver does)? It doesn't.

Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review127403 --- Fix it, then Ship it! src/examples/long_lived_framework.cpp

Re: Review Request 45801: Reset the `LIBPROCESS_IP` environment variable in `network/cni`.

2016-04-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45801/#review127406 --- Ship it! Ship It! - Jie Yu On April 6, 2016, 4:14 a.m.,

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127365 --- LGTM. src/examples/long_lived_framework.cpp (lines 216 - 220)

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread haosdent huang
> On April 5, 2016, 8:01 p.m., Kevin Klues wrote: > > support/hooks/commit-msg, line 20 > > > > > > You should probably quote the $LINE variable here. You should also use > > a single "=", not "==". The double

Re: Review Request 45596: Updated docker containerizer private registry doc.

2016-04-06 Thread Gilbert Song
> On April 2, 2016, 8:20 p.m., Guangya Liu wrote: > > docs/docker-containerizer.md, line 68 > > > > > > What about > > > > Rename `.docker/config.json` to `~/.docker/config.json` > > Rename `.dockercfg`

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 6, 2016, 6:42 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-06 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review127465 --- Fix it, then Ship it!

Re: Review Request 45798: Move long lived executor to use the v1 API.

2016-04-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45798/ --- (Updated April 6, 2016, 10:09 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45067: Update the long-lived-framework example.

2016-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated April 6, 2016, 3:16 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- (Updated April 6, 2016, 3:16 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 44947: Add tests for XFS project quota utilities.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated April 6, 2016, 10:35 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated April 6, 2016, 10:35 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45067: Updated the long-lived-framework example.

2016-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/ --- (Updated April 6, 2016, 3:34 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- (Updated April 6, 2016, 3:34 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-06 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review127367 --- Mostly LGTM. Just a few additional comments.

Re: Review Request 45798: Move long lived executor to use the v1 API.

2016-04-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45798/ --- (Updated April 6, 2016, 10:37 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread Michael Park
> On April 5, 2016, 8:01 p.m., Kevin Klues wrote: > > support/hooks/commit-msg, line 20 > > > > > > You should probably quote the $LINE variable here. You should also use > > a single "=", not "==". The double

Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45839/ --- Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone. Bugs:

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-04-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review127447 --- src/tests/containerizer/fs_tests.cpp (line 35)

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Add duplicate binaries.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review127432 --- Thanks for working on this! I've left some comments below. In

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-06 Thread Joseph Wu
> On April 6, 2016, 11:55 a.m., Vinod Kone wrote: > > src/examples/long_lived_framework.cpp, line 241 > > > > > > Looking at the code below I think it makes more sense to make > > LongLivedScheduler an instance of

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/ --- (Updated April 6, 2016, 9:30 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 45798: Move long lived executor to use the v1 API.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45798/#review127425 --- Fix it, then Ship it! src/examples/long_lived_executor.cpp

Re: Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Kevin Klues
> On April 6, 2016, 10:21 p.m., Kevin Klues wrote: > > Ship It! My only comment would be to add a comment about what this line is doing. It's not obvious that this is the delimiter used in verbose mode. - Kevin --- This is an

Re: Review Request 44949: Add XFS disk isolator tests.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated April 6, 2016, 10:37 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated April 6, 2016, 10:36 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-06 Thread James Peach
> On April 6, 2016, 9:07 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp, line 407 > > > > > > Should we assume that freeProjectId already doesn't include > > `info->projectId`?

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 6, 2016, 10:36 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

2016-04-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated April 6, 2016, 10:36 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review127448 --- Patch looks great! Reviews applied: [45358] Passed command:

Re: Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45839/#review127476 --- Ship it! Ship It! - Kevin Klues On April 6, 2016, 9:46

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/#review127467 --- Ship it! Ship It! - Kevin Klues On April 6, 2016, 9:30

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review127311 --- Patch looks great! Reviews applied: [45731] Passed command:

Re: Review Request 45767: Fixed commit message hook to iterate over the lines rather than words.

2016-04-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45767/#review127302 --- Ship it! Thanks! - Joerg Schad On April 5, 2016, 7:48 p.m.,

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Qian Zhang
> On April 6, 2016, 8:46 a.m., Avinash sridharan wrote: > > src/cli/execute.cpp, line 356 > > > > > > It would much simpler to have a single if conditional here as follows: > > if (networks.isSome()) { > >

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/ --- (Updated April 6, 2016, 3:56 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45381/#review127307 --- Patch looks great! Reviews applied: [45794, 45381] Passed

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/#review127497 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review127499 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:02

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/#review127496 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

2016-04-06 Thread fan du
> On 四月 6, 2016, 6:15 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 2089-2092 > > > > > > we always use braces around our if and else blocks. > > > > if () { > > > > } else { > > >

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

2016-04-06 Thread fan du
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45808/ --- (Updated 四月 7, 2016, 2:25 a.m.) Review request for mesos, Ben Mahler and Vinod

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127501 --- Bad patch! Reviews applied: [45800, 45799, 45440, 45067] Failed

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/#review127491 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03

Re: Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Michael Park
> On April 6, 2016, 10:21 p.m., Kevin Klues wrote: > > Ship It! > > Kevin Klues wrote: > My only comment would be to add a comment about what this line is doing. > It's not obvious that this is the delimiter used in verbose mode. Oh, good point! Thanks, will do. - Michael

Re: Review Request 44084: Windows: Forked os::rename().

2016-04-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/#review127502 --- 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp

Review Request 45854: Updated the default JSON representation of a Resource to include GPUs.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45854/ --- Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. Bugs:

Review Request 45856: Fixed Nvidia GPU test build for namespace change of MasterDetector.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45856/ --- Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. Bugs:

Review Request 45852: Added standard metrics for GPU resources.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45852/ --- Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. Bugs:

Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45855/ --- Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. Bugs:

Review Request 45853: Removed 'dashboard.js' from the webui.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45853/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5137

Re: Review Request 45854: Updated the default JSON representation of a Resource to include GPUs.

2016-04-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45854/#review127535 --- Ship it! Ship It! - haosdent huang On April 7, 2016, 1:54

Re: Review Request 44547: Added functions in promises to the future header.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/#review127490 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03

Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/#review127488 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review127487 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/#review127492 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03

Re: Review Request 44289: Added support for contender and detector modules.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review127489 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:03

Re: Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45839/ --- (Updated April 6, 2016, 11:08 p.m.) Review request for mesos, Joerg Schad,

Re: Review Request 45818: Fixed flakiness in PersistentVolumeTest.AccessPersistentVolume.

2016-04-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45818/#review127505 --- Ship it! Ship It! - Jie Yu On April 6, 2016, 4:35 p.m.,

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread haosdent huang
> On April 5, 2016, 8:01 p.m., Kevin Klues wrote: > > support/hooks/commit-msg, line 20 > > > > > > You should probably quote the $LINE variable here. You should also use > > a single "=", not "==". The double

Re: Review Request 45853: Removed 'dashboard.js' from the webui.

2016-04-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45853/#review127532 --- Ship it! Ship It! - haosdent huang On April 7, 2016, 1:54

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-04-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review127498 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:02

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/ --- (Updated April 6, 2016, 4:19 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45817: Cleaned up some comments.

2016-04-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45817/#review127503 --- Ship it! Ship It! - Jie Yu On April 6, 2016, 4:34 p.m.,

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-06 Thread haosdent huang
> On April 6, 2016, 5 p.m., haosdent huang wrote: > > src/launcher/http_command_executor.cpp, line 264 > > > > > > May you add a comment why need add `Second(1)` here? > > Anand Mazumdar wrote: > It's pretty

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45855/#review127534 --- docs/attributes-resources.md (line 40)

Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45852/#review127537 --- I suggest to split webui changes from this patch. - haosdent

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-06 Thread haosdent huang
> On April 6, 2016, 4:38 p.m., haosdent huang wrote: > > src/examples/dynamic_reservation_framework.cpp, line 181 > > > > > > How about add a default for unexpected state? May just log the error > > status. > >

Re: Review Request 44949: Add XFS disk isolator tests.

2016-04-06 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/#review127471 --- src/tests/containerizer/xfs_quota_tests.cpp (line 338)

Re: Review Request 45856: Fixed Nvidia GPU test build for namespace change of MasterDetector.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45856/#review127541 --- Patch looks great! Reviews applied: [45856] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated April 7, 2016, 11:23 a.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-06 Thread Klaus Ma
> On April 7, 2016, 12:38 a.m., haosdent huang wrote: > > src/examples/dynamic_reservation_framework.cpp, line 181 > > > > > > How about add a default for unexpected state? May just log the error > > status.

Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

2016-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45808/#review127545 --- Ship it! Ship It! - Vinod Kone On April 7, 2016, 2:25 a.m.,

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127556 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-06 Thread Qian Zhang
> On April 5, 2016, 2:26 p.m., Avinash sridharan wrote: > > src/cli/execute.cpp, line 322 > > > > > > We should support this for `DockerContainerizer` as well, since > > MESOS-4369 is going use the `name` field to

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-06 Thread Klaus Ma
> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 69-70 > > > > > > Initialize these in member init list. > > > > ```cpp > > : ... > >

Re: Review Request 37168: Add an example framework using dynamic reservation.

2016-04-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated April 6, 2016, 4:19 p.m.) Review request for mesos, Greg Mann, Joerg

Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

2016-04-06 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45803/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4897

  1   2   >