Review Request 46024: Avoided misleading locking in the libprocess SocketManager.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46024/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 46023: Cleaned up dynamic reservation example framework.

2016-04-11 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46023/#review128120 --- Ship it! Ship It! - Klaus Ma On April 11, 2016, 10 p.m.,

Re: Review Request 46033: Removed request body from some error responses in quota handler.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46033/ --- (Updated April 11, 2016, 3:16 p.m.) Review request for mesos and Joerg Schad.

Re: Review Request 45209: Made sure all Python modules are installed.

2016-04-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45209/ --- (Updated April 11, 2016, 2:27 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45984/#review128134 --- Ship it! Could you please briefly explain the problem with the

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review128096 --- Bad patch! Reviews applied: [45500] Failed command:

Re: Review Request 45209: Made sure all Python modules are installed.

2016-04-11 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45209/#review128098 --- Ship it! Ship It! - Bernd Mathiske On April 11, 2016, 5:15

Review Request 46026: Documented `Socket::shutdown()` member function in libprocess.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46026/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 46029: Mark a few private functions `static` in libprocess tests.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46029/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 46027: Documented `libprocess` helper function.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46027/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 46030: Used initializer list hashmap constructor in libprocess test.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46030/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 46034: Avoided globbing in commit message hook.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46034/ --- Review request for mesos, Artem Harutyunyan, Joerg Schad, and Vinod Kone.

Review Request 46033: Removed request body from some error responses in quota handler.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46033/ --- Review request for mesos and Joerg Schad. Repository: mesos Description

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Alexander Rukletsov
> On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > > > > > Not yours: Above the request.body is included in the output. Feels > > inconsistent here... > > Alexander

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

2016-04-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45984/#review128130 --- Ship it! Ship It! - Joerg Schad On April 10, 2016, 6:41

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/#review128132 --- Patch looks great! Reviews applied: [45898, 44090, 45888, 45940,

Re: Review Request 46034: Avoided globbing in commit message hook.

2016-04-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46034/#review128133 --- I guess this is duplicating https://reviews.apache.org/r/45984 -

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-11 Thread Klaus Ma
> On April 11, 2016, 10:09 p.m., Klaus Ma wrote: > > Ship It! LGTM. Just wonder how to handle the input that did not follow our expectation: // value,event,cgroup // value,unit,event,cgroup // value,unit,event,cgroup,running,ratio - Klaus

Review Request 46025: Clarified comments on socket data structures in SocketManager.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46025/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 46033: Removed request body from some error responses in quota handler.

2016-04-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46033/#review128127 --- Fix it, then Ship it! src/master/quota_handler.cpp (line 265)

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-11 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review128117 --- Ship it! Ship It! - Klaus Ma On April 11, 2016, 3:01 p.m.,

Re: Review Request 46024: Avoided misleading locking in the libprocess SocketManager.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46024/ --- (Updated April 11, 2016, 2:36 p.m.) Review request for mesos and Ben Mahler.

Review Request 46028: Improved comments in SocketManager::next().

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/ --- (Updated April 11, 2016, 2:48 p.m.) Review request for mesos, Yongqiao Wang

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

2016-04-11 Thread Neil Conway
> On April 11, 2016, 10:44 p.m., Ben Mahler wrote: > > Mind doing a sweep for this? I noticed a few more candidates in `futures_test.cpp` and added them to the RR; I didn't try to look beyond the libprocess tests. - Neil --- This is

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46029/ --- (Updated April 12, 2016, 12:13 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45932: Add stripped TaskInfo's to ResourceUsage.Executor message.

2016-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45932/ --- (Updated April 12, 2016, 5 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

2016-04-11 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated April 12, 2016, 5 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

2016-04-11 Thread Anindya Sinha
> On April 9, 2016, 9:02 a.m., Guangya Liu wrote: > > You may want to rebase this patch for dynamic_reservation_framework.cpp as > > well. Yes, done. - Anindya --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-11 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/ --- (Updated 四月 12, 2016, 5:20 a.m.) Review request for mesos, Guangya Liu, Neil

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-11 Thread zhou xing
> On 四月 7, 2016, 10:13 p.m., Neil Conway wrote: > > docs/persistent-volume.md, line 296 > > > > > > Replace "Returns `202 ACCEPTED` which" with "This endpoint returns the > > `202 ACCEPTED` HTTP status code, which

Re: Review Request 45932: Adds task information to container resource usage information.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45932/#review128340 --- Patch looks great! Reviews applied: [45572, 45932] Passed

Re: Review Request 46003: Removed the default value for agent work_dir.

2016-04-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/#review128278 --- src/local/local.cpp (line 353)

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/ --- (Updated April 12, 2016, 4:59 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.

2016-04-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45954/ --- (Updated April 12, 2016, 2:09 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45955: Added CNI helper subcommand to `mesos-containerizer`.

2016-04-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45955/ --- (Updated April 12, 2016, 2:10 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45932: Add stripped TaskInfo's to ResourceUsage.Executor message.

2016-04-11 Thread Zhitao Li
> On April 9, 2016, 12:27 a.m., Ben Mahler wrote: > > include/mesos/mesos.proto, line 1032 > > > > > > Can we omit this? Why did you include it? I'll drop this as I don't have a good reason to use it for now. The

Re: Review Request 45932: Adds task information to container resource usage information.

2016-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45932/ --- (Updated April 12, 2016, 5:03 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45932: Adds task information to container resource usage information.

2016-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45932/ --- (Updated April 12, 2016, 5:03 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46027: Documented `libprocess` helper function.

2016-04-11 Thread Neil Conway
> On April 11, 2016, 9:55 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 559-562 > > > > > > Hm.. this may be a bit confusing for those without context. A > > libprocess message can be sent

Re: Review Request 46027: Documented `libprocess` helper function.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46027/ --- (Updated April 12, 2016, 12:23 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46024: Avoided misleading locking in the libprocess SocketManager.

2016-04-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46024/#review128319 --- Ship it! Ship It! - Ben Mahler On April 11, 2016, 2:36

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

2016-04-11 Thread Guangya Liu
> On April 8, 2016, 6:10 p.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 97-100 > > > > > > Might be nice to note that this is ignored if `flags.shell` is false. > > Alexander Rukletsov wrote: > It's true

Re: Review Request 46028: Improved comments in SocketManager::next().

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/ --- (Updated April 11, 2016, 11:52 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45970/#review128298 --- Patch looks great! Reviews applied: [45969, 46053, 45970]

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Joseph Wu
> On April 11, 2016, 2:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

2016-04-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45927/#review128305 --- Ship it! LGTM, modulo the patch-applying issue ReviewBot has.

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Joseph Wu
> On April 11, 2016, 2:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 46028: Improved comments in SocketManager::next().

2016-04-11 Thread Neil Conway
> On April 11, 2016, 10:42 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 1947-1954 > > > > > > The implication of this comment (regardless of your changes) seems to > > be that the socket

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Jojy Varghese
> On April 11, 2016, 9:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 46053: Added logic to validate for non-fractional GPU requests in the master.

2016-04-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46053/#review128310 --- Ship it! Ship It! - Ben Mahler On April 11, 2016, 10:11

Re: Review Request 45969: Fixed indent in Nvidia GPU test.

2016-04-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45969/#review128309 --- Ship it! Ship It! - Ben Mahler On April 11, 2016, 10:19

Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

2016-04-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45970/#review128307 --- Ship it!

Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.

2016-04-11 Thread Avinash sridharan
> On April 11, 2016, 7 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 198 > > > > > > Please stick to our style guide by moving '{' to the next line. Removed this

Re: Review Request 45956: Added the `_isolate` method.

2016-04-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 12, 2016, 2:13 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review128094 --- Patch looks great! Reviews applied: [44379] Passed command:

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-04-11 Thread Neil Conway
> On April 11, 2016, 4:06 a.m., Kevin Klues wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2170-2195 > > > > > > Is there a reason, we can't just remove the gc process from the list as > > a preliminary

Re: Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

2016-04-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45983/#review128103 --- Ship it! Ship It! - Qian Zhang On April 10, 2016, 12:32

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Joerg Schad
> On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > > > > > Not yours: Above the request.body is included in the output. Feels > > inconsistent here... > > Alexander

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Alexander Rukletsov
> On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > > > > > Not yours: Above the request.body is included in the output. Feels > > inconsistent here... > > Alexander

Re: Review Request 45952: Implemented support for passing agent default docker config.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/#review128116 --- Patch looks great! Reviews applied: [45949, 45950, 45951, 45952]

Review Request 46023: Cleaned up dynamic reservation example framework.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46023/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 45863: Updated error messages in weights handler.

2016-04-11 Thread Alexander Rukletsov
> On April 7, 2016, 11:07 a.m., Joerg Schad wrote: > > src/master/weights_handler.cpp, line 90 > > > > > > Not yours: Above the request.body is included in the output. Feels > > inconsistent here... Above are

Review Request 46035: Introduced `exposed_ports` field in `NetworkInfo`.

2016-04-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46035/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4823

Re: Review Request 45014: Add /containers endpoint.

2016-04-11 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 11, 2016, 4:28 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46003: Removed the default value for agent work_dir.

2016-04-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/ --- (Updated April 11, 2016, 4:29 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

2016-04-11 Thread Alexander Rukletsov
> On April 9, 2016, 2:32 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 157 > > > > > > I can see many people ask the format of `time` in user list, it would > > be great if we can list all supported unit

Review Request 46003: Removed the default value for agent work_dir.

2016-04-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5064

Review Request 46005: Updated agent work_dir references to Option type.

2016-04-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46005/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5064

Review Request 46004: Updated master '--work_dir' help string.

2016-04-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46004/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5064

Re: Review Request 45562: Edited `--work_dir` configuration docs.

2016-04-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated April 11, 2016, 4:38 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 46015: Stout:[2/2] Moved process tests to their own file.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46015/#review128152 --- Bad patch! Reviews applied: [46015, 46014, 46013, 46012, 43985]

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

2016-04-11 Thread Alexander Rukletsov
> On April 9, 2016, 2:24 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 100 > > > > > > I think we cannot sepcify the entrypoint for container here, the > > entrypoint was runtime configuration and was get

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

2016-04-11 Thread Alexander Rukletsov
> On April 8, 2016, 6:10 p.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 97-100 > > > > > > Might be nice to note that this is ignored if `flags.shell` is false. It's true for the _current_ code in

Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 46010: Stout:[2/2] Added simple process environment tests.

2016-04-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46010/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

2016-04-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46009/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/#review128085 --- Patch looks great! Reviews applied: [45991, 45995, 45996, 45999]

Review Request 46015: Stout:[2/2] Moved process tests to their own file.

2016-04-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46015/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 46014: Stout:[1/2] Moved process tests to their own file.

2016-04-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46014/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 45917: Disable http-parser strict mode to allow flexible http header fields.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45917/#review128077 --- Patch looks great! Reviews applied: [45917] Passed command:

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

2016-04-11 Thread Deshi Xiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 11, 2016, 7:15 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-11 Thread Deshi Xiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 四月 11, 2016, 7:23 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 45952: Implemented support for passing agent default docker config.

2016-04-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/#review128078 --- src/uri/fetchers/docker.cpp (lines 323 - 325)

Re: Review Request 45949: Implemented docker config get credential helper.

2016-04-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45949/#review128079 --- src/docker/spec.cpp (line 188)

Re: Review Request 45952: Implemented support for passing agent default docker config.

2016-04-11 Thread Guangya Liu
> On 四月 11, 2016, 7:37 a.m., Guangya Liu wrote: > > src/uri/fetchers/docker.cpp, line 636 > > > > > > Add a log here to identify that the fetcher is now using auth to fetch > > the image? Adding the log in

Re: Review Request 45200: Duplicate flags with keyword 'slave'.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45200/#review128089 --- Patch looks great! Reviews applied: [45200] Passed command:

Re: Review Request 45925: Extended logging for task status updates in mesos-execute.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45925/ --- (Updated April 11, 2016, 6:59 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

2016-04-11 Thread Alexander Rukletsov
> On April 8, 2016, 6:14 p.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 639-651 > > > > > > Given how these flags are pretty much all passed into the > > `CommandScheduler`, can you add another patch that

Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/ --- Review request for mesos, Anand Mazumdar and Joseph Wu. Repository: mesos

Re: Review Request 45955: Added CNI helper binary `mesos-cni-helper`.

2016-04-11 Thread Jie Yu
> On April 11, 2016, 5:02 p.m., Jie Yu wrote: > > Instead of creating a new helper binary, can we use the mesos-containerizer > > binary? > > > > We need to namespace the subcommand properly to avoid conflicts. We can use > > 'network-cni-setup' as the name of the subcommand. > > Avinash

Re: Review Request 45956: Added the `_isolate` method.

2016-04-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review128211 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128216 --- src/cli/execute.cpp (line 306)

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

2016-04-11 Thread Zhitao Li
> On April 9, 2016, 12:16 a.m., Ben Mahler wrote: > > Looks pretty good, thanks! > > > > Could you also add tests that mirror the task label tests? > > > > ``` > > $ grep -R TEST src/tests | grep TaskLabels > > src/tests/master_tests.cpp:TEST_F(MasterTest, TaskLabels) > >

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

2016-04-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45926/ --- (Updated April 11, 2016, 7 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.

2016-04-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45954/#review128168 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 45985: Fixed the commit message hook to use `echo -n` instead.

2016-04-11 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45985/#review128213 --- Ship it! Ship It! - Kevin Klues On April 10, 2016, 6:43

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 11, 2016, 7:19 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46024: Avoided misleading locking in the libprocess SocketManager.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46024/#review128220 --- Patch looks great! Reviews applied: [46025, 46026, 46027, 46028,

  1   2   >