Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/ --- (Updated April 13, 2016, 5:13 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44427: Added --http_command_executor flag.

2016-04-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44427/ --- (Updated April 13, 2016, 5:14 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/ --- (Updated April 13, 2016, 5:15 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45360: Added dvd client for mount and unmount.

2016-04-13 Thread Guangya Liu
> On 四月 4, 2016, 11:37 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp, line 54 > > > > > > `driver_options` is an optional field, right? This may lead to segfault.

Re: Review Request 45360: Added dvd client for mount and unmount.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 13, 2016, 9:17 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45360: Added dvd client for mount and unmount.

2016-04-13 Thread Guangya Liu
> On 四月 5, 2016, 4:55 p.m., haosdent huang wrote: > > > > haosdent huang wrote: > By the way, I saw you didn't support `create`, `remove` and `path` > methods while it exists in dvdcli. Are they unnecessary here? We do not need to use those methods but only `mount` and `umount`. 1) We

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/ --- (Updated 四月 13, 2016, 9:26 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review128640 --- src/tests/master_allocator_tests.cpp (line 1604)

Re: Review Request 45956: Added the `_isolate` method.

2016-04-13 Thread Avinash sridharan
> On April 13, 2016, 5:16 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 716-717 > > > > > > What if IP is not found? Should we use 127.0.0.1? If the container does not

Re: Review Request 45956: Added the `_isolate` method.

2016-04-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 13, 2016, 7:18 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 42342: Added a new test cases for revive offer.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review128627 --- src/tests/hierarchical_allocator_tests.cpp (line 3040)

Review Request 46140: Some clean up in allocator test.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 42342: Added a new test cases for revive offer.

2016-04-13 Thread Guangya Liu
> On 四月 13, 2016, 7:37 a.m., Alexander Rukletsov wrote: > > Thanks Alex, I create a patch here https://reviews.apache.org/r/46140/ - Guangya --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44427: Added --http_command_executor flag.

2016-04-13 Thread Qian Zhang
> On April 13, 2016, 5:07 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 5857-5870 > > > > > > I think this will break slave recovery when a slave is restarted with > > the flag set to true. This is

Re: Review Request 45670: Added tests for HTTP command executor.

2016-04-13 Thread Qian Zhang
> On April 13, 2016, 5:11 a.m., Vinod Kone wrote: > > src/tests/command_executor_tests.cpp, line 67 > > > > > > This is not really a type, this is a bool. > > > > s/ExecutorType/IsHTTPCommandExecutor/

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-13 Thread Guangya Liu
> On 四月 4, 2016, 11:16 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp, line 28 > > > > > > Should we add a inline parse method here? Seems not as the dvd isolator do not

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 13, 2016, 7:16 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45360: Added dvd client for mount and unmount.

2016-04-13 Thread Guangya Liu
> On 四月 4, 2016, 11:37 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp, lines > > 67-71 > > > > > > could we set `dvdcliPath + /dvdcli` as cmd, and append the rest as

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review128634 --- Patch looks great! Reviews applied: [46135] Passed command:

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-13 Thread Qian Zhang
> On April 13, 2016, 4:24 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, lines 296-297 > > > > > > No need to capture taskId because you can get it from `task`? I think just capuring `task` is

Re: Review Request 44334: Cleaned up empty hashmaps from allocator tests.

2016-04-13 Thread Benjamin Bannier
> On March 4, 2016, 12:59 p.m., Bernd Mathiske wrote: > > "{}" is short, but cryptic. It is unclear what kind of entity is being > > passed here. "EMPTY" was not any better. "hashmap()" at > > least revealed the type which hinted a little at the presumable purpose. A > >

Re: Review Request 44334: Cleaned up empty hashmaps from allocator tests.

2016-04-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44334/#review128631 --- Fix it, then Ship it!

Re: Review Request 45922: Added agent authorization flags.

2016-04-13 Thread Adam B
> On April 12, 2016, 2:31 a.m., Adam B wrote: > > docs/configuration.md, line 94 > > > > > > Why would we need to support multiple authorizers? Would a particular > > request check two authorizers then and/or the

Re: Review Request 44334: Replaced empty hashmaps with {} in allocator tests.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44334/ --- (Updated April 13, 2016, 9:38 a.m.) Review request for mesos, Benjamin

Re: Review Request 44334: Replaced empty hashmaps with {} in allocator tests.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44334/ --- (Updated April 13, 2016, 9:34 a.m.) Review request for mesos, Benjamin

Re: Review Request 44335: Moved variable declarations closer to where they are used.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44335/ --- (Updated April 13, 2016, 9:38 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-13 Thread Yongqiao Wang
> On April 13, 2016, 9:27 a.m., Alexander Rukletsov wrote: > > src/tests/master_allocator_tests.cpp, line 1637 > > > > > > You don't need this `settle()`. According to my understanding, call Clock::settle() after

Re: Review Request 44335: Moved variable declarations closer to where they are used.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44335/ --- (Updated April 13, 2016, 10:07 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44336: Removed numeric suffixes where appropriate in allocator tests.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44336/ --- (Updated April 13, 2016, 10:07 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44335: Moved variable declarations closer to where they are used.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44335/ --- (Updated April 13, 2016, 10:08 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-13 Thread Alexander Rukletsov
> On April 13, 2016, 9:27 a.m., Alexander Rukletsov wrote: > > src/tests/master_allocator_tests.cpp, line 1604 > > > > > > If you're not doing any checks with resources, you can use > > `Future` instead. > >

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128646 --- src/cli/execute.cpp

Re: Review Request 46119: Added documentation around using AuthN for HTTP frameworks.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46119/#review128622 --- Bad patch! Reviews applied: [46119, 46118, 46117, 46116, 46115,

Review Request 46139: Add positive tests for /weights endpoint.

2016-04-13 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/ --- Review request for mesos and Adam B. Bugs: MESOS-4316

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-13 Thread Guangya Liu
> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote: > > src/cli/execute.cpp, line 104 > > > > > > Do we introduce 'arguments' flag? It looks like you treat 'command' > > flag as command + arguments. This comment

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review128649 --- Patch looks great! Reviews applied: [45731] Passed command:

Re: Review Request 46140: Some clean up in allocator test.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/#review128655 --- Bad patch! Reviews applied: [46140] Failed command:

Re: Review Request 46102: Fixed logic error in execute.cpp.

2016-04-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46102/#review128647 --- Ship it! Ship It! - Alexander Rukletsov On April 12, 2016,

Review Request 46142: Added Criteo to Powered by Mesos page.

2016-04-13 Thread Pierre Cheynier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46142/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review128658 --- Bad patch! Reviews applied: [45670, 44427, 44424, 44423] Failed

Re: Review Request 44427: Added --http_command_executor flag.

2016-04-13 Thread Qian Zhang
> On April 13, 2016, 5:07 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 5857-5870 > > > > > > I think this will break slave recovery when a slave is restarted with > > the flag set to true. This is

Re: Review Request 45922: Added agent authorization flags.

2016-04-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review128666 --- src/tests/cluster.cpp (lines 398 - 410)

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-13 Thread Qian Zhang
> On April 13, 2016, 4:24 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, lines 804-809 > > > > > > Lets fix this hack now that the executor receives acknowledgements for > > status updates. > >

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128680 --- Patch looks great! Reviews applied: [1] Passed command:

Re: Review Request 44423: Added HTTP command executor to make files.

2016-04-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44423/ --- (Updated April 13, 2016, 9:30 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-13 Thread Vinod Kone
The ack to the executor is done by the slave as soon as it checkpoints it. @vinodkone > On Apr 13, 2016, at 7:17 AM, Qian Zhang wrote: > > > >>> On April 13, 2016, 4:24 a.m., Vinod Kone wrote: >>> src/launcher/http_command_executor.cpp, lines 804-809 >>>

Re: Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

2016-04-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45983/ --- (Updated April 13, 2016, 2:19 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 46035: Introduced `exposed_ports` field in `NetworkInfo`.

2016-04-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46035/ --- (Updated April 13, 2016, 2:20 p.m.) Review request for mesos and Jie Yu.

Review Request 46149: Speed up ExamplesTest.DynamicReservationFramework.

2016-04-13 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46149/ --- Review request for mesos, Benjamin Bannier and Michael Park. Bugs: MESOS-5166

Review Request 46146: Fixed libprocess tests to use smart pointers.

2016-04-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46146/ --- Review request for mesos, Benjamin Bannier and Joris Van Remoortere.

Re: Review Request 46094: Fixed memory leaks in Encoder/Decoder tests in libprocess.

2016-04-13 Thread Neil Conway
> On April 12, 2016, 2:16 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/tests/decoder_tests.cpp, line 202 > > > > > > Here and everywhere below: This still leaks if any of above `EXPECT_*` > > fail; in

Re: Review Request 46142: Added Criteo to Powered by Mesos page.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46142/#review128692 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
> On 四月 13, 2016, 11:25 p.m., Vinod Kone wrote: > > Looks like ReviewBot failed. Can you make sure to fix that issue? Otherwise > > LGTM. > > Kevin Klues wrote: > It looks like it's failing on this step: > ``` > make[5]: Entering directory `/mesos/mesos-0.29.0/_build/src' > cp

Re: Review Request 45500: Keep fs::mount information should be consolidated.

2016-04-13 Thread Deshi Xiao
> On 四月 6, 2016, 9:04 p.m., Neil Conway wrote: > > src/tests/containerizer/fs_tests.cpp, line 35 > > > > > > Not yours, but we should sort these alphabetically. @Neil Conway how aobut your feedback. - Deshi

Re: Review Request 45360: Added volume client for mount and unmount.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 14, 2016, 4:45 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/ --- (Updated April 14, 2016, 5:21 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/ --- (Updated 四月 14, 2016, 4:37 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- (Updated 四月 14, 2016, 5 a.m.) Review request for mesos, Kevin Klues and Vinod

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-13 Thread Qian Zhang
> On April 13, 2016, 4:24 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, lines 804-809 > > > > > > Lets fix this hack now that the executor receives acknowledgements for > > status updates. > >

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128829 --- src/Makefile.am (lines 2135 - 2139)

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- (Updated 四月 14, 2016, 4:24 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 14, 2016, 4:23 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/#review128835 --- Ship it! It looks like the ReviewBot ran between the two most

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/ --- (Updated 四月 14, 2016, 4:57 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/ --- (Updated April 14, 2016, 5:05 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

2016-04-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46014/ --- (Updated April 14, 2016, 2:06 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 14, 2016, 3:23 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45214: Updated protobuf to support external storage.

2016-04-13 Thread Guangya Liu
> On 四月 13, 2016, 9:35 p.m., James DeFelice wrote: > > include/mesos/mesos.proto, line 1625 > > > > > > I definitely prefer this form, but there's also a Parameters message > > type. Which is more idiomatic in

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

2016-04-13 Thread Guangya Liu
> On 四月 13, 2016, 9:01 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 64 > > > > > > should we verify that the dvdcli binary actually exists here (and if > > not

Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 14, 2016, 4:41 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128834 --- Ship it! Ship It! - Kevin Klues On April 14, 2016, 4:23

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 14, 2016, 5:01 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46035: Introduced `exposed_ports` field in `NetworkInfo`.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46035/#review128703 --- Patch looks great! Reviews applied: [46035] Passed command:

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128714 --- Ship it! Looks great! I've commeted in the JIRA with my final

Re: Review Request 45265: Plugged in dvd isolator into agent.

2016-04-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/#review128724 --- Let's put this patch in the end of the patch chain. We don't want

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- (Updated April 13, 2016, 6:43 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/#review128708 --- Ship it! Looks good! Only thing I'd add is to fill in the

Re: Review Request 46146: Fixed libprocess tests to use smart pointers.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46146/#review128722 --- Patch looks great! Reviews applied: [45991, 45995, 45996, 45999,

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- (Updated April 13, 2016, 6:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 13, 2016, 6:47 p.m.) Review request for mesos, Gilbert Song,

Review Request 46158: Completed implementation of the cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-13 Thread Juan Larriba
> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > > > > > See the ASF CI build error on the attached ticket. > > > > I think specifying configuration options this way

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/ --- (Updated April 13, 2016, 6:46 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45472/ --- (Updated April 13, 2016, 6:47 p.m.) Review request for mesos, Avinash

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 13, 2016, 6:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45573: Add `PerfEventHandleManager`.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated April 13, 2016, 6:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45352/ --- (Updated April 13, 2016, 6:46 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46114: Fixed per framework principal metrics for HTTP frameworks.

2016-04-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46114/#review128730 --- src/master/master.cpp (lines 5939 - 5941)

Re: Review Request 46043: Completed default implementation of `Subsystem` abstraction.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46043/ --- (Updated April 13, 2016, 6:45 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46113: Simplified a conditional check while validating framework id.

2016-04-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46113/#review128728 --- Ship it! Ship It! - Vinod Kone On April 12, 2016, 10:25

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated April 13, 2016, 6:46 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45670: Updated tests for HTTP command executor.

2016-04-13 Thread Qian Zhang
> On April 13, 2016, 5:11 a.m., Vinod Kone wrote: > > Are you also planning to update slave recovery tests? Those are the most > > crucial. Sure, I will update slave recovery tests soon. Just want to double confirm, in `slave_recovery_tests.cpp`, I see there are two TODOs related to HTTP

Re: Review Request 46094: Fixed memory leaks in Encoder/Decoder tests in libprocess.

2016-04-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46094/ --- (Updated April 13, 2016, 2:23 p.m.) Review request for mesos, Joris Van

Re: Review Request 45922: Added agent authorization flags.

2016-04-13 Thread Jan Schlicht
> On April 12, 2016, 11:31 a.m., Adam B wrote: > > docs/configuration.md, line 94 > > > > > > Why would we need to support multiple authorizers? Would a particular > > request check two authorizers then and/or the

Re: Review Request 45084: Added stubs for the `Subsystem` abstraction of cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/ --- (Updated April 13, 2016, 6:45 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45217: Implemented docker volume driver isolator interface.

2016-04-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/#review128721 --- Fix it, then Ship it! src/CMakeLists.txt (line 143)

Re: Review Request 45614: Windows: Implemented os::close for Windows.

2016-04-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45614/ --- (Updated April 13, 2016, 6:21 p.m.) Review request for mesos, Alex Naparu,

Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

2016-04-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46164/ --- Review request for mesos. Bugs: MESOS-5171

Review Request 46160: Exposed zookeeper/authentication.hpp.

2016-04-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46160/ --- Review request for mesos. Bugs: MESOS-5171

  1   2   >