Re: Review Request 46114: Fixed per framework principal metrics for HTTP frameworks.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46114/ --- (Updated April 15, 2016, 4:35 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/ --- (Updated April 15, 2016, 4:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46209: Explicitly set `FrameworkInfo.principal` if AuthN is enabled.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46209/ --- (Updated April 15, 2016, 4:35 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Anand Mazumdar
> On April 15, 2016, 12:42 a.m., Vinod Kone wrote: > > src/master/flags.cpp, line 482 > > > > > > do we need a default here? we needed a default for > > `--http_authenticators` for backwards compatibility. since

Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46212/ --- (Updated April 15, 2016, 4:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Anand Mazumdar
- Anand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review129044 --- On April 15, 2016, 4:39 p.m., Anand Mazumdar wrote: >

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-15 Thread fan du
> On April 11, 2016, 7:08 a.m., haosdent huang wrote: > > Thanks you very much for your quick reply! By the way, this patch should > > credited by you, please update the description and remove my name. Quite > > appreciated your great help again so that I could rebase my patches depend > > on

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- (Updated 四月 15, 2016, 3:27 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45360: Added volume client for mount and unmount.

2016-04-15 Thread Guangya Liu
> On 四月 14, 2016, 6:12 p.m., Gilbert Song wrote: > > We can talk more for your comments when sync up. ;-) - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review128931

Re: Review Request 45270: Added spec protobuf for external mount.

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 15, 2016, 2:23 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 15, 2016, 2:44 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45326: Implemented os::which().

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/ --- (Updated 四月 15, 2016, 3:07 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-15 Thread Guangya Liu
> On 四月 14, 2016, 6:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 72-73 > > > > > > How about moving "' used by volume isolator" to the second line?

Re: Review Request 45360: Added volume client for mount and unmount.

2016-04-15 Thread Guangya Liu
> On 四月 14, 2016, 9:27 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/volume_client.cpp, > > lines 60-61 > > > > > > Let's use `https://github.com/emccode/rexray`, which is under

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 15, 2016, 2:43 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45326: Implemented os::which().

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/ --- (Updated 四月 15, 2016, 3:06 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/ --- (Updated April 15, 2016, 5:49 p.m.) Review request for mesos, Adam B and

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-15 Thread Greg Mann
> On April 15, 2016, 12:03 p.m., Alexander Rojas wrote: > > src/tests/logging_tests.cpp, line 148 > > > > > > Too keep it consistent, could you add subtests for wrong credentials > > and one which succeeds?

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

2016-04-15 Thread Michael Park
> On April 14, 2016, 9:55 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, lines > > 355-360 > > > > > > If we pull out `internal::os_version`, we could do less work

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Vinod Kone
> On April 14, 2016, 5:33 p.m., Greg Mann wrote: > > src/master/flags.cpp, lines 225-226 > > > > > > This seems a tiny bit misleading: if the value is `false`, no > > authentication will be performed at all.

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46254/ --- (Updated April 15, 2016, 5:49 p.m.) Review request for mesos, Adam B and

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

2016-04-15 Thread Greg Mann
> On April 15, 2016, 10:35 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/gtest.hpp, line 31 > > > > > > Something tells me there should be a comment here, but I don't know > > exactly what its

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/ --- (Updated April 15, 2016, 6:55 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46212/ --- (Updated April 15, 2016, 7:04 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-15 Thread Greg Mann
> On April 15, 2016, 11:39 a.m., Alexander Rojas wrote: > > src/tests/metrics_tests.cpp, line 288 > > > > > > To be consistent with your other patches, could you add tests for wrong > > credentials. > > > >

Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46118/ --- (Updated April 15, 2016, 7:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45326: Implemented os::which().

2016-04-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review129156 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/which.hpp

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

2016-04-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46163/#review129228 --- Fix it, then Ship it! src/Makefile.am (line 554)

Review Request 46295: Replaced 'using namespace' with 'using'.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46295/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5171

Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

2016-04-15 Thread Kapil Arya
> On April 15, 2016, 8:40 p.m., Jie Yu wrote: > > src/log/log.cpp, line 742 > > > > > > Please move this to the begining of this file. Fixed as part of https://reviews.apache.org/r/46295/ - Kapil

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

2016-04-15 Thread Kapil Arya
> On April 15, 2016, 8:43 p.m., Jie Yu wrote: > > src/Makefile.am, line 554 > > > > > > Align the tailing `` It's aligned properly in the code. RB is displaying it incorrectly. - Kapil

Re: Review Request 46293: Windows: [3/3] Updated `sendfile` test.

2016-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46293/#review129232 --- Bad patch! Reviews applied: [46293, 46285, 43985, 46010, 46009]

Re: Review Request 45326: Implemented os::which().

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/ --- (Updated 四月 16, 2016, 3:16 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46288: Update CMake file to include the new state.proto file.

2016-04-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46288/#review129230 --- Ship it! Ship It! - Jie Yu On April 16, 2016, 12:11 a.m.,

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

2016-04-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46164/#review129229 --- Ship it! Ship It! - Jie Yu On April 16, 2016, 12:10 a.m.,

Re: Review Request 43985: Windows: [1/3] Implemented `sendfile`.

2016-04-15 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43985/ --- (Updated April 16, 2016, 1:10 a.m.) Review request for mesos, Artem

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46295/ --- (Updated April 15, 2016, 9:27 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

2016-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46295/#review129239 --- Patch looks great! Reviews applied: [45900, 45901, 46160, 46161,

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-15 Thread Greg Mann
> On April 15, 2016, 11:22 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, line 551 > > > > > > Can you please add a test where authentication actually works? (for > > saftey) I

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/ --- (Updated April 15, 2016, 6:07 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

2016-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/#review129051 --- Fix it, then Ship it! src/master/http.cpp (lines 437 - 439)

Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-04-15 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46182/ --- Review request for mesos. Repository: mesos Description --- Adding app

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46182/#review129178 --- Patch looks great! Reviews applied: [46182] Passed command:

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 15, 2016, 11:56 p.m.) Review request for mesos, David vonThenen,

Review Request 46293: Windows: [3/3] Updated `sendfile` test.

2016-04-15 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46293/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Review Request 46285: Windows: [2/3] `sendfile` used with the typed error state of `Try`.

2016-04-15 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46285/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review129204 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46163/ --- (Updated April 15, 2016, 8:10 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46164/ --- (Updated April 15, 2016, 8:10 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46288: Update CMake file to include the new state.proto file.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46288/ --- (Updated April 15, 2016, 8:11 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 43985: Windows: [1/3] Implemented `sendfile`.

2016-04-15 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43985/ --- (Updated April 16, 2016, 12:19 a.m.) Review request for mesos, Artem

Re: Review Request 46160: Exposed zookeeper headers.

2016-04-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46160/#review129225 --- Ship it! Ship It! - Jie Yu On April 15, 2016, 10:12 p.m.,

Re: Review Request 46161: Exposed log/log.hpp.

2016-04-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46161/#review129226 --- Ship it! Ship It! - Jie Yu On April 15, 2016, 10:12 p.m.,

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46164/ --- (Updated April 15, 2016, 7 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

2016-04-15 Thread Kapil Arya
> On April 14, 2016, 1:58 p.m., Jie Yu wrote: > > include/mesos/state/state.hpp, line 83 > > > > > > Let's void mesos:: if possible. Ditto for others. Some of the `mesos::`s are required due to conflicts with

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

2016-04-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/#review129199 --- Fix it, then Ship it!

Re: Review Request 46160: Exposed zookeeper headers.

2016-04-15 Thread Kapil Arya
> On April 13, 2016, 8:55 p.m., Jie Yu wrote: > > src/state/zookeeper.hpp, line 23 > > > > > > Let's put mesos headers after stout/libprocess Dropping since it's already inconsistent with codebase. - Kapil

Re: Review Request 46161: Exposed log/log.hpp.

2016-04-15 Thread Kapil Arya
> On April 13, 2016, 8:54 p.m., Jie Yu wrote: > > Please make sure the cmake works. Also, put mesos header after > > libprocess/stout headers. Please all occurances. The CMakelists.txt files don't contain headers so we are good here. - Kapil

Re: Review Request 46161: Exposed log/log.hpp.

2016-04-15 Thread Kapil Arya
> On April 13, 2016, 8:54 p.m., Jie Yu wrote: > > Please make sure the cmake works. Also, put mesos header after > > libprocess/stout headers. Please all occurances. > > Kapil Arya wrote: > The CMakelists.txt files don't contain headers so we are good here. Added

Review Request 46288: Update CMake file to include the new state.proto file.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46288/ --- Review request for mesos, Alex Clemmer and Jie Yu. Bugs: MESOS-5171

Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

2016-04-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46162/#review129227 --- Fix it, then Ship it! src/log/log.cpp (line 742)

Review Request 46281: Fixed broken mesos build.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46281/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46163/ --- (Updated April 15, 2016, 6:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46161: Exposed log/log.hpp.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46161/ --- (Updated April 15, 2016, 6:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46164/ --- (Updated April 15, 2016, 6:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/ --- (Updated April 15, 2016, 6:12 p.m.) Review request for mesos, Anurag Singh and

Re: Review Request 46281: Fixed broken mesos build.

2016-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46281/#review129193 --- Ship it! Ship It! - Vinod Kone On April 15, 2016, 10:04

Re: Review Request 46160: Exposed zookeeper headers.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46160/ --- (Updated April 15, 2016, 6:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45900: Removed stale contender/detector files.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45900/ --- (Updated April 15, 2016, 6:12 p.m.) Review request for mesos, Anurag Singh and

Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46162/ --- (Updated April 15, 2016, 6:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46192: Stout:[1/2] Added `systems_tests.cpp`.

2016-04-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46192/#review129197 --- Ship it! Ship It! - Michael Park On April 15, 2016, 8:51

Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

2016-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46212/#review129183 --- Ship it! Ship It! - Vinod Kone On April 15, 2016, 7:04

Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

2016-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46118/#review129185 --- Ship it! Ship It! - Vinod Kone On April 15, 2016, 7:05

Re: Review Request 45604: Updated the balloon framework and executor.

2016-04-15 Thread Vinod Kone
> On April 12, 2016, 10:46 p.m., Vinod Kone wrote: > > src/examples/balloon_executor.cpp, lines 143-153 > > > > > > Why the change here? > > Joseph Wu wrote: > I couple reasons: > > * I needed to put

Re: Review Request 45604: Updated the balloon framework and executor.

2016-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/#review129187 --- src/examples/balloon_framework.cpp (lines 63 - 64)

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-15 Thread Michael Park
> On April 14, 2016, 9:10 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 173-183 > > > > > > (1) It seems like this should live in `posix/os.hpp`. > > (2) The

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review129192 --- Ship it! Ship It! - Michael Park On April 15, 2016, 7:50

Re: Review Request 46189: Slave rename - Update strings in error messages and other strings.

2016-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46189/#review129194 --- Ship it! Ship It! - Vinod Kone On April 14, 2016, 11:27

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46163/ --- (Updated April 15, 2016, 6:16 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

2016-04-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46164/ --- (Updated April 15, 2016, 6:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review129184 --- Ship it! Ship It! - Vinod Kone On April 15, 2016, 6:55

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

2016-04-15 Thread Michael Park
> On April 14, 2016, 9:55 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 310 > > > > > > Please use a C++ cast. > > Alex Clemmer wrote: > I don't really know

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-15 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44131/ --- (Updated April 15, 2016, 6:32 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46254/ --- (Updated April 15, 2016, 6:51 a.m.) Review request for mesos, Adam B and

Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/ --- Review request for mesos, Adam B and Alexander Rojas. Bugs: MESOS-4902

Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/ --- Review request for mesos, Adam B and Alexander Rojas. Bugs: MESOS-4902

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/ --- (Updated April 15, 2016, 7:01 a.m.) Review request for mesos, Adam B and

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-15 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44131/ --- (Updated April 15, 2016, 7:11 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46249: Support hook/module process operation before main process initialize.

2016-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/#review129072 --- Bad patch! Reviews applied: [46249] Failed command:

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

2016-04-15 Thread Alex Clemmer
> On April 14, 2016, 9:19 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp, lines 43-61 > > > > > > Do we have plans to implement this in stout? We do not. We could, but no

Review Request 46254: Added a default authentication realm to libprocess tests.

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46254/ --- Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-4902

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/ --- (Updated 四月 15, 2016, 6:37 a.m.) Review request for mesos, David vonThenen,

Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/ --- Review request for mesos, Adam B and Alexander Rojas. Bugs: MESOS-4902

Review Request 46264: Fixed a typo in docker_containerizer_tests.cpp.

2016-04-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46264/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 46249: hook/module process operation before main process initialize.

2016-04-15 Thread Andy Pang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/ --- (Updated 四月 15, 2016, 8:09 a.m.) Review request for mesos, BenjaminVW

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

2016-04-15 Thread Michael Park
> On April 14, 2016, 9:19 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp, lines 43-61 > > > > > > Do we have plans to implement this in stout? > > Alex Clemmer wrote: >

Re: Review Request 46242: Removed a check in Reserve operation validation.

2016-04-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46242/ --- (Updated April 15, 2016, 6:25 a.m.) Review request for mesos, Adam B and Joris

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

2016-04-15 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/ --- (Updated April 15, 2016, 7:10 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 15, 2016, 7:50 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-15 Thread Alex Clemmer
> On April 14, 2016, 9:10 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 173-183 > > > > > > (1) It seems like this should live in `posix/os.hpp`. > > (2) The

  1   2   >