Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

> On April 14, 2016, 7:10 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 489-490 > > > > > > This is now effectively managed by the `ProcessManager`, so you could > > bring it into the

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46295/#review129255 --- Fix it, then Ship it!

Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43520/#review129252 --- Patch looks great! Reviews applied: [43520] Passed command:

Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43520/ --- (Updated April 16, 2016, 3:37 p.m.) Review request for mesos, Alexander

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated April 16, 2016, 5:01 p.m.) Review request for mesos and Adam B.

Review Request 46306: Add `HealthCheckTest.HealthyTaskShellEscape`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46306/ --- Review request for mesos, Alexander Rukletsov and Lukas Loesche. Repository:

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review129245 --- src/linux/perf.cpp (line 346)

Re: Review Request 44379: Use tokens size to parse perf stat format.

> On April 16, 2016, 12:23 p.m., haosdent huang wrote: > > src/linux/perf.cpp, line 346 > > > > > > Hi, @fan.du. I believe @bmahler would like to elaborate more details > > here. Just my idea, feel free to correct

Re: Review Request 46298: Rejected relative path agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46298/#review129247 --- Ship it! Ship It! - haosdent huang On April 16, 2016, 8:29

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/#review129244 --- Patch looks great! Reviews applied: [45083, 45084, 46043, 45085,

Review Request 46298: Rejected relative path agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46298/ --- Review request for mesos, Alexander Rukletsov and Jie Yu. Bugs: MESOS-5123

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- (Updated April 16, 2016, 10:12 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 16, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/ --- (Updated April 16, 2016, 10:15 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45352/ --- (Updated April 16, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45472/ --- (Updated April 16, 2016, 10:17 a.m.) Review request for mesos, Avinash

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45364/ --- (Updated April 16, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- (Updated April 16, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45573: Add `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated April 16, 2016, 10:17 a.m.) Review request for mesos, Gilbert Song,

Review Request 46299: Ignore eventfd caused by hierarchy destruction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46299/ --- Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/ --- (Updated April 16, 2016, 10:21 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45573: Add `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated April 16, 2016, 10:22 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 16, 2016, 10:22 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45352/ --- (Updated April 16, 2016, 10:21 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45472/ --- (Updated April 16, 2016, 10:22 a.m.) Review request for mesos, Avinash

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated April 16, 2016, 10:22 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- (Updated April 16, 2016, 10:24 a.m.) Review request for mesos, Ian Downes, Jan

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated April 16, 2016, 10:24 a.m.) Review request for mesos, Gilbert Song,

Review Request 46300: Wait for process:reap in CGROUPS_ROOT_PerfRollForward.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46300/ --- Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes,

Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- (Updated April 16, 2016, 10:28 a.m.) Review request for mesos, Ian Downes, Jan

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated April 16, 2016, 10:29 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46300: Wait for process:reap in CGROUPS_ROOT_PerfRollForward.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46300/ --- (Updated April 16, 2016, 10:29 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 16, 2016, 10:28 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46298: Rejected relative path agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46298/#review129243 --- Patch looks great! Reviews applied: [46298] Passed command:

Re: Review Request 45084: Added stubs for the `Subsystem` abstraction of cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/ --- (Updated April 16, 2016, 10:13 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated April 16, 2016, 10:14 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46043: Completed default implementation of `Subsystem` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46043/ --- (Updated April 16, 2016, 10:13 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- (Updated April 16, 2016, 10:14 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- (Updated April 16, 2016, 10:20 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45575/ --- (Updated April 16, 2016, 10:19 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 16, 2016, 10:19 a.m.) Review request for mesos, Gilbert Song,