Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

2016-04-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review129534 --- This patch does not solve the flakiness for me: failed once after

Re: Review Request 45673: PoC: Docker Volume Isolator.

2016-04-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45673/ --- (Updated 四月 19, 2016, 3:28 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46168: Add subdirectory support to URI.filename field.

2016-04-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/#review129487 --- docs/fetcher.md (line 89)

Re: Review Request 45326: Implemented os::which().

2016-04-19 Thread haosdent huang
> On April 19, 2016, 3:03 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 976 > > > > > > Should `EXPECT_SOME` here? > > Guangya Liu wrote: > Can you please show more

Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-04-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

2016-04-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/ --- (Updated April 19, 2016, 4:35 p.m.) Review request for mesos, Adam B and

Review Request 46393: Windows: Added Windows support for `stout/os/shell.hpp`.

2016-04-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46393/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.

2016-04-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/ --- Review request for mesos. Repository: mesos Description --- This commit

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/#review129557 --- Patch looks great! Reviews applied: [46331] Passed command:

Re: Review Request 45326: Implemented os::which().

2016-04-19 Thread Guangya Liu
> On 四月 19, 2016, 3:03 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 975 > > > > > > Do we need test the priority here? When a binary exists in different > > folders at

Review Request 46370: Introduced linux capabilities API.

2016-04-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- Review request for mesos, Jie Yu and Kevin Klues. Bugs: MESOS-5051

Re: Review Request 45326: Implemented os::which().

2016-04-19 Thread haosdent huang
> On April 19, 2016, 3:03 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 976 > > > > > > Should `EXPECT_SOME` here? > > Guangya Liu wrote: > Can you please show more

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-19 Thread Alexander Rukletsov
> On April 19, 2016, 1:09 a.m., Ben Mahler wrote: > > src/internal/evolve.hpp, line 46 > > > > > > Why did you choose to inject it here? Seems better closer to TaskInfo? Because in "mesos.proto" `KillPolicy` is

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

2016-04-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46254/ --- (Updated April 19, 2016, 4:35 p.m.) Review request for mesos, Adam B and

Review Request 46371: Added basic tests for capabilities API.

2016-04-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 45326: Implemented os::which().

2016-04-19 Thread Jie Yu
> On April 19, 2016, 3:03 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 975 > > > > > > Do we need test the priority here? When a binary exists in different > > folders

Re: Review Request 45326: Implemented os::which().

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review129567 --- Ship it! Ship It! - Jie Yu On April 19, 2016, 2:56 p.m.,

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

2016-04-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/ --- (Updated 四月 19, 2016, 2:52 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-04-19 Thread Neil Conway
> On April 14, 2016, 7:10 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 489-490 > > > > > > This is now effectively managed by the `ProcessManager`, so you could > > bring it into the

Re: Review Request 45673: PoC: Docker Volume Isolator.

2016-04-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45673/ --- (Updated 四月 19, 2016, 4:45 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/#review129565 --- Ship it! Ship It! - Jie Yu On April 19, 2016, 8:21 a.m.,

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review129528 --- Patch looks great! Reviews applied: [46373] Passed command:

Review Request 46388: Fixed typo in test setup error message.

2016-04-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46388/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 45326: Implemented os::which().

2016-04-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/ --- (Updated 四月 19, 2016, 2:56 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

2016-04-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 19, 2016, 3:04 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-19 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/ --- (Updated April 19, 2016, 1:42 p.m.) Review request for mesos and Adam B.

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-04-19 Thread Klaus Ma
> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n",

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-19 Thread Qian Zhang
> On April 19, 2016, 8:56 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 119-125 > > > > > > I would suggest that we don't save that in Info. This is because 'Info' > >

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/ --- (Updated April 19, 2016, 4:46 p.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

2016-04-19 Thread haosdent huang
> On April 19, 2016, 2:35 p.m., Neil Conway wrote: > > This patch does not solve the flakiness for me: failed once after 2 > > iterations, then again after 77 iterations. Verbose test log here: > > https://gist.github.com/neilconway/e6134b4717ee022e7fc32a1f95619fa9 > > haosdent huang wrote: >

Re: Review Request 45326: Implemented os::which().

2016-04-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review129540 --- Fix it, then Ship it! Ship It!

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

2016-04-19 Thread haosdent huang
> On April 19, 2016, 2:35 p.m., Neil Conway wrote: > > This patch does not solve the flakiness for me: failed once after 2 > > iterations, then again after 77 iterations. Verbose test log here: > > https://gist.github.com/neilconway/e6134b4717ee022e7fc32a1f95619fa9 Thank you very much for

Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to meaningful name.

2016-04-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46245/ --- (Updated 四月 19, 2016, 2:48 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-19 Thread Yongqiao Wang
> On April 14, 2016, 11:09 a.m., Adam B wrote: > > src/tests/dynamic_weights_tests.cpp, lines 168-179 > > > > > > Why are role2 and role1 in reverse order? Is this always the case? Why > > wouldn't it be

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review129535 --- Bad patch! Reviews applied: [46314] Failed command:

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129570 --- src/CMakeLists.txt (line 55)

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

2016-04-19 Thread haosdent huang
> On April 19, 2016, 3:37 p.m., Neil Conway wrote: > > Can we update the docs to describe this behavior? e.g., add a note to > > https://mesos.apache.org/documentation/latest/endpoints/ describing the > > redirect behavior -- I suppose it is worth adding a note to every master > > endpoint's

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/#review129578 --- Patch looks great! Reviews applied: [46139] Passed command:

Re: Review Request 46388: Fixed typo in test setup error message.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46388/#review129591 --- Patch looks great! Reviews applied: [46388] Passed command:

Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to meaningful name.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46245/#review129575 --- Ship it! Ship It! - Jie Yu On April 19, 2016, 2:48 p.m.,

Review Request 46401: Corrected acls protobuf file in documentation and flag.

2016-04-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46401/ --- Review request for mesos, Adam B, Alexander Rojas, and Greg Mann. Repository:

Re: Review Request 46401: Corrected acls protobuf file in documentation and flag.

2016-04-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46401/#review129590 --- Ship it! Ship It! - Greg Mann On April 19, 2016, 6:38 p.m.,

Re: Review Request 46322: Added KillPolicy to scheduler and executor Kill protobuf messages.

2016-04-19 Thread Alexander Rukletsov
> On April 19, 2016, 12:33 a.m., Ben Mahler wrote: > > CHANGELOG, lines 61-63 > > > > > > I was initially surprised to see MESOS-4908 repeated here, but I > > suppose the intent was to list all non-deprecation API

Review Request 46391: Clarified several agent log messages.

2016-04-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46391/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Re: Review Request 46142: Added Criteo to Powered by Mesos page.

2016-04-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46142/#review129544 --- Ship it! Ship It! - Timothy Chen On April 19, 2016, 12:13

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

2016-04-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/#review129545 --- Can we update the docs to describe this behavior? e.g., add a

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Yong Tang
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ --- (Updated April 19, 2016, 3:19 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Yong Tang
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Re: Review Request 46331: Fixed the issue that command executor can not join CNI network.

2016-04-19 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46331/#review129554 --- Fix it, then Ship it! Ship It!

Re: Review Request 45326: Implemented os::which().

2016-04-19 Thread Guangya Liu
> On 四月 19, 2016, 3:03 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 976 > > > > > > Should `EXPECT_SOME` here? Can you please show more detail for why use

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129599 --- Patch looks great! Reviews applied: [46364] Passed command:

Re: Review Request 46308: Moved LogProcess declaration to log/log.h.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46308/#review129595 --- Ship it! Ship It! - Jie Yu On April 17, 2016, 4:47 p.m.,

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/#review129598 --- Ship it! Ship It! - Jie Yu On April 19, 2016, 2:52 p.m.,

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review129620 --- src/files/files.cpp (line 380)

Re: Review Request 46375: Updated MACHINE_UP_HELP's comments.

2016-04-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46375/#review129614 --- Ship it! Ship It! - Joseph Wu On April 19, 2016, 12:51

Re: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/#review129446 --- Ship it! LGTM. src/master/main.cpp (lines 242 - 249)

Re: Review Request 46391: Clarified several agent log messages.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46391/#review129616 --- Patch looks great! Reviews applied: [46391] Passed command:

Re: Review Request 46168: Add subdirectory support to URI.filename field.

2016-04-19 Thread Michael Browning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/ --- (Updated April 19, 2016, 11:04 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 46168: Add subdirectory support to URI.filename field.

2016-04-19 Thread Michael Browning
> On April 19, 2016, 4:08 p.m., Jiang Yan Xu wrote: > > src/launcher/fetcher.cpp, line 252 > > > > > > `basename` usually specifically refers to the `the component following > > the final '/'`. > > > > So

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Yong Tang
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Review Request 46425: Add helper function to simplify tokenize handling.

2016-04-19 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46425/ --- Review request for mesos, Ben Mahler, Joris Van Remoortere, and Michael Park.

Re: Review Request 46425: Add helper function to simplify tokenize handling.

2016-04-19 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46425/ --- (Updated April 20, 2016, 1:48 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 45014: Add /containers endpoint.

2016-04-19 Thread Jay Guo
> On April 15, 2016, 12:33 a.m., Jie Yu wrote: > > ping? bump - Jay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review129045

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-04-19 Thread Klaus Ma
> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n",

Review Request 46423: Windows: Forked subprocess.cpp, added `Windows` implementation.

2016-04-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 46424: Windows: Added libprocess to build.

2016-04-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46424/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 四月 20, 2016, 5:57 a.m.) Review request for mesos, Ben Mahler and Greg

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review129674 --- I added a few comments below, but in general, I feel like there

Review Request 46422: Stout: Added Windows support for `stopwatch.hpp`.

2016-04-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46422/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-19 Thread Vinod Kone
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review129682 --- Patch looks great! Reviews applied: [46407, 45604, 46411, 45905]

Re: Review Request 46168: Add subdirectory support to URI.filename field.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/#review129684 --- Bad patch! Reviews applied: [46168] Failed command:

Re: Review Request 46285: Windows: [2/3] `sendfile` used with the typed error state of `Try`.

2016-04-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46285/#review129635 --- 3rdparty/libprocess/src/poll_socket.cpp (line 135)

Re: Review Request 46168: Add subdirectory support to URI.filename field.

2016-04-19 Thread Michael Browning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/ --- (Updated April 19, 2016, 11:05 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 45673: PoC: Docker Volume Isolator.

2016-04-19 Thread Guangya Liu
> On 四月 19, 2016, 11:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, lines > > 108-109 > > > > > > To me, this is just an optimization, isn't it? We can still go

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-19 Thread Guangya Liu
> On 四月 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 41 > > > > > > Do you want to use `const Option& dvdcliPath` here? The idea is > > that if not

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129573 --- src/Makefile.am (line 687)

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review129642 --- Ship it! Ship It! - Michael Park On April 18, 2016, 7:09

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/#review129644 --- Patch looks great! Reviews applied: [46393, 46395] Passed

Re: Review Request 46371: Added basic tests for capabilities API.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/#review129649 --- Bad patch! Reviews applied: [46371, 46370, 46369] Failed

Review Request 46418: Refactored the `os::access` function between POSIX and Windows.

2016-04-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46418/ --- Review request for mesos, Daniel Pravat, Alex Clemmer, and Joris Van Remoortere.

Re: Review Request 46401: Corrected acls protobuf file in documentation and flag.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46401/#review129659 --- Patch looks great! Reviews applied: [46401] Passed command:

Re: Review Request 45673: PoC: Docker Volume Isolator.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45673/#review129639 ---

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129650 ---

Re: Review Request 43985: Windows: [1/3] Implemented `sendfile`.

2016-04-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43985/#review129633 ---

Re: Review Request 46293: Windows: [3/3] Updated `sendfile` test.

2016-04-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46293/#review129637 --- 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

2016-04-19 Thread Guangya Liu
> On 四月 19, 2016, 5:27 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/state.proto, lines > > 32-46 > > > > > > I still don't understand why we want to make it a protobuf? Can that > >

Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/#review129632 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 46411: Removed private header from the balloon framework.

2016-04-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46411/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod

Review Request 46407: Updated balloon executor.

2016-04-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46407/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod

Re: Review Request 45604: Updated the balloon framework and executor.

2016-04-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/ --- (Updated April 19, 2016, 2:51 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45604: Updated the balloon framework and executor.

2016-04-19 Thread Joseph Wu
> On April 15, 2016, 2:13 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, lines 117-118 > > > > > > why would they be incomplete? There will be several metrics that count the number of tasks run

Re: Review Request 45604: Updated the balloon framework and executor.

2016-04-19 Thread Joseph Wu
> On April 12, 2016, 3:46 p.m., Vinod Kone wrote: > > src/examples/balloon_executor.cpp, lines 143-153 > > > > > > Why the change here? > > Joseph Wu wrote: > I couple reasons: > > * I needed to put

Re: Review Request 45905: Added metrics to the balloon framework.

2016-04-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated April 19, 2016, 2:52 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 46372: Fixed broken mesos.native package installation.

2016-04-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46372/ --- (Updated April 19, 2016, 9:12 a.m.) Review request for mesos, Steve Niemitz,

Re: Review Request 46372: Fixed broken mesos.native package installation.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46372/#review129498 --- Patch looks great! Reviews applied: [46372] Passed command:

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/ --- (Updated April 19, 2016, 11:32 a.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Benjamin Bannier
> On April 18, 2016, 8:11 p.m., Vinod Kone wrote: > > Looks good to me. Is there already a bug reported for this in the protobuf > > project? If not, can you create one and link it here? > > > > Also, this review is incomplete. There has to be corresponding changes in > > the Makefiles and

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

2016-04-19 Thread Benjamin Bannier
> On April 18, 2016, 8:11 p.m., Vinod Kone wrote: > > Looks good to me. Is there already a bug reported for this in the protobuf > > project? If not, can you create one and link it here? > > > > Also, this review is incomplete. There has to be corresponding changes in > > the Makefiles and

  1   2   >