Re: Review Request 46285: Windows: [3/4] `sendfile` used with the typed error state of `Try`.

2016-04-20 Thread Michael Park
> On April 19, 2016, 10:31 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/poll_socket.cpp, lines 204-230 > > > > > > How about we clean this up a little bit: > > > > ```cpp > > if

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/#review129782 --- Patch looks great! Reviews applied: [46096, 46097, 46435, 46436,

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated April 20, 2016, 8:19 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
> On April 20, 2016, 3:15 a.m., Kevin Klues wrote: > > src/linux/capabilities.cpp, lines 124-125 > > > > > > This should be unnecessary. See: > >

Re: Review Request 46149: Speed up DynamicReservationFramework.

2016-04-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46149/#review129799 --- Ship it! Ship It! - Michael Park On April 14, 2016, 12:59

Re: Review Request 46442: Fixed typos in comments.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46442/#review129815 --- Ship it! Ship It! - Jie Yu On April 20, 2016, 3:15 p.m.,

Re: Review Request 46440: Fixed typos in comments/docs in stout.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46440/#review129813 --- Ship it! Ship It! - Jie Yu On April 20, 2016, 3:15 p.m.,

Re: Review Request 46441: Fixed typos in comments in libprocess.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46441/#review129814 --- Ship it! Ship It! - Jie Yu On April 20, 2016, 3:15 p.m.,

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated April 20, 2016, 7:05 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.

2016-04-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46293/#review129784 --- 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp

Re: Review Request 46340: Stout:[1/2] Implement `os::waitpid`.

2016-04-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46340/#review129767 --- Fix it, then Ship it!

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Jie Yu
> On April 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 41 > > > > > > Do you want to use `const Option& dvdcliPath` here? The idea is > > that if

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129812 --- Ship it! Guangya, I committed for you. I did a few tweaking on

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

2016-04-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46341/#review129780 --- 3rdparty/libprocess/src/reap.cpp (lines 98 - 106)

Re: Review Request 46149: Speed up DynamicReservationFramework.

2016-04-20 Thread Michael Park
> On April 20, 2016, 8:30 p.m., Michael Park wrote: > > Ship It! Next time, please fix the `Description` such that Reviewbot will be happy. - Michael --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46372: Fixed broken mesos.native package installation.

2016-04-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46372/#review129801 --- Ship it! Ship It! - Vinod Kone On April 19, 2016, 9:12

Re: Review Request 46442: Fixed typos in comments.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46442/#review129798 --- Patch looks great! Reviews applied: [46440, 46441, 46442]

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
> On April 20, 2016, 3:15 a.m., Kevin Klues wrote: > > src/linux/capabilities.hpp, lines 94-99 > > > > > > From my reading of: > > http://man7.org/linux/man-pages/man7/capabilities.7.html > > > > this enum

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
> On April 20, 2016, 3:15 a.m., Kevin Klues wrote: > > I added a few comments below, but in general, I feel like there are places > > this code could be greatly simplified. Specifically, it's not obvious to > > me why we need all of the different classes you define (or maybe more about > >

Re: Review Request 46371: Added basic tests for capabilities API.

2016-04-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- (Updated April 20, 2016, 7:12 p.m.) Review request for mesos and Jie Yu.

Review Request 46416: remove hardcoding for MethodNotAllowed for http

2016-04-20 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46416/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-4126

Review Request 46415: construct http reponse body in libprocess

2016-04-20 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46415/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-4126

Re: Review Request 46418: Refactored the `os::access` function between POSIX and Windows.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46418/#review129693 --- Patch looks great! Reviews applied: [46418] Passed command:

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 20, 2016, 6:38 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

2016-04-20 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43588/#review129691 --- ping :). - Klaus Ma On Feb. 23, 2016, 7:55 a.m., Joerg Schad

Re: Review Request 46426: Added paths helper function for docker volume checkpoint.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46426/ --- (Updated 四月 20, 2016, 7:15 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-20 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review129696 --- Great start! Some concerns: - We need a JIRA to make sure we

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Yongqiao Wang
> On April 13, 2016, 9:27 a.m., Alexander Rukletsov wrote: > > src/tests/master_allocator_tests.cpp, line 1604 > > > > > > If you're not doing any checks with resources, you can use > > `Future` instead. > >

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Yongqiao Wang
> On April 14, 2016, 10:45 a.m., Adam B wrote: > > src/tests/master_allocator_tests.cpp, line 1604 > > > > > > +1 to using Future with FutureSatisfy since you're not > > validating the contents of the Resources.

Re: Review Request 46401: Corrected acls protobuf file in documentation and flag.

2016-04-20 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46401/#review129697 --- Ship it! Ship It! - Adam B On April 19, 2016, 11:38 a.m.,

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
> On 四月 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 41 > > > > > > Do you want to use `const Option& dvdcliPath` here? The idea is > > that if not

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129712 --- Patch looks great! Reviews applied: [46245, 45373, 45326, 45270,

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 20, 2016, 9:25 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
> On 四月 5, 2016, 4:55 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp, line 59 > > > > > > Do we need check `dvdcli` version or something first? > > Guangya Liu

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
> On 四月 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 68 > > > > > > Why 'static'? If it's static, can that be a file local helper in > > driver.cpp?

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
> On 四月 14, 2016, 10:41 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp, > > line 46 > > > > > > Why virtual? Let's not make them virtual yet. I was following the

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- (Updated 四月 20, 2016, 10:14 a.m.) Review request for mesos, David vonThenen,

Review Request 46426: Added paths helper function for docker volume checkpoint.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46426/ --- Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and

Review Request 46428: Added agent flag to turn on/off docker volume reference counter.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/ --- Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and

Re: Review Request 45922: Added agent authorization flags.

2016-04-20 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review129694 --- Looks great. So very close! Just an unnecessary slave::start()

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/ --- (Updated April 20, 2016, 8 a.m.) Review request for mesos, Adam B and

Re: Review Request 45270: Added spec protobuf for DockerVolume.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 20, 2016, 10:57 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46426: Added paths helper function for docker volume checkpoint.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46426/ --- (Updated 四月 20, 2016, 11:05 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 20, 2016, 11:07 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46422: Stout: Added Windows support for `stopwatch.hpp`.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46422/#review129722 --- Patch looks great! Reviews applied: [46393, 46395, 46422]

Review Request 46440: Fixed typos in comments/docs in stout.

2016-04-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46440/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 46442: Fixed typos in comments.

2016-04-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46442/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 46441: Fixed typos in comments in libprocess.

2016-04-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46441/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 46425: Add helper function to simplify tokenize handling.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46425/#review129739 --- Patch looks great! Reviews applied: [46425] Passed command:

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

2016-04-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46435/ --- (Updated April 20, 2016, 10:35 p.m.) Review request for mesos, Avinash

Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

2016-04-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46435/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5167

Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

2016-04-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5167

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-04-20 Thread Qian Zhang
> On April 13, 2016, 12:07 a.m., Avinash sridharan wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 143 > > > > > > Can we make the task long running, and then check that the CNI network > >

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-04-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated April 20, 2016, 9:47 p.m.) Review request for mesos, Avinash

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-04-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated April 20, 2016, 10:26 p.m.) Review request for mesos, Avinash

Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

2016-04-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46436/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5167

Re: Review Request 46424: Windows: Added libprocess to build.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46424/#review129734 --- Patch looks great! Reviews applied: [46424] Passed command:

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review129748 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 43985: Windows: [1/4] Implemented `sendfile`.

2016-04-20 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43985/ --- (Updated April 20, 2016, 4:45 p.m.) Review request for mesos, Artem

Re: Review Request 46285: Windows: [2/3] `sendfile` used with the typed error state of `Try`.

2016-04-20 Thread Daniel Pravat
> On April 19, 2016, 10:31 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/poll_socket.cpp, lines 204-230 > > > > > > How about we clean this up a little bit: > > > > ```cpp > > if

Re: Review Request 43985: Windows: [1/3] Implemented `sendfile`.

2016-04-20 Thread Daniel Pravat
> On April 19, 2016, 10:21 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp, > > line 45 > > > > > > `s/send/sent/` Thanks! - Daniel

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

2016-04-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46341/ --- (Updated April 20, 2016, 4:37 p.m.) Review request for mesos, Alex Naparu,

Review Request 46447: Windows: [2/4] Extracted `SocketError` definition in `error.hpp`.

2016-04-20 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46447/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Re: Review Request 46285: Windows: [3/4] `sendfile` used with the typed error state of `Try`.

2016-04-20 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46285/ --- (Updated April 20, 2016, 4:44 p.m.) Review request for mesos, Artem

Re: Review Request 45270: Added spec protobuf for DockerVolume.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129751 --- Ship it! Ship It! - Jie Yu On April 20, 2016, 10:57 a.m.,

Re: Review Request 45270: Added spec protobuf for DockerVolume.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 20, 2016, 5:39 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.

2016-04-20 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46293/ --- (Updated April 20, 2016, 4:54 p.m.) Review request for mesos, Artem

Re: Review Request 45270: Added spec protobuf for DockerVolume.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129753 --- src/Makefile.am (line 837)

Re: Review Request 46426: Added paths helper function for docker volume checkpoint.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46426/ --- (Updated 四月 20, 2016, 5:41 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 20, 2016, 5:44 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review129758 --- Patch looks great! Reviews applied: [46135] Passed command:

Re: Review Request 46426: Added paths helper function for docker volume checkpoint.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46426/#review129756 --- Fix it, then Ship it!

Re: Review Request 46456: Clarified and improved documentation for maintenance primitives.

2016-04-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46456/ --- (Updated April 21, 2016, 12:39 a.m.) Review request for mesos and Joseph Wu.

Review Request 46469: Added support for credentials to mesos-execute.

2016-04-20 Thread Tim Anderegg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/ --- Review request for mesos. Bugs: MESOS-3402

Re: Review Request 43985: Windows: [1/4] Implemented `sendfile`.

2016-04-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43985/#review129828 --- 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-20 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ --- (Updated April 21, 2016, 2:28 a.m.) Review request for mesos, Adam B, Ben

Review Request 46470: Change to explicit case statements (`UNKNOWN`) for authorization.

2016-04-20 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46470/ --- Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. Bugs: MESOS-5031

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 21, 2016, 3:43 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46456: Clarified and improved documentation for maintenance primitives.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46456/#review129850 --- Patch looks great! Reviews applied: [46456] Passed command:

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-20 Thread Yong Tang
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > >

Re: Review Request 46469: Added support for credentials to mesos-execute.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/#review129852 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-20 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ --- (Updated April 21, 2016, 2:25 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/#review129824 --- Ship it! Thanks Guangya. It looks to me overall. I did a few

Re: Review Request 46388: Fixed typo in test setup error message.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46388/#review129816 --- Ship it! Ship It! - Jie Yu On April 19, 2016, 2:23 p.m.,

Re: Review Request 46371: Added basic tests for capabilities API.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/#review129827 --- Patch looks great! Reviews applied: [46369, 46370, 46371]

Re: Review Request 46456: Clarified and improved documentation for maintenance primitives.

2016-04-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46456/#review129839 --- Fix it, then Ship it! Reads fine to me. docs/maintenance.md

Re: Review Request 46456: Clarified and improved documentation for maintenance primitives.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46456/#review129840 --- Patch looks great! Reviews applied: [46456] Passed command:

Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.

2016-04-20 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46293/ --- (Updated April 20, 2016, 9:48 p.m.) Review request for mesos, Artem

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

2016-04-20 Thread Alex Clemmer
> On April 20, 2016, 7:05 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/reap.cpp, lines 98-106 > > > > > > Does this logic still work the same way, now that we are using `Result`? > > Are we

Re: Review Request 46416: remove hardcoding for MethodNotAllowed for http

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46416/#review129831 --- Bad patch! Reviews applied: [46416, 46415] Failed command:

Review Request 46456: Clarified and improved documentation for maintenance primitives.

2016-04-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46456/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 46340: Stout:[1/2] Implement `os::waitpid`.

2016-04-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46340/ --- (Updated April 20, 2016, 9:51 p.m.) Review request for mesos, Alex Naparu,

Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes,

Re: Review Request 34646: Redirected to the leader master when current master is not the leader.

2016-04-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated April 21, 2016, 4:09 a.m.) Review request for mesos, Adam B, Anand

Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

2016-04-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/ --- Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes,

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

2016-04-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated April 21, 2016, 4:13 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46470: Change to explicit case statements (`UNKNOWN`) for authorization.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46470/#review129853 --- Patch looks great! Reviews applied: [46364, 46470] Passed

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review129859 --- Patch looks great! Reviews applied: [46245, 45373, 45326, 45270,

Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/ --- Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes,

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

2016-04-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated April 21, 2016, 4:11 a.m.) Review request for mesos, Adam B, Anand

  1   2   >