Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

2016-04-25 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46497/#review130415 --- Ship it! Ship It! - Alexander Rojas On April 25, 2016, 4:02

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46259/#review130423 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 10:21

Re: Review Request 45922: Added agent authorization flags.

2016-04-25 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review130419 --- Ship it! Ship It! - Alexander Rojas On April 22, 2016,

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/ --- (Updated April 25, 2016, 4:16 p.m.) Review request for mesos, Adam B,

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-25 Thread Benjamin Bannier
> On April 25, 2016, 1:31 p.m., Adam B wrote: > > src/tests/slave_authorization_tests.cpp, line 176 > > > > > > Shouldn't you give this a more generic name now that it can handle any > > (agent) endpoint? Done.

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-25 Thread Benjamin Bannier
> On April 25, 2016, 12:57 p.m., Alexander Rojas wrote: > > src/slave/http.cpp, lines 647-649 > > > > > > I was thinking that it makes sense to pull up the limiter related logic > > to `statistics()` so that method

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-25 Thread Benjamin Bannier
> On April 22, 2016, 10:22 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 1926-1927 > > > > > > I would expect you to await/validate the response after validating the > > request. > > Benjamin Bannier

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 25, 2016, 4:16 p.m.) Review request for mesos and Adam B.

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

2016-04-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review130422 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46497/#review130429 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 10:02

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46259/ --- (Updated April 25, 2016, 2:21 p.m.) Review request for mesos, Adam B and

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46262/#review130427 --- Ship it! Ship It! - Kapil Arya On April 15, 2016, 3:01

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/#review130425 --- Ship it! src/tests/metrics_tests.cpp (line 85)

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/#review130426 --- Ship it! Ship It! - Kapil Arya On April 22, 2016, 3:14

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46497/ --- (Updated April 25, 2016, 2:02 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

2016-04-25 Thread Greg Mann
> On April 25, 2016, 12:37 p.m., Alexander Rojas wrote: > > Whoops! Thanks Alexander :-) - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46497/#review130395

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46258/ --- (Updated April 25, 2016, 2:20 p.m.) Review request for mesos, Adam B and

Re: Review Request 46593: Added test for containerizer destroy while provisioning race.

2016-04-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46593/#review130418 --- Fix it, then Ship it!

Re: Review Request 46621: Add alias support for flags.

2016-04-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review130421 --- Did a quick review since I spent some time on working on a fix

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-25 Thread Vinod Kone
> On April 14, 2016, 4:49 p.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 749 > > > > > > Looking at slave::statusUpdate() code there are several scenarios where > > the slave ignores a

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

2016-04-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46618/#review130497 --- Patch looks great! Reviews applied: [46618] Passed command:

Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.

2016-04-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46497/#review130438 --- Patch looks great! Reviews applied: [46254, 46255, 46258, 46259,

Review Request 46643: Fixed the build when perftools is enabled.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46643/ --- Review request for mesos and Kapil Arya. Bugs: MESOS-3319

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

2016-04-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46618/#review130445 ---

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46461/ --- (Updated April 25, 2016, 5:25 p.m.) Review request for mesos and Kapil Arya.

Review Request 46641: Added tests for the Profiler to libprocess.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46641/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-4902

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

2016-04-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46618/ --- (Updated 四月 25, 2016, 5:56 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

2016-04-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46618/ --- (Updated 四月 25, 2016, 5:56 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

2016-04-25 Thread Anindya Sinha
> On April 18, 2016, 6:47 a.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 762 > > > > > > How about `optional SharedInfo shared`? > > > >

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/ --- (Updated April 25, 2016, 5:37 p.m.) Review request for mesos, Adam B and

Review Request 46647: Added the '--enable-perftools' flag to configure docs.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46647/ --- Review request for mesos and Kapil Arya. Bugs: MESOS-3319

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46461/#review130436 --- LGTM modulo the comment. Also, have you done a grep for

Re: Review Request 46462: Updated gperftools to version 2.5 (Mesos).

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46462/#review130437 --- Ship it! Ship It! - Kapil Arya On April 21, 2016, 12:22

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

2016-04-25 Thread Greg Mann
> On April 25, 2016, 4:01 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/configure.ac, line 853 > > > > > > I am wondering if we should split out this patch into two: one that > > updates bundled version, and

Re: Review Request 42806: Added the fetcher plugin module interface.

2016-04-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/#review130490 --- FYI: I will be making some changes to the fetcher underneath your

Re: Review Request 46647: Added the '--enable-perftools' flag to configure docs.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46647/#review130482 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 1:45

Re: Review Request 46643: Fixed the build when perftools is enabled.

2016-04-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46643/#review130481 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 1:19

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

2016-04-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review130502 --- Some inline TODO's from an offline review (with Joris & Neil).

Re: Review Request 46588: Added URI struct to stout.

2016-04-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/ --- (Updated April 25, 2016, 4:13 p.m.) Review request for mesos, Gilbert Song,

Review Request 46669: Added deprecation support to Flag name.

2016-04-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5271

Re: Review Request 46665: Added 0.26.2 to the CHANGELOG.

2016-04-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46665/#review130527 --- Patch looks great! Reviews applied: [46663, 46664, 46665]

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-25 Thread Vinod Kone
> On April 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, lines 127-140 > > > > > > Hmm. I was hoping for something more generic than hard coding these 3 > > configurations. But if it's not

Re: Review Request 46621: Add alias support for flags.

2016-04-25 Thread Vinod Kone
> On April 25, 2016, 2:48 p.m., Benjamin Bannier wrote: > > Did a quick review since I spent some time on working on a fix for > > MESOS-3335. It would be great if we wouldn't aggreviate that problem > > further. > > > > What seems unclear to me ATM is how alias'ed flags can override each

Re: Review Request 46621: Added alias support for flags.

2016-04-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- (Updated April 26, 2016, 1:04 a.m.) Review request for mesos and Ben Mahler.

Review Request 46663: Added 0.28.2 to the CHANGELOG.

2016-04-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46663/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 46665: Added 0.26.2 to the CHANGELOG.

2016-04-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46665/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 46664: Added 0.27.3 to the CHANGELOG.

2016-04-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46664/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

2016-04-25 Thread Guangya Liu
> On April 18, 2016, 6:47 a.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 762 > > > > > > How about `optional SharedInfo shared`? > > > >

Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-04-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/ --- Review request for mesos. Bugs: MESOS-4386

Re: Review Request 46580: Added uriparser as a bundled dependency.

2016-04-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46580/ --- (Updated April 25, 2016, 4:12 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-25 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated April 26, 2016, 1:23 a.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130452 --- Patch looks great! Reviews applied: [45922, 46318, 46203, 46319,

Re: Review Request 46462: Updated gperftools to version 2.5 (Mesos).

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46462/ --- (Updated April 25, 2016, 5:26 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.

2016-04-25 Thread Greg Mann
> On April 25, 2016, 3:32 p.m., Kapil Arya wrote: > > src/tests/metrics_tests.cpp, line 85 > > > > > > Newline? Good catch! Fixed. - Greg --- This is an

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review130504 --- Ship it! Thanks for the comment! I've added a commit

Re: Review Request 46641: Added tests for the Profiler to libprocess.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46641/ --- (Updated April 25, 2016, 8:47 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/ --- (Updated April 25, 2016, 8:47 p.m.) Review request for mesos, Adam B and

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated April 25, 2016, 8:34 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

2016-04-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review130501 --- 3rdparty/libprocess/src/process.cpp (line 1356)

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

2016-04-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/#review130500 --- 3rdparty/libprocess/src/process.cpp (line 475)

Re: Review Request 46564: Fixed a typo in Docker containerizer.

2016-04-25 Thread Qian Zhang
> On April 25, 2016, 9:48 a.m., Timothy Chen wrote: > > Can you rebase your patch? Thanks! Sorry, I do not quite understand. I think the file I updated in this patch was not updated by others after I posted this patch, so there should be no conflict, right? :-) - Qian

Re: Review Request 46564: Fixed a typo in Docker containerizer.

2016-04-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46564/ --- (Updated April 25, 2016, 4:15 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

2016-04-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46618/#review130355 --- Patch looks great! Reviews applied: [46618] Passed command:

Re: Review Request 46564: Fixed a typo in Docker containerizer.

2016-04-25 Thread Qian Zhang
> On April 25, 2016, 9:48 a.m., Timothy Chen wrote: > > Can you rebase your patch? Thanks! > > Qian Zhang wrote: > Sorry, I do not quite understand. I think the file I updated in this > patch was not updated by others after I posted this patch, so there should be > no conflict, right? :-)

Re: Review Request 46564: Fixed a typo in Docker containerizer.

2016-04-25 Thread Timothy Chen
> On April 25, 2016, 1:48 a.m., Timothy Chen wrote: > > Can you rebase your patch? Thanks! > > Qian Zhang wrote: > Sorry, I do not quite understand. I think the file I updated in this > patch was not updated by others after I posted this patch, so there should be > no conflict, right? :-)

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 25, 2016, 10:19 a.m.) Review request for mesos, Adam B,

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/ --- (Updated April 25, 2016, 10:19 a.m.) Review request for mesos, Adam B,

Re: Review Request 46318: Added helper to create test agent with injected `Authorizer`.

2016-04-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46318/ --- (Updated April 25, 2016, 10:19 a.m.) Review request for mesos, Adam B,

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-25 Thread Juan Larriba
> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > > > > > What is this for? It tells CMake the generator that it needs to use to generate build files. > On Abr. 18,

Re: Review Request 46624: Added support to mesos to work with flag alias.

2016-04-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46624/#review130368 --- Patch looks great! Reviews applied: [46620, 46621, 46622, 46623,

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/ --- (Updated April 25, 2016, 11:52 a.m.) Review request for mesos, Adam B,

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 25, 2016, 11:52 a.m.) Review request for mesos and Adam B.

Re: Review Request 46564: Fixed a typo in Docker containerizer.

2016-04-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46564/#review130378 --- Patch looks great! Reviews applied: [46564] Passed command:

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Benjamin Bannier
> On April 20, 2016, 10:35 a.m., Adam B wrote: > > src/slave/http.cpp, lines 658-660 > > > > > > Where did you come up with the magic number 3? What if we reorganize > > the operator endpoints in the (1.0) future?

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Benjamin Bannier
> On April 20, 2016, 10:35 a.m., Adam B wrote: > > src/slave/http.cpp, lines 658-660 > > > > > > Where did you come up with the magic number 3? What if we reorganize > > the operator endpoints in the (1.0) future?

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 25, 2016, 10:30 a.m.) Review request for mesos, Adam B,

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Jan Schlicht
> On April 20, 2016, 10:35 a.m., Adam B wrote: > > src/slave/http.cpp, lines 658-660 > > > > > > Where did you come up with the magic number 3? What if we reorganize > > the operator endpoints in the (1.0) future?

Re: Review Request 46264: Fixed a typo in docker_containerizer_tests.cpp.

2016-04-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46264/ --- (Updated April 25, 2016, 4:23 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Jan Schlicht
> On April 20, 2016, 10:35 a.m., Adam B wrote: > > docs/configuration.md, line 897 > > > > > > We're going to have to start documenting which endpoints can/must be > > authorized this way, similar to how Joerg

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-25 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review130385 --- src/slave/http.cpp (lines 647 - 649)

Re: Review Request 46139: Add positive tests for /weights endpoint.

2016-04-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46139/#review130390 --- Ship it! Ship It! - Adam B On April 19, 2016, 6:42 a.m.,

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Jan Schlicht
> On April 20, 2016, 10:35 a.m., Adam B wrote: > > src/slave/http.cpp, lines 658-660 > > > > > > Where did you come up with the magic number 3? What if we reorganize > > the operator endpoints in the (1.0) future?

Re: Review Request 46318: Added helper to create test agent with injected `Authorizer`.

2016-04-25 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46318/#review130383 --- Ship it! Ship It! - Alexander Rojas On April 25, 2016,

Re: Review Request 45922: Added agent authorization flags.

2016-04-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review130384 --- Ship it! Ship It! - Adam B On April 22, 2016, 3:11 a.m.,

Re: Review Request 46318: Added helper to create test agent with injected `Authorizer`.

2016-04-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46318/#review130386 --- Ship it! Ship It! - Adam B On April 25, 2016, 1:19 a.m.,

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-25 Thread Adam B
> On April 22, 2016, 1:22 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 1926-1927 > > > > > > I would expect you to await/validate the response after validating the > > request. > > Benjamin Bannier

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Adam B
> On April 20, 2016, 1:35 a.m., Adam B wrote: > > src/tests/slave_authorization_tests.cpp, lines 110-114 > > > > > > This seems wrong. You don't even bother to reset the authenticator > > after you're done? > >

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Adam B
> On April 20, 2016, 1:35 a.m., Adam B wrote: > > include/mesos/authorizer/acls.proto, line 151 > > > > > > Let's consider calling this `GetEndpoint`, to match the HTTP verb? > > There may be some users that are

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130391 --- Fix it, then Ship it! Looks like a great generalization! What

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-25 Thread Alexander Rojas
> On April 20, 2016, 10:35 a.m., Adam B wrote: > > src/slave/http.cpp, lines 658-660 > > > > > > Where did you come up with the magic number 3? What if we reorganize > > the operator endpoints in the (1.0) future?

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-04-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/#review130536 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-04-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/ --- (Updated April 26, 2016, 2:24 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46665: Added 0.26.2 to the CHANGELOG.

2016-04-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46665/#review130519 --- Ship it! Ship It! - Vinod Kone On April 25, 2016, 11:08

Re: Review Request 46664: Added 0.27.3 to the CHANGELOG.

2016-04-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46664/#review130518 --- Ship it! Ship It! - Vinod Kone On April 25, 2016, 11:08

Re: Review Request 46663: Added 0.28.2 to the CHANGELOG.

2016-04-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46663/#review130517 --- Ship it! Ship It! - Vinod Kone On April 25, 2016, 11:08

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

2016-04-25 Thread Vinod Kone
> On April 25, 2016, 2:48 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 45 > > > > > > If this was `const` it would be much easier to reason how this works >

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

2016-04-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/ --- (Updated April 26, 2016, 12:54 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46588: Added URI struct to stout.

2016-04-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/ --- (Updated April 25, 2016, 5:59 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.

2016-04-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46618/#review130543 --- Ship it! Ship It! - Gilbert Song On April 25, 2016, 10:56

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review130540 --- docs/authorization.md (line 12)

  1   2   >