Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

2016-04-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review130682 --- 3rdparty/libprocess/src/subprocess_windows.cpp (line 77)

答复: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-26 Thread pangbingqiang
OK,I have post review request, thanks. 发件人: Vinod Kone [mailto:nore...@reviews.apache.org] 代表 Vinod Kone 发送时间: 2016年4月22日 8:37 收件人: Kapil Arya; Niklas Nielsen; Adam B; Joseph Wu; Vinod Kone 抄送: pangbingqiang; mesos 主题: Re: Review Request 46249: Hook and module process operation before main

Re: Review Request 46609: [WIP] Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

2016-04-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46609/#review130679 --- Can you rebase this? - Vinod Kone On April 24, 2016, 12:26

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

2016-04-26 Thread zhiwei
According to the initial comment "A workaround for systems that have an old glib but have a new kernel" made by Ian, I am not sure which version of glib is old and which version of kernel if new. At the previous commit, we included a syscall.h to fix this issue[1], but I am not sure this is the

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Alexander Rukletsov
> On April 26, 2016, 3:40 p.m., Alexander Rukletsov wrote: > > docs/configuration.md, line 899 > > > > > > Let's entertain our reader a bit : ). Instead of "a", we can use > > something like "padavan", and if you

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
> On April 26, 2016, 8:27 a.m., Adam B wrote: > > src/slave/http.cpp, line 804 > > > > > > s/access/GET/ and shouldn't you be checking the Verb here, for when we > > have to authorize things other than GETs? I've

Re: Review Request 46682: Made volume isolator logic injectable for MockDriverClient.

2016-04-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46682/#review130580 ---

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
> On April 26, 2016, 8:27 a.m., Adam B wrote: > > src/slave/http.cpp, line 360 > > > > > > Should this perhaps be a `Shared<>`? > > Jan Schlicht wrote: > I don't think so. `Shared<>` is about shared ownership,

Re: Review Request 46680: Fixed docker volume isolator const ref and vlog quotation.

2016-04-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46680/#review130576 ---

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
> On April 26, 2016, 8:27 a.m., Adam B wrote: > > src/slave/http.cpp, line 362 > > > > > > This function still assumes GET. Please pass a something like a Verb > > enum as a parameter, or else you'll need an

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review130575 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 26, 2016, 1:10 p.m.) Review request for mesos, Adam B,

Re: Review Request 46687: Added test cases for passing lambda to `dispatch`.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46687/#review130592 --- Patch looks great! Reviews applied: [46686, 46687] Passed

Re: Review Request 46681: Fixed docker volume isolator checkpointing empty info.

2016-04-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46681/#review130577 ---

Re: Review Request 46621: Added alias support for flags.

2016-04-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review130685 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Review Request 46725: Set default Content-Type for HTTP responses.

2016-04-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46725/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-3739

Re: Review Request 46220: Added documentation for Nvidia GPU support.

2016-04-26 Thread Qian Zhang
> On April 22, 2016, 5:55 p.m., Qian Zhang wrote: > > docs/gpu-support.md, line 440 > > > > > > Does this limitation mean that currently we do not support container > > with an image (e.g., Docker image, Appc

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/ --- (Updated 四月 27, 2016, 1:57 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46609: [WIP] Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46609/#review130707 --- Bad patch! Reviews applied: [46609, 46204, 46188, 46187] Failed

Review Request 46717: Added sketch of fetcher cache metrics.

2016-04-26 Thread Michael Browning
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46717/ --- Review request for mesos and Bernd Mathiske. Bugs: MESOS-4760

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review130716 --- Patch looks great! Reviews applied: [46720, 46676] Passed

Review Request 46723: Send error message to the framework when it is not connected.

2016-04-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46723/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5181

Review Request 46722: Made the master detection log messages more verbose.

2016-04-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46722/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 46188: Added the missing 'break' when handling ERROR event.

2016-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46188/ --- (Updated April 27, 2016, 9:24 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46204: Updated slave recovery tests with HTTP command executor.

2016-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46204/ --- (Updated April 27, 2016, 9:25 a.m.) Review request for mesos, Anand Mazumdar

Review Request 46720: Fix the titles of 'Slave/Agent Rename' series tickets in CHANGELOG.

2016-04-26 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46720/ --- Review request for mesos, Kevin Klues and Vinod Kone. Bugs: mesos-5230

Re: Review Request 46720: Fix the titles of 'Slave/Agent Rename' series tickets in CHANGELOG.

2016-04-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46720/#review130708 --- Ship it! Ship It! - Vinod Kone On April 27, 2016, 1:56

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread Kevin Klues
> On April 26, 2016, 7:08 p.m., Vinod Kone wrote: > > src/Makefile.am, line 535 > > > > > > what does setting this variable do? This is an autotools thing. If you define this and then list which headers to

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread zhou xing
> On 四月 26, 2016, 7:08 p.m., Vinod Kone wrote: > > src/Makefile.am, lines 2151-2152 > > > > > > IIUC, when someone does a `make install` there will be 2 directories > > in the installation directory. > > > >

Re: Review Request 46609: [WIP] Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

2016-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46609/ --- (Updated April 27, 2016, 9:26 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46609: Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

2016-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46609/ --- (Updated April 27, 2016, 9:25 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated April 27, 2016, 9:23 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46682: Made volume isolator logic injectable for MockDriverClient.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46682/#review130600 --- Patch looks great! Reviews applied: [46680, 46681, 46682]

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review130614 --- Ship it! Ship It! - Alexander Rojas On April 26, 2016, 3:34

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review130610 --- src/slave/http.cpp (line 362)

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 26, 2016, 2:51 p.m.) Review request for mesos, Adam B,

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/ --- (Updated April 26, 2016, 1:34 p.m.) Review request for mesos, Adam B,

Re: Review Request 46641: Added tests for the Profiler to libprocess.

2016-04-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46641/#review130617 --- Fix it, then Ship it! Should we also add another test(s) that

Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).

2016-04-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46461/#review130619 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 1:25

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
> On April 26, 2016, 4:01 p.m., Benjamin Bannier wrote: > > src/slave/http.cpp, line 362 > > > > > > You assume that `slave(XYZ)/flags` will only receive `GET` requests, > > but I think it would make more sense to

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/ --- (Updated April 26, 2016, 5:14 p.m.) Review request for mesos, Adam B, Greg

Review Request 46686: Allowed to pass lambda in `dispatch`.

2016-04-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46686/ --- Review request for mesos, Kevin Klues and Michael Park. Bugs: MESOS-4611

Review Request 46687: Added test cases for passing lambda to `dispatch`.

2016-04-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46687/ --- Review request for mesos, Kevin Klues and Michael Park. Bugs: MESOS-4611

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review130639 --- Fix it, then Ship it! src/slave/http.cpp (line 627)

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130638 --- Fix it, then Ship it! src/tests/slave_authorization_tests.cpp

Re: Review Request 46641: Added tests for the Profiler to libprocess.

2016-04-26 Thread Greg Mann
> On April 26, 2016, 2:40 p.m., Kapil Arya wrote: > > Should we also add another test(s) that sets/unsets the environment > > variable to ensure coverage? We can do that in a separate request. The difficulty here is that with the current implementation, the environment variable has to be set

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review130644 --- Patch looks great! Reviews applied: [46501] Passed command:

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
> On April 26, 2016, 5:40 p.m., Alexander Rukletsov wrote: > > src/slave/slave.hpp, lines 471-473 > > > > > > It feels like this class should be somewhere in a more general place. > > Moreover, libprocess'

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 26, 2016, 8:22 p.m.) Review request for mesos and Adam B.

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-26 Thread Benjamin Bannier
> On April 26, 2016, 6:45 p.m., Alexander Rukletsov wrote: > > src/tests/slave_authorization_tests.cpp, line 251 > > > > > > s/SlaveAuthorizationTest/Endpoint > > > > I'd say it's more descriptive. Right

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/ --- (Updated April 26, 2016, 8:22 p.m.) Review request for mesos, Adam B,

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 26, 2016, 8:29 p.m.) Review request for mesos, Adam B,

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Benjamin Bannier
> On April 26, 2016, 6:51 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, line 655 > > > > > > You remove the `Future` here. I believe this is on purpose as it seems > > the right way to pass the parameter

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review130655 --- src/slave/http.cpp (lines 797 - 799)

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 26, 2016, 8:04 p.m.) Review request for mesos, Adam B,

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Alexander Rukletsov
> On April 20, 2016, 8:35 a.m., Adam B wrote: > > src/slave/http.cpp, lines 658-660 > > > > > > Where did you come up with the magic number 3? What if we reorganize > > the operator endpoints in the (1.0) future?

Re: Review Request 46096: Updated prepare() method of "network/cni" isolator for tests.

2016-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46096/ --- (Updated April 26, 2016, 11:53 p.m.) Review request for mesos, Avinash

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated April 26, 2016, 11:53 p.m.) Review request for mesos, Avinash

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 26, 2016, 5:27 p.m.) Review request for mesos, Adam B,

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review130609 --- docs/configuration.md (line 899)

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Alexander Rukletsov
> On April 26, 2016, 2:01 p.m., Benjamin Bannier wrote: > > src/slave/http.cpp, line 787 > > > > > > I really like that we use a dedicated `enum` in the switch below, but > > dislike how users of this function

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-04-26 Thread Qian Zhang
> On April 22, 2016, 5:19 a.m., Avinash sridharan wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 24 > > > > > > I think `mesos` definitions should come after `process`. No, I think we should do it

Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/ --- Review request for mesos, Kevin Klues and Vinod Kone. Bugs: mesos-5230

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Adam B
> On April 22, 2016, 1:22 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 1895 > > > > > > Should we create a TYPED_TEST that tests this ACL in the local > > authorizer (direct and as a module), or do we

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review130549 --- Fix it, then Ship it! Only minor nits left beyond my two

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

2016-04-26 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review130538 --- Looks great! I think we just need to pass the GET/POST verb into

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Adam B
> On April 22, 2016, 1:22 a.m., Adam B wrote: > > src/slave/slave.hpp, lines 471-472 > > > > > > How did this come up? The original `_statistics()` is not static, and > > it had no issues. > > Benjamin Bannier

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130666 --- Patch looks great! Reviews applied: [45922, 46318, 46203, 46319,

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review130664 --- Can you make the description more descriptive please? Make it

Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.

2016-04-26 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46610/#review130668 --- Ship it! Since this followed the existing approach (used by

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-26 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/ --- (Updated 四月 26, 2016, 8:15 a.m.) Review request for mesos, Ben Mahler and Greg

Review Request 46682: Made volume isolator logic injectable for MockDriverClient.

2016-04-26 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46682/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Review Request 46680: Fixed docker volume isolator const ref and vlog quotation.

2016-04-26 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46680/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Review Request 46681: Fixed docker volume isolator checkpointing empty info.

2016-04-26 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46681/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130569 --- Patch looks great! Reviews applied: [45922, 46318, 46203, 46319,

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-26 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130548 --- src/tests/slave_authorization_tests.cpp (line 171)

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-26 Thread Juan Larriba
> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, lines 127-140 > > > > > > Hmm. I was hoping for something more generic than hard coding these 3 > > configurations. But if it's not

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Benjamin Bannier
> On April 26, 2016, 8:53 a.m., Adam B wrote: > > src/slave/http.cpp, lines 630-638 > > > > > > Seems like these lines need to be indented more. Indeed they need to be and now are. > On April 26, 2016, 8:53 a.m.,

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/ --- (Updated April 26, 2016, 9:59 a.m.) Review request for mesos and Adam B.

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Benjamin Bannier
> On April 22, 2016, 10:22 a.m., Adam B wrote: > > src/slave/slave.hpp, lines 471-472 > > > > > > How did this come up? The original `_statistics()` is not static, and > > it had no issues. > > Benjamin Bannier

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review130557 --- Patch looks great! Reviews applied: [46676] Passed command:

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

2016-04-26 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review130558 --- This is still a work in progress, I assume. Do we need to modify

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

2016-04-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/ --- (Updated April 26, 2016, 9:59 a.m.) Review request for mesos, Adam B,

Re: Review Request 46569: Parameterized agent endpoint authorization tests on tested endpoint.

2016-04-26 Thread Benjamin Bannier
> On April 26, 2016, 9 a.m., Adam B wrote: > > src/tests/slave_authorization_tests.cpp, line 171 > > > > > > s/some agent's endpoint/the specified agent endpoint/ Done. > On April 26, 2016, 9 a.m., Adam B wrote: