Re: Review Request 46140: Added test "ROOT_LaunchCommandExecutorNoRootfsWithSingleVolume".

2016-05-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/ --- (Updated 五月 3, 2016, 5:05 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 46140: Added test "ROOT_LaunchCommandExecutorNoRootfsWithSingleVolume".

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/#review131457 --- src/tests/containerizer/docker_volume_isolator_tests.cpp (line

Re: Review Request 46872: Updated quota.md and weights.md for set quota and update weight.

2016-05-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46872/#review131458 --- Patch looks great! Reviews applied: [46872] Passed command:

Re: Review Request 46911: Manually define PRJQUOTA for old kernel headers.

2016-05-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46911/#review131451 --- Patch looks great! Reviews applied: [46911] Passed command:

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/#review131456 --- Can you follow up with a test (e.g., in

Re: Review Request 46794: Unify POSIX and Windows `pstree` implementations.

2016-05-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46794/ --- (Updated May 3, 2016, 5:46 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 46140: Added test "ROOT_LaunchCommandExecutorNoRootfsWithSingleVolume".

2016-05-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/ --- (Updated 五月 3, 2016, 5:12 a.m.) Review request for mesos, Gilbert Song and Jie

Review Request 42028: Added test "ROOT_LaunchCommandExecutorNoRootfsWithMultipleVolumes".

2016-05-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42028/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5266

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

2016-05-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- (Updated May 3, 2016, 5:45 a.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/ --- (Updated May 3, 2016, 5:44 a.m.) Review request for mesos, Alex Naparu, Daniel

Review Request 46923: Added framework failover timeout validation.

2016-05-02 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- Review request for mesos. Repository: mesos Description --- Frameworks

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Jie Yu
> On May 2, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1081-1083 > > > > > > I think we should still set MESOS_SANDBOX to 'directory' for command > > executor itself

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/#review131447 --- Ship it! Ship It! - Jie Yu On May 2, 2016, 3:04 p.m., Shuai

Review Request 46928: Added safety fixes to and tests `os::close`.

2016-05-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46928/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Shuai Lin
> On May 3, 2016, 5:03 a.m., Jie Yu wrote: > > Can you follow up with a test (e.g., in provisioner_docker_tests.cpp) for > > this? Sure, would do that this week. - Shuai --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46735: Added support for Authorization information to HELP.

2016-05-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46735/#review131304 --- Ship it! 3rdparty/libprocess/include/process/help.hpp (line

Re: Review Request 46736: Added authorization description to quota endpoint help.

2016-05-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46736/#review131307 --- Ship it! Ship It! - Alexander Rukletsov On April 29, 2016,

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/ --- (Updated May 2, 2016, 3:04 p.m.) Review request for mesos, Guangya Liu and Jie

Re: Review Request 46796: Synced endpoint documentation by running generation script.

2016-05-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46796/#review131306 --- Ship it! Ship It! - Alexander Rukletsov On April 29, 2016,

Re: Review Request 46680: Fixed docker volume isolator const ref and vlog quotation.

2016-05-02 Thread Jie Yu
> On April 26, 2016, 9:45 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 289-290 > > > > > > According to > >

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-05-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46798/ --- (Updated May 2, 2016, 5:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46872: Updated quota.md and weights.md for set quota and update weight.

2016-05-02 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46872/#review131319 --- docs/quota.md (line 87)

Re: Review Request 41439: Removed unused "containerId" from filesystem isolator test.

2016-05-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41439/#review131324 --- Ship it! Ship It! - Gilbert Song On May 2, 2016, 2:14 a.m.,

Re: Review Request 46807: Simplified the rootfs preparation logic for command tasks.

2016-05-02 Thread Jie Yu
> On May 1, 2016, 4:54 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 744 > > > > > > Why removing this check for `ContainerInfo::MESOS` type? We just did the if check above in

Re: Review Request 46807: Simplified the rootfs preparation logic for command tasks.

2016-05-02 Thread Jie Yu
> On May 2, 2016, 9:39 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 490-500 > > > > > > Not yours, but since we may have more volume source type. Could we just >

Re: Review Request 46681: Fixed docker volume isolator checkpointing empty info.

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46681/#review131333 --- Ship it! Ship It! - Jie Yu On April 26, 2016, 8:32 a.m.,

Re: Review Request 46783: Minor clarifications to HA framework guide.

2016-05-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46783/#review131318 --- Patch looks great! Reviews applied: [46779, 46780, 46781, 46782,

Re: Review Request 46682: Made volume isolator logic injectable for MockDriverClient.

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46682/#review131338 --- Ship it! Ship It! - Jie Yu On April 26, 2016, 8:32 a.m.,

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

2016-05-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45995/#review131340 --- 3rdparty/libprocess/src/process.cpp (line 1007)

Review Request 46900: Updated libprocess HTTP endpoint help strings.

2016-05-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46900/ --- Review request for mesos, Adam B, Joerg Schad, and Kapil Arya. Bugs:

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

2016-05-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46806/#review131347 --- Patch looks great! Reviews applied: [46806] Passed command:

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

2016-05-02 Thread Joseph Wu
> On April 29, 2016, 9:32 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/process.cpp, line 989 > > > > > > I'm guessing this refers to `new Route("/__processes__", None(), > > __processes__);`? I think it might

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

2016-05-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46806/ --- (Updated May 2, 2016, 10:50 a.m.) Review request for mesos, Greg Mann, Joerg

Review Request 46901: Regenerated HTTP endpoint docs.

2016-05-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46901/ --- Review request for mesos, Adam B, Joerg Schad, and Kapil Arya. Bugs:

Re: Review Request 46682: Made volume isolator logic injectable for MockDriverClient.

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46682/#review131334 ---

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

2016-05-02 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated May 2, 2016, 8:35 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 46901: Regenerated HTTP endpoint docs.

2016-05-02 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46901/#review131353 --- Ship it! Ship It! - Joerg Schad On May 2, 2016, 6:34 p.m.,

Review Request 46904: Fixed a typo in libprocess.

2016-05-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46904/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 46900: Updated libprocess HTTP endpoint help strings.

2016-05-02 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46900/#review131352 --- Ship it! Ship It! - Joerg Schad On May 2, 2016, 6:33 p.m.,

Review Request 46907: Windows: Fixed typo in `define` evaluation.

2016-05-02 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46907/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris

Re: Review Request 46735: Added support for Authorization information to HELP.

2016-05-02 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46735/ --- (Updated May 2, 2016, 12:34 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46872: Updated quota.md and weights.md for set quota and update weight.

2016-05-02 Thread Guangya Liu
On 五月 2, 2016, 4:01 p.m., Guangya Liu wrote: > > Could you check whether this is an issue also with other endpoints? Thanks Joerg, others are using `JSON String` in the `curl` command and only quota and weight need some update here. - Guangya

Re: Review Request 46872: Updated quota.md and weights.md for set quota and update weight.

2016-05-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46872/ --- (Updated 五月 2, 2016, 10:35 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-05-02 Thread Jie Yu
> On May 2, 2016, 10:23 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 112-134 > > > > > > Why do we must alredy have a workdir mount in host mount table in the >

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-05-02 Thread Jie Yu
> On May 2, 2016, 10:17 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 113 > > > > > > Trying to understand the new logic here, when do we expect the agent to > >

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-05-02 Thread Jie Yu
> On May 2, 2016, 10:17 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 113 > > > > > > Trying to understand the new logic here, when do we expect the agent to > >

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

2016-05-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131356 --- 3rdparty/libprocess/src/subprocess_windows.cpp (line 89)

Re: Review Request 46140: WIP: Added dvd isolator test "ROOT_LaunchCommandExecutorWithVolumes".

2016-05-02 Thread Guangya Liu
> On 五月 2, 2016, 9:44 p.m., Jie Yu wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, lines 172-181 > > > > > > Why copy the code here? I don't think we need a 'rootfs' to test some > > basic

Re: Review Request 46911: Manually define PRJQUOTA for old kernel headers.

2016-05-02 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46911/#review131390 --- Ship it! Ship It! - James Peach On May 2, 2016, 9:58 p.m.,

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46858/ --- (Updated May 2, 2016, 9:04 p.m.) Review request for mesos, Gilbert Song, Ian

Re: Review Request 46140: WIP: Added dvd isolator test "ROOT_LaunchCommandExecutorWithVolumes".

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/#review131378 --- src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/#review131386 --- src/slave/containerizer/mesos/containerizer.cpp (lines 1081 -

Review Request 46911: Manually define PRJQUOTA for old kernel headers.

2016-05-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46911/ --- Review request for mesos and James Peach. Repository: mesos Description

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-05-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46858/#review131396 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-05-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46858/#review131380 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Review Request 46892: Fixed docker executor not to close streams immediately after SIGTERM.

2016-05-02 Thread Martin Bydzovsky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46892/ --- Review request for mesos. Repository: mesos Description --- Fixed

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-05-02 Thread Neil Conway
> On April 29, 2016, 9:29 a.m., Alexander Rukletsov wrote: > > It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we > > could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do > > you want to do it here or follow up with another patch? > > Neil Conway

Re: Review Request 46892: Fixed docker executor not to close streams immediately after SIGTERM.

2016-05-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46892/#review131295 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 46904: Fixed a typo in libprocess.

2016-05-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46904/#review131432 --- Patch looks great! Reviews applied: [46806, 46900, 46901, 46904]

Re: Review Request 46783: Minor clarifications to HA framework guide.

2016-05-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46783/ --- (Updated May 2, 2016, 2:38 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41439: Removed unused "containerId" from filesystem isolator test.

2016-05-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41439/#review131284 --- Patch looks great! Reviews applied: [41439] Passed command:

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-05-02 Thread Alexander Rukletsov
> On April 29, 2016, 9:29 a.m., Alexander Rukletsov wrote: > > It would be great to implement `CHECK_NREADY`, `CHECK_NDISCARDED`, then we > > could have replaced `CHECK(!candidacy.isDiscarded());` for consistency. Do > > you want to do it here or follow up with another patch? > > Neil Conway

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-05-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46827/#review131287 --- Ship it! Ship It! - Alexander Rukletsov On April 29, 2016,

Re: Review Request 46505: Removed MethodNotAllowed error string creation.

2016-05-02 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46505/ --- (Updated May 3, 2016, 12:20 a.m.) Review request for mesos and Alexander

Re: Review Request 46504: Constructed error string in MethodNotAllowed.

2016-05-02 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46504/ --- (Updated May 3, 2016, 12:20 a.m.) Review request for mesos and Alexander

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Shuai Lin
> On May 2, 2016, 9:54 a.m., Gilbert Song wrote: > > BTW Shuai, would you mind to label the JIRA ticket# in `bug`? Thanks! Updated, thanks for reminding :) - Shuai --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46140: WIP: Added test "ROOT_LaunchCommandExecutorWithSingleVolume".

2016-05-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/ --- (Updated 五月 2, 2016, 11:57 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-05-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46858/ --- (Updated May 2, 2016, 11:59 p.m.) Review request for mesos, Gilbert Song, Ian

Re: Review Request 46858: Skipped the bind mounting of the agent's work_dir if possible.

2016-05-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46858/#review131424 --- Ship it! Ship It! - Gilbert Song On May 2, 2016, 4:59 p.m.,

Review Request 41439: Removed unused "containerId" from filesystem isolator test.

2016-05-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41439/ --- Review request for mesos, Gilbert Song, Jie Yu, and Joseph Wu. Repository:

Re: Review Request 46782: Removed false claim that TEARDOWN can remove persistent volumes.

2016-05-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46782/ --- (Updated May 2, 2016, 9:15 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 46807: Simplified the rootfs preparation logic for command tasks.

2016-05-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46807/#review131278 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/#review131281 --- Ship it! Thanks for applying that patch! Sweet! - Gilbert

Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.

2016-05-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46873/#review131282 --- Ship it! BTW Shuai, would you mind to label the JIRA ticket#