Re: Review Request 46942: Fixed docker volume isolator container mount target.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46942/#review131539 --- Patch looks great! Reviews applied: [46942] Passed command:

Review Request 46942: Fixed docker volume isolator container mount target.

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46942/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

2016-05-03 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131543 --- 3rdparty/libprocess/src/subprocess.cpp (line 235)

Re: Review Request 46942: Fixed docker volume isolator container mount target.

2016-05-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46942/#review131536 --- Fix it, then Ship it!

Re: Review Request 46942: Fixed docker volume isolator container mount target.

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46942/ --- (Updated May 3, 2016, 12:50 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 46505: Removed MethodNotAllowed error string creation.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46505/#review131461 --- Bad patch! Reviews applied: [46505, 46504] Failed command:

Re: Review Request 46140: Added test "ROOT_LaunchCommandExecutorNoRootfsWithSingleVolume".

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/#review131464 --- src/tests/containerizer/docker_volume_isolator_tests.cpp (line

Re: Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

2016-05-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45996/ --- (Updated May 3, 2016, 9:41 a.m.) Review request for mesos and Joris Van

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-05-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/ --- (Updated May 3, 2016, 9:41 a.m.) Review request for mesos and Joris Van

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

2016-05-03 Thread Neil Conway
> On May 2, 2016, 5:53 p.m., haosdent huang wrote: > > 3rdparty/libprocess/src/process.cpp, line 1007 > > > > > > I am no sure if use `processes_route` style to keep consistent with > > `process_manager`. Good

Re: Review Request 46146: Fixed libprocess tests to use smart pointers.

2016-05-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46146/ --- (Updated May 3, 2016, 9:42 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131467 --- Patch looks great! Reviews applied: [46923] Passed command:

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsMultipleSameVolumes".

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/#review131472 --- Patch looks great! Reviews applied: [46680, 46681, 46682, 46140,

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsSingleVolume".

2016-05-03 Thread Guangya Liu
> On 五月 3, 2016, 5:28 a.m., Jie Yu wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, line 204 > > > > > > > > `s/ROOT_LaunchCommandExecutorNoRootfsWithSingleVolume/ROOT_CommandTaskNoRootfs/` I

Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

2016-05-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45995/ --- (Updated May 3, 2016, 9:40 a.m.) Review request for mesos and Joris Van

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsSingleVolume".

2016-05-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/ --- (Updated 五月 3, 2016, 7:51 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 42028: Added test "ROOT_CommandTaskNoRootfsMultipleVolumes".

2016-05-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42028/ --- (Updated 五月 3, 2016, 8:01 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Benjamin Bannier
> On April 14, 2016, 11:33 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp, line 95 > > > > > > This one is subtle as in principle we could use a moved-from > >

Re: Review Request 42028: Added test "ROOT_CommandTaskNoRootfsMultipleVolumes".

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42028/#review131565 --- I am thinking we should only have one

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsMultipleSameVolumes".

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/#review131564 --- I am thinking we should only have one

Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46945/ --- Review request for mesos, Benjamin Bannier, Benjamin Hindman, Ben Mahler, and

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsMultipleSameVolumes".

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/#review131566 --- src/tests/containerizer/docker_volume_isolator_tests.cpp (line

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsSingleVolume".

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/#review131538 --- src/tests/containerizer/docker_volume_isolator_tests.cpp (line

Re: Review Request 46942: Fixed docker volume isolator container mount target.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46942/#review131550 --- Patch looks great! Reviews applied: [46942] Passed command:

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/ --- (Updated May 3, 2016, 8:34 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46945/#review131553 --- Ship it! Ship It! - Benjamin Bannier On May 3, 2016, 10:34

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/ --- (Updated May 3, 2016, 1:50 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/ --- (Updated May 3, 2016, 8:53 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review131574 --- Bad patch! Reviews applied: [46165, 46945] Failed command:

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsSingleVolume".

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/#review131558 --- Could you fix the other patches correspondingly? Thanks, Guangya!

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review131548 --- Fix it, then Ship it!

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131567 --- Patch looks great! Reviews applied: [46920] Passed command:

Re: Review Request 46813: Update distribute to setuptools.

2016-05-03 Thread Bernd Mathiske
> On April 29, 2016, 9:20 a.m., haosdent huang wrote: > > 3rdparty/versions.am, line 25 > > > > > > I saw the latest version of setuptools is `20.10.1` in > > https://pypi.python.org/pypi/setuptools Do we have any

Re: Review Request 39474: Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".

2016-05-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39474/ --- (Updated 五月 3, 2016, 12:19 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131485 --- src/master/master.hpp (line 937)

Re: Review Request 46813: Update distribute to setuptools.

2016-05-03 Thread Zhiwei Chen
> On April 30, 2016, 12:20 a.m., haosdent huang wrote: > > 3rdparty/versions.am, line 25 > > > > > > I saw the latest version of setuptools is `20.10.1` in > > https://pypi.python.org/pypi/setuptools Do we have any

Re: Review Request 46813: Update distribute to setuptools.

2016-05-03 Thread haosdent huang
> On April 29, 2016, 4:20 p.m., haosdent huang wrote: > > 3rdparty/versions.am, line 25 > > > > > > I saw the latest version of setuptools is `20.10.1` in > > https://pypi.python.org/pypi/setuptools Do we have any

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-05-03 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/ --- (Updated May 3, 2016, 2:42 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-05-03 Thread Jan Schlicht
> On April 29, 2016, 11:20 a.m., Benjamin Bannier wrote: > > src/tests/master_authorization_tests.cpp, line 1024 > > > > > > This looks very similar to the `SlaveEndpointTest` suite ;) Should we > > just also make

Re: Review Request 39474: Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39474/#review131490 --- Patch looks great! Reviews applied: [46680, 46681, 46682, 46140,

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131489 --- You can put `MESOS-1575` to the `bugs` column at right.

Review Request 46936: Documented the agent endpoint '/flags'.

2016-05-03 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46936/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil Conway.

Re: Review Request 46934: Fixed typo in authentication help.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46934/#review131506 --- Patch looks great! Reviews applied: [46934] Passed command:

Review Request 38451: Added test "ROOT_CommandTaskNoRootfsMultipleSameVolumes".

2016-05-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5266

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-05-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review131491 --- Ship it! src/master/http.cpp (line 2882)

Review Request 46934: Fixed typo in authentication help.

2016-05-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46934/ --- Review request for mesos, Alexander Rukletsov and Neil Conway. Repository:

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/#review131575 --- It seems to me that we have `Starting container..` in launch()

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review131593 --- Ship it! Ship It! - Ben Mahler On May 3, 2016, 8:53 p.m.,

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 4, 2016, 12:27 a.m.) Review request for mesos, Kevin Sweeney and

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review131557 --- Fix it, then Ship it! src/tests/persistent_volume_tests.cpp

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 4, 2016, 12:31 a.m.) Review request for mesos, Kevin Sweeney and

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/ --- (Updated May 4, 2016, 12:31 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46945/ --- (Updated May 3, 2016, 10:54 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46945/#review131581 --- Fix it, then Ship it!

Re: Review Request 46945: Renamed a shadowing variable.

2016-05-03 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46945/ --- (Updated May 4, 2016, 12:30 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 46165: Removed dependency on Boost.Foreach.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review131605 --- Patch looks great! Reviews applied: [46945, 46165] Passed

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/#review131614 --- src/common/http.cpp (lines 587 - 588)

Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.

2016-05-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46876/#review131617 --- src/tests/scheduler_driver_tests.cpp (line 99)

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/#review131622 --- Patch looks great! Reviews applied: [46954] Passed command:

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/#review131625 --- Patch looks great! Reviews applied: [46958] Passed command:

Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-03 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/ --- Review request for mesos and Zhiwei Chen. Bugs: MESOS-5201

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

2016-05-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/ --- (Updated May 4, 2016, 10:42 a.m.) Review request for mesos, zhou xing, James

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

2016-05-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46883/#review131616 --- src/common/http.cpp (line 599)

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

2016-05-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/#review131613 --- 3rdparty/libprocess/include/process/http.hpp (lines 89 - 91)

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsSingleVolume".

2016-05-03 Thread Guangya Liu
> On 五月 3, 2016, 9:05 p.m., Gilbert Song wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, lines 272-273 > > > > > > Do we need it on this test? I want to make sure that the option works as I can

Re: Review Request 46730: Cleanup syscalls logic.

2016-05-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131612 --- Ship it! Ship It! - Zhiwei Chen On April 29, 2016, 9:03

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131610 --- Patch looks great! Reviews applied: [46923] Passed command:

Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/ --- Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.

Review Request 46960: Remove un-necessary copying of `slave->tasks` in master.

2016-05-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46960/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 46936: Documented the agent endpoint '/flags'.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46936/#review131519 --- Patch looks great! Reviews applied: [46935, 46936] Passed

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review131500 --- Patch looks great! Reviews applied: [46784] Passed command:

Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

2016-05-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46935/ --- Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil Conway.

Re: Review Request 46107: Add Appc runtime spec for command, working directory and environment.

2016-05-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46107/#review131527 --- include/mesos/appc/spec.proto (line 71)

Re: Review Request 46934: Fixed typo in authentication help.

2016-05-03 Thread Benjamin Bannier
> On May 3, 2016, 6:56 p.m., Neil Conway wrote: > > This isn't a typo; the intended meaning is "if and only if" > > (https://en.wikipedia.org/wiki/If_and_only_if). Admittedly that is a little > > too clever; I'd be fine with changing it, either to "if" or to "if and only > > if". Note we

Re: Review Request 46934: Fixed typo in authentication help.

2016-05-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46934/#review131524 --- This isn't a typo; the intended meaning is "if and only if"